@coreplane/switchboard 1.261.3 → 1.261.4

package/dist/assets/deploy/cloudflare-memory/worker.ts

@@ -2732,12 +2732,12 @@ export class RunHistoryDO extends DurableObject<Env> {
     return { ok: true };
   }
 
-  /** One compare-and-replace transaction reserves a legacy continuation for
-   * exactly one caller. The whole expected JSON is the fence: any intervening
-   * unit write, including another recovery, makes this caller stale. */
-  async claimLegacyContinuation(
+  /** One compare-and-replace transaction updates a unit for exactly one
+   * caller. The whole expected JSON is the fence: any intervening unit write
+   * makes this caller stale. */
+  async compareAndReplaceUnit(
     expected: CoordinatorUnit,
-    recovered: CoordinatorUnit,
+    replacement: CoordinatorUnit,
     now: number,
   ): Promise<{ ok: true } | { ok: false; reason: "stale" }> {
     let out: { ok: true } | { ok: false; reason: "stale" } = { ok: true };
@@ -2755,7 +2755,7 @@ export class RunHistoryDO extends DurableObject<Env> {
       }
       this.sql.exec(
         `UPDATE coordinator_units SET json = ?, updated_at = ? WHERE instance_id = ? AND unit = ?`,
-        JSON.stringify(recovered),
+        JSON.stringify(replacement),
         now,
         expected.instanceId,
         expected.unit,
@@ -5924,9 +5924,9 @@ async function handleLedger(pathname: string, body: unknown, env: Env): Promise<
       return json({ error: "expected and recovered must be coordinator unit rows" }, 400);
     if (b.expected.instanceId !== b.recovered.instanceId || b.expected.unit !== b.recovered.unit)
       return json({ error: "expected and recovered must name the same unit" }, 400);
-    const r = await stub.claimLegacyContinuation(b.expected, b.recovered, now);
+    const r = await stub.compareAndReplaceUnit(b.expected, b.recovered, now);
     console.log(
-      `[runs/coordinator/units/claim-legacy-continuation] ${key.value} ${b.expected.instanceId}:${b.expected.unit} → ${r.ok ? "claimed" : r.reason}`,
+      `[runs/coordinator/units/claim-legacy-continuation] ${key.value} ${b.expected.instanceId}:${b.expected.unit} → ${r.ok ? "replaced" : r.reason}`,
     );
     return r.ok ? json(r) : json(r, 409);
   }

package/dist/assets/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "switchboard",
-  "version": "1.261.3",
+  "version": "1.261.4",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "switchboard",
-      "version": "1.261.3",
+      "version": "1.261.4",
       "license": "Apache-2.0",
       "workspaces": [
         "web",
@@ -21060,7 +21060,7 @@
     },
     "packages/switchboard": {
       "name": "@coreplane/switchboard",
-      "version": "1.261.3",
+      "version": "1.261.4",
       "license": "Apache-2.0",
       "dependencies": {
         "@earendil-works/pi-ai": "0.85.1",

package/dist/assets/package.json

@@ -1,6 +1,6 @@
 {
   "name": "switchboard",
-  "version": "1.261.3",
+  "version": "1.261.4",
   "private": true,
   "description": "Mention it in Slack and an agent reviews the PR, ships the fix, or answers the question — on the model you choose, with its tools running where you decide.",
   "license": "Apache-2.0",

package/dist/assets/source.json

@@ -1,5 +1,5 @@
 {
-  "version": "1.261.3",
-  "commit": "b727e58725e3d234e0d34b43e04ca0dc9af17075",
-  "builtAt": "2026-09-24T14:03:08.080Z"
+  "version": "1.261.4",
+  "commit": "9f4d0f4c9645ea67ecab3ede2455e658f38a7d4c",
+  "builtAt": "2026-09-24T16:28:36.099Z"
 }

package/dist/cli.js

@@ -34687,7 +34687,7 @@ var init_instanceStore = __esm({
       async putUnits(_units) {
         return { ok: false, reason: "unavailable" };
       }
-      async claimLegacyContinuation(_expected, _recovered) {
+      async compareAndReplaceUnit(_expected, _replacement) {
         return { ok: false, reason: "unavailable" };
       }
       async listUnits(_instanceId) {
@@ -34764,8 +34764,11 @@ var init_instanceStore = __esm({
         if (d.ok === true) return { ok: true };
         throw new Error(`coordinator store /runs/coordinator/units/put: unexpected answer (HTTP ${r.status})`);
       }
-      async claimLegacyContinuation(expected, recovered) {
-        const r = await this.post("/runs/coordinator/units/claim-legacy-continuation", { expected, recovered });
+      async compareAndReplaceUnit(expected, replacement) {
+        const r = await this.post("/runs/coordinator/units/claim-legacy-continuation", {
+          expected,
+          recovered: replacement
+        });
         const d = r.data;
         if (r.status === 409 && d.reason === "stale") return { ok: false, reason: "stale" };
         if (d.ok === true) return { ok: true };
@@ -56132,16 +56135,22 @@ function continuationBudgetOf(instance, unit) {
 }
 async function legacyReviewedHeadOf(runs, instance, unit, prNumber) {
   const listed = await runs.listUnitRuns(unitKeyOf({ instanceId: instance.id, unit: unit.unit }), { kind: "all" }).catch(() => void 0);
-  if (listed === void 0 || !listed.ok || listed.value.unit !== unitKeyOf({ instanceId: instance.id, unit: unit.unit }) || listed.value.instanceId !== instance.id || listed.value.id !== unit.unit || listed.value.instance.id !== instance.id || listed.value.instance.repo.toLowerCase() !== instance.repo.toLowerCase())
+  if (listed === void 0 || !listed.ok || listed.value.unit !== unitKeyOf({ instanceId: instance.id, unit: unit.unit }) || listed.value.instanceId !== instance.id || listed.value.id !== unit.unit || listed.value.branch !== unit.branch || listed.value.pr?.number !== prNumber || listed.value.instance.id !== instance.id || listed.value.instance.repo.toLowerCase() !== instance.repo.toLowerCase())
     return void 0;
   const prefix = `${instance.id}:${unit.unit}/`;
   const owned = listed.value.runs.filter(
     (run2) => run2.finished && run2.status === "completed" && run2.parentInstanceId === instance.id && run2.idempotencyKey?.startsWith(prefix) === true && run2.userId === instance.userId && run2.repo?.toLowerCase() === instance.repo.toLowerCase()
   );
   const coding = new Set(
-    owned.flatMap(
-      (run2) => run2.agent === "coding" && run2.pr?.number === prNumber && typeof run2.headSha === "string" && FULL_SHA2.test(run2.headSha) ? [run2.headSha.toLowerCase()] : []
-    )
+    owned.flatMap((run2) => {
+      if (run2.agent !== "coding" || run2.pr?.number !== prNumber) return [];
+      return [
+        ...typeof run2.headSha === "string" && FULL_SHA2.test(run2.headSha) ? [run2.headSha.toLowerCase()] : [],
+        ...(run2.pushed ?? []).flatMap(
+          (pushed) => pushed.ref === unit.branch && FULL_SHA2.test(pushed.sha) ? [pushed.sha.toLowerCase()] : []
+        )
+      ];
+    })
   );
   const approved = new Set(
     owned.flatMap((run2) => {
@@ -56613,7 +56622,7 @@ async function dispatch(deps, msg, io, opts = {}) {
                   `Unit ${legacyUnit.unit}'s ownership reservation was lost, so continuation did not start. Nothing else ran.`
                 )
               };
-            const persisted = await coordinatorInstances.claimLegacyContinuation(legacyUnit, recoveredUnit).catch(() => void 0);
+            const persisted = await coordinatorInstances.compareAndReplaceUnit(legacyUnit, recoveredUnit).catch(() => void 0);
             if (persisted?.ok !== true) {
               const released = releaseLegacyOwnership?.() ?? true;
               const reason2 = persisted?.reason === "stale" ? `Unit ${legacyUnit.unit} changed while its legacy continuation was being reserved, so continuation did not start.` : `Unit ${legacyUnit.unit}'s recovered continuation binding could not be stored, so continuation did not start.`;
@@ -56622,7 +56631,7 @@ async function dispatch(deps, msg, io, opts = {}) {
             }
             const reservedOwner = runnerOwnership.owner(instance.repo, recordedPr.number);
             if (reservedOwner?.instanceId !== reservationOwner.instanceId || reservedOwner.unit !== reservationOwner.unit) {
-              const restored = await coordinatorInstances.claimLegacyContinuation(recoveredUnit, legacyUnit).catch(() => void 0);
+              const restored = await coordinatorInstances.compareAndReplaceUnit(recoveredUnit, legacyUnit).catch(() => void 0);
               const released = releaseLegacyOwnership?.() ?? true;
               const rollbackFailure = restored?.ok === true ? void 0 : restored?.reason ?? "unavailable";
               const cleanupFailure = released ? "" : " and its ownership reservation could not be released";
@@ -56648,7 +56657,7 @@ async function dispatch(deps, msg, io, opts = {}) {
                 transferredOwner = void 0;
               },
               abort: async () => {
-                const restored = await coordinatorInstances.claimLegacyContinuation(recoveredUnit, legacyUnit).catch(() => void 0);
+                const restored = await coordinatorInstances.compareAndReplaceUnit(recoveredUnit, legacyUnit).catch(() => void 0);
                 const released = releaseLegacyOwnership?.() ?? true;
                 owner.unit = legacyUnit;
                 const failures = [
@@ -73363,6 +73372,68 @@ async function steerChild(body, deps) {
   const steered = await deps.steerChild?.(body.runId, text, instance) ?? false;
   return json3(200, { ok: true, outcome: steered ? "steered" : "not_live", at });
 }
+async function bindOpenPullRequest(deps, instance, row2, pr, facts2) {
+  if (row2 === void 0) return;
+  const verified = facts2.verifiedHead;
+  if (instance.base === void 0 || facts2.state !== "open" || facts2.sameRepoHead !== true || facts2.headBranchExists !== true || facts2.headRef !== row2.branch || facts2.baseRef !== instance.base || verified === void 0 || verified.repo.toLowerCase() !== instance.repo.toLowerCase() || verified.ref !== row2.branch || !/^[0-9a-f]{40}$/i.test(verified.sha) || facts2.headSha !== verified.sha || row2.pr !== void 0 && row2.pr.number !== pr.number)
+    throw new PublicationBindingRefusal("publication_facts_mismatch");
+  const owner = { instanceId: instance.id, unit: row2.unit };
+  const publication = {
+    repo: instance.repo,
+    pr: pr.number,
+    headRef: row2.branch,
+    baseRef: instance.base,
+    expectedHeadSha: verified.sha,
+    publicationRef: row2.branch,
+    owner
+  };
+  const existing = row2.publication;
+  if (existing !== void 0 && (existing.repo !== publication.repo || existing.pr !== publication.pr || existing.headRef !== publication.headRef || existing.baseRef !== publication.baseRef || existing.expectedHeadSha !== publication.expectedHeadSha || existing.publicationRef !== publication.publicationRef || !samePublicationOwner(existing.owner, owner)))
+    throw new PublicationBindingRefusal("publication_facts_mismatch");
+  const fence = deps.runnerOwnership;
+  if (fence === void 0) throw new PublicationBindingRefusal("publication_ownership_unknown");
+  let priorOwner;
+  try {
+    priorOwner = fence.owner(instance.repo, pr.number);
+  } catch {
+    throw new PublicationBindingRefusal("publication_ownership_unknown");
+  }
+  if (priorOwner !== void 0 && !samePublicationOwner(priorOwner, owner))
+    throw new PublicationBindingRefusal("publication_ownership_changed");
+  if (!fence.claim(instance.repo, pr.number, owner))
+    throw new PublicationBindingRefusal("publication_ownership_changed");
+  let claimedHere = priorOwner === void 0;
+  const releaseClaim = () => {
+    if (!claimedHere) return;
+    fence.release(instance.repo, pr.number, owner);
+    claimedHere = false;
+  };
+  try {
+    if (!samePublicationOwner(fence.owner(instance.repo, pr.number), owner)) {
+      releaseClaim();
+      throw new PublicationBindingRefusal("publication_ownership_unknown");
+    }
+  } catch (err2) {
+    releaseClaim();
+    if (err2 instanceof PublicationBindingRefusal) throw err2;
+    throw new PublicationBindingRefusal("publication_ownership_unknown");
+  }
+  const replacement = { ...row2, pr, publication };
+  if (JSON.stringify(replacement) === JSON.stringify(row2)) return;
+  let replaced;
+  try {
+    replaced = await deps.instances.compareAndReplaceUnit(row2, replacement);
+  } catch {
+    releaseClaim();
+    throw new PublicationBindingRefusal("publication_store_unavailable");
+  }
+  if (!replaced.ok) {
+    releaseClaim();
+    throw new PublicationBindingRefusal(
+      replaced.reason === "stale" ? "publication_binding_stale" : "publication_store_unavailable"
+    );
+  }
+}
 async function prCheck(body, deps) {
   const id = parseInstanceId(body.parentInstanceId);
   if (!id.ok) return json3(400, { ok: false, error: id.error });
@@ -73379,19 +73450,9 @@ async function prCheck(body, deps) {
   const unit = await unitRowOf(deps, instance, body.unit);
   if (!unit.ok) return unit.response;
   const branch2 = unit.row?.branch ?? instance.branch;
-  const remember = async (pr, facts2) => {
-    if (!unit.row) return;
-    const publication = unit.row.publication ?? (facts2?.state === "open" && facts2.sameRepoHead === true && facts2.headBranchExists === true && typeof facts2.headRef === "string" && typeof facts2.baseRef === "string" && typeof facts2.headSha === "string" && /^[0-9a-f]{40}$/i.test(facts2.headSha) ? {
-      repo: instance.repo,
-      pr: pr.number,
-      headRef: facts2.headRef,
-      baseRef: facts2.baseRef,
-      expectedHeadSha: facts2.headSha,
-      publicationRef: facts2.headRef,
-      owner: { instanceId: instance.id, unit: unit.row.unit }
-    } : void 0);
-    if (unit.row.pr?.number !== pr.number || unit.row.pr.url !== pr.url || unit.row.publication === void 0 && publication !== void 0)
-      await deps.instances.putUnits([{ ...unit.row, pr, ...publication !== void 0 ? { publication } : {} }]);
+  const rememberTerminal = async (pr) => {
+    if (!unit.row || unit.row.pr?.number === pr.number && unit.row.pr.url === pr.url) return;
+    await deps.instances.putUnits([{ ...unit.row, pr }]);
   };
   try {
     if (follow !== void 0) {
@@ -73400,12 +73461,12 @@ async function prCheck(body, deps) {
       const fallbackUrl = unit.row?.pr?.url ?? `https://github.com/${instance.repo}/pull/${follow}`;
       const state2 = pullRequestState(follow, fallbackUrl, facts2);
       if (state2 === void 0) throw new Error(headBranchStateError(instance.repo, follow));
-      await remember({ number: follow, url: String(state2.url) }, facts2);
-      if (state2.state !== "open") return json3(200, { ok: true, ...state2, at });
-      deps.runnerOwnership?.claim(instance.repo, follow, {
-        instanceId: instance.id,
-        unit: unit.row?.unit ?? body.unit
-      });
+      const followedPr = { number: follow, url: String(state2.url) };
+      if (state2.state !== "open") {
+        await rememberTerminal(followedPr);
+        return json3(200, { ok: true, ...state2, at });
+      }
+      await bindOpenPullRequest(deps, instance, unit.row, followedPr, facts2);
       const prRef = { repo: instance.repo, number: follow };
       const headSha = facts2.headSha;
       const approved = entry && headSha !== void 0 ? await reviewPostedAt(deps, prRef, "approve", headSha) : void 0;
@@ -73436,16 +73497,16 @@ async function prCheck(body, deps) {
     }
     const open2 = await deps.findOpenPrByHead(instance.repo, branch2);
     if (open2) {
-      deps.runnerOwnership?.claim(instance.repo, open2.number, {
-        instanceId: instance.id,
-        unit: unit.row?.unit ?? body.unit
-      });
       const liveFacts = await deps.fetchPrFacts({ repo: instance.repo, number: open2.number });
       if (liveFacts === void 0) throw new Error(`could not read ${instance.repo}#${open2.number}`);
-      await remember({ number: open2.number, url: open2.htmlUrl }, liveFacts);
       const current = pullRequestState(open2.number, open2.htmlUrl, liveFacts);
       if (current === void 0) throw new Error(headBranchStateError(instance.repo, open2.number));
-      if (current.state !== "open") return json3(200, { ok: true, ...current, at });
+      const discoveredPr = { number: open2.number, url: open2.htmlUrl };
+      if (current.state !== "open") {
+        await rememberTerminal(discoveredPr);
+        return json3(200, { ok: true, ...current, at });
+      }
+      await bindOpenPullRequest(deps, instance, unit.row, discoveredPr, liveFacts);
       const entryFacts = entry ? liveFacts : void 0;
       const branchHead = entryFacts?.headSha;
       const entryHead = branchHead ?? open2.headSha;
@@ -73496,22 +73557,27 @@ async function prCheck(body, deps) {
       }
       const recovered = await recoverPushedBranch(deps, instance, unit.row, branch2, recover.runId);
       if (recovered.kind === "opened") {
-        await remember({ number: recovered.pr.number, url: recovered.pr.htmlUrl });
         const recoveredFacts = await deps.fetchPrFacts({ repo: instance.repo, number: recovered.pr.number });
         if (recoveredFacts === void 0) throw new Error(`could not read ${instance.repo}#${recovered.pr.number}`);
         const recoveredState = pullRequestState(recovered.pr.number, recovered.pr.htmlUrl, recoveredFacts);
         if (recoveredState === void 0) throw new Error(headBranchStateError(instance.repo, recovered.pr.number));
+        const recoveredPr = { number: recovered.pr.number, url: recovered.pr.htmlUrl };
+        if (recoveredState.state === "open")
+          await bindOpenPullRequest(deps, instance, unit.row, recoveredPr, recoveredFacts);
+        else await rememberTerminal(recoveredPr);
         return json3(200, { ok: true, ...recoveredState, at });
       }
       return json3(200, { ok: true, state: "none", unrecovered: recovered.why, at });
     }
-    await remember({ number: merged.number, url: merged.htmlUrl });
     const mergedFacts = await deps.fetchPrFacts({ repo: instance.repo, number: merged.number });
     if (mergedFacts === void 0) throw new Error(`could not read ${instance.repo}#${merged.number}`);
     const state = pullRequestState(merged.number, merged.htmlUrl, mergedFacts);
     if (state?.state !== "merged") throw new Error(`${instance.repo}#${merged.number} no longer reads merged`);
+    await rememberTerminal({ number: merged.number, url: merged.htmlUrl });
     return json3(200, { ok: true, ...state, at });
   } catch (err2) {
+    if (err2 instanceof PublicationBindingRefusal)
+      return json3(409, { ok: false, error: err2.reason, message: "the open pull request was not durably bound", at });
     return json3(502, { ok: false, error: "github_unavailable", message: describe12(err2), at });
   }
 }
@@ -74734,7 +74800,7 @@ function createAdminCoordinatorHandler(deps) {
     })();
   };
 }
-var COORDINATOR_ADMIN_PREFIX, MAX_SPAWN_PROMPT_CHARS, FINISHED_LOOKBACK_PAGES, MAX_ADMIN_BODY_BYTES, UNIT_ID, PRESETS_OF_KIND, invalid, json3, describe12, isGenerated2, EVERY_RUN, REVIEW_POSTED_CHECKS, REVIEW_POSTED_RECHECK_MS, githubSecondStart, CHILD_SUPERSESSION_REASONS, ROUND_OUTCOMES, ENDING_ICON, STEPS;
+var COORDINATOR_ADMIN_PREFIX, MAX_SPAWN_PROMPT_CHARS, FINISHED_LOOKBACK_PAGES, MAX_ADMIN_BODY_BYTES, UNIT_ID, PRESETS_OF_KIND, invalid, json3, describe12, isGenerated2, EVERY_RUN, REVIEW_POSTED_CHECKS, REVIEW_POSTED_RECHECK_MS, githubSecondStart, CHILD_SUPERSESSION_REASONS, PublicationBindingRefusal, samePublicationOwner, ROUND_OUTCOMES, ENDING_ICON, STEPS;
 var init_adminCoordinator = __esm({
   "../../src/channels/adminCoordinator.ts"() {
     "use strict";
@@ -74790,6 +74856,14 @@ var init_adminCoordinator = __esm({
     REVIEW_POSTED_RECHECK_MS = 2e3;
     githubSecondStart = (at) => Math.floor(at / SECOND_MS) * SECOND_MS;
     CHILD_SUPERSESSION_REASONS = /* @__PURE__ */ new Set(["merged", "closed", "head_moved", "branch_deleted"]);
+    PublicationBindingRefusal = class extends Error {
+      constructor(reason2) {
+        super(reason2);
+        this.reason = reason2;
+      }
+      reason;
+    };
+    samePublicationOwner = (left, right) => left?.instanceId === right.instanceId && left.unit === right.unit;
     ROUND_OUTCOMES = [
       "started",
       "pr_opened",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@coreplane/switchboard",
-  "version": "1.261.3",
+  "version": "1.261.4",
   "description": "Mention it in Slack and an agent reviews the PR, ships the fix, or answers the question — on the model you choose, with its tools running where you decide.",
   "license": "Apache-2.0",
   "homepage": "https://openswitchboard.dev",