@coorpacademy/app-review 0.5.0 → 0.5.1

package/es/common/index.js

@@ -7,7 +7,7 @@ export const VIEWS = {
 };
 export const slideIndexes = ['0', '1', '2', '3', '4'];
 export const getProgressionSlidesRefs = (progression) => {
-    if (progression.state.step.current < 5) {
+    if (progression.state.step.current <= 5) {
         const slideRef = progression.state.nextContent.ref;
         return concat(progression.state.slides, [slideRef]);
     }

package/lib/common/index.js

@@ -7,7 +7,7 @@ export var VIEWS = {
 };
 export var slideIndexes = ['0', '1', '2', '3', '4'];
 export var getProgressionSlidesRefs = function (progression) {
-    if (progression.state.step.current < 5) {
+    if (progression.state.step.current <= 5) {
         var slideRef = progression.state.nextContent.ref;
         return concat(progression.state.slides, [slideRef]);
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@coorpacademy/app-review",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "",
   "engines": {
     "node": ">=16.15.0"
@@ -9,7 +9,7 @@
   "scripts": {
     "static": "webpack --progress --output-path static/dist",
     "poststatic": "cp sandbox/index.html static/index.html",
-    "start": "cross-env BABEL_ENV=es webpack-dev-server --content-base sandbox --host 0.0.0.0 --history-api-fallback true --hot true",
+    "start": "cross-env BABEL_ENV=es webpack-dev-server",
     "prepare": "npm run clean && npm run build --production",
     "build:commonjs": "tsc -p tsconfig.lib.json",
     "build:es": "tsc -p tsconfig.es.json",
@@ -43,11 +43,11 @@
     "./package.json": "./package.json"
   },
   "dependencies": {
-    "@coorpacademy/components": "10.23.8",
+    "@coorpacademy/components": "10.24.0",
     "@coorpacademy/redux-task": "^1.1.5",
     "cross-fetch": "^3.1.5",
     "jwt-decode": "^3.1.2",
-    "react-redux": "7.2.8",
+    "react-redux": "^7.2.9",
     "redux": "^4.2.0",
     "redux-thunk": "^2.4.1"
   },
@@ -58,7 +58,7 @@
   "devDependencies": {
     "@coorpacademy/css-modules-require-hook": "2.1.5",
     "@coorpacademy/eslint-plugin-coorpacademy": "^11.0.0",
-    "@coorpacademy/webpack-config": "10.0.4",
+    "@coorpacademy/webpack-config": "10.0.5",
     "@testing-library/react": "^12.1.5",
     "@types/lodash": "^4.14.182",
     "@typescript-eslint/eslint-plugin": "^5.28.0",
@@ -66,17 +66,16 @@
     "ava": "^4.3.0",
     "browser-env": "^3.3.0",
     "concurrently": "^5.2.0",
-    "dotenv": "^16.0.1",
     "eslint": "^8.18.0",
     "eslint-plugin-react-hooks": "^4.6.0",
     "nock": "^13.2.9",
     "react-dom": "^17.0.2",
-    "ts-loader": "^8.2.0",
+    "ts-loader": "^9.4.1",
     "ts-node": "^10.9.1",
     "typescript": "^4.7.4",
-    "webpack": "^4.43.0",
-    "webpack-cli": "^3.3.11",
-    "webpack-dev-server": "^3.11.0"
+    "webpack": "^5.74.0",
+    "webpack-cli": "^4.10.0",
+    "webpack-dev-server": "^4.11.1"
   },
-  "gitHead": "ef2f2340a0169672d5880e8fb9900cd7c7ebf12c"
+  "gitHead": "abad47a390275389da6de707a0473141eab843ac"
 }

package/src/common/index.ts

@@ -17,7 +17,7 @@ export const slideIndexes = ['0', '1', '2', '3', '4'] as const;
 export type SlideIndexes = typeof slideIndexes[number];
 
 export const getProgressionSlidesRefs = (progression: ProgressionFromAPI): string[] => {
-  if (progression.state.step.current < 5) {
+  if (progression.state.step.current <= 5) {
     const slideRef = progression.state.nextContent.ref;
     return concat(progression.state.slides, [slideRef]);
   }

package/src/common/test/get-progression-slide-ref.test.ts

@@ -0,0 +1,35 @@
+import test from 'ava';
+import {
+  postAnswerResponses,
+  postProgressionResponse,
+  progressionSlideWithPendingSlide
+} from '../../test/util/services.mock';
+import {templateSlide} from '../../views/slides/test/fixtures/template';
+import {getProgressionSlidesRefs} from '..';
+
+test('should return first slide for a created slide', t => {
+  const slides = getProgressionSlidesRefs(postProgressionResponse);
+  t.deepEqual(slides, ['sli_VJYjJnJhg']);
+});
+
+test('should return all 5 slides when user is going to answer the 5th slide', t => {
+  const slides = getProgressionSlidesRefs(postAnswerResponses[templateSlide._id]);
+  t.deepEqual(slides, [
+    'sli_VJYjJnJhg',
+    'sli_VkSQroQnx',
+    'sli_N1XACJobn',
+    'sli_VkAzsCLKb',
+    'sli_N13-hG3kX'
+  ]);
+});
+
+test('should return all 5 slides when progression has a nextContent ref that is a pending slide', t => {
+  const slides = getProgressionSlidesRefs(progressionSlideWithPendingSlide);
+  t.deepEqual(slides, [
+    'sli_VJYjJnJhg',
+    'sli_VkSQroQnx',
+    'sli_N1XACJobn',
+    'sli_VkAzsCLKb',
+    'sli_N13-hG3kX'
+  ]);
+});