@coolon/angular-ui-powerups 12.4.0-alpha.31 → 12.4.0-alpha.33

package/bundles/coolon-angular-ui-powerups.umd.js

@@ -7321,17 +7321,28 @@
             _this.childPlaces = _this.placeDefinition.children.map(function (d) { return d.component; });
             return _this;
         }
-        // @Trace()
         PlaceComponent.prototype.initialiseVisit = function (visit, notifyVisitChanged) {
             var _this = this;
             pectin.assert.isNil(this.visitModel.value);
             var when = pectin.Dsl.disposeWith(this).when;
             this.visitModel.value = visit;
             pectin.DebugContext.getOrCreate(this.visitModel).tag(this.placeDefinition.component.name + ".visitModel");
-            this.placeDefinition.getVisitParameterDefs().forEach(function (parameterDef) { return _this.installBinding(parameterDef); });
+            // we track if the any of the bindings updated the route.  If so we remember it and update the
+            // route in one go at the end.
+            this.placeDefinition
+                .getVisitParameterDefs()
+                .forEach(function (parameterDef) { return _this.installAndInitialiseBinding(visit, parameterDef); });
             when(this.visitModel).changes(function (current, previous) {
                 notifyVisitChanged(current, previous);
             }, { unless: this._inVisitUpdate });
+            // TODO: this needs to do a replace url option so that the new url isn't put in the history.... for
+            //       now we're not doing it as it's a fair bit of effort and will only affect people if they're
+            //       cutting and pasting urls to each other.
+            // // the binding process can update the visit (e.g. if a selection model has already selected during
+            // // component construction) and there was no value specified in the route
+            // if (visit.hasRoutingChangedFrom(this.visitModel.value)) {
+            //   notifyVisitChanged(this.visitModel.value, visit)
+            // }
         };
         PlaceComponent.prototype.updateVisit = function (visit) {
             var _this = this;
@@ -7345,7 +7356,12 @@
             return !!this.visitModel.value;
         };
         // @Trace()
-        PlaceComponent.prototype.installBinding = function (parameterDef) {
+        /**
+         * Initialised the component bindings.  If any binding has an initial model value (e.g. a selection model
+         * initialised during the constructor) and the route has nothing, then the visit will be udpated and this
+         * method will return ture to nofiy the the visit has changed.
+         */
+        PlaceComponent.prototype.installAndInitialiseBinding = function (initialVisit, parameterDef) {
             var model = this[parameterDef.propertyName];
             pectin.DebugContext.tag(model, this.placeDefinition.component.name + "." + parameterDef.propertyName);
             var binding = this.registerDisposable(new pectin.Binding(this.visitModel, model, {
@@ -7359,7 +7375,17 @@
                     return currentVisit.replace(parameterDef, value);
                 }
             }));
-            binding.writeRight();
+            // Now we need to initialise the binding direction.  If we have a value in the Url then we should always push
+            // that to the view.  If we don't and the view already has a value (e.g. a selection model has already initialised in the
+            // component constructor) then we should push that to the route.
+            var isInVisit = !___namespace.isNil(initialVisit.getParameterValue(parameterDef));
+            var isInModel = !___namespace.isNil(model.value);
+            if (!isInVisit && isInModel) {
+                binding.writeLeft(); // push it to the route
+            }
+            else {
+                binding.writeRight(); // push it to the model
+            }
         };
         Object.defineProperty(PlaceComponent.prototype, "placeDefinition", {
             get: function () {
@@ -8620,9 +8646,13 @@
             });
             return new Visit(this.placeDefinition, params);
         };
+        // @Trace()
         Visit.prototype.hasRoutingChangedFrom = function (other) {
             var samePlace = other.placeDefinition === this.placeDefinition;
-            var sameRouteParameters = ___namespace.isEqual(this.placeDefinition.getFormattedRouteParameters(this, true), this.placeDefinition.getFormattedRouteParameters(other, true));
+            var currentParams = this.placeDefinition.getFormattedRouteParameters(this, true);
+            var otherParams = this.placeDefinition.getFormattedRouteParameters(other, true);
+            // console.log({currentParams, otherParams});
+            var sameRouteParameters = ___namespace.isEqual(currentParams, otherParams);
             return !samePlace || !sameRouteParameters;
         };
         Visit.prototype.hasChangedFrom = function (other) {