@coolon/angular-ui-powerups 0.0.68 → 0.0.69

package/bundles/coolon-angular-ui-powerups.umd.js

@@ -2572,7 +2572,7 @@
          * @return {?}
          */
         function (visit) {
-            return !visit.hasParameter(this.name) || (this.isRouteId && !visit.hasRouteId());
+            return !visit.hasParameter(this.name);
         };
         return ParameterDefinition;
     }());
@@ -3039,7 +3039,17 @@
                         function (v) { return def.urlFormat.parse(v); }));
                     }
                     else {
-                        result[def.name] = def.urlFormat.parse(params.get(def.name));
+                        /** @type {?} */
+                        var value = def.urlFormat.parse(params.get(def.name));
+                        // because our id routes redirect if the id isn't pressent we always have a id
+                        // parameter in our params.  This will bugger our remember and defaultvalue sanitisation
+                        // as it'll see that the id is present (event thought its null).  The sanitisation can't
+                        // check for null as that's a valid value for the id.
+                        /** @type {?} */
+                        var isEmptyRouteId = def.isRouteId && def.isEmptyValue(value);
+                        if (!isEmptyRouteId) {
+                            result[def.name] = value;
+                        }
                     }
                 }
             }));
@@ -3969,6 +3979,9 @@
             return __awaiter(this, void 0, void 0, function () {
                 var _this = this;
                 return __generator(this, function (_a) {
+                    // we have to push to history so our remember sanitisers don't pick up the previous value
+                    // when it's been cleared by the user.
+                    this.placeHistory.add(next);
                     // FIXME: no route id -> route id duplicates route parameters
                     if (next.hasRoutingChangedFrom(previous)) {
                         return [2 /*return*/, this.doNavigation(next, (/**
@@ -3992,9 +4005,6 @@
                                 });
                             }))];
                     }
-                    else {
-                        this.placeHistory.add(next);
-                    }
                     return [2 /*return*/];
                 });
             });
@@ -4026,6 +4036,7 @@
                             return [3 /*break*/, 5];
                         case 3:
                             def = visit.placeDefinition;
+                            // @see https://coolon.atlassian.net/browse/AUP-41
                             parameterCommands = visit.hasRouteId() ?
                                 [def.getFormattedRouteId(visit), def.getFormattedRouteParameters(visit)] :
                                 [def.getFormattedRouteParameters(visit)];