@cookshack/eslint-config 2.0.5 → 4.0.0

package/dist/index.js

@@ -1,18 +1,17 @@
 import globals from 'globals';
 
-let rules, languageOptions, plugins;
-
-let printBuffer;
+let varIds, nextVarId, printBuffer;
 
 printBuffer = [];
+varIds = new Map();
+nextVarId = 0;
 
 function print
 (...args) {
-  //console.log(args.join(' '))
   printBuffer.push(args.join(' '));
 }
 
-function trace
+function trace$2
 (...args) {
 }
 
@@ -32,7 +31,7 @@ function getNarrowestScope
 
   common = null;
   for (let ref of variable.references) {
-    if (variable.defs.some(def => def.name === ref.identifier))
+    if (variable.defs.some(def => def.name == ref.identifier))
       continue
     if (ref.from)
       if (common)
@@ -102,15 +101,15 @@ function getConditionalContext
   prevNode = ref.identifier;
   node = ref.identifier.parent;
   while (node) {
-    if (node === scopeBlock)
+    if (node == scopeBlock)
       break
-    if (node.type === 'IfStatement')
-      if (prevNode === node.test || nodeContains(node.test, prevNode))
+    if (node.type == 'IfStatement')
+      if (prevNode == node.test || nodeContains(node.test, prevNode))
         prevNode = node;
       else
         return 'B'
     else if ([ 'WhileStatement', 'DoWhileStatement', 'ForStatement', 'ForInStatement', 'ForOfStatement', 'SwitchStatement' ].includes(node.type))
-      if (prevNode === node.test || nodeContains(node.test, prevNode))
+      if (prevNode == node.test || nodeContains(node.test, prevNode))
         prevNode = node;
       else
         return 'B'
@@ -121,18 +120,20 @@ function getConditionalContext
   return ''
 }
 
-function nodeContains(node, target) {
-  if (node === target)
+function nodeContains
+(node, target) {
+  if (node == target)
     return true
-  if (node && typeof node === 'object')
+  if (node && typeof node == 'object')
     for (let key in node)
       if (nodeHas(node[key], target))
         return true
   return false
 }
 
-function nodeHas(value, target) {
-  if (value === target)
+function nodeHas
+(value, target) {
+  if (value == target)
     return true
   if (Array.isArray(value))
     return value.some(v => nodeContains(v, target))
@@ -146,15 +147,15 @@ function isConditionalRef
   node = ref.identifier.parent;
 
   while (node) {
-    if (node === narrowestScope.block)
+    if (node == narrowestScope.block)
       break
-    if (node.type === 'BlockStatement') {
+    if (node.type == 'BlockStatement') {
       let parent;
 
       parent = node.parent;
-      if (parent?.type === 'IfStatement' && (parent.consequent === node || parent.alternate === node))
+      if (parent?.type == 'IfStatement' && (parent.consequent == node || parent.alternate == node))
         return true
-      if ([ 'WhileStatement', 'DoWhileStatement', 'ForStatement', 'ForInStatement', 'ForOfStatement' ].includes(parent?.type) && parent.body === node)
+      if ([ 'WhileStatement', 'DoWhileStatement', 'ForStatement', 'ForInStatement', 'ForOfStatement' ].includes(parent?.type) && parent.body == node)
         return true
     }
     node = node.parent;
@@ -186,19 +187,17 @@ function mayBeReadBeforeAnyWrite
     let item;
 
     if (isReadRef(ref))
-      // a possible read
       return 1
 
     item = ref.cookshackNarrowestScopeItem;
     if (item.ctx == 'B' || isConditionalRef(ref, narrowestScope))
-      // a conditional write
       continue
-    // A guaranteed write before any possible read.
     return 0
   }
 }
 
-function scopeStart(scope) {
+function scopeStart
+(scope) {
   if (scope.block == null)
     return Infinity
   if (scope.type == 'function' && scope.block.id)
@@ -208,50 +207,73 @@ function scopeStart(scope) {
   return scope.block.range[0]
 }
 
-function buildScopeTree(scope, prefix, scopeToNode) {
+function ensureInVarIds
+(variable) {
+  if (varIds.has(variable))
+    return
+  varIds.set(variable, nextVarId++);
+}
+
+function isCompoundAssignmentOp
+(op) {
+  if (op == '=')
+    return 0
+  return 1
+}
+
+function buildScopeTree
+(scope, prefix, scopeToNode, astToTree) {
   let node, siblingNum;
 
-  node = {
-    scope,
-    prefix,
-    items: [],
-    children: []
-  };
+  node = { scope,
+           prefix,
+           items: [],
+           children: [] };
+
   scopeToNode.set(scope, node);
+  if (scope.block && astToTree)
+    astToTree.set(scope.block, node);
 
   siblingNum = 0;
   for (let child of scope.childScopes) {
     siblingNum++;
-    node.children.push(buildScopeTree(child, prefix + '.' + siblingNum, scopeToNode));
+    node.children.push(buildScopeTree(child, prefix + '.' + siblingNum, scopeToNode, astToTree));
   }
 
   for (let variable of scope.variables) {
-    if (variable.defs.length > 0)
-      node.items.push({ type: 'LET', name: variable.name, pos: variable.defs[0].name.range[0] });
+    if (variable.defs.length > 0) {
+      ensureInVarIds(variable);
+      node.items.push({ type: 'LET', name: variable.name, pos: variable.defs[0].name.range[0], defNode: variable.defs[0].node, defType: variable.defs[0].type, identifier: variable.defs[0].name, variable, varId: varIds.get(variable) });
+    }
 
     for (let ref of variable.references) {
       let targetNode;
 
       targetNode = scopeToNode.get(ref.from);
       if (targetNode) {
-        let parent, sortPos, ctx, item;
+        let parent, sortPos, ctx, item1, item2;
 
         ctx = getConditionalContext(ref);
         parent = ref.identifier.parent;
 
         if (isWriteRef(ref))
           if (ref.identifier.parent?.type == 'UpdateExpression') {
-            targetNode.items.push({ type: 'READ', name: ref.identifier.name, ctx, pos: ref.identifier.range[0] });
-            item = { ref, type: 'WRITE', name: ref.identifier.name, pos: ref.identifier.range[0] };
+            item1 = { ref, type: 'READ', name: ref.identifier.name, ctx, pos: ref.identifier.range[0] };
+            item2 = { ref, type: 'WRITE', name: ref.identifier.name, pos: ref.identifier.range[0] };
           }
           else if (ref.identifier.parent?.type == 'AssignmentExpression') {
             sortPos = parent.right.range[1] + 0.4;
-            item = { ref, type: 'WRITE', name: ref.identifier.name, ctx, pos: sortPos };
+            if (ref.identifier.parent.left == ref.identifier && isCompoundAssignmentOp(ref.identifier.parent.operator)) {
+              item1 = { ref, type: 'READ', name: ref.identifier.name, ctx, pos: ref.identifier.range[0] };
+              item2 = { ref, type: 'WRITE', name: ref.identifier.name, pos: sortPos };
+            }
+            else
+              item1 = { ref, type: 'WRITE', name: ref.identifier.name, ctx, pos: sortPos };
           }
           else if (ref.identifier.parent?.type == 'VariableDeclarator')
-            item = { ref, type: 'WRITE', name: ref.identifier.name, pos: ref.identifier.range[0] + 0.4 };
+            item1 = { ref, type: 'WRITE', name: ref.identifier.name, pos: ref.identifier.range[0] + 0.4 };
           else
-            item = { ref, type: 'WRITE', name: ref.identifier.name, pos: ref.identifier.range[0] };
+            item1 = { ref, type: 'WRITE', name: ref.identifier.name, pos: ref.identifier.range[0] };
         else {
           let declarator;
 
@@ -265,10 +287,16 @@ function buildScopeTree(scope, prefix, scopeToNode) {
             sortPos = declarator.id ? declarator.id.range[0] - 0.4 : ref.identifier.range[0];
           else
             sortPos = ref.identifier.range[0];
-          item = { ref, type: 'READ', name: ref.identifier.name, ctx, pos: sortPos };
+          item1 = { ref, type: 'READ', name: ref.identifier.name, ctx, pos: sortPos };
+        }
+        ensureInVarIds(variable);
+        item1.varId = varIds.get(variable);
+        targetNode.items.push(item1);
+        if (item2) {
+          item2.varId = varIds.get(variable);
+          targetNode.items.push(item2);
         }
-        targetNode.items.push(item);
-        ref.cookshackNarrowestScopeItem = item;
+        ref.cookshackNarrowestScopeItem = item2 || item1;
       }
     }
   }
@@ -278,7 +306,8 @@ function buildScopeTree(scope, prefix, scopeToNode) {
   return node
 }
 
-function checkScopeNode(context, treeNode, reported, scopeToNode) {
+function checkScopeNode
+(context, treeNode, reported, scopeToNode) {
   let indent;
 
   reported = reported || new Set;
@@ -289,11 +318,11 @@ function checkScopeNode(context, treeNode, reported, scopeToNode) {
 
     if (reported.has(variable))
       continue
-    if (variable.defs.length === 0)
+    if (variable.defs.length == 0)
       continue
     if ([ 'Parameter', 'FunctionName', 'ImportBinding', 'CatchClause', 'ClassName' ].includes(variable.defs[0].type))
       continue
-    if (variable.defs[0].node.parent?.parent?.type === 'ExportNamedDeclaration')
+    if (variable.defs[0].node.parent?.parent?.type == 'ExportNamedDeclaration')
       continue
 
     defNode = variable.defs[0]?.name;
@@ -302,38 +331,36 @@ function checkScopeNode(context, treeNode, reported, scopeToNode) {
 
       defScope = getDefinitionScope(variable);
       defNodePrefix = scopeToNode.get(defScope)?.prefix ?? '?';
-      trace(indent, '1 found decl scope of', variable.name + ':', defNodePrefix + ' ' + defScope.type.toUpperCase());
+      trace$2(indent, '1 found decl scope of', variable.name + ':', defNodePrefix + ' ' + defScope.type.toUpperCase());
 
       narrowestScope = getNarrowestScope(variable);
       if (narrowestScope) {
         let narrowestPrefix;
 
         narrowestPrefix = scopeToNode.get(narrowestScope)?.prefix ?? '?';
-        trace(indent, '2 found narrowest scope of', variable.name + ':', narrowestPrefix + ' ' + narrowestScope?.type.toUpperCase());
+        trace$2(indent, '2 found narrowest scope of', variable.name + ':', narrowestPrefix + ' ' + narrowestScope?.type.toUpperCase());
 
         markConditionalRefs(variable, scopeToNode, narrowestScope);
 
         if (defScope == narrowestScope)
           continue
-        trace(indent, '3', variable.name, 'could be moved to a narrower scope');
+        trace$2(indent, '3', variable.name, 'could be moved to a narrower scope');
 
         if (defScope.type == 'for') {
-          trace(indent, '4 exception:', variable.name, 'is in a for loop header');
+          trace$2(indent, '4 exception:', variable.name, 'is in a for loop header');
           continue
         }
         if (mayBeReadBeforeAnyWrite(variable, scopeToNode, narrowestScope)) {
-          trace(indent, '4 exception:', variable.name, 'mayBeReadBeforeAnyWrite');
+          trace$2(indent, '4 exception:', variable.name, 'mayBeReadBeforeAnyWrite');
           continue
         }
 
-        trace(indent, '5', variable.name, 'is too broad');
+        trace$2(indent, '5', variable.name, 'is too broad');
 
         reported.add(variable);
-        context.report({
-          node: defNode,
-          messageId: 'tooBroad',
-          data: { name: variable.name }
-        });
+        context.report({ node: defNode,
+                         messageId: 'tooBroad',
+                         data: { name: variable.name } });
       }
     }
   }
@@ -342,10 +369,11 @@ function checkScopeNode(context, treeNode, reported, scopeToNode) {
     checkScopeNode(context, child, reported, scopeToNode);
 }
 
-function printTree(node, siblingNum) {
+function printTree
+(node, siblingNum) {
   let prefix, all, indent;
 
-  prefix = siblingNum === 0 ? node.prefix : node.prefix.split('.').slice(0, -1).join('.') + '.' + siblingNum;
+  prefix = siblingNum == 0 ? node.prefix : node.prefix.split('.').slice(0, -1).join('.') + '.' + siblingNum;
   indent = '  '.repeat(prefix.split('.').length - 1);
   {
     let name;
@@ -359,13 +387,11 @@ function printTree(node, siblingNum) {
   all.sort((a, b) => a.pos - b.pos);
 
   for (let entry of all)
-    if (entry.type === 'item')
+    if (entry.type == 'item')
       print(indent
             + '  ' + entry.data.type.padEnd(5)
             + ' ' + entry.data.name
-            // B: is the ref conditional within the scope that "owns" the ref (for single statement `if`)
             + (entry.data.ctx ? ' ' + entry.data.ctx : '').padEnd(3)
-            // C: is the ref conditional within the variable's narrowestScope?
             + (entry.data.isConditional ? 'C' : ' ').padEnd(2)
             + 'pos ' + entry.data.pos);
     else
@@ -379,111 +405,713 @@ function createNarrowestScope
   clearPrintBuffer();
   scopeManager = context.sourceCode.scopeManager;
   if (scopeManager)
-    return {
-      'Program:exit'() {
-        let tree, scopeToNode;
-
-        scopeToNode = new Map;
-        tree = buildScopeTree(scopeManager.scopes[0], '1', scopeToNode);
-        checkScopeNode(context, tree, null, scopeToNode);
-        printTree(tree, 0);
+    return { 'Program:exit'
+             () {
+               let tree, scopeToNode;
+
+               scopeToNode = new Map;
+               nextVarId = 0;
+               tree = buildScopeTree(scopeManager.scopes[0], '1', scopeToNode);
+               checkScopeNode(context, tree, null, scopeToNode);
+               printTree(tree, 0);
+             } }
+}
+
+var narrowestScopePlugin = { meta: { type: 'suggestion',
+                  docs: { description: 'Enforce variables are declared in their narrowest possible scope.' },
+                  messages: { tooBroad: 'Variable "{{ name }}" is declared in a broader scope than necessary.' },
+                  schema: [] },
+          create: createNarrowestScope };
+
+function createPositiveVibes
+(context) {
+  return { UnaryExpression
+           (node) {
+             if (node.operator == '!')
+               context.report({ node,
+                                messageId: 'positiveVibes' });
+           },
+           BinaryExpression
+           (node) {
+             if (node.operator == '!=')
+               context.report({ node,
+                                messageId: 'equality' });
+             else if (node.operator == '!==')
+               context.report({ node,
+                                messageId: 'strictEquality' });
+           } }
+}
+
+var positiveVibesPlugin = { meta: { type: 'problem',
+                  docs: { description: 'Prefer positive expressions.' },
+                  messages: { positiveVibes: 'Be positive!',
+                              equality: 'Use ==.',
+                              strictEquality: 'Use ===.' },
+                  schema: [] },
+          create: createPositiveVibes };
+
+var useRiskyEqualPlugin = { meta: { type: 'problem',
+                  docs: { description: 'Enforce use of == instead of ===.' },
+                  messages: { risky: 'Use ==.' },
+                  schema: [] },
+          create
+          (context) {
+            return { BinaryExpression
+                     (node) {
+                       if (node.operator == '===')
+                         context.report({ node, messageId: 'risky' });
+                     } }
+          } };
+
+function create$4
+(context) {
+  return { VariableDeclaration
+           (node) {
+             if (node.kind == 'const' || node.kind == 'var')
+               context.report({ node, messageId: 'useLet' });
+           } }
+}
+
+var alwaysLetPlugin = { meta: { type: 'problem',
+                  docs: { description: 'Enforce use of let instead of const or var.' },
+                  messages: { useLet: 'Use let.' },
+                  schema: [] },
+          create: create$4 };
+
+let ostIdCounter, ost;
+
+ostIdCounter = 0;
+ost = 0;
+
+function trace$1
+(...args) {
+}
+
+function createInitBeforeUse
+(context) {
+  let scopeManager;
+
+  scopeManager = context.sourceCode.scopeManager;
+  if (scopeManager)
+    return { 'Program:exit'
+             () {
+               let scopeToNode, astToTree, astToOst;
+               scopeToNode = new Map;
+               astToTree = new Map;
+               astToOst = new Map;
+               buildScopeTree(scopeManager.scopes[0], '1', scopeToNode, astToTree);
+
+               ostIdCounter = 0;
+               ost = processAst(context.sourceCode.ast, null, astToTree, astToOst, '', new Set());
+
+               ostAnnotate(ost, astToOst, context);
+
+               ostCheck(ost, context);
+             } }
+}
+
+function isRegularDeclaration
+(item) {
+  if (item.type == 'LET') {
+    if (item.defType == 'FunctionName' || item.defType == 'Parameter')
+      return 0
+    return 1
+  }
+  return 0
+}
+
+function processAst
+(astNode, parentOst, astToTree, astToOst, indent, visited) {
+  if (astNode) {
+    let treeNode, scopeName, lets, reads, writes, ost, children;
+
+    if (visited.has(astNode))
+      return
+    visited.add(astNode);
+
+    treeNode = astToTree.get(astNode) ?? parentOst?.treeNode;
+
+    scopeName = treeNode?.scope ? `${treeNode.scope.type}` : 'no-scope';
+    if (treeNode?.scope?.block?.id?.name)
+      scopeName += `(${treeNode.scope.block.id.name})`;
+    trace$1(`${indent}${astNode.type}`);
+
+    lets = [];
+    reads = [];
+    writes = [];
+
+    for (let item of treeNode?.items ?? [])
+      if (isRegularDeclaration(item)) {
+        let scopeCreator;
+
+        scopeCreator = treeNode?.scope?.block;
+        if (scopeCreator && astNode == scopeCreator) {
+          lets.push({ item });
+          trace$1(`${indent}  | LET ${item.name}:${item.varId}`);
+        }
       }
+      else if (item.ref)
+        if (astNode == item.ref.identifier)
+          if (item.type == 'READ') {
+            reads.push({ item });
+            trace$1(`${indent}  | READ ${item.name}:${item.varId}`);
+          }
+          else if (item.type == 'WRITE') {
+            writes.push({ item });
+            trace$1(`${indent}  | WRITE ${item.name}:${item.varId}`);
+          }
+
+    ost = { id: ostIdCounter++,
+            astNode,
+            treeNode,
+            scopeItems: treeNode?.items ?? [],
+            lets,
+            reads,
+            writes,
+            children: [],
+            fnDefOst: null };
+
+    astToOst.set(astNode, ost);
+
+    children = [];
+
+    if (astNode.type == 'ForOfStatement' || astNode.type == 'ForInStatement') {
+      if (astNode.right)
+        children.push(astNode.right);
+      if (astNode.left)
+        children.push(astNode.left);
+      if (astNode.body)
+        children.push(astNode.body);
+    }
+    else if (astNode.type == 'ForStatement') {
+      if (astNode.init)
+        children.push(astNode.init);
+      if (astNode.test)
+        children.push(astNode.test);
+      if (astNode.update)
+        children.push(astNode.update);
+      if (astNode.body)
+        children.push(astNode.body);
+    }
+    else if (astNode.type == 'AssignmentExpression') {
+      if (astNode.right)
+        children.push(astNode.right);
+      if (astNode.left)
+        children.push(astNode.left);
+    }
+    else {
+      if (astNode.body)
+        if (Array.isArray(astNode.body))
+          children.push(...astNode.body);
+        else
+          children.push(astNode.body);
+      if (astNode.consequent)
+        children.push(astNode.consequent);
+      if (astNode.alternate)
+        children.push(astNode.alternate);
+      if (astNode.block)
+        children.push(astNode.block);
+      if (astNode.expression)
+        children.push(astNode.expression);
+      if (astNode.callee)
+        children.push(astNode.callee);
+      if (astNode.object)
+        children.push(astNode.object);
+      if (astNode.property)
+        children.push(astNode.property);
+      if (astNode.init)
+        children.push(astNode.init);
+      if (astNode.id)
+        children.push(astNode.id);
+      if (astNode.declarations)
+        children.push(...astNode.declarations);
+      if (astNode.test)
+        children.push(astNode.test);
+      if (astNode.update)
+        children.push(astNode.update);
+      if (astNode.left)
+        children.push(astNode.left);
+      if (astNode.right)
+        children.push(astNode.right);
+      if (astNode.argument)
+        children.push(astNode.argument);
+      if (astNode.arguments)
+        children.push(...astNode.arguments);
+      if (astNode.elements)
+        children.push(...astNode.elements);
+      if (astNode.properties)
+        children.push(...astNode.properties);
     }
+
+    for (let child of children) {
+      let childOst;
+
+      childOst = processAst(child, ost, astToTree, astToOst, indent + '  ', visited);
+      if (childOst)
+        ost.children.push(childOst);
+    }
+
+    return ost
+  }
 }
 
-function createPositiveVibes
+function ostAnnotate
+(ost, astToOst, context) {
+  if (ost) {
+    for (let letInfo of ost.lets) {
+      let writeOst;
+
+      writeOst = findFirstWrite(ost, letInfo);
+      letInfo.firstWrite = writeOst;
+      if (writeOst)
+        continue
+      if (letInfo.item.defType == 'ImportBinding')
+        continue
+      context.report({ node: letInfo.item.identifier,
+                       messageId: 'mustInit',
+                       data: { name: letInfo.item.name } });
+    }
+
+    if (ost.astNode.type == 'CallExpression' && ost.astNode.callee?.type == 'Identifier')
+      for (let child of ost.children)
+        if (child.astNode == ost.astNode.callee && child.reads.length > 0) {
+          let readRef;
+
+          readRef = child.reads[0].item.ref;
+          if (readRef?.resolved) {
+            let variable;
+
+            variable = readRef.resolved;
+            if (variable.defs.length > 0) {
+              let fnDefAst;
+
+              fnDefAst = variable.defs[0].node;
+              if (fnDefAst) {
+                if (fnDefAst.init?.type == 'ArrowFunctionExpression' || fnDefAst.init?.type == 'FunctionExpression')
+                  fnDefAst = fnDefAst.init;
+                ost.fnDefOst = astToOst.get(fnDefAst);
+              }
+            }
+          }
+        }
+
+    for (let child of ost.children)
+      ostAnnotate(child, astToOst, context);
+  }
+}
+
+function findFirstWrite
+(ost, letInfo) {
+  if (ost.astNode.type == 'FunctionDeclaration' || ost.astNode.type == 'ArrowFunctionExpression' || ost.astNode.type == 'FunctionExpression')
+    for (let child of ost.children)
+      if (child.astNode.type == 'BlockStatement')
+        return findFirstWriteInSubtree(child, letInfo)
+  return findFirstWriteInSubtree(ost, letInfo)
+}
+
+function findFirstWriteInSubtree
+(ost, letInfo) {
+  if (ost) {
+    if (ost.astNode.type == 'FunctionDeclaration' || ost.astNode.type == 'ArrowFunctionExpression' || ost.astNode.type == 'FunctionExpression')
+      return null
+
+    for (let writeInfo of ost.writes) {
+      let writeVar;
+
+      writeVar = writeInfo.item.ref.resolved;
+      if (writeVar == letInfo.item.variable)
+        return ost
+    }
+
+    for (let child of ost.children) {
+      let result;
+
+      result = findFirstWriteInSubtree(child, letInfo);
+      if (result)
+        return result
+    }
+  }
+
+  return null
+}
+
+function ostCheck
+(ost, context) {
+  if (ost) {
+    for (let letInfo of ost.lets)
+      if (letInfo.firstWrite)
+        walk2Start(ost, letInfo, context);
+
+    for (let child of ost.children)
+      ostCheck(child, context);
+  }
+}
+
+function walk2Start
+(node, letInfo, context) {
+  if (node.astNode.type == 'FunctionDeclaration')
+    for (let child of node.children)
+      if (child.astNode.type == 'BlockStatement')
+        return walk2(child, letInfo, context, new Set())
+  return walk2(node, letInfo, context, new Set())
+}
+
+function walk2
+(node, letInfo, context, visited) {
+  if (node) {
+    if (node.astNode.type == 'FunctionDeclaration' || node.astNode.type == 'ArrowFunctionExpression' || node.astNode.type == 'FunctionExpression')
+      return false
+
+    if (node == letInfo.firstWrite) {
+      for (let readInfo of node.reads)
+        if (readInfo.item.ref.resolved == letInfo.item.variable) {
+          context.report({ node: readInfo.item.ref.identifier,
+                           messageId: 'initBeforeUse',
+                           data: { name: letInfo.item.name } });
+        }
+      return true
+    }
+
+    if (node.astNode.type == 'CallExpression' && node.fnDefOst) {
+      let fnType;
+
+      fnType = node.fnDefOst.astNode.type;
+
+      if (fnType == 'FunctionDeclaration' || fnType == 'ArrowFunctionExpression' || fnType == 'FunctionExpression') {
+        let key;
+
+        key = `${letInfo.item.name}:${node.fnDefOst.id}`;
+        if (visited.has(key)) ;
+        else {
+          visited.add(key);
+          for (let child of node.fnDefOst.children)
+            if (child.astNode.type == 'BlockStatement' && walk2(child, letInfo, context, visited))
+              return true
+        }
+      }
+    }
+
+    for (let readInfo of node.reads)
+      if (readInfo.item.ref.resolved == letInfo.item.variable) {
+        context.report({ node: readInfo.item.ref.identifier,
+                         messageId: 'initBeforeUse',
+                         data: { name: letInfo.item.name } });
+      }
+
+    for (let child of node.children)
+      if (walk2(child, letInfo, context, visited))
+        return true
+  }
+
+  return false
+}
+
+var initBeforeUsePlugin = { meta: { type: 'problem',
+                         docs: { description: 'Warn when a variable is used before being explicitly initialized.' },
+                         messages: { initBeforeUse: "'{{name}}' used before initialization.",
+                                     mustInit: "'{{name}}' must be initialized." },
+                         schema: [] },
+                 create: createInitBeforeUse };
+
+function VariableDeclaration
+(context, node) {
+  let parent;
+
+  parent = node.parent;
+
+  for (parent = node.parent; parent; parent = parent.parent)
+    if (parent.type == 'BlockStatement')
+      break
+
+  if (parent) {
+    let idx;
+
+    if (parent.parent?.type == 'CatchClause')
+      return
+
+    idx = parent.body.indexOf(node);
+    for (let i = 0; i < idx; i++) {
+      if (parent.body[i].type == 'VariableDeclaration')
+        continue
+      context.report({ node, messageId: 'varDeclBlockStart' });
+      return
+    }
+  }
+}
+
+function create$3
 (context) {
-  return {
-    UnaryExpression(node) {
-      if (node.operator == '!')
-        context.report({ node,
-                         messageId: 'positiveVibes' });
-    },
-    BinaryExpression(node) {
-      if (node.operator == '!=')
-        context.report({ node,
-                         messageId: 'equality' });
-      else if (node.operator == '!==')
-        context.report({ node,
-                         messageId: 'strictEquality' });
+  return { VariableDeclaration: node => VariableDeclaration(context, node) }
+}
+
+var varDeclBlockStartPlugin = { meta: { type: 'suggestion',
+                  docs: { description: 'Require variable declarations to be at the start of the block.' },
+                  messages: { varDeclBlockStart: 'VarDecl must be at start of block.' },
+                  schema: [] },
+          create: create$3 };
+
+function FunctionDeclaration
+(context, node) {
+  let parent;
+
+  for (parent = node.parent; parent; parent = parent.parent)
+    if (parent.type == 'BlockStatement')
+      break
+
+  if (parent) {
+    let idx;
+
+    if (parent.parent?.type == 'CatchClause')
+      return
+
+    idx = parent.body.indexOf(node);
+    for (let i = 0; i < idx; i++) {
+      if (parent.body[i].type == 'VariableDeclaration'
+          || parent.body[i].type == 'FunctionDeclaration'
+          || parent.body[i].type == 'EmptyStatement')
+        continue
+      context.report({ node, messageId: 'fnDeclBlockStart' });
+      return
     }
   }
 }
 
-plugins = { 'cookshack': { rules: { 'positive-vibes': { meta: { type: 'problem',
-                                                                docs: { description: 'Prefer positive expressions.' },
-                                                                messages: { positiveVibes: 'Be positive!',
-                                                                            equality: 'Use ==.',
-                                                                            strictEquality: 'Use ===.' },
-                                                                schema: [] },
-                                                        create: createPositiveVibes },
-                                    'narrowest-scope': { meta: { type: 'suggestion',
-                                                                 docs: { description: 'Enforce variables are declared in their narrowest possible scope.' },
-                                                                 messages: { tooBroad: 'Variable "{{ name }}" is declared in a broader scope than necessary.' },
-                                                                 schema: [] },
-                                                         create: createNarrowestScope } } } };
-
-rules = {
-  'array-bracket-newline': [ 'error', 'never' ],
-  'array-bracket-spacing': [ 'error', 'always' ],
-  'arrow-parens': [ 'error', 'as-needed' ],
-  'brace-style': [ 'error', 'stroustrup' ],
-  'comma-dangle': 'error',
-  'curly': [ 'error', 'multi' ],
-  'eol-last': [ 'error', 'always' ],
-  'function-paren-newline': [ 'error', 'never' ],
-  'indent': [ 'error', 2, { ArrayExpression: 'first',
-                            CallExpression: { arguments: 'first' },
-                            //flatTernaryExpressions: true,
-                            //offsetTernaryExpressions: true,
-                            // ternary, because overhangs strangely (eg multiline in array def)
-                            'ignoredNodes': [ 'ConditionalExpression' ],
-                            FunctionDeclaration: { parameters: 'first', body: 1 },
-                            FunctionExpression: { parameters: 'first', body: 1 },
-                            ImportDeclaration: 'first',
-                            ObjectExpression: 'first',
-                            offsetTernaryExpressions: true,
-                            VariableDeclarator: 'first' } ],
-  'init-declarations': [ 'error', 'never', { 'ignoreForLoopInit': true } ],
-  'keyword-spacing': [ 'error', { before: true, after: true } ],
-  'linebreak-style': [ 'error', 'unix' ],
-  'padding-line-between-statements': [ 'error',
-                                       { blankLine: 'always', prev: 'let', next: '*' },
-                                       { blankLine: 'never', prev: 'let', next: 'let' } ],
-  'no-case-declarations': 'error',
-  'no-global-assign': 'error',
-  'cookshack/narrowest-scope': 'error',
-  'cookshack/positive-vibes': 'error',
-  'no-mixed-operators': 'error',
-  'no-multi-spaces': 'error',
-  'no-multiple-empty-lines': [ 'error', { max: 1, maxEOF: 0 } ],
-  'no-negated-condition': 'error',
-  'no-redeclare': 'error',
-  'no-sequences': 'error',
-  'no-sparse-arrays': 'error',
-  'no-tabs': 'error',
-  'no-trailing-spaces': 'error',
-  'no-undef': 'error',
-  'no-unsafe-negation': 'error',
-  'no-unused-vars': 'error',
-  'no-var': 'error',
-  'object-curly-spacing': [ 'error', 'always' ],
-  'object-shorthand': [ 'error', 'always' ],
-  quotes: [ 'error', 'single', { avoidEscape: true } ],
-  semi: [ 'error', 'never' ]
-  //'vars-on-top': [ 'error' ], // want version for let
-  //'newline-before-function-paren': ['error', 'always'],
-};
-
-languageOptions = {
-  globals: {
-    ...globals.node
-  },
-  parserOptions: {
-    ecmaVersion: 2025,
-    sourceType: 'module'
+function create$2
+(context) {
+  return { FunctionDeclaration: node => FunctionDeclaration(context, node) }
+}
+
+var fnDeclBlockStartPlugin = { meta: { type: 'suggestion',
+                  docs: { description: 'Require function declarations to be at the start of the block.' },
+                  messages: { fnDeclBlockStart: 'FnDecl must be the start the block (after VarDecls).' },
+                  schema: [] },
+          create: create$2 };
+
+function FnArgsNl
+(node, context) {
+  let nameLine, parenLine, nameEnd, i, newlines, parent;
+
+  parent = node.parent;
+
+  if (parent?.type == 'Property' && (parent.method || parent.kind == 'get' || parent.kind == 'set')) {
+    nameLine = parent.key.loc.start.line;
+    nameEnd = parent.key.range[1];
+  }
+  else if (parent?.type == 'MethodDefinition') {
+    nameLine = parent.key.loc.start.line;
+    nameEnd = parent.key.range[1];
+  }
+  else {
+    nameLine = node.loc.start.line;
+    nameEnd = node.range[0];
+  }
+
+  i = nameEnd;
+  newlines = 0;
+  while (i < context.sourceCode.text.length) {
+    if (context.sourceCode.text[i] == '(')
+      break
+    if (context.sourceCode.text[i] == '\n')
+      newlines++;
+    i++;
+  }
+
+  parenLine = nameLine + newlines;
+
+  if (parenLine - nameLine == 1)
+    return
+  context.report({ node, messageId: 'fnArgsNl' });
+}
+
+function create$1
+(context) {
+  return { FunctionDeclaration: node => FnArgsNl(node, context),
+           FunctionExpression: node => FnArgsNl(node, context) }
+}
+
+var fnArgsNlPlugin = { meta: { type: 'suggestion',
+                         docs: { description: 'Require function args on the line immediately after the function name.' },
+                         messages: { fnArgsNl: 'Fn args must be on the line immediately after the function name.' },
+                         schema: [] },
+                 create: create$1 };
+
+function trace
+(...args) {
+}
+
+function unit
+(context) {
+  return context.options[0] ?? 2
+}
+
+function checkObjectExpressionProperties
+(properties, node, context) {
+  let firstProp, sourceCode, lastProp, lastPropEnd, closingBrace, firstPropLine, firstPropCol, afterLastProp, closingLine, lastPropValueEndLine;
+
+  sourceCode = context.sourceCode.text;
+  firstProp = properties[0];
+  lastProp = properties[properties.length - 1];
+  firstPropLine = firstProp.loc.start.line;
+  firstPropCol = firstProp.loc.start.column;
+  lastPropEnd = lastProp.range[1];
+  closingBrace = sourceCode.indexOf('}', lastPropEnd);
+  closingLine = sourceCode.slice(0, closingBrace).split('\n').length;
+  afterLastProp = sourceCode.slice(lastPropEnd, closingBrace);
+  lastPropValueEndLine = sourceCode.slice(0, lastPropEnd).split('\n').length;
+  trace('CHECK POINT 1: is single-line? firstPropLine=%d, braceLine=%d, closingLine=%d', firstPropLine, node.loc.start.line, closingLine);
+  if (firstPropLine == node.loc.start.line && closingLine == firstPropLine)
+    return
+  trace('CHECK POINT 2: is firstPropLine (%d) != braceLine (%d)?', firstPropLine, node.loc.start.line);
+  if (firstPropLine == node.loc.start.line) ;
+  else if (firstPropCol == node.loc.start.column + unit(context)) ;
+  else {
+    context.report({ node: firstProp, messageId: 'indentStruct' });
   }
-};
+  for (let i = 1; i < properties.length; i++) {
+    let prop;
+
+    prop = properties[i];
+    if (prop.loc.start.column == firstPropCol) ;
+    else {
+      context.report({ node: prop, messageId: 'indentStruct' });
+    }
+  }
+  if (closingLine > lastPropValueEndLine) {
+    let braceCol, closingCol;
+
+    braceCol = node.loc.start.column;
+    closingCol = node.loc.end.column - 1;
+    if (closingCol == braceCol) ;
+    else {
+      context.report({ node, messageId: 'indentStruct' });
+    }
+  }
+  if (closingLine == lastPropValueEndLine) {
+    if (afterLastProp == ' ') ;
+    else {
+      context.report({ node, messageId: 'indentStruct' });
+    }
+  }
+  for (let prop of properties)
+    if (prop.method) {
+      let keyLine, keyEnd, i, newlines, parenLine;
+
+      keyLine = prop.key.loc.start.line;
+      keyEnd = prop.key.range[1];
+      i = keyEnd;
+      newlines = 0;
+
+      while (i < sourceCode.length) {
+        if (sourceCode[i] == '(')
+          break
+        if (sourceCode[i] == '\n')
+          newlines++;
+        i++;
+      }
+      parenLine = keyLine + newlines;
+      if (parenLine > keyLine) {
+        let parenCol;
+
+        parenCol = i - sourceCode.lastIndexOf('\n', i);
+        if (prop.value.type == 'FunctionExpression' && prop.value.async) ;
+        else if (parenCol - 1 == prop.key.loc.start.column) ;
+        else {
+          context.report({ node: prop, messageId: 'indentStruct' });
+        }
+      }
+    }
+}
+
+function checkObjectExpression
+(node, context) {
+  let properties;
+
+  properties = node.properties;
+  if (properties.length)
+    checkObjectExpressionProperties(properties, node, context);
+}
+
+function create
+(context) {
+  return { ObjectExpression: node => checkObjectExpression(node, context) }
+}
+
+var indentStructPlugin = { meta: { type: 'suggestion',
+                         docs: { description: 'Struct alignment rules.' },
+                         messages: { indentStruct: 'Indent structure' },
+                         schema: [] },
+                 create };
+
+let rules, languageOptions, plugins;
+
+plugins = { 'cookshack': { rules: { 'positive-vibes': positiveVibesPlugin,
+                                    'narrowest-scope': narrowestScopePlugin,
+                                    'use-risky-equal': useRiskyEqualPlugin,
+                                    'always-let': alwaysLetPlugin,
+                                    'init-before-use': initBeforeUsePlugin,
+                                    'var-decl-block-start': varDeclBlockStartPlugin,
+                                    'fn-decl-block-start': fnDeclBlockStartPlugin,
+                                    'fn-args-nl': fnArgsNlPlugin,
+                                    'indent-struct': indentStructPlugin } } };
+
+rules = { 'array-bracket-newline': [ 'error', 'never' ],
+          'array-bracket-spacing': [ 'error', 'always' ],
+          'arrow-parens': [ 'error', 'as-needed' ],
+          'brace-style': [ 'error', 'stroustrup' ],
+          'comma-dangle': 'error',
+          'curly': [ 'error', 'multi' ],
+          'eol-last': [ 'error', 'always' ],
+          'function-paren-newline': [ 'error', 'never' ],
+          'indent': [ 'error', 2, { ArrayExpression: 'first',
+                                    CallExpression: { arguments: 'first' },
+                                    //flatTernaryExpressions: true,
+                                    //offsetTernaryExpressions: true,
+                                    // ternary, because overhangs strangely (eg multiline in array def)
+                                    'ignoredNodes': [ 'ConditionalExpression', 'ObjectExpression *' ],
+                                    FunctionDeclaration: { parameters: 'first', body: 1 },
+                                    FunctionExpression: { parameters: 'first', body: 1 },
+                                    ImportDeclaration: 'first',
+                                    offsetTernaryExpressions: true,
+                                    VariableDeclarator: 'first' } ],
+          'init-declarations': [ 'error', 'never', { 'ignoreForLoopInit': true } ],
+          'keyword-spacing': [ 'error', { before: true, after: true } ],
+          'linebreak-style': [ 'error', 'unix' ],
+          'padding-line-between-statements': [ 'error',
+                                               { blankLine: 'always', prev: 'let', next: '*' },
+                                               { blankLine: 'never', prev: 'let', next: 'let' } ],
+          'no-case-declarations': 'error',
+          'no-global-assign': 'error',
+          'cookshack/positive-vibes': 'error',
+          'cookshack/narrowest-scope': 'error',
+          'cookshack/use-risky-equal': 'error',
+          'cookshack/always-let': 'error',
+          // using the implicit inititialization to undefined fits better
+          //'cookshack/init-before-use': 'error',
+          'cookshack/var-decl-block-start': 'error',
+          'cookshack/fn-decl-block-start': 'error',
+          'cookshack/fn-args-nl': 'error',
+          'cookshack/indent-struct': 'error',
+          'no-mixed-operators': 'error',
+          'no-multi-spaces': 'error',
+          'no-multiple-empty-lines': [ 'error', { max: 1, maxEOF: 0 } ],
+          'no-negated-condition': 'error',
+          'no-redeclare': 'error',
+          'no-sequences': 'error',
+          'no-sparse-arrays': 'error',
+          'no-tabs': 'error',
+          'no-trailing-spaces': 'error',
+          'no-undef': 'error',
+          'no-unsafe-negation': 'error',
+          'no-unused-vars': 'error',
+          'no-var': 'error',
+          'object-curly-spacing': [ 'error', 'always' ],
+          'object-shorthand': [ 'error', 'always' ],
+          quotes: [ 'error', 'single', { avoidEscape: true } ],
+          semi: [ 'error', 'never' ] };
+
+languageOptions = { globals: { ...globals.node },
+                    parserOptions: { ecmaVersion: 2025,
+                                     sourceType: 'module' } };
 
 var index = [ { ignores: [ 'TAGS.mjs' ] },
           { languageOptions,