@converse/skeletor 3.1.2 → 3.1.4

package/dist/skeletor.js

@@ -8711,7 +8711,7 @@
           // eslint-disable-next-line @typescript-eslint/no-this-alias
           const that = this;
           async function localSync(method, model, options) {
-              let resp, errorMessage, promise, new_attributes;
+              let resp, caughtError, promise, new_attributes;
               // We get the collection (and if necessary the model attribute.
               // Waiting for storeInitialized will cause another iteration of
               // the event loop, after which the collection reference will
@@ -8768,10 +8768,12 @@
               catch (error) {
                   const storageSize = await that.getStorageSize();
                   if (error.code === 22 && storageSize === 0) {
-                      errorMessage = 'Private browsing is unsupported';
+                      caughtError = new Error('Private browsing is unsupported');
                   }
                   else {
-                      errorMessage = error.message;
+                      // Preserve a real Error (stack/name); wrap anything else so the
+                      // error path always surfaces an Error, never a bare string.
+                      caughtError = error instanceof Error ? error : new Error(error?.message ?? String(error));
                   }
               }
               if (resp) {
@@ -8785,10 +8787,21 @@
                       options.success(data, options);
                   }
               }
+              else if (method === 'read' && !caughtError) {
+                  // A read that finds no record is a normal empty result (first run /
+                  // empty storage), not an error. Resolve with `null` so the callback
+                  // and promise forms of fetch() agree and a first-run read never
+                  // rejects.
+                  if (options && options.success) {
+                      options.success(null, options);
+                  }
+              }
               else {
-                  errorMessage = errorMessage ? errorMessage : 'Record Not Found';
+                  // A genuine failure (storage threw, or a write produced no result):
+                  // surface a real Error so consumers get a stack and `instanceof Error`
+                  // holds.
                   if (options && options.error) {
-                      options.error(errorMessage);
+                      options.error(caughtError ?? new Error('Record Not Found'));
                   }
               }
           }
@@ -10900,18 +10913,18 @@
           this.initialize.apply(this, arguments);
           // Reset changed after initial set
           this.changed = {};
-          // When autoSync is on, `initialized` is always a Promise so callers can
-          // uniformly `await model.initialized`. It only hydrates from storage when
+          // When autoSync is on, `hydrated` is always a Promise so callers can
+          // uniformly `await model.hydrated`. It only hydrates from storage when
           // there's something to load (storage configured and the model isn't new);
           // otherwise it's already ready and resolves immediately.
           if (this.autoSync) {
               if (getStorage(this) && !this.isNew()) {
                   __classPrivateFieldSet(this, _Model_state, 'hydrating', "f");
-                  this.initialized = __classPrivateFieldGet(this, _Model_instances, "m", _Model_hydrate).call(this);
+                  this.hydrated = __classPrivateFieldGet(this, _Model_instances, "m", _Model_hydrate).call(this);
               }
               else {
                   __classPrivateFieldSet(this, _Model_state, 'ready', "f");
-                  this.initialized = Promise.resolve();
+                  this.hydrated = Promise.resolve();
               }
           }
           else {
@@ -11084,7 +11097,7 @@
           // Guard must come after arg normalization: when called as set(obj, opts),
           // fromStorage lives in `val` (second arg), not `options` (third arg).
           if (this.autoSync && __classPrivateFieldGet(this, _Model_state, "f") === 'hydrating' && !options.fromStorage) {
-              throw new Error(`Skeletor: set() called on an autoSync model before initialized resolved. Await model.initialized first.`);
+              throw new Error(`Skeletor: set() called on an autoSync model before hydration resolved. Await model.hydrated first.`);
           }
           // Run validation.
           if (!this._validate(attrs, options))
@@ -11460,12 +11473,6 @@
       try {
           await this.fetch({ fromStorage: true, promise: true });
       }
-      catch (e) {
-          // 'Record Not Found' is a normal first-run state (nothing stored yet);
-          // keep the initial attributes and resolve. Re-throw anything else.
-          if (e !== 'Record Not Found')
-              throw e;
-      }
       finally {
           __classPrivateFieldSet(this, _Model_state, 'ready', "f");
       }
@@ -11530,11 +11537,11 @@
           if (models)
               this.reset(models, Object.assign({ silent: true }, options));
           this[Symbol.iterator] = this.values;
-          // When autoSync is on, `initialized` is always a Promise so callers can
-          // uniformly `await collection.initialized`; it resolves immediately when
+          // When autoSync is on, `hydrated` is always a Promise so callers can
+          // uniformly `await collection.hydrated`; it resolves immediately when
           // there's no storage to hydrate from.
           if (this.autoSync) {
-              this.initialized = getStorage(this) ? __classPrivateFieldGet(this, _Collection_instances, "m", _Collection_hydrate).call(this) : Promise.resolve();
+              this.hydrated = getStorage(this) ? __classPrivateFieldGet(this, _Collection_instances, "m", _Collection_hydrate).call(this) : Promise.resolve();
           }
       }
       get comparator() {
@@ -11566,7 +11573,7 @@
       }
       /**
        * Override to return `true` to automatically load the collection from
-       * storage on construction. Await `initialized` to know when hydration
+       * storage on construction. Await `hydrated` to know when hydration
        * is complete.
        *
        * Note: collection `autoSync` is hydrate-only. Unlike `Model`, it does
@@ -12240,8 +12247,9 @@
   }
   _Collection_instances = new WeakSet(), _Collection_hydrate = async function _Collection_hydrate() {
       ensureUnloadListener(PersistentStorage);
-      // findAll() returns [] for an empty store, so a first-run collection
-      // resolves rather than erroring the way a model fetch-by-id would.
+      // An empty store is a normal first-run state: findAll() returns [] and a
+      // missing model record resolves to null, so hydration resolves rather
+      // than rejecting.
       await this.fetch({ fromStorage: true, promise: true });
   }, _a = Symbol.iterator;
   // This "enum" defines the three possible kinds of values which can be emitted