@controleonline/ui-customers 1.0.81 → 1.0.82

package/src/tests/react/components/tabs/peopleMediaTabs.test.js

@@ -1,11 +1,11 @@
-const React = require('react');
-const renderer = require('react-test-renderer');
-const {jest} = require('@jest/globals');
-
-const {describe, expect, it, beforeEach} = global;
-
-global.IS_REACT_ACT_ENVIRONMENT = true;
-
+const React = require('react');
+const renderer = require('react-test-renderer');
+const {jest} = require('@jest/globals');
+
+const {describe, expect, it, beforeEach} = global;
+
+global.IS_REACT_ACT_ENVIRONMENT = true;
+
 const peopleActions = {
   getMediaTypes: jest.fn(),
   getPeopleMedia: jest.fn(),
@@ -14,7 +14,7 @@ const peopleActions = {
   deletePeopleMedia: jest.fn(),
   setItem: jest.fn(),
 };
-
+
 const peopleLinkActions = {
   getItems: jest.fn(),
 };
@@ -24,56 +24,56 @@ const messageActions = {
   showSuccess: jest.fn(),
 };
 
-jest.mock('@store', () => ({
-  useStore: jest.fn(name => {
-    if (name === 'people') {
-      return {
-        actions: peopleActions,
-        getters: {
-          currentCompany: {id: 12},
-        },
-      };
-    }
-
-    if (name === 'people_link') {
-      return {
-        actions: peopleLinkActions,
-        getters: {},
-      };
-    }
-
-    if (name === 'theme') {
-      return {
-        getters: {
-          colors: {},
-        },
-      };
-    }
-
-    return {actions: {}, getters: {}};
-  }),
-  useStores: jest.fn(() => ({
-    actions: peopleActions,
-    getters: {
-      currentCompany: {id: 12},
-    },
-  })),
-}));
-
-jest.mock('@react-navigation/native', () => ({
-  useNavigation: () => ({
-    push: jest.fn(),
-  }),
-}));
-
-jest.mock('react-native', () => ({
-  ActivityIndicator: props => React.createElement('activityindicator', props, props.children),
-  Alert: {
-    alert: jest.fn(),
-  },
-  Keyboard: {
-    dismiss: jest.fn(),
-  },
+jest.mock('@store', () => ({
+  useStore: jest.fn(name => {
+    if (name === 'people') {
+      return {
+        actions: peopleActions,
+        getters: {
+          currentCompany: {id: 12},
+        },
+      };
+    }
+
+    if (name === 'people_link') {
+      return {
+        actions: peopleLinkActions,
+        getters: {},
+      };
+    }
+
+    if (name === 'theme') {
+      return {
+        getters: {
+          colors: {},
+        },
+      };
+    }
+
+    return {actions: {}, getters: {}};
+  }),
+  useStores: jest.fn(() => ({
+    actions: peopleActions,
+    getters: {
+      currentCompany: {id: 12},
+    },
+  })),
+}));
+
+jest.mock('@react-navigation/native', () => ({
+  useNavigation: () => ({
+    push: jest.fn(),
+  }),
+}));
+
+jest.mock('react-native', () => ({
+  ActivityIndicator: props => React.createElement('activityindicator', props, props.children),
+  Alert: {
+    alert: jest.fn(),
+  },
+  Keyboard: {
+    dismiss: jest.fn(),
+  },
   Platform: {OS: 'web'},
   ScrollView: props => React.createElement('scrollview', props, props.children),
   StyleSheet: {
@@ -82,36 +82,36 @@ jest.mock('react-native', () => ({
   Text: props => React.createElement('text', props, props.children),
   TextInput: props => React.createElement('textinput', props, props.children),
   TouchableOpacity: props => React.createElement('touchableopacity', props, props.children),
-  View: props => React.createElement('view', props, props.children),
-}));
-
-jest.mock('react-native-vector-icons/Feather', () => props =>
-  React.createElement('icon', props, props.children),
-  {virtual: true},
-);
-
-jest.mock('react-native-vector-icons/FontAwesome', () => props =>
-  React.createElement('icon', props, props.children),
-  {virtual: true},
-);
-
-jest.mock('react-native-vector-icons/MaterialIcons', () => props =>
-  React.createElement('icon', props, props.children),
-  {virtual: true},
-);
-
-jest.mock('@react-native-picker/picker', () => ({
-  Picker: props => React.createElement('picker', props, props.children),
-}), {virtual: true});
-
-jest.mock('@controleonline/ui-common/src/react/components/AnimatedModal', () => props =>
-  (props.visible ? React.createElement('modal', props, props.children) : null),
-);
-
+  View: props => React.createElement('view', props, props.children),
+}));
+
+jest.mock('react-native-vector-icons/Feather', () => props =>
+  React.createElement('icon', props, props.children),
+  {virtual: true},
+);
+
+jest.mock('react-native-vector-icons/FontAwesome', () => props =>
+  React.createElement('icon', props, props.children),
+  {virtual: true},
+);
+
+jest.mock('react-native-vector-icons/MaterialIcons', () => props =>
+  React.createElement('icon', props, props.children),
+  {virtual: true},
+);
+
+jest.mock('@react-native-picker/picker', () => ({
+  Picker: props => React.createElement('picker', props, props.children),
+}), {virtual: true});
+
+jest.mock('@controleonline/ui-common/src/react/components/AnimatedModal', () => props =>
+  (props.visible ? React.createElement('modal', props, props.children) : null),
+);
+
 jest.mock('@controleonline/ui-common/src/react/components/MessageService', () => ({
   useMessage: () => messageActions,
 }));
-
+
 jest.mock('@controleonline/ui-common/src/react/components/UserAvatar', () => props =>
   React.createElement('avatar', props, props.children),
 );
@@ -139,138 +139,138 @@ const MediaTab =
   require('@controleonline/ui-customers/src/react/components/tabs/MediaTab').default;
 const employeesTabModule =
   require('@controleonline/ui-customers/src/react/components/tabs/EmployeesTab');
-const EmployeesTab = employeesTabModule.default;
-const {
-  formatEmployeeContactMeta,
-  formatEmployeeContactTitle,
-} = employeesTabModule;
-
-const flush = () => new Promise(resolve => setImmediate(resolve));
-
-describe('people media tabs', () => {
-  beforeEach(() => {
-    jest.clearAllMocks();
-  });
-
-  it('loads company icons through the people store on SalesmanTab', async () => {
-    peopleLinkActions.getItems.mockResolvedValue([
-      {
-        id: 1,
-        linkType: 'sellers-client',
-        people: {id: '/people/12'},
-        company: {id: '/people/55', name: 'Companhia 55'},
-      },
-    ]);
-    peopleActions.getPeopleMedia.mockResolvedValue([
-      {
-        id: 9,
-        file: {id: 91, fileName: 'icon.png'},
-      },
-    ]);
-
-    await renderer.act(async () => {
-      renderer.create(
-        React.createElement(SalesmanTab, {
-          client: {id: 12},
-          customStyles: {
-            tabContent: {},
-            section: {},
-            loadingIndicator: {color: '#000'},
-            emptyText: {},
-            listItem: {},
-            listItemWithEndAction: {},
-            itemContent: {},
-            listAvatarBrand: {backgroundColor: '#fff', borderColor: '#ddd'},
-            listAvatarText: {color: '#000'},
-            listAvatar: {},
-            itemText: {},
-            itemSubtext: {},
-            iconButtonGhost: {},
-            iconButtonGhostIcon: {color: '#000'},
-          },
-          linkType: 'sellers-client',
-          emptyText: 'empty',
-          errorText: 'error',
-        }),
-      );
-      await flush();
-    });
-
-    expect(peopleActions.getPeopleMedia).toHaveBeenCalledWith({
-      people: '/people/55',
-      'mediaType.type': 'icon',
-      itemsPerPage: 1,
-    });
-  });
-
-  it('loads avatars through the people store on EmployeesTab', async () => {
-    peopleLinkActions.getItems.mockResolvedValue([
-      {
-        id: 2,
-        linkType: 'employee',
-        people: {id: '/people/77', peopleType: 'F'},
-        company: {id: '/people/12'},
-      },
-    ]);
-    peopleActions.getPeopleMedia.mockResolvedValue([
-      {
-        id: 10,
-        file: {id: 101, fileName: 'avatar.png'},
-      },
-    ]);
-
-    await renderer.act(async () => {
-      renderer.create(
-        React.createElement(EmployeesTab, {
-          client: {id: 12},
-          customStyles: {
-            tabContent: {},
-            section: {},
-            sectionHeader: {},
-            sectionTitle: {},
-            iconButtonPrimary: {},
-            iconButtonPrimaryIcon: {color: '#000'},
-            loadingIndicator: {color: '#000'},
-            emptyText: {},
-            txt_title_emptyText: {},
-            listItem: {},
-            listItemWithEndAction: {},
-            itemContent: {},
-            listAvatarBrand: {backgroundColor: '#fff', borderColor: '#ddd'},
-            listAvatarText: {color: '#000'},
-            listAvatar: {},
-            itemText: {},
-            itemSubtext: {},
-            iconButtonGhost: {},
-            iconButtonGhostIcon: {color: '#000'},
-            saveButton: {},
-            saveButtonDisabled: {},
-            saveButtonText: {color: '#000'},
-          },
-        }),
-      );
-      await flush();
-    });
-
-    expect(peopleActions.getPeopleMedia).toHaveBeenCalledWith({
-      people: '/people/77',
-      'mediaType.type': 'avatar',
-      itemsPerPage: 1,
-    });
-  });
-
+const EmployeesTab = employeesTabModule.default;
+const {
+  formatEmployeeContactMeta,
+  formatEmployeeContactTitle,
+} = employeesTabModule;
+
+const flush = () => new Promise(resolve => setImmediate(resolve));
+
+describe('people media tabs', () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
+  it('loads company icons through the people store on SalesmanTab', async () => {
+    peopleLinkActions.getItems.mockResolvedValue([
+      {
+        id: 1,
+        linkType: 'sellers-client',
+        people: {id: '/people/12'},
+        company: {id: '/people/55', name: 'Companhia 55'},
+      },
+    ]);
+    peopleActions.getPeopleMedia.mockResolvedValue([
+      {
+        id: 9,
+        file: {id: 91, fileName: 'icon.png'},
+      },
+    ]);
+
+    await renderer.act(async () => {
+      renderer.create(
+        React.createElement(SalesmanTab, {
+          client: {id: 12},
+          customStyles: {
+            tabContent: {},
+            section: {},
+            loadingIndicator: {color: '#000'},
+            emptyText: {},
+            listItem: {},
+            listItemWithEndAction: {},
+            itemContent: {},
+            listAvatarBrand: {backgroundColor: '#fff', borderColor: '#ddd'},
+            listAvatarText: {color: '#000'},
+            listAvatar: {},
+            itemText: {},
+            itemSubtext: {},
+            iconButtonGhost: {},
+            iconButtonGhostIcon: {color: '#000'},
+          },
+          linkType: 'sellers-client',
+          emptyText: 'empty',
+          errorText: 'error',
+        }),
+      );
+      await flush();
+    });
+
+    expect(peopleActions.getPeopleMedia).toHaveBeenCalledWith({
+      people: '/people/55',
+      'mediaType.type': 'icon',
+      itemsPerPage: 1,
+    });
+  });
+
+  it('loads avatars through the people store on EmployeesTab', async () => {
+    peopleLinkActions.getItems.mockResolvedValue([
+      {
+        id: 2,
+        linkType: 'employee',
+        people: {id: '/people/77', peopleType: 'F'},
+        company: {id: '/people/12'},
+      },
+    ]);
+    peopleActions.getPeopleMedia.mockResolvedValue([
+      {
+        id: 10,
+        file: {id: 101, fileName: 'avatar.png'},
+      },
+    ]);
+
+    await renderer.act(async () => {
+      renderer.create(
+        React.createElement(EmployeesTab, {
+          client: {id: 12},
+          customStyles: {
+            tabContent: {},
+            section: {},
+            sectionHeader: {},
+            sectionTitle: {},
+            iconButtonPrimary: {},
+            iconButtonPrimaryIcon: {color: '#000'},
+            loadingIndicator: {color: '#000'},
+            emptyText: {},
+            txt_title_emptyText: {},
+            listItem: {},
+            listItemWithEndAction: {},
+            itemContent: {},
+            listAvatarBrand: {backgroundColor: '#fff', borderColor: '#ddd'},
+            listAvatarText: {color: '#000'},
+            listAvatar: {},
+            itemText: {},
+            itemSubtext: {},
+            iconButtonGhost: {},
+            iconButtonGhostIcon: {color: '#000'},
+            saveButton: {},
+            saveButtonDisabled: {},
+            saveButtonText: {color: '#000'},
+          },
+        }),
+      );
+      await flush();
+    });
+
+    expect(peopleActions.getPeopleMedia).toHaveBeenCalledWith({
+      people: '/people/77',
+      'mediaType.type': 'avatar',
+      itemsPerPage: 1,
+    });
+  });
+
   it('formats contact rows as name alias and id link type', () => {
-    const contact = {
-      id: '/people/77',
-      name: 'Maria Silva',
-      alias: 'Mari',
-      linkType: 'employee',
-      peopleLink: {
-        linkType: 'owner',
-      },
-    };
-
-    expect(formatEmployeeContactTitle(contact)).toBe('MARIA SILVA / MARI');
+    const contact = {
+      id: '/people/77',
+      name: 'Maria Silva',
+      alias: 'Mari',
+      linkType: 'employee',
+      peopleLink: {
+        linkType: 'owner',
+      },
+    };
+
+    expect(formatEmployeeContactTitle(contact)).toBe('Maria Silva / Mari');
     expect(formatEmployeeContactMeta(contact)).toBe('ID: 77 / owner');
   });
 

package/src/tests/react/components/tabs/peopleType.contract.test.mjs

@@ -0,0 +1,47 @@
+import assert from 'node:assert/strict';
+import fs from 'node:fs';
+import test from 'node:test';
+
+const helpers = fs.readFileSync(
+  new URL('../../../../react/components/tabs/generalTabHelpers.js', import.meta.url),
+  'utf8',
+);
+const employeesHelpers = fs.readFileSync(
+  new URL('../../../../react/components/tabs/employeesTabHelpers.js', import.meta.url),
+  'utf8',
+);
+const contacts = fs.readFileSync(
+  new URL('../../../../react/components/tabs/employeeContacts.js', import.meta.url),
+  'utf8',
+);
+const generalTab = fs.readFileSync(
+  new URL('../../../../react/components/tabs/GeneralTab.js', import.meta.url),
+  'utf8',
+);
+const createFields = fs.readFileSync(
+  new URL('../../../../react/components/tabs/EmployeeCreateFormFields.js', import.meta.url),
+  'utf8',
+);
+
+test('peopleType contract is F/J only — contrato is not a People type', () => {
+  assert.match(helpers, /PEOPLE_TYPE_OPTIONS/);
+  assert.match(helpers, /value: 'F'/);
+  assert.match(helpers, /value: 'J'/);
+  assert.doesNotMatch(helpers, /value: 'contrato'/);
+  assert.match(helpers, /do not invent values/);
+});
+
+test('create payload and general save persist peopleType from the form', () => {
+  assert.match(employeesHelpers, /peopleType: normalizePeopleType\(peopleType\)/);
+  assert.match(generalTab, /peopleType,/);
+  assert.match(generalTab, /onUpdateClient\?\.\('peopleType', peopleType\)/);
+  assert.match(createFields, /PEOPLE_TYPE_OPTIONS/);
+});
+
+test('employee list keeps PJ collaborators linked to the company', () => {
+  assert.match(contacts, /peopleType F\|J both allowed as collaborators/);
+  assert.doesNotMatch(
+    contacts,
+    /peopleType \|\| ''\)\.toUpperCase\(\) === 'J'/,
+  );
+});

package/src/tests/react/components/tabs/resolveSeededLinkType.test.mjs

@@ -0,0 +1,20 @@
+import assert from 'node:assert/strict';
+import test from 'node:test';
+import {createRequire} from 'node:module';
+
+const require = createRequire(import.meta.url);
+const {
+  resolveSeededLinkType,
+  normalizeLinkType,
+} = require('../../../../react/components/tabs/generalTabHelpers.js');
+
+test('resolveSeededLinkType prefers client linkType over route seed', () => {
+  assert.equal(resolveSeededLinkType('courier', 'owner'), 'courier');
+  assert.equal(resolveSeededLinkType('after-sales', 'employee'), 'after-sales');
+});
+
+test('resolveSeededLinkType falls back to route when client empty', () => {
+  assert.equal(resolveSeededLinkType('', 'owner'), 'owner');
+  assert.equal(resolveSeededLinkType(undefined, 'manager'), 'manager');
+  assert.equal(resolveSeededLinkType(null, ''), normalizeLinkType(''));
+});

package/src/tests/react/components/tabs/salesmanTabMedia.no-redeclare.test.mjs

@@ -0,0 +1,33 @@
+/**
+ * Regression: GIT BUILD ERROR — Identifier 'COMPANY_ICON_MEDIA_TYPES' has already been declared
+ * (import from salesmanTabMedia + local const redeclaration in SalesmanTab).
+ * Refs: ControleOnline/ui-customers#20
+ */
+import assert from 'node:assert/strict';
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const __dirname = path.dirname(fileURLToPath(import.meta.url));
+const tabsDir = path.resolve(__dirname, '../../../../react/components/tabs');
+const tabSrc = fs.readFileSync(path.join(tabsDir, 'SalesmanTab.js'), 'utf8');
+const mediaSrc = fs.readFileSync(path.join(tabsDir, 'salesmanTabMedia.js'), 'utf8');
+
+assert.match(
+  tabSrc,
+  /from ['"]\.\/salesmanTabMedia['"]/,
+  'SalesmanTab must import from ./salesmanTabMedia',
+);
+assert.match(tabSrc, /COMPANY_ICON_MEDIA_TYPES/, 'SalesmanTab must reference COMPANY_ICON_MEDIA_TYPES');
+assert.doesNotMatch(
+  tabSrc,
+  /const COMPANY_ICON_MEDIA_TYPES\s*=/,
+  'SalesmanTab must NOT redeclare COMPANY_ICON_MEDIA_TYPES locally (causes SyntaxError on web bundle)',
+);
+assert.match(
+  mediaSrc,
+  /export \{[^}]*COMPANY_ICON_MEDIA_TYPES/,
+  'salesmanTabMedia must export COMPANY_ICON_MEDIA_TYPES',
+);
+
+console.log('ok: salesmanTabMedia single source of truth for COMPANY_ICON_MEDIA_TYPES');

package/src/tests/react/components/tabs/usersTabHelpers.test.js

@@ -6,6 +6,8 @@ const {
   toTimezoneItem,
   extractCollectionItems,
   extractErrorMessage,
+  buildUsersListQuery,
+  embeddedUsersFromClient,
 } = require('../../../../react/components/tabs/usersTabHelpers');
 
 describe('usersTabHelpers', () => {
@@ -51,6 +53,24 @@ describe('usersTabHelpers', () => {
     expect(item.username).toBe('alice');
   });
 
+  test('buildUsersListQuery uses people IRI and does not send company', () => {
+    const query = buildUsersListQuery({id: 31468, company: 3});
+    expect(query.people).toBe('/people/31468');
+    expect(query.itemsPerPage).toBe(100);
+    expect(query.__storeMeta.dedupeKey).toBe('client-details-users-/people/31468');
+    expect(query.company).toBeUndefined();
+    expect(buildUsersListQuery({})).toBe(null);
+  });
+
+  test('embeddedUsersFromClient is fallback only and normalizes items', () => {
+    const items = embeddedUsersFromClient({
+      user: {id: 9, username: 'alice'},
+    });
+    expect(items).toHaveLength(1);
+    expect(items[0].username).toBe('alice');
+    expect(embeddedUsersFromClient({user: []})).toEqual([]);
+  });
+
   test('extractCollectionItems supports hydra and member', () => {
     expect(extractCollectionItems({'hydra:member': [{id: 1}]}).length).toBe(1);
     expect(extractCollectionItems({member: [{id: 2}]}).length).toBe(1);

package/src/tests/react/components/tabs/usersTabHelpers.test.mjs

@@ -0,0 +1,63 @@
+/**
+ * Unit tests for UsersTab pure helpers (#369).
+ */
+import { describe, it } from 'node:test';
+import assert from 'node:assert/strict';
+import {
+  extractId,
+  toPeopleIri,
+  normalizeUserItem,
+  mapUsersForClient,
+  extractErrorMessage,
+  buildCreateUserPayload,
+  formatApiKeyPreview,
+} from '../../../../react/components/tabs/usersTabHelpers.js';
+
+describe('usersTabHelpers', () => {
+  it('extractId strips non-digits', () => {
+    assert.equal(extractId('/people/106218'), '106218');
+    assert.equal(extractId('106218'), '106218');
+    assert.equal(extractId(null), '');
+  });
+
+  it('toPeopleIri builds API Platform IRI', () => {
+    assert.equal(toPeopleIri(106218), '/people/106218');
+    assert.equal(toPeopleIri('/people/9'), '/people/9');
+    assert.equal(toPeopleIri(''), '');
+  });
+
+  it('buildCreateUserPayload uses people IRI', () => {
+    const payload = buildCreateUserPayload({
+      username: 'alice',
+      password: 'secret',
+      confirmPassword: 'secret',
+      peopleId: 106218,
+    });
+    assert.equal(payload.people, '/people/106218');
+    assert.equal(payload.username, 'alice');
+  });
+
+  it('extractErrorMessage maps 401 / Authentication required', () => {
+    const msg = extractErrorMessage({
+      response: {status: 401, data: {message: 'Authentication required'}},
+    });
+    assert.match(msg, /Autenticação necessária/);
+    assert.match(
+      extractErrorMessage({message: 'Authentication required'}),
+      /Autenticação necessária/,
+    );
+  });
+
+  it('normalizeUserItem and mapUsersForClient', () => {
+    const n = normalizeUserItem({id: '/users/1', username: 'bob', apiKey: 'k'});
+    assert.equal(n.id, '1');
+    assert.equal(n.username, 'bob');
+    const mapped = mapUsersForClient([n]);
+    assert.equal(mapped[0].username, 'bob');
+  });
+
+  it('formatApiKeyPreview truncates long keys', () => {
+    assert.equal(formatApiKeyPreview('short'), 'short');
+    assert.match(formatApiKeyPreview('abcdefghijklmnopqrstuvwxyz'), /\.\.\./);
+  });
+});