@contrast/route-coverage 1.4.0 → 1.5.0

package/lib/index.js

@@ -52,6 +52,7 @@ module.exports = function init(core) {
       if (store && !store.route) {
         store.route = route;
       }
+
       // these events need source correlation
       messages.emit(Event.ROUTE_COVERAGE_OBSERVATION, {
         ...route,

package/lib/install/koa.js

@@ -17,33 +17,24 @@
 const { createSignature, patchType } = require('./../utils/route-info');
 
 module.exports = function init(core) {
-  const { patcher, depHooks, routeCoverage, logger } = core;
+  const { patcher, depHooks, routeCoverage } = core;
 
   function emitRouteCoverage(url, method) {
     const event = { signature: createSignature(url, method), url, method };
     routeCoverage.discover(event);
   }
 
-  function emitObservation(url, method) {
-    routeCoverage.observe({ method, url });
-  }
-
-  async function routeObservationMiddleware(ctx, next) {
-    const req = ctx.request;
+  const routeObservationPathClosure = ({ path }) =>
+    async function routeObservationMiddleware(ctx, next) {
+      const req = ctx.request;
 
-    if (req) {
-      const { url, method } = req;
-      try {
-        // Arbitrary basename needed to parse out path
-        const parsedUrl = new URL(url, 'file://').pathname;
-        emitObservation(parsedUrl, method.toLowerCase());
-      } catch (err) {
-        logger.error({ err, url }, 'failed to parse route');
+      if (req) {
+        const { method } = req;
+        routeCoverage.observe({ url: path, method: method.toLowerCase() });
       }
-    }
 
-    await next();
-  }
+      await next();
+    };
 
   function registerRouteHandler(Router) {
     patcher.patch(Router.prototype, 'register', {
@@ -63,7 +54,7 @@ module.exports = function init(core) {
           });
         }
 
-        layer.stack.unshift(routeObservationMiddleware.bind(this));
+        layer.stack.unshift(routeObservationPathClosure({ path }).bind(this));
       }
     });
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@contrast/route-coverage",
-  "version": "1.4.0",
+  "version": "1.5.0",
   "description": "",
   "license": "SEE LICENSE IN LICENSE",
   "author": "Contrast Security <nodejs@contrastsecurity.com> (https://www.contrastsecurity.com)",
@@ -14,6 +14,6 @@
     "test": "../scripts/test.sh"
   },
   "dependencies": {
-    "@contrast/common": "1.8.0"
+    "@contrast/common": "1.9.0"
   }
 }