@contrast/assess 1.40.0 → 1.42.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (167) hide show
  1. package/lib/crypto-analysis/install/crypto.js +4 -5
  2. package/lib/crypto-analysis/install/crypto.test.js +1 -1
  3. package/lib/crypto-analysis/install/math.js +2 -4
  4. package/lib/dataflow/propagation/install/JSON/parse.js +2 -3
  5. package/lib/dataflow/propagation/install/JSON/stringify.js +3 -4
  6. package/lib/dataflow/propagation/install/array-prototype-join.js +2 -3
  7. package/lib/dataflow/propagation/install/buffer.js +3 -4
  8. package/lib/dataflow/propagation/install/contrast-methods/add.js +2 -3
  9. package/lib/dataflow/propagation/install/contrast-methods/number.js +2 -3
  10. package/lib/dataflow/propagation/install/contrast-methods/string.js +2 -3
  11. package/lib/dataflow/propagation/install/contrast-methods/tag.js +2 -3
  12. package/lib/dataflow/propagation/install/decode-uri-component.js +2 -3
  13. package/lib/dataflow/propagation/install/ejs/escape-xml.js +3 -4
  14. package/lib/dataflow/propagation/install/ejs/template.js +3 -4
  15. package/lib/dataflow/propagation/install/ejs/template.test.js +1 -1
  16. package/lib/dataflow/propagation/install/encode-uri.js +2 -3
  17. package/lib/dataflow/propagation/install/escape-html.js +3 -4
  18. package/lib/dataflow/propagation/install/escape.js +2 -3
  19. package/lib/dataflow/propagation/install/fastify-send.js +3 -3
  20. package/lib/dataflow/propagation/install/fastify-send.test.js +1 -3
  21. package/lib/dataflow/propagation/install/handlebars-utils-escape-expression.js +3 -4
  22. package/lib/dataflow/propagation/install/isnumeric-0.js +1 -1
  23. package/lib/dataflow/propagation/install/joi/any.js +1 -1
  24. package/lib/dataflow/propagation/install/joi/any.test.js +1 -1
  25. package/lib/dataflow/propagation/install/joi/array.test.js +5 -5
  26. package/lib/dataflow/propagation/install/joi/boolean.js +3 -3
  27. package/lib/dataflow/propagation/install/joi/boolean.test.js +1 -1
  28. package/lib/dataflow/propagation/install/joi/expression.js +3 -3
  29. package/lib/dataflow/propagation/install/joi/expression.test.js +1 -1
  30. package/lib/dataflow/propagation/install/joi/index.js +3 -3
  31. package/lib/dataflow/propagation/install/joi/keys.js +3 -3
  32. package/lib/dataflow/propagation/install/joi/number.js +3 -3
  33. package/lib/dataflow/propagation/install/joi/number.test.js +1 -1
  34. package/lib/dataflow/propagation/install/joi/object.js +1 -1
  35. package/lib/dataflow/propagation/install/joi/object.test.js +1 -1
  36. package/lib/dataflow/propagation/install/joi/ref.test.js +4 -4
  37. package/lib/dataflow/propagation/install/joi/string-schema.js +4 -4
  38. package/lib/dataflow/propagation/install/joi/string-schema.test.js +4 -4
  39. package/lib/dataflow/propagation/install/joi/values.js +3 -3
  40. package/lib/dataflow/propagation/install/mongoose/schema-map.js +4 -4
  41. package/lib/dataflow/propagation/install/mongoose/schema-mixed.js +4 -4
  42. package/lib/dataflow/propagation/install/mongoose/schema-string.js +4 -4
  43. package/lib/dataflow/propagation/install/mustache-escape.js +3 -4
  44. package/lib/dataflow/propagation/install/mustache-escape.test.js +1 -1
  45. package/lib/dataflow/propagation/install/mysql-connection-escape.js +22 -14
  46. package/lib/dataflow/propagation/install/mysql-connection-escape.test.js +1 -1
  47. package/lib/dataflow/propagation/install/parse-int.js +2 -3
  48. package/lib/dataflow/propagation/install/path/basename.js +3 -4
  49. package/lib/dataflow/propagation/install/path/dirname.js +3 -4
  50. package/lib/dataflow/propagation/install/path/extname.js +3 -4
  51. package/lib/dataflow/propagation/install/path/format.js +3 -4
  52. package/lib/dataflow/propagation/install/path/index.test.js +1 -1
  53. package/lib/dataflow/propagation/install/path/join-and-resolve.js +3 -4
  54. package/lib/dataflow/propagation/install/path/normalize.js +4 -5
  55. package/lib/dataflow/propagation/install/path/parse.js +3 -4
  56. package/lib/dataflow/propagation/install/path/relative.js +4 -5
  57. package/lib/dataflow/propagation/install/path/toNamespacedPath.js +3 -4
  58. package/lib/dataflow/propagation/install/pug/index.js +3 -4
  59. package/lib/dataflow/propagation/install/pug-runtime-escape.js +3 -4
  60. package/lib/dataflow/propagation/install/querystring/escape.js +3 -4
  61. package/lib/dataflow/propagation/install/querystring/escape.test.js +1 -1
  62. package/lib/dataflow/propagation/install/querystring/parse.js +3 -4
  63. package/lib/dataflow/propagation/install/querystring/parse.test.js +1 -1
  64. package/lib/dataflow/propagation/install/querystring/stringify.js +3 -4
  65. package/lib/dataflow/propagation/install/querystring/stringify.test.js +1 -1
  66. package/lib/dataflow/propagation/install/reg-exp-prototype-exec.js +2 -3
  67. package/lib/dataflow/propagation/install/send.js +3 -3
  68. package/lib/dataflow/propagation/install/sequelize/query-generator.js +3 -3
  69. package/lib/dataflow/propagation/install/sequelize/query-generator.test.js +2 -1
  70. package/lib/dataflow/propagation/install/sequelize/sql-string.js +5 -5
  71. package/lib/dataflow/propagation/install/sql-template-strings.js +3 -3
  72. package/lib/dataflow/propagation/install/string/concat.js +2 -3
  73. package/lib/dataflow/propagation/install/string/format-methods.js +2 -3
  74. package/lib/dataflow/propagation/install/string/html-methods.js +3 -4
  75. package/lib/dataflow/propagation/install/string/match-all.js +2 -3
  76. package/lib/dataflow/propagation/install/string/match.js +2 -3
  77. package/lib/dataflow/propagation/install/string/replace.js +2 -3
  78. package/lib/dataflow/propagation/install/string/slice.js +2 -3
  79. package/lib/dataflow/propagation/install/string/split.js +2 -3
  80. package/lib/dataflow/propagation/install/string/substring.js +2 -3
  81. package/lib/dataflow/propagation/install/string/trim.js +2 -3
  82. package/lib/dataflow/propagation/install/unescape.js +2 -3
  83. package/lib/dataflow/propagation/install/url/domain-parsers.js +3 -4
  84. package/lib/dataflow/propagation/install/url/parse.js +3 -4
  85. package/lib/dataflow/propagation/install/url/parse.test.js +2 -2
  86. package/lib/dataflow/propagation/install/url/searchParams.js +3 -4
  87. package/lib/dataflow/propagation/install/url/url.js +3 -4
  88. package/lib/dataflow/propagation/install/util-format.js +3 -4
  89. package/lib/dataflow/propagation/install/validator/hooks.js +9 -9
  90. package/lib/dataflow/sinks/install/child-process.js +5 -6
  91. package/lib/dataflow/sinks/install/eval.js +2 -3
  92. package/lib/dataflow/sinks/install/express/reflected-xss.js +3 -4
  93. package/lib/dataflow/sinks/install/express/unvalidated-redirect.js +3 -4
  94. package/lib/dataflow/sinks/install/fastify/unvalidated-redirect.js +3 -4
  95. package/lib/dataflow/sinks/install/fs.js +4 -5
  96. package/lib/dataflow/sinks/install/fs.test.js +2 -2
  97. package/lib/dataflow/sinks/install/function.js +2 -3
  98. package/lib/dataflow/sinks/install/hapi/unvalidated-redirect.js +3 -4
  99. package/lib/dataflow/sinks/install/http/request.js +3 -4
  100. package/lib/dataflow/sinks/install/http/request.test.js +2 -2
  101. package/lib/dataflow/sinks/install/http/server-response.js +5 -6
  102. package/lib/dataflow/sinks/install/http/server-response.test.js +3 -3
  103. package/lib/dataflow/sinks/install/koa/unvalidated-redirect.js +3 -4
  104. package/lib/dataflow/sinks/install/libxmljs.js +4 -5
  105. package/lib/dataflow/sinks/install/libxmljs.test.js +2 -2
  106. package/lib/dataflow/sinks/install/marsdb.js +3 -4
  107. package/lib/dataflow/sinks/install/marsdb.test.js +3 -3
  108. package/lib/dataflow/sinks/install/mongodb.js +3 -4
  109. package/lib/dataflow/sinks/install/mongodb.test.js +2 -6
  110. package/lib/dataflow/sinks/install/mssql.js +4 -5
  111. package/lib/dataflow/sinks/install/mssql.test.js +2 -2
  112. package/lib/dataflow/sinks/install/mysql.js +4 -5
  113. package/lib/dataflow/sinks/install/mysql.test.js +2 -11
  114. package/lib/dataflow/sinks/install/node-serialize.js +3 -4
  115. package/lib/dataflow/sinks/install/node-serialize.test.js +1 -3
  116. package/lib/dataflow/sinks/install/postgres.js +5 -6
  117. package/lib/dataflow/sinks/install/postgres.test.js +3 -9
  118. package/lib/dataflow/sinks/install/restify.js +3 -4
  119. package/lib/dataflow/sinks/install/restify.test.js +3 -5
  120. package/lib/dataflow/sinks/install/sequelize.js +3 -4
  121. package/lib/dataflow/sinks/install/sqlite3.js +3 -4
  122. package/lib/dataflow/sinks/install/vm.js +3 -4
  123. package/lib/dataflow/sources/install/body-parser1.js +2 -4
  124. package/lib/dataflow/sources/install/body-parser1.test.js +4 -8
  125. package/lib/dataflow/sources/install/busboy.js +3 -4
  126. package/lib/dataflow/sources/install/busboy.test.js +2 -2
  127. package/lib/dataflow/sources/install/cookie-parser1.js +2 -4
  128. package/lib/dataflow/sources/install/cookie-parser1.test.js +2 -4
  129. package/lib/dataflow/sources/install/express/params.js +56 -38
  130. package/lib/dataflow/sources/install/express/params.test.js +80 -73
  131. package/lib/dataflow/sources/install/express/parsedUrl.js +45 -29
  132. package/lib/dataflow/sources/install/express/parsedUrl.test.js +71 -29
  133. package/lib/dataflow/sources/install/fastify/fastify.js +2 -3
  134. package/lib/dataflow/sources/install/fastify/fastify.test.js +3 -6
  135. package/lib/dataflow/sources/install/formidable1.js +2 -3
  136. package/lib/dataflow/sources/install/hapi/hapi.js +1 -2
  137. package/lib/dataflow/sources/install/http.js +2 -3
  138. package/lib/dataflow/sources/install/http.test.js +2 -2
  139. package/lib/dataflow/sources/install/koa/koa-bodyparsers.js +3 -5
  140. package/lib/dataflow/sources/install/koa/koa-multer.js +3 -4
  141. package/lib/dataflow/sources/install/koa/koa-multer.test.js +1 -1
  142. package/lib/dataflow/sources/install/koa/koa-routers.js +3 -4
  143. package/lib/dataflow/sources/install/koa/koa2.js +2 -4
  144. package/lib/dataflow/sources/install/multer1.js +2 -3
  145. package/lib/dataflow/sources/install/multer1.test.js +1 -3
  146. package/lib/dataflow/sources/install/qs6.js +2 -4
  147. package/lib/dataflow/sources/install/querystring.js +2 -3
  148. package/lib/dataflow/sources/install/restify/fieldedTextBodyParser.js +2 -3
  149. package/lib/dataflow/sources/install/restify/fieldedTextBodyParser.test.js +1 -1
  150. package/lib/dataflow/sources/install/restify/jsonBodyParser.js +2 -3
  151. package/lib/dataflow/sources/install/restify/jsonBodyParser.test.js +1 -1
  152. package/lib/dataflow/sources/install/restify/router.js +2 -4
  153. package/lib/dataflow/sources/install/restify/router.test.js +4 -6
  154. package/lib/get-source-context.js +77 -37
  155. package/lib/get-source-context.test.js +106 -53
  156. package/lib/index.d.ts +3 -9
  157. package/lib/response-scanning/install/http.js +3 -3
  158. package/lib/response-scanning/install/http.test.js +2 -2
  159. package/lib/session-configuration/install/express-session.js +1 -1
  160. package/lib/session-configuration/install/express-session.test.js +1 -3
  161. package/lib/session-configuration/install/fastify-cookie.js +1 -1
  162. package/lib/session-configuration/install/fastify-cookie.test.js +1 -3
  163. package/lib/session-configuration/install/koa.js +1 -1
  164. package/lib/session-configuration/install/koa.test.js +1 -1
  165. package/package.json +11 -11
  166. package/lib/constants.js +0 -26
  167. package/lib/dataflow/sinks/install/fs-original.js +0 -170
@@ -1,170 +0,0 @@
1
- /*
2
- * Copyright: 2024 Contrast Security, Inc
3
- * Contact: support@contrastsecurity.com
4
- * License: Commercial
5
-
6
- * NOTICE: This Software and the patented inventions embodied within may only be
7
- * used as part of Contrast Security’s commercial offerings. Even though it is
8
- * made available through public repositories, use of this Software is subject to
9
- * the applicable End User Licensing Agreement found at
10
- * https://www.contrastsecurity.com/enduser-terms-0317a or as otherwise agreed
11
- * between Contrast Security and the End User. The Software may not be reverse
12
- * engineered, modified, repackaged, sold, redistributed or otherwise used in a
13
- * way not consistent with the End User License Agreement.
14
- */
15
- 'use strict';
16
- const { patchType } = require('../common');
17
-
18
- const {
19
- DataflowTag: {
20
- URL_ENCODED,
21
- LIMITED_CHARS,
22
- ALPHANUM_SPACE_HYPHEN,
23
- SAFE_PATH,
24
- UNTRUSTED,
25
- },
26
- FS_METHODS,
27
- Rule: { PATH_TRAVERSAL: ruleId },
28
- isString,
29
- ArrayPrototypeJoin,
30
- } = require('@contrast/common');
31
- const { InstrumentationType: { RULE } } = require('../../../constants');
32
-
33
- module.exports = function(core) {
34
- const {
35
- depHooks,
36
- patcher,
37
- assess: {
38
- inspect, // TODO NODE-3455: remove
39
- getSourceContext,
40
- eventFactory: { createSinkEvent },
41
- dataflow: {
42
- tracker,
43
- sinks: { isVulnerable, reportFindings },
44
- },
45
- },
46
- } = core;
47
-
48
- const safeTags = [
49
- `excluded:${ruleId}`,
50
- URL_ENCODED,
51
- LIMITED_CHARS,
52
- ALPHANUM_SPACE_HYPHEN,
53
- SAFE_PATH,
54
- ];
55
-
56
- function getValues(indices, args) {
57
- return indices.reduce((acc, idx) => {
58
- const value = args[idx];
59
- if (value && isString(value)) acc.push(value);
60
- return acc;
61
- }, []);
62
- }
63
-
64
- const pre = (name, method, moduleName = 'fs', fullMethodName = '') => (data) => {
65
- const { name: methodName, indices } = method;
66
- if (!getSourceContext(RULE, ruleId)) return;
67
-
68
- const values = getValues(indices, data.args);
69
- if (!values.length) return;
70
-
71
- const args = values.map((v) => {
72
- const strInfo = tracker.getData(v);
73
- return {
74
- value: strInfo ? strInfo.value : v,
75
- tracked: !!strInfo,
76
- strInfo
77
- };
78
- });
79
- for (let i = 0; i < values.length; i++) {
80
- const { strInfo } = args[i];
81
-
82
- if (!strInfo || !isVulnerable(UNTRUSTED, safeTags, strInfo.tags)) {
83
- continue;
84
- }
85
-
86
- const event = createSinkEvent({
87
- name,
88
- moduleName,
89
- methodName: fullMethodName || methodName,
90
- context: `${name}(${ArrayPrototypeJoin.call(
91
- args.map((a) => inspect(a.value)),
92
- ', '
93
- )})`,
94
- history: [strInfo],
95
- object: {
96
- value: 'fs',
97
- tracked: false,
98
- },
99
- args: args.map(({ value, tracked }) => ({ value, tracked })),
100
- tags: strInfo.tags,
101
- source: `P${i}`,
102
- stacktraceOpts: {
103
- contructorOpt: data.hooked,
104
- prependFrames: [data.orig],
105
- },
106
- });
107
-
108
- if (event) {
109
- reportFindings({
110
- ruleId,
111
- sinkEvent: event,
112
- });
113
- }
114
- }
115
- };
116
-
117
- core.assess.dataflow.sinks.pathTraversal = {
118
- install() {
119
- depHooks.resolve({ name: 'fs' }, (fs) => {
120
- for (const method of FS_METHODS) {
121
- // not all methods are available on every OS or Node version.
122
- if (fs[method.name]) {
123
- const name = `fs.${method.name}`;
124
- patcher.patch(fs, method.name, {
125
- name,
126
- patchType,
127
- pre: pre(name, method),
128
- });
129
- }
130
-
131
- if (method.sync) {
132
- const syncName = `${method.name}Sync`;
133
- if (fs[syncName]) {
134
- const name = `fs.${syncName}`;
135
- patcher.patch(fs, syncName, {
136
- name,
137
- patchType,
138
- pre: pre(name, method, 'fs', syncName),
139
- });
140
- }
141
- }
142
-
143
- if (method.promises && fs.promises && fs.promises[method.name]) {
144
- const name = `fs.promises.${method.name}`;
145
- patcher.patch(fs.promises, method.name, {
146
- name,
147
- patchType,
148
- pre: pre(name, method, 'fs.promises'),
149
- });
150
- }
151
- }
152
- });
153
-
154
- depHooks.resolve({ name: 'fs/promises' }, (fsPromises) => {
155
- for (const method of FS_METHODS) {
156
- if (method.promises && fsPromises[method.name]) {
157
- const name = `fsPromises.${method.name}`;
158
- patcher.patch(fsPromises, method.name, {
159
- name,
160
- patchType,
161
- pre: pre(name, method, 'fsPromises'),
162
- });
163
- }
164
- }
165
- });
166
- },
167
- };
168
-
169
- return core.assess.dataflow.sinks.pathTraversal;
170
- };