@contrast/agentify 1.15.0 → 1.17.0

package/lib/index.d.ts

@@ -14,9 +14,10 @@
  */
 
 import { Config } from '@contrast/config';
+import { Installable } from '@contrast/common';
 import { Logger } from '@contrast/logger';
-import RequireHook from '@contrast/require-hook';
 import { Rewriter } from '@contrast/rewriter';
+import RequireHook from '@contrast/require-hook';
 
 declare module 'module' {
   class Module {
@@ -35,39 +36,26 @@ declare module 'node:module' {
   export = Module;
 }
 
-interface AgentifyOptions {
-  install: boolean;
-  svcList: string[];
-}
-
-interface AgentOptions<T> {
-  install: boolean;
-  preRunMain: PreRunMain<T>;
-}
-
-declare class Agent<T> {
-  constructor(deps: T, opts: AgentOptions<T>);
-  hookRunMain(): void;
-  handleInstallFailure(err: Error): Promise<void>;
-  install(): Promise<void>;
+// TODO: this is now much larger with all of the existing core deps
+export interface Core {
+  readonly config: Config;
+  readonly depHooks: RequireHook;
+  readonly logger: Logger;
+  readonly rewriter: Rewriter;
 }
 
-interface PreRunMain<T> {
-  (core: T, agent: Agent<T>): void | Promise<void>;
+export interface AgentifyOptions {
+  installOrder?: string[];
 }
 
-export interface Agentify<T> {
-  (preRunMain: PreRunMain<T>, opts?: AgentifyOptions): Agent<T>;
+export interface PreRunMain {
+  (core: any): Installable | void | Promise<Installable | void>;
 }
 
-export interface Core<T> {
-  readonly config: Config;
-  readonly depHooks: RequireHook;
-  readonly logger: Logger;
-  readonly rewriter: Rewriter;
-  agentify: Agentify<T>;
+export interface Agentify {
+  (preRunMain: PreRunMain, opts?: AgentifyOptions): any;
 }
 
-declare function init<T>(core: Core<T>): Agentify<T>;
+declare function init(core: any): Agentify;
 
 export = init;

package/lib/index.js

@@ -15,154 +15,128 @@
 
 'use strict';
 
-const fs = require('fs').promises;
-const path = require('path');
 const Module = require('module');
 
-const defaultOpts = {
-  installOrder: [
-    'reporter',
-    'contrastMethods',
-    'deadzones',
-    'scopes',
-    'sources',
-    'architectureComponents',
-    'assess',
-    'protect',
-    'depHooks',
-    'routeCoverage',
-    'libraryAnalysis',
-    'heapSnapshots',
-    'rewriteHooks',
-    'functionHooks'
-  ]
-};
-
-module.exports = function (core) {
-  // compose add'l local services
-  require('./heap-snapshots')(core);
-  require('./sources')(core);
-  require('./function-hooks')(core);
-  require('./rewrite-hooks')(core);
-
-
-  /**
-   * The interface is a function, which when called, will hook runMain
-   * @param {function} preRunMain
-   * @param {object} opts
-   */
-  function agentify(preRunMain, opts = defaultOpts) {
-    if (typeof preRunMain !== 'function') {
-      throw new Error('Invalid usage: first argument must be a function');
-    }
-
-    opts.preRunMain = preRunMain;
-
-    if (opts !== defaultOpts) {
-      opts = { ...defaultOpts, ...opts };
-    }
-
-    return new Agent(core, opts);
-  }
-
-  core.agentify = agentify;
-
-  return agentify;
-};
-
-class Agent {
-  /**
-   *
-   * @param {object} core dependencies
-   * @param {object} opts
-   * @param {function} opts.preRunMain custom function for registering services
-   * @param {boolean} opts.install whether to automatically install
-   */
-  constructor(core, opts) {
-    const self = this;
-    const { config, logger } = core;
-
-    this.core = core;
-    this.opts = opts;
-    this.runMain = Module.runMain;
+const ERROR_MESSAGE = 'A fatal agent installation error has occurred. The application will be run without instrumentation.';
+const DEFAULT_INSTALL_ORDER = [
+  'reporter',
+  'contrastMethods',
+  'deadzones',
+  'scopes',
+  'sources',
+  'architectureComponents',
+  'assess',
+  'protect',
+  'depHooks',
+  'routeCoverage',
+  'libraryAnalysis',
+  'heapSnapshots',
+  'rewriteHooks',
+  'functionHooks',
+  'metrics',
+];
+
+/**
+ * @param {any} core
+ * @returns {import('.').Agentify}
+ */
+module.exports = function init(core = {}) {
+  try {
+    require('@contrast/core/lib/messages')(core);
+    require('@contrast/config')(core);
+    require('@contrast/logger').default(core);
+
+    // @contrast/info ?
+    require('@contrast/core/lib/agent-info')(core);
+    require('@contrast/core/lib/system-info')(core);
+    require('@contrast/core/lib/app-info')(core);
+    require('@contrast/core/lib/sensitive-data-masking')(core);
+    require('@contrast/core/lib/is-agent-path')(core);
+    require('@contrast/core/lib/capture-stacktrace')(core);
+
+    require('@contrast/patcher')(core);
+    require('@contrast/rewriter')(core); // merge contrast-methods?
+    require('@contrast/core/lib/contrast-methods')(core); // can we remove dependency on patcher?
+
+    require('@contrast/dep-hooks')(core);
+    require('@contrast/scopes')(core);
+    require('@contrast/deadzones')(core);
+    require('@contrast/reporter').default(core);
+    require('@contrast/instrumentation')(core);
+    require('@contrast/metrics')(core);
+
+    // compose add'l local services
+    require('./heap-snapshots')(core);
+    require('./sources')(core);
+    require('./function-hooks')(core);
+    require('./log-diagnostic-files')(core); // this doesn't really belong in agentify
+    require('./rewrite-hooks')(core);
 
     /**
-     * This is one side effect that will always occur, even with `install: false`.
-     * The act of calling `agentify()` is enough to cause this side effect, by design.
+     * The interface is a function, which when called, will hook runMain
+     * @type {import('.').Agentify}
      */
-    Module.runMain = async function (...args) {
-      try {
-        for (const err of config._errors) {
-          throw err;
-        }
-
-        logger.info('Starting the Contrast agent');
-        logger.info({ config }, 'Agent configuration');
-
-        const plugin = await opts.preRunMain(core);
+    core.agentify = function agentify(
+      preRunMain,
+      { installOrder = DEFAULT_INSTALL_ORDER } = {},
+    ) {
+      if (typeof preRunMain !== 'function') {
+        throw new Error('Invalid usage: first argument must be a function');
+      }
 
-        if (opts.installOrder?.length) {
-          await self.install();
+      const { runMain } = Module;
+      const { config, logger } = core;
+
+      /**
+       * This is one side effect that will always occur, even with `installOrder: []`.
+       * The act of calling `agentify()` is enough to cause this side effect, by design.
+       */
+      Module.runMain = async function (...args) {
+        try {
+          for (const err of config._errors) {
+            throw err; // move this into config itself since we now handle errors
+          }
+
+          logger.info('Starting %s v%s', core.agentName, core.agentVersion);
+          logger.info({ config }, 'Agent configuration');
+
+          const plugin = await preRunMain(core);
+
+          for (const svcName of installOrder ?? []) {
+            const svc = core[svcName];
+            if (svc?.install) {
+              logger.trace('installing service: %s', svcName);
+              await svc.install();
+            }
+          }
+
+          if (plugin?.install) {
+            await plugin.install();
+          }
+
+          core.logDiagnosticFiles(); // should this be moved into a separate install side-effect?
+        } catch (err) {
+          // TODO: Consider proper UNINSTALLATION and normal startup w/o agent
+          logger.error({ err }, ERROR_MESSAGE);
         }
 
-        if (plugin?.install) {
-          await plugin.install();
-        }
-      } catch (err) {
-        await self.handleInstallFailure(err);
-      }
+        return runMain.apply(this, args);
+      };
 
-      self.logDiagnosticFiles();
-      return self.runMain.apply(this, args);
+      return core;
     };
-  }
-
-  /**
-   * Original `runMain` will get called after this.
-   *
-   * TODO: Consider proper UNINSTALLATION and normal startup w/o agent
-   *
-   * @param {error} err Error thrown during install
-   */
-  async handleInstallFailure(err) {
-    this.core.logger.error(
-      { err },
-      'A fatal agent installation error has occurred. The application will be run without instrumentation.'
-    );
-  }
-
-  async install() {
-    for (const svcName of this.opts.installOrder) {
-      const svc = this.core[svcName];
-      if (svc?.install) {
-        this.core.logger.trace('installing service: %s', svcName);
-        await svc.install();
-      }
+  } catch (err) {
+    // TODO: Consider proper UNINSTALLATION and normal startup w/o agent
+    if (core.logger) {
+      core.logger.error({ err }, ERROR_MESSAGE);
+    } else {
+      console.error(new Error(ERROR_MESSAGE, { cause: err }));
     }
-  }
-
-  logDiagnosticFiles() {
-    const { config, logger } = this.core;
-
-    if (!config.agent.diagnostics.enable) return;
-
-    const { report_path } = config.agent.diagnostics;
 
-    // let these run async so they don't block agent startup.
-    fs.writeFile(
-      path.join(report_path, 'contrast_effective_config.json'),
-      JSON.stringify(config.getReport({ redact: true }), null, 2)
-    ).catch((err) => {
-      logger.warn({ err }, 'unable to write effective config file');
-    });
-
-    fs.writeFile(
-      path.join(report_path, 'contrast_system_info.json'),
-      JSON.stringify(this.core.getSystemInfo(), null, 2)
-    ).catch((err) => {
-      logger.warn({ err }, 'unable to write system info file');
-    });
+    core.agentify = function agentify() {
+      return core;
+    };
   }
-}
 
-module.exports.Agent = Agent;
+  return core.agentify;
+};

package/lib/log-diagnostic-files.js

@@ -0,0 +1,46 @@
+/*
+ * Copyright: 2023 Contrast Security, Inc
+ * Contact: support@contrastsecurity.com
+ * License: Commercial
+
+ * NOTICE: This Software and the patented inventions embodied within may only be
+ * used as part of Contrast Security’s commercial offerings. Even though it is
+ * made available through public repositories, use of this Software is subject to
+ * the applicable End User Licensing Agreement found at
+ * https://www.contrastsecurity.com/enduser-terms-0317a or as otherwise agreed
+ * between Contrast Security and the End User. The Software may not be reverse
+ * engineered, modified, repackaged, sold, redistributed or otherwise used in a
+ * way not consistent with the End User License Agreement.
+ */
+
+'use strict';
+
+const fs = require('fs/promises');
+const path = require('path');
+
+module.exports = function init(core) {
+  core.logDiagnosticFiles = function logDiagnosticFiles() {
+    const { config, logger } = core;
+
+    if (!config.agent.diagnostics.enable) return;
+
+    const { report_path } = config.agent.diagnostics;
+
+    // let these run async so they don't block agent startup.
+    fs.writeFile(
+      path.join(report_path, 'contrast_effective_config.json'),
+      JSON.stringify(config.getReport({ redact: true }), null, 2)
+    ).catch((err) => {
+      logger.warn({ err }, 'unable to write effective config file');
+    });
+
+    fs.writeFile(
+      path.join(report_path, 'contrast_system_info.json'),
+      JSON.stringify(core.getSystemInfo(), null, 2)
+    ).catch((err) => {
+      logger.warn({ err }, 'unable to write system info file');
+    });
+  };
+
+  return core.logDiagnosticFiles;
+};

package/lib/sources.js

@@ -20,7 +20,7 @@ const patchType = 'sources';
 
 module.exports = function(core) {
   const {
-    events: { lifecycle },
+    messages,
     instrumentation: { instrument },
     scopes: { sources: sourcesStorage }
   } = core;
@@ -41,7 +41,7 @@ module.exports = function(core) {
       };
 
       res.on('finish', () => {
-        lifecycle.emit(Event.RESPONSE_FINISH, store);
+        messages.emit(Event.RESPONSE_FINISH, store);
       });
 
       return sourcesStorage.run(store, next);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@contrast/agentify",
-  "version": "1.15.0",
+  "version": "1.17.0",
   "description": "Configures Contrast agent services and instrumentation within an application",
   "license": "SEE LICENSE IN LICENSE",
   "author": "Contrast Security <nodejs@contrastsecurity.com> (https://www.contrastsecurity.com)",
@@ -17,8 +17,17 @@
     "test": "../scripts/test.sh"
   },
   "dependencies": {
-    "@contrast/common": "1.15.1",
-    "@contrast/config": "1.20.0",
-    "@contrast/logger": "1.6.0"
+    "@contrast/common": "1.16.0",
+    "@contrast/config": "1.22.0",
+    "@contrast/core": "1.27.0",
+    "@contrast/deadzones": "1.1.1",
+    "@contrast/dep-hooks": "1.3.0",
+    "@contrast/instrumentation": "1.3.0",
+    "@contrast/logger": "1.7.0",
+    "@contrast/metrics": "1.2.0",
+    "@contrast/patcher": "1.7.1",
+    "@contrast/reporter": "1.22.0",
+    "@contrast/rewriter": "1.4.2",
+    "@contrast/scopes": "1.4.0"
   }
 }