@contrail/flexplm 1.5.0-alpha.98b8b06 → 1.5.0

package/lib/publish/base-process-publish-assortment.js

@@ -13,7 +13,7 @@ const app_framework_1 = require("@contrail/app-framework");
 const event_short_message_status_1 = require("../util/event-short-message-status");
 class BaseProcessPublishAssortment {
     constructor(_config, _dc, _mapFileUtil) {
-        this.TTL = 30 * 24 * 60 * 60 * 1000; // 30 days
+        this.TTL = 30 * 24 * 60 * 60 * 1000;
         this.cache = {
             carriedFromSeason: {}
         };
@@ -52,14 +52,13 @@ class BaseProcessPublishAssortment {
             }
             apcHistory = await this.getApcHistory(assortmentId);
             const sinceDate = await this.getSinceDate(assortmentId, assortmentPublishChangeId, apcHistory);
-            //Get detail information
             const assortmentPublishChange = await this.downloadAssortmentPublishChange(assortmentId, assortmentPublishChangeId);
             publisher = this.getPublisher(assortmentPublishChange);
             const changeDetail = await this.downloadHydratedChangeDetail(assortmentPublishChange);
             const assortmentBaseline = await this.downloadAssortmentBaseline(assortmentPublishChange);
             const deleteChanges = await this.getDeleteChanges(assortmentPublishChange, apcHistory, assortmentBaseline, sinceDate);
             const releasedForDevelopmentItemIds = this.getReleasedForDevelopmentItemAndFamilyIds(assortmentBaseline, deleteChanges);
-            const itemToFederatedIdMapping = await this.getItemFederatedIds( /*allItemIds*/);
+            const itemToFederatedIdMapping = await this.getItemFederatedIds();
             const pcd = new publish_change_data_1.PublishChangeData(assortmentId, seasonFed, assortmentPublishChangeId, sinceDate, publisher);
             pcd.itemToFederatedIdMapping = itemToFederatedIdMapping;
             pcd.releasedForDevelopmentItemIds = releasedForDevelopmentItemIds;
@@ -95,15 +94,6 @@ class BaseProcessPublishAssortment {
         };
         return publishInfo;
     }
-    /** Gets the version number of the snapshot that was created for the publish change.
-     * But if no snapshot was found for the publish change, and the last snapshot was
-     * created before the publish change, then it returns 'after: versionNumber' where
-     * versionNumber is the version number of the last snapshot.
-     * If no snapshot was found for the publish change, and the last snapshot was
-     * created after the publish change, then it returns 'unknown'.
-     *
-     * @returns versionNumber or 'unknown' or 'after: versionNumber'
-     */
     async getSnapshotVersion(assortment, apc) {
         const entityReference = assortment?.createdForReference;
         const createdOnString = apc?.createdOn;
@@ -111,7 +101,7 @@ class BaseProcessPublishAssortment {
             return 'unknown';
         }
         const createdOnDate = new Date(createdOnString);
-        createdOnDate.setMonth(createdOnDate.getMonth() - 1); //subtract 1 month
+        createdOnDate.setMonth(createdOnDate.getMonth() - 1);
         const createdOnStringMinus1 = createdOnDate.toISOString();
         const createdOn = 'ISGREATERTHAN ' + createdOnStringMinus1;
         const snapshots = await new sdk_1.Entities().get({
@@ -358,7 +348,6 @@ class BaseProcessPublishAssortment {
             console.info('sinceDateMilliseconds: ' + sinceDateMilliseconds);
             console.info('apcDateMilliseconds: ' + previousApcDate);
         }
-        //if only 1 apc, no processing needed
         if (sinceDateMilliseconds !== previousApcDate) {
             console.info('sinceDateMilliseconds !== apcDateMilliseconds');
             const currentAssortmentItemIds = this.getBaselineItemIds(assortmentBaseline);
@@ -444,27 +433,12 @@ class BaseProcessPublishAssortment {
             previousBaseline = await this.downloadAssortmentBaseline(previousApc);
         }
         const deleteIds = apc?.detail?.deletes.map(dItem => dItem?.id);
-        //building deletes based on previous baseline; because some APCs don't have delete data
         const deleteArray = previousBaseline?.assortmentItems.filter(aItem => deleteIds.includes(aItem?.itemId));
         console.info('deleteArray.length: ' + deleteArray.length);
         return deleteArray;
     }
-    async getItemFederatedIds( /*itemIds*/) {
+    async getItemFederatedIds() {
         const itemFederatedIds = new Map();
-        // const expandedItemIds = itemIds.map(id => 'item:' + id);
-        // const fedRecords = await new Federation(this.logger).getFederationRecordsFromIdsBulk(expandedItemIds);
-        // for (let i = 0; i < fedRecords.length; i++) {
-        //   const federationRecord = fedRecords[i];
-        //   // console.log('federationRecord: ' + JSON.stringify(federationRecord));
-        //   // console.log('federationRecord.reference: ' + federationRecord.reference);
-        //   // console.log('federationRecord.mappedReference: ' + federationRecord.mappedReference);
-        //   let vibeId = federationRecord.reference;
-        //   if (vibeId && vibeId.startsWith('item:')) {
-        //     vibeId = vibeId.substring(5);
-        //   }
-        //   itemFederatedIds.set(vibeId, federationRecord.mappedReference);
-        // }
-        // console.log('itemFederatedIds: ' + JSON.stringify(Object.fromEntries(itemFederatedIds)));
         return itemFederatedIds;
     }
     getFullChangeAssortmentMap(fullChange) {
@@ -591,7 +565,7 @@ class BaseProcessPublishAssortment {
             case 'vibeiqfile-dontsendtoflexplm':
                 return this.handleVibeIQFile(events, eventType, sendMode);
             default:
-                return {}; // Or handle other cases as required
+                return {};
         }
     }
     async sendToFlexPLM(events, eventType) {
@@ -761,7 +735,7 @@ class BaseProcessPublishAssortment {
             else {
                 ifc.colorDeletes.push(itemId);
             }
-        } //End deletes for loop
+        }
         if (app_framework_1.Logger.isDebugOn()) {
             console.debug('returning size: ' + itemFamilyChanges.size);
             for (const [key, value] of itemFamilyChanges) {
@@ -781,22 +755,6 @@ class BaseProcessPublishAssortment {
         }
         return seasonalPayloads;
     }
-    /**Returns the events for a given ItemFamilyChanges object
-     *
-     * Cases:
-     * Add just family:
-     * Add option to family (with existing option):
-     * Add option to family (no options on assortment):
-     * Remove family and option:
-     * Remove only option and leave family:
-     * Remove one option of multiple for family:
-     *
-     * @param itemFamilyChanges
-     * @param assortmentId
-     * @param assortmentFederationId
-     * @param itemToFederatedIdMapping
-     * @returns
-     */
     async getEventsForItemFamilyChanges(itemFamilyChanges, assortmentId, seasonFed, itemToFederatedIdMapping) {
         console.info('getEventsForItemFamilyChanges()');
         const events = [];
@@ -806,10 +764,7 @@ class BaseProcessPublishAssortment {
         const familyAssortmentItem = itemFamilyChanges.familyAdd || itemFamilyChanges.familyUpdate || itemFamilyChanges.familyDelete
             || itemFamilyChanges.colorAdds.length > 0 || itemFamilyChanges.colorUpdates.length > 0 || itemFamilyChanges.colorDeletes.length > 0
             || (projectItem && this.updatedSinceDate(projectItem, itemFamilyChanges.sinceDate));
-        //familyItemRemoved is used when adding the first option to an assortment
-        //and will have updates for the family item.
         if (familyAssortmentItem) {
-            //Product-season add
             const entityReference = itemFamilyChanges.itemFamilyId;
             const prodEntityData = (itemFamilyChanges.assortmentItemFullChangeMap.has(entityReference))
                 ? itemFamilyChanges.assortmentItemFullChangeMap.get(entityReference)?.item
@@ -835,9 +790,6 @@ class BaseProcessPublishAssortment {
             }
             events.push(psUpsert);
         }
-        //colorway-season adds
-        //colorAdds
-        //colorUpdates
         const colorwayChanges = [];
         colorwayChanges.push(...itemFamilyChanges.colorAdds);
         colorwayChanges.push(...itemFamilyChanges.colorUpdates);
@@ -878,9 +830,6 @@ class BaseProcessPublishAssortment {
             const aItem = itemFamilyChanges?.assortmentItemFullChangeMap.get(id);
             projectItem = aItem?.projectItem;
         }
-        /////////////////////////////////////////////////////////////////////////////
-        //Get from option assortmentItem because family not in assortmentItemFullChangeMap:start
-        /////////////////////////////////////////////////////////////////////////////
         if (id === itemFamilyChanges.itemFamilyId && Object.keys(projectItem).length == 0) {
             for (const asstItem of itemFamilyChanges.assortmentItemFullChangeMap.values()) {
                 if (asstItem?.familyProjectItem) {
@@ -889,9 +838,6 @@ class BaseProcessPublishAssortment {
                 }
             }
         }
-        /////////////////////////////////////////////////////////////////////////////
-        //Get from option assortmentItem because family not in assortmentItemFullChangeMap:end
-        /////////////////////////////////////////////////////////////////////////////
         return projectItem;
     }
     async getSeasonalData(projectItem) {

package/lib/publish/base-process-publish-assortment.spec.js

@@ -13,7 +13,6 @@ let federatedId = '';
 jest.mock('../util/data-converter', () => {
     return {
         DataConverter: class {
-            // eslint-disable-next-line @typescript-eslint/no-unused-vars, unused-imports/no-unused-vars
             getFlexPLMObjectData(newData, dataToSkip, inflateObjRef) {
                 return newData;
             }
@@ -96,7 +95,6 @@ describe('getPublishInfo', () => {
             return { id: assortmentId, name: assortmentName };
         });
         const spyyGetSnapshotVersion = jest.spyOn(ppa, 'getSnapshotVersion')
-            // eslint-disable-next-line unused-imports/no-unused-vars, @typescript-eslint/no-unused-vars
             .mockImplementation(async (assortmentId, assortmentPublishChangeId) => {
             return versionHistoryNumber;
         });
@@ -122,7 +120,6 @@ describe('getPublishInfo', () => {
             return { id: assortmentId, name: undefined };
         });
         const spyyGetSnapshotVersion = jest.spyOn(ppa, 'getSnapshotVersion')
-            // eslint-disable-next-line unused-imports/no-unused-vars, @typescript-eslint/no-unused-vars
             .mockImplementation(async (assortmentId, assortmentPublishChangeId) => {
             return versionHistoryNumber;
         });
@@ -148,7 +145,6 @@ describe('getPublishInfo', () => {
             return undefined;
         });
         const spyyGetSnapshotVersion = jest.spyOn(ppa, 'getSnapshotVersion')
-            // eslint-disable-next-line unused-imports/no-unused-vars, @typescript-eslint/no-unused-vars
             .mockImplementation(async (assortmentId, assortmentPublishChangeId) => {
             return versionHistoryNumber;
         });
@@ -183,7 +179,6 @@ describe('getPublishInfo', () => {
             return { id: assortmentId, name: assortmentName };
         });
         const spyyGetSnapshotVersion = jest.spyOn(ppa, 'getSnapshotVersion')
-            // eslint-disable-next-line unused-imports/no-unused-vars, @typescript-eslint/no-unused-vars
             .mockImplementation(async (assortmentId, assortmentPublishChangeId) => {
             return versionHistoryNumber;
         });
@@ -208,7 +203,6 @@ describe('getPublishInfo', () => {
             return { id: assortmentId, name: assortmentName };
         });
         const spyyGetSnapshotVersion = jest.spyOn(ppa, 'getSnapshotVersion')
-            // eslint-disable-next-line unused-imports/no-unused-vars, @typescript-eslint/no-unused-vars
             .mockImplementation(async (assortmentId, assortmentPublishChangeId) => {
             return versionHistoryNumber;
         });
@@ -235,7 +229,6 @@ describe('getPublishInfo', () => {
             return { id: assortmentId, name: assortmentName };
         });
         const spyyGetSnapshotVersion = jest.spyOn(ppa, 'getSnapshotVersion')
-            // eslint-disable-next-line unused-imports/no-unused-vars, @typescript-eslint/no-unused-vars
             .mockImplementation(async (assortmentId, assortmentPublishChangeId) => {
             return versionHistoryNumber;
         });
@@ -262,7 +255,6 @@ describe('getPublishInfo', () => {
             return { id: assortmentId, name: assortmentName };
         });
         const spyyGetSnapshotVersion = jest.spyOn(ppa, 'getSnapshotVersion')
-            // eslint-disable-next-line unused-imports/no-unused-vars, @typescript-eslint/no-unused-vars
             .mockImplementation(async (assortmentId, assortmentPublishChangeId) => {
             return versionHistoryNumber;
         });
@@ -416,7 +408,6 @@ describe('getSnapshotVersion', () => {
             {
                 id: 'qewrwer',
                 assortmentChangeId: 'bad-id',
-                // createdOn: '2023-01-14T19:13:58.902Z',
                 versionNumber
             }
         ];
@@ -1149,7 +1140,6 @@ describe('getItemFamilyChanges', () => {
         const ifcs = pcd.itemFamilyChanges;
         expect(ifcs.size).toEqual(1);
         const ifc = ifcs.get(itemFamilyId);
-        // expect(ifc.familyAdd).toBe(true);
         expect(ifc.colorAdds.length).toEqual(1);
     });
     it('Feb 3 - 2+ Option A', () => {
@@ -1179,7 +1169,6 @@ describe('getItemFamilyChanges', () => {
         const ifcs = pcd.itemFamilyChanges;
         expect(ifcs.size).toEqual(1);
         const ifc = ifcs.get(itemFamilyId);
-        // expect(ifc.familyAdd).toBe(true);
         expect(ifc.colorAdds.length).toEqual(2);
     });
     it('Feb 3 - 2+ Option A & Feb 3 - 1 Option A', () => {
@@ -1311,8 +1300,6 @@ describe('getItemFamilyChanges', () => {
         const ifcs = pcd.itemFamilyChanges;
         expect(ifcs.size).toEqual(1);
         const ifc = ifcs.get(itemFamilyId);
-        //TODO fix
-        // expect(ifc.familyDelete).toBe(true);
         expect(ifc.colorAdds.length).toEqual(0);
         expect(ifc.colorDeletes.length).toEqual(1);
     });
@@ -1585,10 +1572,9 @@ describe('getEventsForItemFamilyChanges - conditional eventType', () => {
         jest.spyOn(type_conversion_utils_1.TypeConversionUtils, 'getIdentifierProperties').mockResolvedValue(['identifier']);
         jest.spyOn(type_conversion_utils_1.TypeConversionUtils, 'getInformationalProperties').mockResolvedValue([]);
         jest.spyOn(type_conversion_utils_1.TypeConversionUtils, 'isOutboundCreatableFromEntity')
-            .mockResolvedValueOnce(true) // for family
-            .mockResolvedValueOnce(true); // for SKU
+            .mockResolvedValueOnce(true)
+            .mockResolvedValueOnce(true);
         const events = await bppa.getEventsForItemFamilyChanges(itemFamilyChanges, 'assort123', seasonFed, new Map());
-        // Should have both family and SKU events because familyAssortmentItem is true when colorAdds.length > 0
         expect(events).toHaveLength(2);
         const skuEvent = events.find(e => e.objectClass === 'LCSSKUSeasonLink');
         expect(skuEvent.eventType).toBe('UPSERT_ON_SEASON');
@@ -1627,10 +1613,9 @@ describe('getEventsForItemFamilyChanges - conditional eventType', () => {
         jest.spyOn(type_conversion_utils_1.TypeConversionUtils, 'getIdentifierProperties').mockResolvedValue(['identifier']);
         jest.spyOn(type_conversion_utils_1.TypeConversionUtils, 'getInformationalProperties').mockResolvedValue([]);
         jest.spyOn(type_conversion_utils_1.TypeConversionUtils, 'isOutboundCreatableFromEntity')
-            .mockResolvedValueOnce(false) // for family
-            .mockResolvedValueOnce(false); // for SKU
+            .mockResolvedValueOnce(false)
+            .mockResolvedValueOnce(false);
         const events = await bppa.getEventsForItemFamilyChanges(itemFamilyChanges, 'assort123', seasonFed, new Map());
-        // Should have both family and SKU events because familyAssortmentItem is true when colorUpdates.length > 0
         expect(events).toHaveLength(2);
         const skuEvent = events.find(e => e.objectClass === 'LCSSKUSeasonLink');
         expect(skuEvent.eventType).toBe('UPDATE_ON_SEASON');
@@ -1669,7 +1654,6 @@ describe('getEventsForItemFamilyChanges - conditional eventType', () => {
         jest.spyOn(map_utils_1.MapUtil, 'applyTransformMap').mockResolvedValue({ transformedData: 'value' });
         jest.spyOn(type_conversion_utils_1.TypeConversionUtils, 'getIdentifierProperties').mockResolvedValue(['identifier']);
         jest.spyOn(type_conversion_utils_1.TypeConversionUtils, 'getInformationalProperties').mockResolvedValue([]);
-        // Product is creatable (true), SKU is not (false)
         jest.spyOn(type_conversion_utils_1.TypeConversionUtils, 'isOutboundCreatableFromEntity')
             .mockResolvedValueOnce(true)
             .mockResolvedValueOnce(false);
@@ -1680,9 +1664,7 @@ describe('getEventsForItemFamilyChanges - conditional eventType', () => {
         expect(productEvent.eventType).toBe('UPSERT_ON_SEASON');
         expect(skuEvent.eventType).toBe('UPDATE_ON_SEASON');
         expect(type_conversion_utils_1.TypeConversionUtils.isOutboundCreatableFromEntity).toHaveBeenCalledTimes(2);
-        // Verify product event called with assortment entity
         expect(type_conversion_utils_1.TypeConversionUtils.isOutboundCreatableFromEntity).toHaveBeenNthCalledWith(1, undefined, mapFileUtil, familyProjectItem, { item: prodEntityData, assortment });
-        // Verify SKU event called with assortment entity
         expect(type_conversion_utils_1.TypeConversionUtils.isOutboundCreatableFromEntity).toHaveBeenNthCalledWith(2, undefined, mapFileUtil, colorProjectItem, { item: itemData, assortment });
     });
 });

package/lib/publish/mockData.js

@@ -3399,11 +3399,6 @@ exports.fall_2003_fedMapping = [
         mappedReference: 'VR:com.lcs.wc.product.LCSSKU:372509'
     }
 ];
-//SYHfQzYWlfXDqK7r - 4 adds
-//JreGRNvoJ3FsoRZI - 1 delete
-//NaPUhAdEzKB-5tQ3 - no changes
-//CHGKSCT358qyh1Nu - 1 delete
-//H4L4dHziO6WZRIwa - re-add from JreGRNvoJ3FsoRZI
 exports.apc_2bOWR2j9R0QThDVu_delete_history = [
     {
         adds: 4,

package/lib/transform/identifier-conversion-spec-mockData.js

@@ -31,20 +31,6 @@ exports.mapping = {
                 }
             }
         }
-        // flex2vibe: {
-        //   LCSRevisableEntity: {
-        //     getMapKey: (object) =>{ return object;}
-        //   },
-        //   LCSLast: {
-        //     getMapKey: (object) => {return object;}
-        //   },
-        //   LCSMaterial: {
-        //     getMapKey: (object) =>{ return object;}
-        //   },
-        //   LCSBusinessObject: {
-        //     getMapKey: (object) => {return object;}
-        //   }
-        // },
     },
     LCSSeason: {
         vibe2flex: {
@@ -68,7 +54,7 @@ exports.mapping = {
         vibeOwningKeys: ['itemNumber', 'lifecycleStage'],
         vibe2flex: {
             getClass: () => 'LCSProduct',
-            getSoftType: (entity /*, dependencies*/) => {
+            getSoftType: (entity) => {
                 const prodType = entity['prodType'];
                 let val = '';
                 switch (prodType) {
@@ -93,7 +79,7 @@ exports.mapping = {
                 vibeIQIdentifier: 'itemNumber'
             },
             valueTransform: {
-                transformEx: (row /*, dependencies*/) => {
+                transformEx: (row) => {
                     return row['otherProp'] + 'xxx';
                 }
             }
@@ -111,7 +97,7 @@ exports.mapping = {
         vibeOwningKeys: ['itemNumber', 'lifecycleStage'],
         vibe2flex: {
             getClass: () => 'LCSSKU',
-            getSoftType: (entity /*, dependencies*/) => {
+            getSoftType: (entity) => {
                 const prodType = entity['prodType'];
                 let val = '';
                 switch (prodType) {
@@ -266,20 +252,6 @@ exports.mapping2 = {
                 }
             }
         }
-        // flex2vibe: {
-        //   LCSRevisableEntity: {
-        //     getMapKey: (object) =>{ return object;}
-        //   },
-        //   LCSLast: {
-        //     getMapKey: (object) => {return object;}
-        //   },
-        //   LCSMaterial: {
-        //     getMapKey: (object) =>{ return object;}
-        //   },
-        //   LCSBusinessObject: {
-        //     getMapKey: (object) => {return object;}
-        //   }
-        // },
     },
     LCSSeason: {
         getIdentifierProperties: () => ['brand', 'year', 'seasonType'],
@@ -302,7 +274,7 @@ exports.mapping2 = {
         vibeOwningKeys: ['itemNumber', 'lifecycleStage'],
         vibe2flex: {
             getClass: () => 'LCSProduct',
-            getSoftType: (entity /*, dependencies*/) => {
+            getSoftType: (entity) => {
                 const prodType = entity['prodType'];
                 let val = '';
                 switch (prodType) {
@@ -327,7 +299,7 @@ exports.mapping2 = {
                 vibeIQIdentifier: 'itemNumber'
             },
             valueTransform: {
-                transformEx: (row /*, dependencies*/) => {
+                transformEx: (row) => {
                     return row['otherProp'] + 'xxx';
                 }
             }
@@ -346,7 +318,7 @@ exports.mapping2 = {
         getIdentifierProperties: () => ['uniqueIdentifierA', 'uniqueIdentifierB'],
         vibe2flex: {
             getClass: () => 'LCSSKU',
-            getSoftType: (entity /*, dependencies*/) => {
+            getSoftType: (entity) => {
                 const prodType = entity['prodType'];
                 let val = '';
                 switch (prodType) {

package/lib/transform/identifier-conversion.d.ts

@@ -5,45 +5,9 @@ export declare class IdentifierConversion {
     static readonly INBOUND_ENTITY_MISSING_IDENIFIER_PROPS = "IdentifierConversion.getEntityCriteriaFromObject(): missing identifier properties: ";
     static readonly MISSING_OBJECT = "IdentifierConversion.getEntityCriteriaFromObject(): missing: object";
     static readonly MISSING_FLEXPLM_OBJECT_CLASS = "IdentifierConversion.getEntityCriteriaFromObject(): missing: flexPLMObjectClass";
-    /** Takes in an assortment and returns an object to query for an LCSSeason
-     * This will only return the identifier properties, and information properties if specified.
-     * @param transformMapFile
-     * @param mapFileUtil
-     * @param dc
-     * @param assortment
-     * @param includeInformationKeys defaults true
-     * @returns
-     */
     static getSeasonIdentityObject(transformMapFile: string, mapFileUtil: MapFileUtil, dc: DataConverter, assortment: any, includeInformationKeys?: boolean): Promise<SeasonFederation>;
-    /** Takes in an assortment and returns an object to query for an SeasonGroup
-   * This will only return the identifier properties, and information properties if specified.
-   * @param transformMapFile
-   * @param mapFileUtil
-   * @param dc
-   * @param assortment
-   * @param includeInformationKeys defaults true
-   * @returns
-   */
     static getSeasonGroupIdentityObject(transformMapFile: string, mapFileUtil: MapFileUtil, dc: DataConverter, assortment: any, includeInformationKeys?: boolean): Promise<SeasonGroupFederation>;
-    /** Takes in an item and returns an object to query for an LCSProduct
-   * This will only return the identifier properties, and information properties if specified.
-   * @param transformMapFile
-   * @param mapFileUtil
-   * @param dc
-   * @param assortment
-   * @param includeInformationKeys defaults true
-   * @returns
-   */
     static getProductIdentityObject(transformMapFile: string, mapFileUtil: MapFileUtil, dc: DataConverter, itemFamilyObject: any, includeInformationKeys?: boolean): Promise<ProductFederation>;
-    /** Takes in an item and returns an object to query for an LCSSKU
-   * This will only return the identifier properties, and information properties if specified.
-   * @param transformMapFile
-   * @param mapFileUtil
-   * @param dc
-   * @param assortment
-   * @param includeInformationKeys defaults true
-   * @returns
-   */
     static getSKUIdentityObject(transformMapFile: string, mapFileUtil: MapFileUtil, dc: DataConverter, itemObject: any, includeInformationKeys?: boolean): Promise<SkuFederation>;
     static getEntityCriteriaFromObject(transformMapFile: string, mapFileUtil: MapFileUtil, dc: DataConverter, object: any): Promise<any>;
     static getAssortmentCriteriaFromObject(transformMapFile: string, mapFileUtil: MapFileUtil, dc: DataConverter, object: any): Promise<any>;

package/lib/transform/identifier-conversion.js

@@ -5,15 +5,6 @@ const map_utils_1 = require("../util/map-utils");
 const type_conversion_utils_1 = require("../util/type-conversion-utils");
 const event_short_message_status_1 = require("../util/event-short-message-status");
 class IdentifierConversion {
-    /** Takes in an assortment and returns an object to query for an LCSSeason
-     * This will only return the identifier properties, and information properties if specified.
-     * @param transformMapFile
-     * @param mapFileUtil
-     * @param dc
-     * @param assortment
-     * @param includeInformationKeys defaults true
-     * @returns
-     */
     static async getSeasonIdentityObject(transformMapFile, mapFileUtil, dc, assortment, includeInformationKeys = true) {
         if (!assortment) {
             throw new Error('IdentifierConversion.getSeasonIdentityObject(): assortment must be provided.');
@@ -58,15 +49,6 @@ class IdentifierConversion {
         }
         return seasonObj;
     }
-    /** Takes in an assortment and returns an object to query for an SeasonGroup
-   * This will only return the identifier properties, and information properties if specified.
-   * @param transformMapFile
-   * @param mapFileUtil
-   * @param dc
-   * @param assortment
-   * @param includeInformationKeys defaults true
-   * @returns
-   */
     static async getSeasonGroupIdentityObject(transformMapFile, mapFileUtil, dc, assortment, includeInformationKeys = true) {
         if (!assortment) {
             throw new Error('IdentifierConversion.getSeasonGroupIdentityObject(): assortment must be provided.');
@@ -110,15 +92,6 @@ class IdentifierConversion {
         }
         return seasonGroupObj;
     }
-    /** Takes in an item and returns an object to query for an LCSProduct
-   * This will only return the identifier properties, and information properties if specified.
-   * @param transformMapFile
-   * @param mapFileUtil
-   * @param dc
-   * @param assortment
-   * @param includeInformationKeys defaults true
-   * @returns
-   */
     static async getProductIdentityObject(transformMapFile, mapFileUtil, dc, itemFamilyObject, includeInformationKeys = true) {
         if (!itemFamilyObject) {
             throw new Error('IdentifierConversion.getProductIdentityObject(): itemFamilyObject must be provided.');
@@ -156,15 +129,6 @@ class IdentifierConversion {
             .applyTransformMap(transformMapFile, mapFileUtil, prodObj, mapKey, type_conversion_utils_1.TypeConversionUtils.VIBE2FLEX_DIRECTION);
         return prodObj;
     }
-    /** Takes in an item and returns an object to query for an LCSSKU
-   * This will only return the identifier properties, and information properties if specified.
-   * @param transformMapFile
-   * @param mapFileUtil
-   * @param dc
-   * @param assortment
-   * @param includeInformationKeys defaults true
-   * @returns
-   */
     static async getSKUIdentityObject(transformMapFile, mapFileUtil, dc, itemObject, includeInformationKeys = true) {
         if (!itemObject) {
             throw new Error('IdentifierConversion.getSKUIdentityObject(): itemObject must be provided.');

package/lib/transform/identifier-conversion.spec.js

@@ -31,11 +31,9 @@ describe('getAssortmentFromObject', () => {
                     entityValues[key] = value;
                 }
                 else if (Array.isArray(value)) {
-                    //multi select
                     entityValues[key] = value.map((v) => v.value);
                 }
                 else if (value.value) {
-                    //single select
                     entityValues[key] = value.value;
                 }
             }
@@ -169,11 +167,9 @@ describe('getItemCriteriaFromObject', () => {
                     entityValues[key] = value;
                 }
                 else if (Array.isArray(value)) {
-                    //multi select
                     entityValues[key] = value.map((v) => v.value);
                 }
                 else if (value.value) {
-                    //single select
                     entityValues[key] = value.value;
                 }
             }

package/lib/util/config-defaults.js

@@ -6,11 +6,9 @@ const util_1 = require("@contrail/util");
 const type_defaults_1 = require("./type-defaults");
 class ConfigDefaults {
     static async setConfigDefaults(config) {
-        //Validate config
         if (!config.apiHost || !config.userName || !config.password) {
             throw new Error(ConfigDefaults.NEED_CONFIG_VALUES);
         }
-        //List will be comma separated list in UI, so convert to array
         if (config?.itemPreDevelopmentLifecycleStages && !(config?.itemPreDevelopmentLifecycleStages instanceof Array)) {
             config.itemPreDevelopmentLifecycleStages = config.itemPreDevelopmentLifecycleStages.split(',');
         }
@@ -28,7 +26,6 @@ class ConfigDefaults {
         const pass = outputConfig.password;
         outputConfig.userName = () => uName;
         outputConfig.password = () => pass;
-        //Don't allow overwriting this.
         outputConfig['OOBvibeEventEndpoint'] = '/rfa/vibeiq/vibeEvents';
         type_defaults_1.TypeDefaults.applyConfig(outputConfig);
         console.log('outputConfig: ' + JSON.stringify(outputConfig));

package/lib/util/config-defaults.spec.js

@@ -22,13 +22,11 @@ describe('all tests', () => {
     describe('setConfigDefaults - required values', () => {
         it('missing apiHost', async () => {
             const config = {
-                //apiHost: 'http://test.com',
                 userName: 'vibeiq',
                 password: 'vibeiq',
                 plmEnviornment: 'SB'
             };
             try {
-                // eslint-disable-next-line @typescript-eslint/no-unused-vars, unused-imports/no-unused-vars
                 const fcConfig = await config_defaults_1.ConfigDefaults.setConfigDefaults(config);
             }
             catch (e) {
@@ -38,12 +36,10 @@ describe('all tests', () => {
         it('missing userName', async () => {
             const config = {
                 apiHost: 'http://test.com',
-                //userName: 'vibeiq',
                 password: 'vibeiq',
                 plmEnviornment: 'SB'
             };
             try {
-                // eslint-disable-next-line @typescript-eslint/no-unused-vars, unused-imports/no-unused-vars
                 const fcConfig = await config_defaults_1.ConfigDefaults.setConfigDefaults(config);
             }
             catch (e) {
@@ -54,11 +50,9 @@ describe('all tests', () => {
             const config = {
                 apiHost: 'http://test.com',
                 userName: 'vibeiq',
-                //password: 'vibeiq',
                 plmEnviornment: 'SB'
             };
             try {
-                // eslint-disable-next-line @typescript-eslint/no-unused-vars, unused-imports/no-unused-vars
                 const fcConfig = await config_defaults_1.ConfigDefaults.setConfigDefaults(config);
             }
             catch (e) {
@@ -70,10 +64,8 @@ describe('all tests', () => {
                 apiHost: 'http://test.com',
                 userName: 'vibeiq',
                 password: 'vibeiq',
-                //plmEnviornment: 'SB'
             };
             try {
-                // eslint-disable-next-line @typescript-eslint/no-unused-vars, unused-imports/no-unused-vars
                 const fcConfig = await config_defaults_1.ConfigDefaults.setConfigDefaults(config);
             }
             catch (e) {
@@ -224,7 +216,6 @@ describe('all tests', () => {
             const startConfig = Object.assign({}, config);
             const objectClass = 'LCSSeason';
             const expectedAtts = ['flexPLMSeasonName'];
-            // const expectedAtts =['seasonType', 'seasonYear'];
             const fcConfig = await config_defaults_1.ConfigDefaults.setConfigDefaults(startConfig);
             const identifierAtts = fcConfig.identifierAtts[objectClass];
             expect(identifierAtts instanceof Array).toBeTruthy();