@contrail/flexplm 1.5.0-alpha.6fc44c4 → 1.5.0-alpha.aaef470

package/src/util/type-defaults.spec.ts

@@ -485,14 +485,28 @@ describe('Type Defaults', () =>{
       expect(entityClass).toBe('custom-entity');
     });
 
-    it('item - LCSMaterial', () =>{
+    it('item - LCSMaterial - processAsItem=true', () =>{
+      const object = {
+        flexPLMObjectClass: 'LCSMaterial'
+      };
+
+      TypeDefaults.applyConfig({ LCSMaterial: { processAsItem: true } });
+      try {
+        const entityClass = TypeDefaults.getDefaultEntityClass(object);
+        expect(entityClass).toBe('item');
+      } finally {
+        TypeDefaults.applyConfig({});
+      }
+    });
+
+    it('custom-entity - LCSMaterial - processAsItem=false (default)', () =>{
       const object = {
         flexPLMObjectClass: 'LCSMaterial'
       };
 
       const entityClass = TypeDefaults.getDefaultEntityClass(object);
 
-      expect(entityClass).toBe('item');
+      expect(entityClass).toBe('custom-entity');
     });
 
   });//getDefaultEntityClass
@@ -560,13 +574,26 @@ describe('Type Defaults', () =>{
       expect(typePath).toBe('assortment');
     });
 
-    it('LCSMaterial', () =>{
+    it('LCSMaterial - processAsItem=true', () =>{
       const object = {
         flexPLMObjectClass: 'LCSMaterial'
       };
 
-      const typePath = TypeDefaults.getDefaultEntityTypePath(object);
-      expect(typePath).toBe('item:material');
+      TypeDefaults.applyConfig({ LCSMaterial: { processAsItem: true } });
+      try {
+        const typePath = TypeDefaults.getDefaultEntityTypePath(object);
+        expect(typePath).toBe('item:material');
+      } finally {
+        TypeDefaults.applyConfig({});
+      }
+    });
+
+    it('LCSMaterial - processAsItem=false (default) throws', () =>{
+      const object = {
+        flexPLMObjectClass: 'LCSMaterial'
+      };
+
+      expect(() => TypeDefaults.getDefaultEntityTypePath(object)).toThrowError(TypeDefaults.NO_TYPE_PATH);
     });
   });//getDefaultEntityTypePath
 
@@ -641,13 +668,27 @@ describe('Type Defaults', () =>{
       expect(defaultIdentifiers).toHaveLength(1);
     });
 
-    it('LCSMaterial', () =>{
+    it('LCSMaterial - processAsItem=true', () =>{
+      const object = {
+        flexPLMObjectClass: 'LCSMaterial'
+      };
+      TypeDefaults.applyConfig({ LCSMaterial: { processAsItem: true } });
+      try {
+        const defaultIdentifiers = TypeDefaults.getDefaultIdentifierPropertiesFromObject(object);
+        expect(defaultIdentifiers).toContain('itemNumber');
+        expect(defaultIdentifiers).toHaveLength(1);
+      } finally {
+        TypeDefaults.applyConfig({});
+      }
+    });
+
+    it('LCSMaterial - processAsItem=false (default)', () =>{
       const object = {
         flexPLMObjectClass: 'LCSMaterial'
       };
       const defaultIdentifiers = TypeDefaults.getDefaultIdentifierPropertiesFromObject(object);
 
-      expect(defaultIdentifiers).toContain('itemNumber');
+      expect(defaultIdentifiers).toContain('name');
       expect(defaultIdentifiers).toHaveLength(1);
     });
 
@@ -694,15 +735,63 @@ describe('Type Defaults', () =>{
       expect(defaultIdentifiers).toHaveLength(1);
     });
 
-    it('LCSMaterial', () =>{
+    it('LCSMaterial - processAsItem=true', () =>{
+      const object = {
+        flexPLMObjectClass: 'LCSMaterial'
+      };
+
+      TypeDefaults.applyConfig({ LCSMaterial: { processAsItem: true } });
+      try {
+        const defaultIdentifiers = TypeDefaults.getDefaultInformationalPropertiesFromObject(object);
+        expect(defaultIdentifiers).toContain('name');
+        expect(defaultIdentifiers).toHaveLength(1);
+      } finally {
+        TypeDefaults.applyConfig({});
+      }
+    });
+
+    it('LCSMaterial - processAsItem=false (default) yields no informational props', () =>{
       const object = {
         flexPLMObjectClass: 'LCSMaterial'
       };
 
       const defaultIdentifiers = TypeDefaults.getDefaultInformationalPropertiesFromObject(object);
-      expect(defaultIdentifiers).toContain('name');
-      expect(defaultIdentifiers).toHaveLength(1);
+      expect(defaultIdentifiers).toHaveLength(0);
     });
 
   });//getDefaultInformationalPropertiesFromObject
+
+  describe('applyConfig', () => {
+    afterEach(() => {
+      TypeDefaults.applyConfig({});
+    });
+
+    it('sets processLCSMaterialAsItem=true when processAsItem=true', () => {
+      TypeDefaults.applyConfig({ LCSMaterial: { processAsItem: true } });
+      expect(TypeDefaults.processLCSMaterialAsItem).toBe(true);
+    });
+
+    it('sets processLCSMaterialAsItem=true when processAsItem=\"true\" (string)', () => {
+      TypeDefaults.applyConfig({ LCSMaterial: { processAsItem: 'true' } });
+      expect(TypeDefaults.processLCSMaterialAsItem).toBe(true);
+    });
+
+    it('sets processLCSMaterialAsItem=false when processAsItem=false', () => {
+      TypeDefaults.processLCSMaterialAsItem = true;
+      TypeDefaults.applyConfig({ LCSMaterial: { processAsItem: false } });
+      expect(TypeDefaults.processLCSMaterialAsItem).toBe(false);
+    });
+
+    it('sets processLCSMaterialAsItem=false when LCSMaterial missing', () => {
+      TypeDefaults.processLCSMaterialAsItem = true;
+      TypeDefaults.applyConfig({});
+      expect(TypeDefaults.processLCSMaterialAsItem).toBe(false);
+    });
+
+    it('sets processLCSMaterialAsItem=false when config is null/undefined', () => {
+      TypeDefaults.processLCSMaterialAsItem = true;
+      TypeDefaults.applyConfig(undefined);
+      expect(TypeDefaults.processLCSMaterialAsItem).toBe(false);
+    });
+  });
 });

package/src/util/type-defaults.ts

@@ -2,8 +2,25 @@ export class TypeDefaults {
   static NO_ENTITY_TYPE = 'Not able to determine the entity type of the entity object';
   static NO_OBJECT_CLASS = 'Please ensure that the flexPLMObjectClass property is provided.';
   static NO_TYPE_PATH = 'Please ensure that the flexPLMTypePath property is provided.';
+  static processLCSMaterialAsItem = false;
   constructor() {
   }
+
+  /** Applies values from the resolved config to TypeDefaults static state.
+   *  Currently toggles whether LCSMaterial is treated as an item (new) or a
+   *  custom-entity (old) based on config.LCSMaterial.processAsItem.
+   *  Technically this could cause side effects if different parts of the code
+   *  expect different behavior, but in practice * @param config will be 
+   *  consistent across the app and this is simpler than passing this config
+   *  through multiple layers of function calls.
+   */
+  static applyConfig(config: any): void {
+    TypeDefaults.processLCSMaterialAsItem = TypeDefaults.isPropertyTrue(config?.LCSMaterial?.processAsItem);
+  }
+
+  static isPropertyTrue(value: any): boolean {
+    return value === true || (typeof value === 'string' && value.toLowerCase() === 'true');
+  }
   /**Takes in full entity and returs the default FlexPLM
    * object class.
    *
@@ -87,7 +104,7 @@ export class TypeDefaults {
    */
 
   static getDefaultIdentifierProperties(entity): string[] {
-    const identifierProps = [];
+    const identifierProps: string[] = [];
     const entityType = this.getEntityType(entity);
 
     switch (entityType) {
@@ -168,7 +185,14 @@ export class TypeDefaults {
   static getDefaultEntityClass(object): string {
     let entityClass = '';
     let objectClass = TypeDefaults.getObjectClass(object);
-    if(['LCSProduct', 'LCSSKU', 'LCSMaterial'].includes(objectClass)){
+    const itemClasses = TypeDefaults.processLCSMaterialAsItem
+      ? ['LCSProduct', 'LCSSKU', 'LCSMaterial']
+      : ['LCSProduct', 'LCSSKU'];
+    const customEntityClasses = TypeDefaults.processLCSMaterialAsItem
+      ? ['LCSRevisableEntity', 'LCSLifecycleManaged', 'LCSLast']
+      : ['LCSRevisableEntity', 'LCSLifecycleManaged', 'LCSLast', 'LCSMaterial'];
+
+    if(itemClasses.includes(objectClass)){
       entityClass = 'item';
     }else if(['LCSProductSeasonLink', 'LCSSKUSeasonLink'].includes(objectClass)){
       entityClass = 'project-item'
@@ -176,7 +200,7 @@ export class TypeDefaults {
       entityClass = 'color';
     } else if(['LCSSeason', 'SeasonGroup'].includes(objectClass)) {
       entityClass = 'assortment';
-    } else if(['LCSRevisableEntity', 'LCSLifecycleManaged', 'LCSLast'].includes(objectClass)) {
+    } else if(customEntityClasses.includes(objectClass)) {
       entityClass = 'custom-entity';
     }
 
@@ -202,7 +226,9 @@ export class TypeDefaults {
           typePath = 'item';
           break;
         case 'LCSMaterial':
-          typePath = 'item:material';
+          if (TypeDefaults.processLCSMaterialAsItem) {
+            typePath = 'item:material';
+          }
           break;
         case 'LCSProductSeasonLink':
         case 'LCSSKUSeasonLink':
@@ -238,8 +264,14 @@ export class TypeDefaults {
     switch (objectClass) {
       case 'LCSProduct':
       case 'LCSSKU':
+          identifierProps.push('itemNumber');
+        break;
       case 'LCSMaterial':
+        if (TypeDefaults.processLCSMaterialAsItem) {
           identifierProps.push('itemNumber');
+        } else {
+          identifierProps.push('name');
+        }
         break;
       case 'LCSSeason':
         identifierProps.push('flexPLMSeasonName');
@@ -268,7 +300,11 @@ export class TypeDefaults {
     static getDefaultInformationalPropertiesFromObject(object): string[] {
       const objectClass = TypeDefaults.getObjectClass(object);
       let properties:string[] = [];
-      if (['LCSProduct', 'LCSMaterial'].includes(objectClass)) {
+      const itemClasses = TypeDefaults.processLCSMaterialAsItem
+        ? ['LCSProduct', 'LCSMaterial']
+        : ['LCSProduct'];
+
+      if (itemClasses.includes(objectClass)) {
         properties.push('name');
       } else if ('LCSSKU' === objectClass) {
         properties.push('optionName');