@contrail/flexplm 1.3.1-alpha.7db7b62 → 1.3.1-alpha.8bc920d

package/lib/util/thumbnail-util.js

@@ -8,7 +8,6 @@ const flexplm_connect_1 = require("./flexplm-connect");
 class ThumbnailUtil {
     constructor(config) {
         this.config = config;
-        /** The max_thumbnail_size is for limiting the size of the thumbnail being sent to FlexPLM.  It is used when checking the size of the auto generated thumbnails (smallViewable, tinyViewable, etc.). */
         this.max_thumbnail_size = 5 * 1024 * 1024;
         this.entities = new sdk_1.Entities();
         if (this.config['max_thumbnail_size']) {
@@ -18,7 +17,6 @@ class ThumbnailUtil {
     async setOutboundThumbnail(data, event) {
         if (event?.newData?.primaryViewableId && event?.newData?.largeViewableDownloadUrl) {
             const primaryViewableId = event.newData.primaryViewableId;
-            //get custom sizes
             const fileId = await this.getFileId(primaryViewableId);
             if (fileId) {
                 const customSizes = await this.getCustomSizes();
@@ -33,9 +31,6 @@ class ThumbnailUtil {
         }
         return data;
     }
-    /** Determines if a new image has been generated.  If any viewable is new, there might be a better
-   * sized image.  So send the fileId as new.
-   */
     isThumbnailNew(event, customSizes) {
         const propertyDiffs = event?.propertyDiffs;
         if (propertyDiffs) {
@@ -57,7 +52,6 @@ class ThumbnailUtil {
         const OOBSizes = JSON.parse(JSON.stringify(ThumbnailUtil.OOB_SIZES));
         sizes.push(...OOBSizes);
         console.info('sizes: ' + JSON.stringify(sizes));
-        //get Content
         const content = await this.getContentEntity(primaryViewableId, sizes);
         if (!content) {
             return undefined;
@@ -105,14 +99,6 @@ class ThumbnailUtil {
         this.logContentResults(content, relations);
         return content;
     }
-    /** This outputs the content entity, without the inflated file entities.
-   * To help debugging issues with sending the thumbnail info.
-   * The inflated entities are removed, because are large and cause
-   * problems with log file size limits.
-   *
-   * @param content: the content with inflated objects
-   * @param relations: string[] of the slugs for inflated objects
-   */
     logContentResults(content, relations) {
         if (app_framework_1.Logger.isDebugOn() && content && relations) {
             const contentCopy = JSON.parse(JSON.stringify(content));
@@ -122,22 +108,12 @@ class ThumbnailUtil {
             console.debug('content: ' + JSON.stringify(contentCopy));
         }
     }
-    /** Syncs the thumbnail from FlexPLM to VibeIQ. Handles creating, replacing, or removing
-     * the primary viewable content and persists the updates directly to the entity.
-     *
-     * @param entityId - The ID of the entity to update with thumbnail properties.
-     * @param primaryViewableId - The existing primary viewable content ID, if any.
-     * @param event - The inbound event containing thumbnail data (NEW_THUMBNAIL_ID / EXISTING_THUMBNAIL_ID).
-     * @param entityName - The entity type name (e.g. 'item', 'color') used for API calls.
-     * @returns The updated entity, or undefined if no thumbnail changes were needed.
-     */
     async syncThumbnailToVibeIQ({ entityId, primaryViewableId, event, entityName }) {
         console.debug(`syncThumbnailToVibeIQ: entityId=${entityId}, primaryViewableId=${primaryViewableId}, entityName=${entityName}`);
         const eventData = event.data || {};
         const newThumbnailId = eventData[ThumbnailUtil.NEW_THUMBNAIL_ID];
         const existingThumbnailId = eventData[ThumbnailUtil.EXISTING_THUMBNAIL_ID];
         const thumbnailUrl = newThumbnailId || existingThumbnailId;
-        // Case 1: REMOVE_THUMBNAIL
         if (newThumbnailId === ThumbnailUtil.REMOVE_THUMBNAIL) {
             if (primaryViewableId) {
                 await this.entities.delete({ entityName: 'content', id: primaryViewableId });
@@ -147,12 +123,10 @@ class ThumbnailUtil {
             console.debug(`syncThumbnailToVibeIQ: applied clear updates for entityId=${entityId}`);
             return updatedEntity;
         }
-        // Early return if no thumbnail URL
         if (!thumbnailUrl) {
             console.debug(`syncThumbnailToVibeIQ: no thumbnail URL for entityId=${entityId}`);
             return undefined;
         }
-        // Case 2: No existing primaryViewableId — create new content
         if (!primaryViewableId) {
             const content = await this.createContentFromFlexPLM(thumbnailUrl, entityId, entityName);
             await this.entities.update({ entityName: 'content', id: content.id, object: { flexplmThumbnailUrl: thumbnailUrl } });
@@ -161,11 +135,10 @@ class ThumbnailUtil {
             console.debug(`syncThumbnailToVibeIQ: created new content ${content.id} for entityId=${entityId}`);
             return updatedEntity;
         }
-        // Case 3: Has primaryViewableId — check if thumbnail changed
         const primaryViewable = await this.entities.get({ entityName: 'content', id: primaryViewableId });
         if (primaryViewable?.flexplmThumbnailUrl === thumbnailUrl) {
             console.debug(`syncThumbnailToVibeIQ: thumbnail already synced for entityId=${entityId}`);
-            return undefined; // Already synced
+            return undefined;
         }
         const content = await this.createContentFromFlexPLM(thumbnailUrl, entityId, entityName);
         await this.entities.update({ entityName: 'content', id: content.id, object: { flexplmThumbnailUrl: thumbnailUrl } });

package/lib/util/thumbnail-util.spec.js

@@ -327,13 +327,11 @@ describe('ThumbnailUtil Tests', () => {
                 contentType: 'image/png',
                 contentHolderReference: 'color:entity1',
             }));
-            // Updates content with flexplmThumbnailUrl
             expect(mockEntitiesUpdate).toHaveBeenCalledWith(expect.objectContaining({
                 entityName: 'content',
                 id: 'newContent1',
                 object: { flexplmThumbnailUrl: '/rest/thumbnail/thumb.png' },
             }));
-            // Updates the main entity
             expect(mockEntitiesUpdate).toHaveBeenCalledWith(expect.objectContaining({
                 entityName: 'color',
                 id: 'entity1',
@@ -407,17 +405,13 @@ describe('ThumbnailUtil Tests', () => {
             mockContentCreate.mockResolvedValue(createdContent);
             const event = { data: { [thumbnail_util_1.ThumbnailUtil.NEW_THUMBNAIL_ID]: '/rest/thumbnail/new.jpg' } };
             await tu.syncThumbnailToVibeIQ({ entityId: 'entity1', primaryViewableId: 'oldPv', event, entityName: 'item' });
-            // Creates new content
             expect(mockContentCreate).toHaveBeenCalled();
-            // Updates new content with flexplmThumbnailUrl
             expect(mockEntitiesUpdate).toHaveBeenCalledWith(expect.objectContaining({
                 entityName: 'content',
                 id: 'newContent2',
                 object: { flexplmThumbnailUrl: '/rest/thumbnail/new.jpg' },
             }));
-            // Updates the main entity
             expect(mockEntitiesUpdate).toHaveBeenCalledWith(expect.objectContaining({ entityName: 'item', id: 'entity1' }));
-            // Deletes old content
             expect(mockEntitiesDelete).toHaveBeenCalledWith({ entityName: 'content', id: 'oldPv' });
         });
         it('does not update when primaryViewable.flexplmThumbnailUrl matches', async () => {

package/lib/util/type-conversion-utils-spec-mockData.js

@@ -57,7 +57,7 @@ exports.mapping = {
         vibeOwningKeys: ['itemNumber', 'lifecycleStage'],
         vibe2flex: {
             getClass: () => 'LCSProduct',
-            getSoftType: (entity /*, dependencies*/) => {
+            getSoftType: (entity) => {
                 const prodType = entity['prodType'];
                 let val = '';
                 switch (prodType) {
@@ -82,7 +82,7 @@ exports.mapping = {
                 vibeIQIdentifier: 'itemNumber'
             },
             valueTransform: {
-                transformEx: (row /*, dependencies*/) => {
+                transformEx: (row) => {
                     return row['otherProp'] + 'xxx';
                 }
             }
@@ -100,7 +100,7 @@ exports.mapping = {
         vibeOwningKeys: ['itemNumber', 'lifecycleStage'],
         vibe2flex: {
             getClass: () => 'LCSSKU',
-            getSoftType: (entity /*, dependencies*/) => {
+            getSoftType: (entity) => {
                 const prodType = entity['prodType'];
                 let val = '';
                 switch (prodType) {

package/lib/util/type-conversion-utils.d.ts

@@ -1,162 +1,23 @@
 import { MapFileUtil } from '@contrail/transform-data';
-/** This class is helper functions to get the data for converting
- * VibeIQ entities to / from FlexPLM Objects
-*/
 export declare class TypeConversionUtils {
     static NO_ENTITY_TYPE: string;
     static VIBE2FLEX_DIRECTION: string;
     static FLEX2VIBE_DIRECTION: string;
     constructor();
-    /** Takes in a VibeIQ entity object and returns the correct FlexPLM
-     * object class associated to the entity. Order of precedence
-     * Property 'flexPLMObjectClass'
-     * Map file entry in 'typeConversion:vibe2flex:<value>:getObjectClass()'
-     *  for value from 'entityClass' or root from 'typePath'
-     * TypeDefaults.getDefaultObjectClass() function
-     * @param transformMapFile id for mapFile
-     * @param mapFileUtil class to get mapfile
-     * @param entity
-     * @returns Promise<string>
-     */
     static getObjectClass(transformMapFile: any, mapFileUtil: any, entity: any): Promise<string>;
-    /** Takes in a VibeIQ entity object and returns the correct FlexPLM
-     * FlexType associated to the entity. Order of precedence
-     * Property 'flexPLMTypePath'
-     * Map file entry in 'typeConversion:vibe2flex:<value>:getSoftType()'
-     *  for value from 'entityClass' or root from 'typePath'
-     * TypeDefaults.getDefaultObjectTypePath() function
-     *
-     * @param transformMapFile id for mapFile
-     * @param mapFileUtil class to get mapfile
-     * @param entity VibeIQ entity
-     * @returns Promise<string>
-     */
     static getObjectTypePath(transformMapFile: any, mapFileUtil: any, entity: any): Promise<string>;
-    /**Takes in a VibeIQ entity object and returns the correct
-     * identifier properties.  Order of precedence
-     * Property 'flexPLMIdentifierProperties'
-     * Map file entry in 'typeConversion:vibe2flex:<value>:getIdentifierProperties()'
-     *  for value from 'entityClass' or root from 'typePath'
-     * TypeDefaults.getDefaultIdentifierProperties() function
-     *
-     * @param transformMapFile id for mapFile
-     * @param mapFileUtil class to get mapfile
-     * @param entity
-     * @returns Promise<string[]>
-     */
     static getIdentifierProperties(transformMapFile: any, mapFileUtil: any, entity: any): Promise<string[]>;
-    /**Takes in a VibeIQ entity object and returns the correct
-   * informational properties.  Order of precedence
-   * Property 'flexPLMInformationalProperties'
-   * Map file entry in 'typeConversion:vibe2flex:<value>:getInformationalProperties()'
-   *  for value from 'entityClass' or root from 'typePath'
-   * TypeDefaults.getDefaultObjectTypePath() function
-   *
-   * @param transformMapFile id for mapFile
-   * @param mapFileUtil class to get mapfile
-   * @param entity
-   * @returns string
-   */
     static getInformationalProperties(transformMapFile: any, mapFileUtil: any, entity: any): Promise<string[]>;
-    /**Takes in a VibeIQ entity object and returns the correct mapKey
-   * Order of precedence:
-   * Map file entry in 'typeConversion:<direction>:<value>:getObjectClass()'
-   *  for value from 'entityClass' or root from 'typePath'
-   * TypeDefaults.getDefaultObjectClass() function
-     *
-     * @param transformMapFile
-     * @param mapFileUtil
-     * @param entity
-     * @param type
-     * @param direction
-     * @returns
-     */
     static getMapKey(transformMapFile: any, mapFileUtil: MapFileUtil, entity: any, direction: string): Promise<string>;
-    /** Returns the VibeIQ entity type from an entity.
-     * Throws error if it can't determine the entity type
-     *
-     * @param entity
-     * @returns string
-     */
     static getEntityType(entity: any): any;
-    /** Takes in a FlexPLM object and returns the correct VibeIQ entity
-     * class associated to the object. Order of precedence
-     * Property 'vibeIQEntityClass'
-     * Map file entry in 'typeConversion:flex2vibe:<value>:getObjectClass()'
-     *  for value from 'objectClass'
-     * TypeDefaults.getDefaultEntityClass() function
-     *
-     * @param fileId id for mapFile
-     * @param mapFileUtil class to get mapfile
-     * @param object FlexPLM object
-     * @returns Promise<string>
-     */
     static getEntityClassFromObject(fileId: any, mapFileUtil: any, object: any): Promise<string>;
-    /** Takes in a FlexPLM object and returns the correct VibeIQ
-   * type associated to the object. Order of precedence
-   * Property 'vibeIQTypePath'
-   * Map file entry in 'typeConversion:flex2vibe:<value>:getSoftType()'
-   *  for value from 'objectClass' or root from 'flexPLMTypePath'
-   * TypeDefaults.getDefaultEntityTypePath() function
-   *
-   * @param transformMapFile id for mapFile
-   * @param mapFileUtil class to get mapfile
-   * @param entity VibeIQ entity
-   * @returns Promise<string>
-   */
     static getEntityTypePathFromOjbect(fileId: any, mapFileUtil: any, object: any): Promise<string>;
-    /**Takes in a FlexPLM object and returns the correct
-   * identifier properties.  Order of precedence
-   * Property 'vibeIQIdentifierProperties'
-   * Map file entry in 'typeConversion:flex2vibe:<value>:getIdentifierProperties()'
-   *  for value from 'objectClass'
-   * TypeDefaults.getDefaultIdentifierPropertiesFromObject() function
-   *
-   * @param transformMapFile id for mapFile
-   * @param mapFileUtil class to get mapfile
-   * @param object
-   * @returns Promise<string[]>
-   */
     static getIdentifierPropertiesFromObject(fileId: any, mapFileUtil: MapFileUtil, object: any): Promise<string[]>;
-    /**Takes in a FlexPLM object and returns the correct
- * identifier properties.  Order of precedence
- * Property 'vibeIQIdentifierProperties'
- * Map file entry in 'typeConversion:flex2vibe:<value>:getInformationalProperties()'
- *  for value from 'objectClass'
- * TypeDefaults.getDefaultIdentifierPropertiesFromObject() function
- *
- * @param transformMapFile id for mapFile
- * @param mapFileUtil class to get mapfile
- * @param object
- * @returns Promise<string[]>
- */
     static getInformationalPropertiesFromObject(fileId: any, mapFileUtil: MapFileUtil, object: any): Promise<string[]>;
     static getMapKeyFromObject(fileId: any, mapFileUtil: MapFileUtil, object: any, direction: string): Promise<string | undefined>;
     static isInboundCreatableFromObject(fileId: string, mapFileUtil: MapFileUtil, object: any, context?: any): Promise<boolean>;
     static isOutboundCreatableFromEntity(fileId: string, mapFileUtil: MapFileUtil, entity: any, context?: any): Promise<boolean>;
-    /** Takes in a FlexPLM object and determines whether inbound
-     * images should be synced. In most cases, the creation owning system
-     * will also control image syncing. Defaults to false if no mapping exists.
-     * Map file entry in '<mapKey>:syncInboundImages()'
-     *
-     * @param fileId id for mapFile
-     * @param mapFileUtil class to get mapfile
-     * @param object FlexPLM object
-     * @param context optional context object
-     * @returns Promise<boolean>
-     */
     static syncInboundImages(fileId: string, mapFileUtil: MapFileUtil, object: any, context?: any): Promise<boolean>;
-    /** Takes in a VibeIQ entity object and determines whether outbound
-     * images should be synced. In most cases, the creation owning system
-     * will also control image syncing. Defaults to true if no mapping exists.
-     * Map file entry in '<mapKey>:syncOutboundImages()'
-     *
-     * @param fileId id for mapFile
-     * @param mapFileUtil class to get mapfile
-     * @param entity VibeIQ entity
-     * @param context optional context object
-     * @returns Promise<boolean>
-     */
     static syncOutboundImages(fileId: string, mapFileUtil: MapFileUtil, entity: any, context?: any): Promise<boolean>;
     static getObjectType(object: any): any;
 }

package/lib/util/type-conversion-utils.js

@@ -3,23 +3,9 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.TypeConversionUtils = void 0;
 const type_defaults_1 = require("./type-defaults");
 const map_utils_1 = require("./map-utils");
-/** This class is helper functions to get the data for converting
- * VibeIQ entities to / from FlexPLM Objects
-*/
 class TypeConversionUtils {
     constructor() {
     }
-    /** Takes in a VibeIQ entity object and returns the correct FlexPLM
-     * object class associated to the entity. Order of precedence
-     * Property 'flexPLMObjectClass'
-     * Map file entry in 'typeConversion:vibe2flex:<value>:getObjectClass()'
-     *  for value from 'entityClass' or root from 'typePath'
-     * TypeDefaults.getDefaultObjectClass() function
-     * @param transformMapFile id for mapFile
-     * @param mapFileUtil class to get mapfile
-     * @param entity
-     * @returns Promise<string>
-     */
     static async getObjectClass(transformMapFile, mapFileUtil, entity) {
         let objectClass = entity['flexPLMObjectClass'];
         if (objectClass) {
@@ -37,18 +23,6 @@ class TypeConversionUtils {
         }
         return type_defaults_1.TypeDefaults.getDefaultObjectClass(entity);
     }
-    /** Takes in a VibeIQ entity object and returns the correct FlexPLM
-     * FlexType associated to the entity. Order of precedence
-     * Property 'flexPLMTypePath'
-     * Map file entry in 'typeConversion:vibe2flex:<value>:getSoftType()'
-     *  for value from 'entityClass' or root from 'typePath'
-     * TypeDefaults.getDefaultObjectTypePath() function
-     *
-     * @param transformMapFile id for mapFile
-     * @param mapFileUtil class to get mapfile
-     * @param entity VibeIQ entity
-     * @returns Promise<string>
-     */
     static async getObjectTypePath(transformMapFile, mapFileUtil, entity) {
         let typePath = entity['flexPLMTypePath'];
         if (typePath) {
@@ -66,18 +40,6 @@ class TypeConversionUtils {
         }
         return type_defaults_1.TypeDefaults.getDefaultObjectTypePath(entity);
     }
-    /**Takes in a VibeIQ entity object and returns the correct
-     * identifier properties.  Order of precedence
-     * Property 'flexPLMIdentifierProperties'
-     * Map file entry in 'typeConversion:vibe2flex:<value>:getIdentifierProperties()'
-     *  for value from 'entityClass' or root from 'typePath'
-     * TypeDefaults.getDefaultIdentifierProperties() function
-     *
-     * @param transformMapFile id for mapFile
-     * @param mapFileUtil class to get mapfile
-     * @param entity
-     * @returns Promise<string[]>
-     */
     static async getIdentifierProperties(transformMapFile, mapFileUtil, entity) {
         let identifiers = entity['flexPLMIdentifierProperties'];
         if (identifiers) {
@@ -95,18 +57,6 @@ class TypeConversionUtils {
         }
         return type_defaults_1.TypeDefaults.getDefaultIdentifierProperties(entity);
     }
-    /**Takes in a VibeIQ entity object and returns the correct
-   * informational properties.  Order of precedence
-   * Property 'flexPLMInformationalProperties'
-   * Map file entry in 'typeConversion:vibe2flex:<value>:getInformationalProperties()'
-   *  for value from 'entityClass' or root from 'typePath'
-   * TypeDefaults.getDefaultObjectTypePath() function
-   *
-   * @param transformMapFile id for mapFile
-   * @param mapFileUtil class to get mapfile
-   * @param entity
-   * @returns string
-   */
     static async getInformationalProperties(transformMapFile, mapFileUtil, entity) {
         let identifiers = entity['flexPLMInformationalProperties'];
         if (identifiers) {
@@ -124,19 +74,6 @@ class TypeConversionUtils {
         }
         return type_defaults_1.TypeDefaults.getDefaultInformationalProperties(entity);
     }
-    /**Takes in a VibeIQ entity object and returns the correct mapKey
-   * Order of precedence:
-   * Map file entry in 'typeConversion:<direction>:<value>:getObjectClass()'
-   *  for value from 'entityClass' or root from 'typePath'
-   * TypeDefaults.getDefaultObjectClass() function
-     *
-     * @param transformMapFile
-     * @param mapFileUtil
-     * @param entity
-     * @param type
-     * @param direction
-     * @returns
-     */
     static async getMapKey(transformMapFile, mapFileUtil, entity, direction) {
         if (transformMapFile) {
             const type = this.getEntityType(entity);
@@ -148,12 +85,6 @@ class TypeConversionUtils {
         }
         return type_defaults_1.TypeDefaults.getDefaultObjectClass(entity);
     }
-    /** Returns the VibeIQ entity type from an entity.
-     * Throws error if it can't determine the entity type
-     *
-     * @param entity
-     * @returns string
-     */
     static getEntityType(entity) {
         let entityType = entity['entityType'];
         if (!entityType) {
@@ -170,18 +101,6 @@ class TypeConversionUtils {
         }
         return entityType;
     }
-    /** Takes in a FlexPLM object and returns the correct VibeIQ entity
-     * class associated to the object. Order of precedence
-     * Property 'vibeIQEntityClass'
-     * Map file entry in 'typeConversion:flex2vibe:<value>:getObjectClass()'
-     *  for value from 'objectClass'
-     * TypeDefaults.getDefaultEntityClass() function
-     *
-     * @param fileId id for mapFile
-     * @param mapFileUtil class to get mapfile
-     * @param object FlexPLM object
-     * @returns Promise<string>
-     */
     static async getEntityClassFromObject(fileId, mapFileUtil, object) {
         let entityClass = object['vibeIQEntityClass'];
         if (entityClass) {
@@ -199,18 +118,6 @@ class TypeConversionUtils {
         }
         return type_defaults_1.TypeDefaults.getDefaultEntityClass(object);
     }
-    /** Takes in a FlexPLM object and returns the correct VibeIQ
-   * type associated to the object. Order of precedence
-   * Property 'vibeIQTypePath'
-   * Map file entry in 'typeConversion:flex2vibe:<value>:getSoftType()'
-   *  for value from 'objectClass' or root from 'flexPLMTypePath'
-   * TypeDefaults.getDefaultEntityTypePath() function
-   *
-   * @param transformMapFile id for mapFile
-   * @param mapFileUtil class to get mapfile
-   * @param entity VibeIQ entity
-   * @returns Promise<string>
-   */
     static async getEntityTypePathFromOjbect(fileId, mapFileUtil, object) {
         let typePath = object['vibeIQTypePath'];
         if (typePath) {
@@ -228,18 +135,6 @@ class TypeConversionUtils {
         }
         return type_defaults_1.TypeDefaults.getDefaultEntityTypePath(object);
     }
-    /**Takes in a FlexPLM object and returns the correct
-   * identifier properties.  Order of precedence
-   * Property 'vibeIQIdentifierProperties'
-   * Map file entry in 'typeConversion:flex2vibe:<value>:getIdentifierProperties()'
-   *  for value from 'objectClass'
-   * TypeDefaults.getDefaultIdentifierPropertiesFromObject() function
-   *
-   * @param transformMapFile id for mapFile
-   * @param mapFileUtil class to get mapfile
-   * @param object
-   * @returns Promise<string[]>
-   */
     static async getIdentifierPropertiesFromObject(fileId, mapFileUtil, object) {
         let identifiers = object['vibeIQIdentifierProperties'];
         if (identifiers) {
@@ -257,18 +152,6 @@ class TypeConversionUtils {
         }
         return type_defaults_1.TypeDefaults.getDefaultIdentifierPropertiesFromObject(object);
     }
-    /**Takes in a FlexPLM object and returns the correct
- * identifier properties.  Order of precedence
- * Property 'vibeIQIdentifierProperties'
- * Map file entry in 'typeConversion:flex2vibe:<value>:getInformationalProperties()'
- *  for value from 'objectClass'
- * TypeDefaults.getDefaultIdentifierPropertiesFromObject() function
- *
- * @param transformMapFile id for mapFile
- * @param mapFileUtil class to get mapfile
- * @param object
- * @returns Promise<string[]>
- */
     static async getInformationalPropertiesFromObject(fileId, mapFileUtil, object) {
         let identifiers = object['vibeIQInformationalProperties'];
         if (identifiers) {
@@ -296,7 +179,6 @@ class TypeConversionUtils {
             }
             return type;
         }
-        //TODO use TypeDefaults?
     }
     static async isInboundCreatableFromObject(fileId, mapFileUtil, object, context) {
         let isInboundCreatable = false;
@@ -330,17 +212,6 @@ class TypeConversionUtils {
         }
         return isOutboundCreatable;
     }
-    /** Takes in a FlexPLM object and determines whether inbound
-     * images should be synced. In most cases, the creation owning system
-     * will also control image syncing. Defaults to false if no mapping exists.
-     * Map file entry in '<mapKey>:syncInboundImages()'
-     *
-     * @param fileId id for mapFile
-     * @param mapFileUtil class to get mapfile
-     * @param object FlexPLM object
-     * @param context optional context object
-     * @returns Promise<boolean>
-     */
     static async syncInboundImages(fileId, mapFileUtil, object, context) {
         let syncImages = false;
         if (!fileId) {
@@ -362,17 +233,6 @@ class TypeConversionUtils {
         }
         return syncImages;
     }
-    /** Takes in a VibeIQ entity object and determines whether outbound
-     * images should be synced. In most cases, the creation owning system
-     * will also control image syncing. Defaults to true if no mapping exists.
-     * Map file entry in '<mapKey>:syncOutboundImages()'
-     *
-     * @param fileId id for mapFile
-     * @param mapFileUtil class to get mapfile
-     * @param entity VibeIQ entity
-     * @param context optional context object
-     * @returns Promise<boolean>
-     */
     static async syncOutboundImages(fileId, mapFileUtil, entity, context) {
         let syncImages = true;
         if (!fileId) {

package/lib/util/type-defaults.d.ts

@@ -3,72 +3,14 @@ export declare class TypeDefaults {
     static NO_OBJECT_CLASS: string;
     static NO_TYPE_PATH: string;
     constructor();
-    /**Takes in full entity and returs the default FlexPLM
-     * object class.
-     *
-     * @param entity
-     * @returns string
-     */
     static getDefaultObjectClass(entity: any): string;
-    /**Takes in full entity and returns the default FlexPLM type path
-     * object class.
-     *
-     * @param entity
-     * @returns string
-     */
     static getDefaultObjectTypePath(entity: any): string;
-    /**Takes in full entity and returns the slugs for the default identifier
-     *  properties. These properties are used when searching for an entity
-     * object class.
-     *
-     * @param entity
-     * @returns string[]
-     */
     static getDefaultIdentifierProperties(entity: any): string[];
-    /** Takes in full entity and returns the slugs for informational
-     * properties.  These properties are helpful when debugging issues
-     * where the identifier properties don't find a match.
-     *
-     * @param entity
-     * @returns string[]
-     */
     static getDefaultInformationalProperties(entity: any): string[];
-    /** Returns the VibeIQ entity type from an entity.
-     * Throws error if it can't determine the entity type
-     *
-     * @param entity
-     * @returns string
-     */
     static getEntityType(entity: any): any;
-    /**Takes in full object and returns the default VibeIQ
-   * entity class.
-   *
-   * @param entity
-   * @returns string
-   */
     static getDefaultEntityClass(object: any): string;
-    /**Takes in full object and returns the default VibeIQ type path
-   * object class.
-   *
-   * @param object
-   * @returns string
-   */
     static getDefaultEntityTypePath(object: any): string;
-    /**Takes in full entity and returns the slugs for the default identifier
- *  properties. These properties are used when searching for an entity
- * object class.
- *
- * @param entity
- * @returns string[]
- */
     static getDefaultIdentifierPropertiesFromObject(object: any): string[];
-    /** Takes in full object and returns the slugs for informational
-   * properties.  These properties are helpful when debugging issues
-   * where the identifier properties don't find a match.
-   *
-   * @param object
-   * @returns string[]
-   */
     static getDefaultInformationalPropertiesFromObject(object: any): string[];
     static getObjectClass(object: any): string;
 }