@contrail/flexplm 1.3.1-alpha.763fca8 → 1.3.1-alpha.8bc920d

package/.github/pull_request_template.md

@@ -0,0 +1,31 @@
+## What
+- [ ] Bugfix
+- [ ] Feature
+- [ ] Enhancement
+
+Description: 
+<!--
+Describe the functional changes of the PR.
+
+If the mechanism of your change are complex, describe them in detail as you
+would if you were explaining them to a team mate.
+
+If the PR is simple, there is no need to repeat yourself. A small description
+is sufficient.
+-->
+
+## Why
+<!-- 
+why is this change needed? Same rules as with #What
+ -->
+
+
+## Testing added
+<!-- 
+Describe the testing you added to this PR
+ -->
+
+
+## Link to Jira ticket(s)
+https://vibe-team.atlassian.net/browse/VIBE-TICKET_NUMBER_HERE
+

package/.github/workflows/flexplm-lib.yml

@@ -0,0 +1,27 @@
+name: flexplm-lib-tests
+on:
+  pull_request:
+  workflow_dispatch: # allow running in github actions manually
+jobs:
+  test:
+    runs-on: ubuntu-24.04
+    strategy:
+      matrix:
+        node-version: [22.14.0, 24]
+    steps:
+      - name: Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+
+      - uses: actions/checkout@v3
+
+      - name: NPM Install
+        env:
+          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+        run: npm ci
+
+      - name: Unit Tests -
+        env:
+          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+        run: npm test

package/.github/workflows/publish-to-npm.yml

@@ -0,0 +1,121 @@
+name: Publish to NPM
+
+on:
+  push:
+    branches: [master]
+    paths-ignore:
+      - '.github/**'
+  pull_request:
+    branches: [master]
+    paths-ignore:
+      - '.github/**'
+
+jobs:
+  check-version:
+    name: Verify version is available on npm
+    if: github.event_name == 'pull_request'
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Check version not already published
+        run: |
+          PACKAGE_NAME=$(node -p "require('./package.json').name")
+          VERSION=$(node -p "require('./package.json').version")
+          echo "Checking if ${PACKAGE_NAME}@${VERSION} exists on npm..."
+          if npm view "${PACKAGE_NAME}@${VERSION}" version 2>/dev/null; then
+            echo "::error::Version ${VERSION} is already published on npm. Bump the version in package.json before merging."
+            exit 1
+          else
+            echo "Version ${VERSION} is available."
+          fi
+
+  check-dependencies:
+    name: Verify no private dependencies
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Verify no private dependencies
+        run: |
+          node -e "
+            const deps = require('./package.json').dependencies || {};
+            const { execSync } = require('child_process');
+            let failed = false;
+            for (const pkg of Object.keys(deps)) {
+              try {
+                execSync('npm view ' + pkg, { stdio: 'pipe' });
+              } catch {
+                console.error('::error::Dependency ' + pkg + ' is not publicly accessible on npm');
+                failed = true;
+              }
+            }
+            if (failed) process.exit(1);
+            console.log('All ' + Object.keys(deps).length + ' dependencies are public.');
+          "
+
+  publish-alpha:
+    name: Publish alpha
+    needs: check-dependencies
+    if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository
+    runs-on: ubuntu-latest
+    permissions:
+      id-token: write
+      contents: read
+    outputs:
+      version: ${{ steps.publish.outputs.version }}
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-node@v4
+        with:
+          node-version: '24'
+          registry-url: 'https://registry.npmjs.org'
+
+      - name: Install and build
+        run: npm ci && npm run build
+
+      - name: Publish alpha
+        id: publish
+        run: |
+          SHORT_SHA=$(echo ${{ github.event.pull_request.head.sha }} | cut -c1-7)
+          VERSION=$(node -p "require('./package.json').version")-alpha.${SHORT_SHA}
+          npm version $VERSION --no-git-tag-version
+          OUTPUT=$(npm publish --tag alpha 2>&1) && {
+            echo "version=$VERSION" >> $GITHUB_OUTPUT
+          } || {
+            if echo "$OUTPUT" | grep -q "You cannot publish over the previously published versions"; then
+              echo "::warning::Alpha ${VERSION} already published, skipping."
+            else
+              echo "::error::Failed to publish alpha ${VERSION}"
+              echo "$OUTPUT"
+              exit 1
+            fi
+          }
+
+  publish-release:
+    name: Publish release
+    needs: check-dependencies
+    if: github.event_name == 'push'
+    runs-on: ubuntu-latest
+    permissions:
+      id-token: write
+      contents: read
+    outputs:
+      version: ${{ steps.publish.outputs.version }}
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-node@v4
+        with:
+          node-version: '24'
+          registry-url: 'https://registry.npmjs.org'
+
+      - name: Install and build
+        run: npm ci && npm run build
+
+      - name: Publish release
+        id: publish
+        run: |
+          npm publish
+          echo "version=$(node -p "require('./package.json').version")" >> $GITHUB_OUTPUT

package/CHANGELOG.md

@@ -0,0 +1,32 @@
+# Changelog
+
+All notable changes to `@contrail/flexplm` are documented here.
+
+Format follows [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
+Versioning follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [Unreleased]
+
+## [1.3.0] - 2026-04-15
+### Added
+- Added inbound thumbnail/primary content syncing from FlexPLM to VibeIQ via `ThumbnailUtil.syncThumbnailToVibeIQ`.
+- Added `syncInboundImages` and `syncOutboundImages` methods to `TypeConversionUtils` for controlling image sync per map file configuration.
+- Added `PRIMARY_CONTENT_UPDATED` status to `EventShortMessageStatus` for when only primary content changes are detected.
+
+### Changed
+- `BaseEntityProcessor` update flow now distinguishes between primary-content-only changes and no changes, returning the updated entity when only the thumbnail was synced.
+- Improved `FlexPLMConnect.getRequest` function and added unit tests.
+
+## [1.2.1] - 2026-04-08
+
+### Added
+- Added EventShortMessageStatus status values for adding items to projects functionality.
+- Added `TypeConversionUtils.isOutboundCreatableFromEntity` method to determine if VibeIQ entities are creatable in FlexPLM (defaults to true).
+
+### Changed
+- Added optional `context` parameter to `TypeConversionUtils.isInboundCreatableFromObject` method to allow passing context data to map file `isInboundCreatable` functions.
+
+## [1.1.66] - (initial changelog entry)
+
+- Initial changelog. Prior releases did not include a changelog.
+  See git history for changes predating this entry.

package/lib/entity-processor/base-entity-processor.d.ts

@@ -19,36 +19,8 @@ export declare abstract class BaseEntityProcessor {
     inbound(event: EntityPayloadType): Promise<any>;
     handleIncomingUpsert(event: EntityPayloadType): Promise<any>;
     getInboundStatusMessage(statusObject: any): string;
-    /**This will query for the entity, and handle post-processing
-     * of any critieria that is defined at the sub-type level.
-     * Because sub-type criteria can't be used in the search done
-     * on the server. This is expected to be called by getIncomingEntity().
-     *
-     * @param entityType: the root type of the entity
-     * @param entityTypePath: the full type path of the entity. Ex: custom-entity:sample
-     * @param propertyCriteria: all the criteria to search for the entity
-     * @returns the entities that match the criteria
-     */
     queryEntityWithSubTypeCriteria(entityType: string, entityTypePath: string, propertyCriteria: any): Promise<any[]>;
-    /** This is to get the criteria for the entity that is being processed.
-     * This is to be overridden for item & project-item because of the need for
-     * setting the roles criteria.
-     *
-     * @param entityType: the root type of the entity
-     * @param entityTypePath: the full type path of the entity. Ex: custom-entity:sample
-     * @param propertyCriteria: all the criteria to search for the entity
-     * @returns the criteria for the entity
-     */
     getCriteriaForEntity(entityType: string, entityTypePath: string, propertyCriteria: any): Promise<any>;
-    /** This is to get the properties that are owned by the root type
-     * This needs to be overridded for multi-level types, such as item
-     * and project-item. And for those types, the propertyCriteria
-     * will be needed to determine the correct level.
-     *
-     * @param rootType: the full root type entity for the processed entity
-     * @param propertyCriteria: the criteria to determine the correct level (unused for single level types)
-     * @returns: string[] of the property keys
-     */
     getRootTypePropertyKeys(rootType: any, propertyCriteria?: any): string[];
     handleIncomingDelete(event: any): Promise<void>;
     getTransformedData(event: any): Promise<any>;
@@ -64,26 +36,7 @@ export declare abstract class BaseEntityProcessor {
     getOutboundEntityUpdates(event: any, flexResponse: any): Promise<any>;
     handleOutgoingDelete(entityType: any, event: any): Promise<void>;
     protected abstract getOutgoingUpsertPayload(entityType: any, event: any): Promise<EntityPayloadType>;
-    /** Create a new event-workflow-request to rerun sending the entity to FlexPLM
-     * The event must contain any information needed to ensure it is put in the correct queue for the entity
-     *
-     * @param triggerKey Ex: event.entityType + '|sendUpsertToFlexPLM'
-     * @param event
-     * @returns
-     */
     protected triggerNewEvent(triggerKey: string, event: any): Promise<any>;
-    /** Sends the current state of the entity to FlexPLM.
-     * So any changes made in Vibe between the event being generated and the event being processed are sent to FlexPLM.
-     *
-     * @param event must contain entityType, id; which are used to query for the entity
-     * @returns results of sending the entity to FlexPLM
-     */
     protected sendUpsertToFlexPLM(event: any): Promise<any>;
-    /** Generates the payload to send to FlexPLM, based on the current state of the entity.
-     * The current state of the entity are used as the newData and oldData; which is passed
-     * to getOutgoingUpsertPayload to generate the payload.
-     * @param event information about the item to send to FlexPLM
-     * @returns The payload to send to FlexPLM
-     */
     protected getEntityCurrentStateUpsertPayload(event: any): Promise<EntityPayloadType>;
 }

package/lib/entity-processor/base-entity-processor.js

@@ -23,7 +23,6 @@ class BaseEntityProcessor {
         this.entities = new sdk_1.Entities();
         this.orgSlug = this.config?.orgSlug || 'unset-orgSlug';
     }
-    // inbound
     async inbound(event) {
         const eventType = event.eventType;
         console.log(`inbound entity: ${eventType}:${event.objectClass}`);
@@ -43,7 +42,6 @@ class BaseEntityProcessor {
     async handleIncomingUpsert(event) {
         const inboundData = await this.getTransformedData(event);
         const incomingEntityResponse = await this.getIncomingEntity(event, inboundData);
-        // This case means there was an early return in the getIncomingEntity method
         if (incomingEntityResponse.earlyReturn) {
             const statusMsg = this.getInboundStatusMessage({
                 status: event_short_message_status_1.EventShortMessageStatus.FAILURE,
@@ -138,18 +136,7 @@ class BaseEntityProcessor {
             + ', federatedId: ' + statusObject.federatedId
             + ', orgSlug: ' + this.orgSlug;
     }
-    /**This will query for the entity, and handle post-processing
-     * of any critieria that is defined at the sub-type level.
-     * Because sub-type criteria can't be used in the search done
-     * on the server. This is expected to be called by getIncomingEntity().
-     *
-     * @param entityType: the root type of the entity
-     * @param entityTypePath: the full type path of the entity. Ex: custom-entity:sample
-     * @param propertyCriteria: all the criteria to search for the entity
-     * @returns the entities that match the criteria
-     */
     async queryEntityWithSubTypeCriteria(entityType, entityTypePath, propertyCriteria) {
-        //allCriteria; identifierKeys; entityType; entityTypePath
         if (!entityType || !entityTypePath) {
             throw new Error('type and entityTypePath must be defined');
         }
@@ -160,15 +147,6 @@ class BaseEntityProcessor {
         const returnedEntities = await this.dc.getAllObjectReferences(entityType, rootTypeCriteria, subTypeCriteria);
         return returnedEntities;
     }
-    /** This is to get the criteria for the entity that is being processed.
-     * This is to be overridden for item & project-item because of the need for
-     * setting the roles criteria.
-     *
-     * @param entityType: the root type of the entity
-     * @param entityTypePath: the full type path of the entity. Ex: custom-entity:sample
-     * @param propertyCriteria: all the criteria to search for the entity
-     * @returns the criteria for the entity
-     */
     async getCriteriaForEntity(entityType, entityTypePath, propertyCriteria) {
         if (!entityType || !entityTypePath) {
             throw new Error('type and entityTypePath must be defined');
@@ -193,15 +171,6 @@ class BaseEntityProcessor {
         }
         return { rootTypeCriteria, subTypeCriteria };
     }
-    /** This is to get the properties that are owned by the root type
-     * This needs to be overridded for multi-level types, such as item
-     * and project-item. And for those types, the propertyCriteria
-     * will be needed to determine the correct level.
-     *
-     * @param rootType: the full root type entity for the processed entity
-     * @param propertyCriteria: the criteria to determine the correct level (unused for single level types)
-     * @returns: string[] of the property keys
-     */
     getRootTypePropertyKeys(rootType, propertyCriteria = null) {
         const props = rootType['typeProperties'];
         const rootTypePropertyKeys = props.map(prop => prop.slug);
@@ -234,8 +203,6 @@ class BaseEntityProcessor {
     async getVibeOwningKeys(entity) {
         let vibeOwningKeys = [];
         if (this.transformMapFile && entity) {
-            //Technically the transform is flex->vibe.  But the vibe entity being updated was passed in,
-            // so we use VIBE2FLEX_DIRECTION to get the mapKey
             const mapKey = await type_conversion_utils_1.TypeConversionUtils.getMapKey(this.transformMapFile, this.mapFileUtil, entity, type_conversion_utils_1.TypeConversionUtils.VIBE2FLEX_DIRECTION);
             const mapSection = await map_utils_1.MapUtil.getFullMapSection(this.transformMapFile, this.mapFileUtil, mapKey);
             vibeOwningKeys = mapSection?.vibeOwningKeys || [];
@@ -270,7 +237,6 @@ class BaseEntityProcessor {
         console.log('updateEntity: ' + JSON.stringify(options));
         return await new sdk_1.Entities().update(options);
     }
-    // outbound
     async outbound(event) {
         const entityType = event.entityType;
         const eventType = event.eventType;
@@ -347,13 +313,6 @@ class BaseEntityProcessor {
     async handleOutgoingDelete(entityType, event) {
         console.warn('delete is not configured', entityType, event.oldData);
     }
-    /** Create a new event-workflow-request to rerun sending the entity to FlexPLM
-     * The event must contain any information needed to ensure it is put in the correct queue for the entity
-     *
-     * @param triggerKey Ex: event.entityType + '|sendUpsertToFlexPLM'
-     * @param event
-     * @returns
-     */
     async triggerNewEvent(triggerKey, event) {
         const newEvent = {
             entityName: 'event-workflow-request',
@@ -365,12 +324,6 @@ class BaseEntityProcessor {
         const response = await this.entities.create(newEvent);
         return response;
     }
-    /** Sends the current state of the entity to FlexPLM.
-     * So any changes made in Vibe between the event being generated and the event being processed are sent to FlexPLM.
-     *
-     * @param event must contain entityType, id; which are used to query for the entity
-     * @returns results of sending the entity to FlexPLM
-     */
     async sendUpsertToFlexPLM(event) {
         const payload = await this.getEntityCurrentStateUpsertPayload(event);
         if (!payload) {
@@ -411,12 +364,6 @@ class BaseEntityProcessor {
             throw e;
         }
     }
-    /** Generates the payload to send to FlexPLM, based on the current state of the entity.
-     * The current state of the entity are used as the newData and oldData; which is passed
-     * to getOutgoingUpsertPayload to generate the payload.
-     * @param event information about the item to send to FlexPLM
-     * @returns The payload to send to FlexPLM
-     */
     async getEntityCurrentStateUpsertPayload(event) {
         const id = event.id;
         if (!id) {

package/lib/entity-processor/base-entity-processor.spec.js

@@ -269,7 +269,6 @@ describe('BaseEntityProcessor', () => {
             const rootCriteriaResults = Object.assign({}, rootCriteria);
             const subCriteriaResults = Object.assign({}, subCriteria);
             const mockGetByRootTypeProperties = jest.spyOn(btep, 'getRootTypePropertyKeys').mockReturnValue(['rootText']);
-            // const mockDCgetAllObjectReferences = jest.spyOn(dc, 'getAllObjectReferences').mockReturnValue(Promise.resolve([]));
             const { rootTypeCriteria, subTypeCriteria } = await btep.getCriteriaForEntity(entityType, entityTypePath, propertyCriteria);
             expect(mockTypeUtilGetByRootAndPath).toBeCalledTimes(1);
             expect(mockTypeUtilGetByRootAndPath).toBeCalledWith({ root: entityType });

package/lib/index.d.ts

@@ -16,7 +16,6 @@ export * from './util/map-utils';
 export * from './interfaces/interfaces';
 export * from './interfaces/item-family-changes';
 export * from './interfaces/publish-change-data';
-export * from './interfaces/mapping-file';
 export * from './publish/base-process-publish-assortment';
 export * from './publish/base-process-publish-assortment-callback';
 export * from './entity-processor/base-entity-processor';

package/lib/index.js

@@ -32,7 +32,6 @@ __exportStar(require("./util/map-utils"), exports);
 __exportStar(require("./interfaces/interfaces"), exports);
 __exportStar(require("./interfaces/item-family-changes"), exports);
 __exportStar(require("./interfaces/publish-change-data"), exports);
-__exportStar(require("./interfaces/mapping-file"), exports);
 __exportStar(require("./publish/base-process-publish-assortment"), exports);
 __exportStar(require("./publish/base-process-publish-assortment-callback"), exports);
 __exportStar(require("./entity-processor/base-entity-processor"), exports);

package/lib/publish/base-process-publish-assortment.d.ts

@@ -32,15 +32,6 @@ export declare class BaseProcessPublishAssortment {
         skip_await?: undefined;
     }>;
     getPublishInfo(assortmentId: string, assortmentPublishChangeId: string, apcHistory: any, publisher: any): Promise<any>;
-    /** Gets the version number of the snapshot that was created for the publish change.
-     * But if no snapshot was found for the publish change, and the last snapshot was
-     * created before the publish change, then it returns 'after: versionNumber' where
-     * versionNumber is the version number of the last snapshot.
-     * If no snapshot was found for the publish change, and the last snapshot was
-     * created after the publish change, then it returns 'unknown'.
-     *
-     * @returns versionNumber or 'unknown' or 'after: versionNumber'
-     */
     getSnapshotVersion(assortment: any, apc: any): Promise<number | string>;
     getSeasonFederation(assortmentId: any): Promise<SeasonFederation>;
     getAssortment(assortmentId: any): Promise<any>;
@@ -91,22 +82,6 @@ export declare class BaseProcessPublishAssortment {
     private getCurrentDateString;
     getItemFamilyChanges(pcd: PublishChangeData, changeDetail: any, assortmentItemFullChangeMap: Map<string, any>, assortmentItemDeleteMap: Map<string, any>): Map<string, ItemFamilyChanges>;
     getEventsForPublishChangeData(publishChangeData: PublishChangeData): Promise<SeasonalPayload[]>;
-    /**Returns the events for a given ItemFamilyChanges object
-     *
-     * Cases:
-     * Add just family:
-     * Add option to family (with existing option):
-     * Add option to family (no options on assortment):
-     * Remove family and option:
-     * Remove only option and leave family:
-     * Remove one option of multiple for family:
-     *
-     * @param itemFamilyChanges
-     * @param assortmentId
-     * @param assortmentFederationId
-     * @param itemToFederatedIdMapping
-     * @returns
-     */
     getEventsForItemFamilyChanges(itemFamilyChanges: ItemFamilyChanges, assortmentId: string, seasonFed: SeasonFederation, itemToFederatedIdMapping: Map<string, string>): Promise<SeasonalPayload[]>;
     getProjectItem(itemFamilyChanges: ItemFamilyChanges, id: string): any;
     getSeasonalData(projectItem: any): Promise<object>;

package/lib/publish/base-process-publish-assortment.js

@@ -13,7 +13,7 @@ const app_framework_1 = require("@contrail/app-framework");
 const event_short_message_status_1 = require("../util/event-short-message-status");
 class BaseProcessPublishAssortment {
     constructor(_config, _dc, _mapFileUtil) {
-        this.TTL = 30 * 24 * 60 * 60 * 1000; // 30 days
+        this.TTL = 30 * 24 * 60 * 60 * 1000;
         this.cache = {
             carriedFromSeason: {}
         };
@@ -52,14 +52,13 @@ class BaseProcessPublishAssortment {
             }
             apcHistory = await this.getApcHistory(assortmentId);
             const sinceDate = await this.getSinceDate(assortmentId, assortmentPublishChangeId, apcHistory);
-            //Get detail information
             const assortmentPublishChange = await this.downloadAssortmentPublishChange(assortmentId, assortmentPublishChangeId);
             publisher = this.getPublisher(assortmentPublishChange);
             const changeDetail = await this.downloadHydratedChangeDetail(assortmentPublishChange);
             const assortmentBaseline = await this.downloadAssortmentBaseline(assortmentPublishChange);
             const deleteChanges = await this.getDeleteChanges(assortmentPublishChange, apcHistory, assortmentBaseline, sinceDate);
             const releasedForDevelopmentItemIds = this.getReleasedForDevelopmentItemAndFamilyIds(assortmentBaseline, deleteChanges);
-            const itemToFederatedIdMapping = await this.getItemFederatedIds( /*allItemIds*/);
+            const itemToFederatedIdMapping = await this.getItemFederatedIds();
             const pcd = new publish_change_data_1.PublishChangeData(assortmentId, seasonFed, assortmentPublishChangeId, sinceDate, publisher);
             pcd.itemToFederatedIdMapping = itemToFederatedIdMapping;
             pcd.releasedForDevelopmentItemIds = releasedForDevelopmentItemIds;
@@ -95,15 +94,6 @@ class BaseProcessPublishAssortment {
         };
         return publishInfo;
     }
-    /** Gets the version number of the snapshot that was created for the publish change.
-     * But if no snapshot was found for the publish change, and the last snapshot was
-     * created before the publish change, then it returns 'after: versionNumber' where
-     * versionNumber is the version number of the last snapshot.
-     * If no snapshot was found for the publish change, and the last snapshot was
-     * created after the publish change, then it returns 'unknown'.
-     *
-     * @returns versionNumber or 'unknown' or 'after: versionNumber'
-     */
     async getSnapshotVersion(assortment, apc) {
         const entityReference = assortment?.createdForReference;
         const createdOnString = apc?.createdOn;
@@ -111,7 +101,7 @@ class BaseProcessPublishAssortment {
             return 'unknown';
         }
         const createdOnDate = new Date(createdOnString);
-        createdOnDate.setMonth(createdOnDate.getMonth() - 1); //subtract 1 month
+        createdOnDate.setMonth(createdOnDate.getMonth() - 1);
         const createdOnStringMinus1 = createdOnDate.toISOString();
         const createdOn = 'ISGREATERTHAN ' + createdOnStringMinus1;
         const snapshots = await new sdk_1.Entities().get({
@@ -358,7 +348,6 @@ class BaseProcessPublishAssortment {
             console.info('sinceDateMilliseconds: ' + sinceDateMilliseconds);
             console.info('apcDateMilliseconds: ' + previousApcDate);
         }
-        //if only 1 apc, no processing needed
         if (sinceDateMilliseconds !== previousApcDate) {
             console.info('sinceDateMilliseconds !== apcDateMilliseconds');
             const currentAssortmentItemIds = this.getBaselineItemIds(assortmentBaseline);
@@ -444,27 +433,12 @@ class BaseProcessPublishAssortment {
             previousBaseline = await this.downloadAssortmentBaseline(previousApc);
         }
         const deleteIds = apc?.detail?.deletes.map(dItem => dItem?.id);
-        //building deletes based on previous baseline; because some APCs don't have delete data
         const deleteArray = previousBaseline?.assortmentItems.filter(aItem => deleteIds.includes(aItem?.itemId));
         console.info('deleteArray.length: ' + deleteArray.length);
         return deleteArray;
     }
-    async getItemFederatedIds( /*itemIds*/) {
+    async getItemFederatedIds() {
         const itemFederatedIds = new Map();
-        // const expandedItemIds = itemIds.map(id => 'item:' + id);
-        // const fedRecords = await new Federation(this.logger).getFederationRecordsFromIdsBulk(expandedItemIds);
-        // for (let i = 0; i < fedRecords.length; i++) {
-        //   const federationRecord = fedRecords[i];
-        //   // console.log('federationRecord: ' + JSON.stringify(federationRecord));
-        //   // console.log('federationRecord.reference: ' + federationRecord.reference);
-        //   // console.log('federationRecord.mappedReference: ' + federationRecord.mappedReference);
-        //   let vibeId = federationRecord.reference;
-        //   if (vibeId && vibeId.startsWith('item:')) {
-        //     vibeId = vibeId.substring(5);
-        //   }
-        //   itemFederatedIds.set(vibeId, federationRecord.mappedReference);
-        // }
-        // console.log('itemFederatedIds: ' + JSON.stringify(Object.fromEntries(itemFederatedIds)));
         return itemFederatedIds;
     }
     getFullChangeAssortmentMap(fullChange) {
@@ -591,7 +565,7 @@ class BaseProcessPublishAssortment {
             case 'vibeiqfile-dontsendtoflexplm':
                 return this.handleVibeIQFile(events, eventType, sendMode);
             default:
-                return {}; // Or handle other cases as required
+                return {};
         }
     }
     async sendToFlexPLM(events, eventType) {
@@ -761,7 +735,7 @@ class BaseProcessPublishAssortment {
             else {
                 ifc.colorDeletes.push(itemId);
             }
-        } //End deletes for loop
+        }
         if (app_framework_1.Logger.isDebugOn()) {
             console.debug('returning size: ' + itemFamilyChanges.size);
             for (const [key, value] of itemFamilyChanges) {
@@ -781,22 +755,6 @@ class BaseProcessPublishAssortment {
         }
         return seasonalPayloads;
     }
-    /**Returns the events for a given ItemFamilyChanges object
-     *
-     * Cases:
-     * Add just family:
-     * Add option to family (with existing option):
-     * Add option to family (no options on assortment):
-     * Remove family and option:
-     * Remove only option and leave family:
-     * Remove one option of multiple for family:
-     *
-     * @param itemFamilyChanges
-     * @param assortmentId
-     * @param assortmentFederationId
-     * @param itemToFederatedIdMapping
-     * @returns
-     */
     async getEventsForItemFamilyChanges(itemFamilyChanges, assortmentId, seasonFed, itemToFederatedIdMapping) {
         console.info('getEventsForItemFamilyChanges()');
         const events = [];
@@ -806,10 +764,7 @@ class BaseProcessPublishAssortment {
         const familyAssortmentItem = itemFamilyChanges.familyAdd || itemFamilyChanges.familyUpdate || itemFamilyChanges.familyDelete
             || itemFamilyChanges.colorAdds.length > 0 || itemFamilyChanges.colorUpdates.length > 0 || itemFamilyChanges.colorDeletes.length > 0
             || (projectItem && this.updatedSinceDate(projectItem, itemFamilyChanges.sinceDate));
-        //familyItemRemoved is used when adding the first option to an assortment
-        //and will have updates for the family item.
         if (familyAssortmentItem) {
-            //Product-season add
             const entityReference = itemFamilyChanges.itemFamilyId;
             const prodEntityData = (itemFamilyChanges.assortmentItemFullChangeMap.has(entityReference))
                 ? itemFamilyChanges.assortmentItemFullChangeMap.get(entityReference)?.item
@@ -835,9 +790,6 @@ class BaseProcessPublishAssortment {
             }
             events.push(psUpsert);
         }
-        //colorway-season adds
-        //colorAdds
-        //colorUpdates
         const colorwayChanges = [];
         colorwayChanges.push(...itemFamilyChanges.colorAdds);
         colorwayChanges.push(...itemFamilyChanges.colorUpdates);
@@ -878,9 +830,6 @@ class BaseProcessPublishAssortment {
             const aItem = itemFamilyChanges?.assortmentItemFullChangeMap.get(id);
             projectItem = aItem?.projectItem;
         }
-        /////////////////////////////////////////////////////////////////////////////
-        //Get from option assortmentItem because family not in assortmentItemFullChangeMap:start
-        /////////////////////////////////////////////////////////////////////////////
         if (id === itemFamilyChanges.itemFamilyId && Object.keys(projectItem).length == 0) {
             for (const asstItem of itemFamilyChanges.assortmentItemFullChangeMap.values()) {
                 if (asstItem?.familyProjectItem) {
@@ -889,9 +838,6 @@ class BaseProcessPublishAssortment {
                 }
             }
         }
-        /////////////////////////////////////////////////////////////////////////////
-        //Get from option assortmentItem because family not in assortmentItemFullChangeMap:end
-        /////////////////////////////////////////////////////////////////////////////
         return projectItem;
     }
     async getSeasonalData(projectItem) {