@contrail/flexplm 1.3.0-alpha.5 → 1.3.0-alpha.7cd23d9

package/src/util/thumbnail-util.spec.ts

@@ -389,6 +389,56 @@ describe('ThumbnailUtil Tests', () =>{
       );
     });
 
+    it('encodes URL path segments with special characters', async () => {
+      const mockResponse = {
+        arrayBuffer: jest.fn().mockResolvedValue(new ArrayBuffer(8)),
+        headers: { get: jest.fn().mockReturnValue('image/png') },
+      };
+      mockGetRequest.mockResolvedValue(mockResponse);
+      mockContentCreate.mockResolvedValue({
+        id: 'c1', contentType: 'image/png', fileName: 'my image.png',
+        primaryFileUrl: 'https://files/primary.png', largeViewableUrl: null,
+        mediumLargeViewableUrl: null, mediumViewableUrl: null, smallViewableUrl: null, tinyViewableUrl: null,
+      });
+
+      const event = { data: { [ThumbnailUtil.NEW_THUMBNAIL_ID]: '/rest/thumbnail/my image.png' } };
+      await tu.syncThumbnailToVibeIQ({ entityId: 'entity1', event, entityName: 'color' });
+
+      expect(mockGetRequest).toHaveBeenCalledWith({
+        urlPath: '/rest/thumbnail/my%20image.png',
+        includeUrlContext: false,
+        returnFullResponse: true,
+      });
+      expect(mockContentCreate).toHaveBeenCalledWith(
+        expect.objectContaining({ fileName: 'my image.png' }),
+      );
+    });
+
+    it('encodes URL path segments with unicode characters', async () => {
+      const mockResponse = {
+        arrayBuffer: jest.fn().mockResolvedValue(new ArrayBuffer(8)),
+        headers: { get: jest.fn().mockReturnValue('image/jpeg') },
+      };
+      mockGetRequest.mockResolvedValue(mockResponse);
+      mockContentCreate.mockResolvedValue({
+        id: 'c2', contentType: 'image/jpeg', fileName: 'café-logo.jpg',
+        primaryFileUrl: 'https://files/primary.jpg', largeViewableUrl: null,
+        mediumLargeViewableUrl: null, mediumViewableUrl: null, smallViewableUrl: null, tinyViewableUrl: null,
+      });
+
+      const event = { data: { [ThumbnailUtil.NEW_THUMBNAIL_ID]: '/rest/thumbnail/café-logo.jpg' } };
+      await tu.syncThumbnailToVibeIQ({ entityId: 'entity1', event, entityName: 'item' });
+
+      expect(mockGetRequest).toHaveBeenCalledWith({
+        urlPath: '/rest/thumbnail/caf%C3%A9-logo.jpg',
+        includeUrlContext: false,
+        returnFullResponse: true,
+      });
+      expect(mockContentCreate).toHaveBeenCalledWith(
+        expect.objectContaining({ fileName: 'café-logo.jpg' }),
+      );
+    });
+
     it('replaces content when primaryViewable.flexplmThumbnailUrl differs and updates entity', async () => {
       mockEntitiesGet.mockImplementation((opts) => {
         if (opts.entityName === 'content-custom-size') return Promise.resolve([]);

package/src/util/thumbnail-util.ts

@@ -201,9 +201,13 @@ export class ThumbnailUtil {
   }
 
   private async createContentFromFlexPLM(thumbnailUrl: string, entityId: string, entityName: string): Promise<any> {
+    const urlParts = thumbnailUrl.split('/');
+    const fileName = urlParts[urlParts.length - 1] || 'thumbnail';
+
+    const encodedUrl = urlParts.map(part => encodeURIComponent(part)).join('/');
     const flexPLMConnect = new FlexPLMConnect(this.config);
     const response = await flexPLMConnect.getRequest({
-      urlPath: thumbnailUrl,
+      urlPath: encodedUrl,
       includeUrlContext: false,
       returnFullResponse: true,
     }) as Response;
@@ -213,9 +217,6 @@ export class ThumbnailUtil {
     const contentTypeHeader = response.headers.get('content-type');
     const contentType = contentTypeHeader ? contentTypeHeader.split(';')[0] : 'application/octet-stream';
 
-    const urlParts = thumbnailUrl.split('/');
-    const fileName = urlParts[urlParts.length - 1] || 'thumbnail';
-
     const contentHolderReference = `${entityName}:${entityId}`;
     const content = await new Content().create({
       fileBuffer: buffer,

package/tsconfig.json

@@ -15,14 +15,9 @@
     "removeComments": true,
     "skipLibCheck": true,
     "lib": [
-      "es5",
-      "ES2015",
-      "ES2016",
-      "ES2017",
       "ES2020",
       "dom",
-      "esnext.asynciterable"
-    ],    
+    ],
   },
   "include": ["src"],
   "exclude": ["node_modules", "**/__tests__/*"]

package/.claude/settings.local.json

@@ -1,8 +0,0 @@
-{
-  "permissions": {
-    "allow": [
-      "Bash(npx jest:*)",
-      "Bash(npx tsc:*)"
-    ]
-  }
-}