@contrail/flexplm 1.1.37 → 1.1.39

package/lib/entity-processor/base-entity-processor.d.ts

@@ -31,7 +31,4 @@ export declare abstract class BaseEntityProcessor {
     getOutboundEntityUpdates(event: any, flexResponse: any): Promise<any>;
     handleOutgoingDelete(entityType: any, event: any): Promise<void>;
     protected abstract getOutgoingUpsertPayload(entityType: any, event: any): Promise<EntityPayloadType>;
-    protected triggerSendEvent(triggerKey: string, event: any): Promise<any>;
-    protected sendUpsertToFlexPLM(event: any): Promise<any>;
-    protected getEntityUpsertPayload(event: any): Promise<EntityPayloadType>;
 }

package/lib/entity-processor/base-entity-processor.js

@@ -133,8 +133,6 @@ class BaseEntityProcessor {
                 return await this.handleOutgoingUpsert(entityType, event);
             case 'delete':
                 return await this.handleOutgoingDelete(entityType, event);
-            case 'sendUpsertToFlexPLM':
-                return await this.sendUpsertToFlexPLM(event);
             default:
                 console.log(UNSUPPORTED_TYPE);
                 return {
@@ -173,38 +171,5 @@ class BaseEntityProcessor {
     async handleOutgoingDelete(entityType, event) {
         console.warn('delete is not configured', entityType, event.oldData);
     }
-    async triggerSendEvent(triggerKey, event) {
-        const newEvent = {
-            entityName: 'event-workflow-request',
-            object: {
-                triggerKey,
-                event
-            }
-        };
-        const response = await this.entities.create(newEvent);
-        return response;
-    }
-    async sendUpsertToFlexPLM(event) {
-        const payload = await this.getEntityUpsertPayload(event);
-        if (!payload) {
-            const message = 'No payload to send to FlexPLM';
-            console.log(message);
-            return {
-                status: 500,
-                data: { message }
-            };
-        }
-        ;
-        const flexResponse = await new flexplm_connect_1.FlexPLMConnect(this.config).sendToFlexPLM(payload);
-        const outboundEntityUpdates = await this.getOutboundEntityUpdates(event, flexResponse);
-        if (outboundEntityUpdates) {
-            flexResponse['outboundEntityUpdates'] = outboundEntityUpdates;
-        }
-        return flexResponse;
-    }
-    async getEntityUpsertPayload(event) {
-        console.warn('getEntityUpsertPayload is not configured', JSON.stringify(event));
-        return undefined;
-    }
 }
 exports.BaseEntityProcessor = BaseEntityProcessor;

package/lib/publish/base-process-publish-assortment.d.ts

@@ -13,6 +13,7 @@ export declare class BaseProcessPublishAssortment {
     private mapFileUtil;
     private transformMapFile;
     private cache;
+    private assortment;
     constructor(_config: FCConfig, _dc: DataConverter, _mapFileUtil: MapFileUtil);
     process(event: any): Promise<{
         results: {
@@ -23,7 +24,9 @@ export declare class BaseProcessPublishAssortment {
         results: any;
         skip_await?: undefined;
     }>;
+    getPublishInfo(assortmentPublishChangeId: any, apcHistory: any, publisher: any): Promise<any>;
     getSeasonFederation(assortmentId: any): Promise<SeasonFederation>;
+    getAssortment(assortmentId: any): Promise<any>;
     getSinceDate(assortmentId: any, assortmentPublishChangeId: any, apcHistory: object[]): Promise<Date>;
     getApcHistory(assortmentId: any): Promise<any>;
     protected updatedSinceDate(entity: any, sinceDate: Date): boolean;

package/lib/publish/base-process-publish-assortment.js

@@ -22,6 +22,9 @@ class BaseProcessPublishAssortment {
         this.transformMapFile = this.config['transformMapFile'];
     }
     async process(event) {
+        const assortmentPublishChangeId = event.assortmentPublishChangeId;
+        let apcHistory;
+        let publisher;
         try {
             console.info('process-start!');
             const assortmentId = event.assortmentId;
@@ -38,40 +41,50 @@ class BaseProcessPublishAssortment {
                 };
                 return output;
             }
-            const assortmentPublishChangeId = event.assortmentPublishChangeId;
-            const apcHistory = await this.getApcHistory(assortmentId);
+            apcHistory = await this.getApcHistory(assortmentId);
             const sinceDate = await this.getSinceDate(assortmentId, assortmentPublishChangeId, apcHistory);
             const assortmentPublishChange = await this.downloadAssortmentPublishChange(assortmentId, assortmentPublishChangeId);
+            publisher = this.getPublisher(assortmentPublishChange);
             const changeDetail = await this.downloadHydratedChangeDetail(assortmentPublishChange);
             const assortmentBaseline = await this.downloadAssortmentBaseline(assortmentPublishChange);
             const deleteChanges = await this.getDeleteChanges(assortmentPublishChange, apcHistory, assortmentBaseline, sinceDate);
             const releasedForDevelopmentItemIds = this.getReleasedForDevelopmentItemAndFamilyIds(assortmentBaseline, deleteChanges);
             const itemToFederatedIdMapping = await this.getItemFederatedIds();
-            const publisher = this.getPublisher(assortmentPublishChange);
             const pcd = new publish_change_data_1.PublishChangeData(assortmentId, seasonFed, assortmentPublishChangeId, sinceDate, publisher);
             pcd.itemToFederatedIdMapping = itemToFederatedIdMapping;
             pcd.releasedForDevelopmentItemIds = releasedForDevelopmentItemIds;
             const output = await this.processPublish(pcd, changeDetail, assortmentBaseline, deleteChanges);
+            output['publishInfo'] = await this.getPublishInfo(assortmentPublishChangeId, apcHistory, publisher);
             console.info('process-end');
             return output;
         }
         catch (e) {
+            try {
+                const publishInfo = await this.getPublishInfo(assortmentPublishChangeId, apcHistory, publisher);
+                e.publishInfo = publishInfo;
+            }
+            catch (e2) {
+                console.log('catch e2: ' + e2.message);
+            }
             console.log('catch e: ' + e.message);
             throw e;
         }
     }
+    async getPublishInfo(assortmentPublishChangeId, apcHistory, publisher) {
+        const apc = apcHistory?.find(apc => apc?.id === assortmentPublishChangeId) || {};
+        const assortmentName = (await this.getAssortment(assortmentPublishChangeId))?.name;
+        const publishInfo = {
+            assortmentName,
+            versionName: apc?.versionName,
+            versionComments: apc?.versionComments,
+            publishDate: apc?.createdOn,
+            publisher
+        };
+        return publishInfo;
+    }
     async getSeasonFederation(assortmentId) {
-        let assortment;
-        try {
-            assortment = await new sdk_1.Entities().get({
-                entityName: 'assortment',
-                id: assortmentId
-            });
-            console.info('assortment-name: ' + assortment['name']);
-        }
-        catch (e) {
-            console.warn(`No Assortment found for id: ${assortmentId}`);
-        }
+        const assortment = await this.getAssortment(assortmentId);
+        console.error('assortment-name: ' + assortment?.name);
         const publishToFlexPLM = assortment?.publishToFlexPLM;
         if (!publishToFlexPLM) {
             throw new Error(BaseProcessPublishAssortment.ASSORTMENT_NOT_PUBLISHABLE);
@@ -95,6 +108,16 @@ class BaseProcessPublishAssortment {
         seasonObj = await map_utils_1.MapUtil.applyTransformMap(this.transformMapFile, this.mapFileUtil, seasonObj, 'LCSSeason', 'vibe2flex');
         return seasonObj;
     }
+    async getAssortment(assortmentId) {
+        if (this.assortment != undefined) {
+            return this.assortment;
+        }
+        this.assortment = await new sdk_1.Entities().get({
+            entityName: 'assortment',
+            id: assortmentId
+        });
+        return this.assortment;
+    }
     async getSinceDate(assortmentId, assortmentPublishChangeId, apcHistory) {
         let sinceDate = null;
         let pastPublishCount = 1;
@@ -226,7 +249,7 @@ class BaseProcessPublishAssortment {
         return publisher;
     }
     async downloadAssortmentPublishChange(assortmentId, assortmentPublishChangeId) {
-        const resourceString = '/assortments/' + assortmentId + '/history/' + assortmentPublishChangeId;
+        const resourceString = '/assortments/' + assortmentId + '/history/' + assortmentPublishChangeId + '?relations=createdBy';
         return await sdk_1.Request.request(resourceString, {
             method: 'GET',
             Headers: {

package/lib/publish/base-process-publish-assortment.spec.js

@@ -57,6 +57,159 @@ describe('process publish assortment', () => {
         expect(results['results']['message']).toEqual(base_process_publish_assortment_1.BaseProcessPublishAssortment.ASSORTMENT_NO_FED_INFO + config.identifierAtts.LCSSeason);
     });
 });
+describe('getPublishInfo', () => {
+    const config = {};
+    const mapFileUtil = new transform_data_1.MapFileUtil(new sdk_1.Entities());
+    const dc = new data_converter_1.DataConverter(config, mapFileUtil);
+    const versionName = 'Version 1';
+    const versionComments = 'Some Comments';
+    const createdOn = '2023-01-15T19:13:58.902Z';
+    const plan_history = [
+        {
+            id: 'sJbGx1Fpq1v2MmcI',
+            versionName,
+            versionComments,
+            createdOn
+        }
+    ];
+    it('All Publish Info', async () => {
+        const ppa = new base_process_publish_assortment_1.BaseProcessPublishAssortment(config, dc, mapFileUtil);
+        const assortmentPublishChangeId = 'sJbGx1Fpq1v2MmcI';
+        const publisher = {
+            email: 'chris@vibeiq.com'
+        };
+        const assortmentName = 'VibeIQ Fall 2023';
+        const spy = jest.spyOn(ppa, 'getAssortment')
+            .mockImplementation(async (assortmentId) => {
+            return { id: assortmentId, name: assortmentName };
+        });
+        const publishInfo = await ppa.getPublishInfo(assortmentPublishChangeId, plan_history, publisher);
+        expect(publishInfo.assortmentName).toEqual(assortmentName);
+        expect(publishInfo.versionName).toEqual(versionName);
+        expect(publishInfo.versionComments).toEqual(versionComments);
+        expect(publishInfo.publishDate).toEqual(createdOn);
+        expect(publishInfo.publisher).toEqual(publisher);
+        spy.mockRestore();
+    });
+    it('No Assortment Name', async () => {
+        const ppa = new base_process_publish_assortment_1.BaseProcessPublishAssortment(config, dc, mapFileUtil);
+        const assortmentPublishChangeId = 'sJbGx1Fpq1v2MmcI';
+        const publisher = {
+            email: 'chris@vibeiq.com'
+        };
+        const spy = jest.spyOn(ppa, 'getAssortment')
+            .mockImplementation(async (assortmentId) => {
+            return { id: assortmentId, name: undefined };
+        });
+        const publishInfo = await ppa.getPublishInfo(assortmentPublishChangeId, plan_history, publisher);
+        expect(publishInfo.assortmentName).toBeUndefined;
+        expect(publishInfo.versionName).toEqual(versionName);
+        expect(publishInfo.versionComments).toEqual(versionComments);
+        expect(publishInfo.publishDate).toEqual(createdOn);
+        expect(publishInfo.publisher).toEqual(publisher);
+        spy.mockRestore();
+    });
+    it('No Assortment', async () => {
+        const ppa = new base_process_publish_assortment_1.BaseProcessPublishAssortment(config, dc, mapFileUtil);
+        const assortmentPublishChangeId = 'sJbGx1Fpq1v2MmcI';
+        const publisher = {
+            email: 'chris@vibeiq.com'
+        };
+        const spy = jest.spyOn(ppa, 'getAssortment')
+            .mockImplementation(async (assortmentId) => {
+            return undefined;
+        });
+        const publishInfo = await ppa.getPublishInfo(assortmentPublishChangeId, plan_history, publisher);
+        expect(publishInfo.assortmentName).toBeUndefined();
+        expect(publishInfo.versionName).toEqual(versionName);
+        expect(publishInfo.versionComments).toEqual(versionComments);
+        expect(publishInfo.publishDate).toEqual(createdOn);
+        expect(publishInfo.publisher).toEqual(publisher);
+        spy.mockRestore();
+    });
+    it('Empty Version Name & Comments', async () => {
+        const ppa = new base_process_publish_assortment_1.BaseProcessPublishAssortment(config, dc, mapFileUtil);
+        const history = [
+            {
+                id: 'sJbGx1Fpq1v2MmcI',
+                versionName: '',
+                versionComments: '',
+                createdOn
+            }
+        ];
+        const assortmentPublishChangeId = 'sJbGx1Fpq1v2MmcI';
+        const publisher = {
+            email: 'chris@vibeiq.com'
+        };
+        const assortmentName = 'VibeIQ Fall 2023';
+        const spy = jest.spyOn(ppa, 'getAssortment')
+            .mockImplementation(async (assortmentId) => {
+            return { id: assortmentId, name: assortmentName };
+        });
+        const publishInfo = await ppa.getPublishInfo(assortmentPublishChangeId, history, publisher);
+        expect(publishInfo.assortmentName).toEqual(assortmentName);
+        expect(publishInfo.versionName).toEqual('');
+        expect(publishInfo.versionComments).toEqual('');
+        expect(publishInfo.publishDate).toEqual(createdOn);
+        expect(publishInfo.publisher).toEqual(publisher);
+        spy.mockRestore();
+    });
+    it('Undefined Publisher', async () => {
+        const ppa = new base_process_publish_assortment_1.BaseProcessPublishAssortment(config, dc, mapFileUtil);
+        const assortmentPublishChangeId = 'sJbGx1Fpq1v2MmcI';
+        const publisher = undefined;
+        const assortmentName = 'VibeIQ Fall 2023';
+        const spy = jest.spyOn(ppa, 'getAssortment')
+            .mockImplementation(async (assortmentId) => {
+            return { id: assortmentId, name: assortmentName };
+        });
+        const publishInfo = await ppa.getPublishInfo(assortmentPublishChangeId, plan_history, publisher);
+        expect(publishInfo.assortmentName).toEqual(assortmentName);
+        expect(publishInfo.versionName).toEqual(versionName);
+        expect(publishInfo.versionComments).toEqual(versionComments);
+        expect(publishInfo.publishDate).toEqual(createdOn);
+        expect(publishInfo.publisher).toBeUndefined();
+        spy.mockRestore();
+    });
+    it('No APC', async () => {
+        const ppa = new base_process_publish_assortment_1.BaseProcessPublishAssortment(config, dc, mapFileUtil);
+        const assortmentPublishChangeId = 'bad-id';
+        const publisher = {
+            email: 'chris@vibeiq.com'
+        };
+        const assortmentName = 'VibeIQ Fall 2023';
+        const spy = jest.spyOn(ppa, 'getAssortment')
+            .mockImplementation(async (assortmentId) => {
+            return { id: assortmentId, name: assortmentName };
+        });
+        const publishInfo = await ppa.getPublishInfo(assortmentPublishChangeId, plan_history, publisher);
+        expect(publishInfo.assortmentName).toEqual(assortmentName);
+        expect(publishInfo.versionName).toBeUndefined();
+        expect(publishInfo.versionComments).toBeUndefined();
+        expect(publishInfo.publishDate).toBeUndefined();
+        expect(publishInfo.publisher).toEqual(publisher);
+        spy.mockRestore();
+    });
+    it('No APC history', async () => {
+        const ppa = new base_process_publish_assortment_1.BaseProcessPublishAssortment(config, dc, mapFileUtil);
+        const assortmentPublishChangeId = 'bad-id';
+        const publisher = {
+            email: 'chris@vibeiq.com'
+        };
+        const assortmentName = 'VibeIQ Fall 2023';
+        const spy = jest.spyOn(ppa, 'getAssortment')
+            .mockImplementation(async (assortmentId) => {
+            return { id: assortmentId, name: assortmentName };
+        });
+        const publishInfo = await ppa.getPublishInfo(assortmentPublishChangeId, undefined, publisher);
+        expect(publishInfo.assortmentName).toEqual(assortmentName);
+        expect(publishInfo.versionName).toBeUndefined();
+        expect(publishInfo.versionComments).toBeUndefined();
+        expect(publishInfo.publishDate).toBeUndefined();
+        expect(publishInfo.publisher).toEqual(publisher);
+        spy.mockRestore();
+    });
+});
 describe('getSeasonFederation', () => {
     const config = {
         identifierAtts: {

package/lib/util/config-defaults.js

@@ -11,6 +11,9 @@ class ConfigDefaults {
         if (config?.itemPreDevelopmentLifecycleStages && !(config?.itemPreDevelopmentLifecycleStages instanceof Array)) {
             config.itemPreDevelopmentLifecycleStages = config.itemPreDevelopmentLifecycleStages.split(',');
         }
+        else if (Object.keys(config).includes('itemPreDevelopmentLifecycleStages')) {
+            delete config['itemPreDevelopmentLifecycleStages'];
+        }
         const defaultConfig = {
             urlContext: '/Windchill',
             sendMode: {

package/lib/util/config-defaults.spec.js

@@ -159,6 +159,32 @@ describe('all tests', () => {
             expect(itemPreDevelopmentLifecycleStages.includes(concept));
             expect(itemPreDevelopmentLifecycleStages.includes(development));
         });
+        it('itemPreDevelopmentLifecycleStages as empty string', async () => {
+            console.log('itemPreDevelopmentLifecycleStages as empty string');
+            const concept = 'concept';
+            const startConfig = Object.assign({}, config);
+            startConfig['itemPreDevelopmentLifecycleStages'] = '';
+            console.log('startConfig: ' + JSON.stringify(startConfig));
+            const fcConfig = await config_defaults_1.ConfigDefaults.setConfigDefaults(startConfig);
+            console.log('fcConfig: ' + JSON.stringify(fcConfig));
+            const itemPreDevelopmentLifecycleStages = fcConfig['itemPreDevelopmentLifecycleStages'];
+            expect(itemPreDevelopmentLifecycleStages instanceof Array).toBeTruthy();
+            expect(itemPreDevelopmentLifecycleStages.length).toBe(1);
+            expect(itemPreDevelopmentLifecycleStages.includes(concept));
+        });
+        it('itemPreDevelopmentLifecycleStages as empty array', async () => {
+            console.log('itemPreDevelopmentLifecycleStages as empty string');
+            const concept = 'concept';
+            const startConfig = Object.assign({}, config);
+            startConfig['itemPreDevelopmentLifecycleStages'] = [];
+            console.log('startConfig: ' + JSON.stringify(startConfig));
+            const fcConfig = await config_defaults_1.ConfigDefaults.setConfigDefaults(startConfig);
+            console.log('fcConfig: ' + JSON.stringify(fcConfig));
+            const itemPreDevelopmentLifecycleStages = fcConfig['itemPreDevelopmentLifecycleStages'];
+            expect(itemPreDevelopmentLifecycleStages instanceof Array).toBeTruthy();
+            expect(itemPreDevelopmentLifecycleStages.length).toBe(1);
+            expect(itemPreDevelopmentLifecycleStages.includes(concept));
+        });
         it('identifierAtts-LCSProduct-get default', async () => {
             const startConfig = Object.assign({}, config);
             const objectClass = 'LCSProduct';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@contrail/flexplm",
-  "version": "1.1.37",
+  "version": "1.1.39",
   "description": "Library used for integration with flexplm.",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -9,7 +9,8 @@
     "format": "prettier --write \"src/**/*.ts\" \"src/**/*.js\"",
     "lint": "tslint -p tsconfig.json",
     "test": "jest",
-    "test-watch": "jest --watch"
+    "test-watch": "jest --watch",
+    "test-debug": "jest --runInBand"
   },
   "keywords": [],
   "author": "",

package/src/entity-processor/base-entity-processor.ts

@@ -176,8 +176,6 @@ export abstract class BaseEntityProcessor {
       return await this.handleOutgoingUpsert(entityType, event);
     case 'delete':
       return await this.handleOutgoingDelete(entityType, event);
-    case 'sendUpsertToFlexPLM':
-      return await this.sendUpsertToFlexPLM(event);
     default:
       console.log(UNSUPPORTED_TYPE);
       return {
@@ -225,57 +223,4 @@ export abstract class BaseEntityProcessor {
 
   // This method must be implemented by derived classes
   protected abstract getOutgoingUpsertPayload(entityType, event): Promise<EntityPayloadType>;
-
-  /** Create a new event-workflow-request to rerun sending the entity to FlexPLM
-   * The event must contain any information needed to ensure it is put in the correct queue for the entity
-   *
-   * @param triggerKey Ex: event.entityType + '|sendUpsertToFlexPLM'
-   * @param event
-   * @returns
-   */
-
-  protected async triggerSendEvent(triggerKey: string, event: any) {
-    const newEvent = {
-      entityName: 'event-workflow-request',
-      object: {
-        triggerKey,
-        event
-      }
-  };
-  const response = await this.entities.create(newEvent);
-
-    return response;
-  }
-
-  /** Sends the current state of the entity to FlexPLM.
-   * So any changes made in Vibe between the event being generated and the event being processed are sent to FlexPLM.
-   *
-   * @param event must contain entityType, id; which are used to query for the entity
-   * @returns results of sending the entity to FlexPLM
-   */
-  protected async sendUpsertToFlexPLM(event) {
-    const payload = await this.getEntityUpsertPayload(event);
-    if(!payload){
-      const message = 'No payload to send to FlexPLM';
-      console.log(message);
-      return {
-        status: 500,
-        data: {message}
-      };
-    };
-    const flexResponse: any = await new FlexPLMConnect(this.config).sendToFlexPLM(payload);
-
-    const outboundEntityUpdates = await this.getOutboundEntityUpdates(event, flexResponse);
-    if(outboundEntityUpdates){
-      flexResponse['outboundEntityUpdates'] = outboundEntityUpdates;
-    }
-
-    return flexResponse;
-
-  }
-
-  protected async getEntityUpsertPayload(event: any): Promise<EntityPayloadType> {
-    console.warn('getEntityUpsertPayload is not configured', JSON.stringify(event));
-    return undefined;
-  }
 }

package/src/publish/base-process-publish-assortment.spec.ts

@@ -60,6 +60,174 @@ describe('process publish assortment', () => {
   });
 });
 
+describe('getPublishInfo', () =>{
+  const config = {} as FCConfig;
+  const mapFileUtil = new MapFileUtil(new Entities());
+  const dc = new DataConverter(config, mapFileUtil);
+
+  const versionName = 'Version 1';
+  const versionComments = 'Some Comments';
+  const createdOn = '2023-01-15T19:13:58.902Z';
+  const plan_history = [
+    {
+      id: 'sJbGx1Fpq1v2MmcI',
+      versionName,
+      versionComments,
+      createdOn
+
+    }
+  ];
+  it('All Publish Info', async () =>{
+    const ppa = new BaseProcessPublishAssortment(config, dc, mapFileUtil);
+
+    const assortmentPublishChangeId = 'sJbGx1Fpq1v2MmcI';
+    const publisher = {
+      email: 'chris@vibeiq.com'
+    };
+    const assortmentName = 'VibeIQ Fall 2023';
+    const spy = jest.spyOn(ppa, 'getAssortment')
+      .mockImplementation(async (assortmentId) => {
+        return {id: assortmentId, name: assortmentName};
+      });
+    const publishInfo = await ppa.getPublishInfo(assortmentPublishChangeId, plan_history, publisher);
+    expect(publishInfo.assortmentName).toEqual(assortmentName);
+    expect(publishInfo.versionName).toEqual(versionName);
+    expect(publishInfo.versionComments).toEqual(versionComments);
+    expect(publishInfo.publishDate).toEqual(createdOn);
+    expect(publishInfo.publisher).toEqual(publisher);
+    spy.mockRestore();
+  });
+
+  it('No Assortment Name', async () =>{
+    const ppa = new BaseProcessPublishAssortment(config, dc, mapFileUtil);
+
+    const assortmentPublishChangeId = 'sJbGx1Fpq1v2MmcI';
+    const publisher = {
+      email: 'chris@vibeiq.com'
+    };
+    const spy = jest.spyOn(ppa, 'getAssortment')
+      .mockImplementation(async (assortmentId) => {
+        return {id: assortmentId, name: undefined};
+      });
+    const publishInfo = await ppa.getPublishInfo(assortmentPublishChangeId, plan_history, publisher);
+    expect(publishInfo.assortmentName).toBeUndefined;
+    expect(publishInfo.versionName).toEqual(versionName);
+    expect(publishInfo.versionComments).toEqual(versionComments);
+    expect(publishInfo.publishDate).toEqual(createdOn);
+    expect(publishInfo.publisher).toEqual(publisher);
+    spy.mockRestore();
+  });
+
+  it('No Assortment', async () =>{
+    const ppa = new BaseProcessPublishAssortment(config, dc, mapFileUtil);
+
+    const assortmentPublishChangeId = 'sJbGx1Fpq1v2MmcI';
+    const publisher = {
+      email: 'chris@vibeiq.com'
+    };
+    const spy = jest.spyOn(ppa, 'getAssortment')
+      .mockImplementation(async (assortmentId) => {
+        return undefined;
+      });
+    const publishInfo = await ppa.getPublishInfo(assortmentPublishChangeId, plan_history, publisher);
+    expect(publishInfo.assortmentName).toBeUndefined();
+    expect(publishInfo.versionName).toEqual(versionName);
+    expect(publishInfo.versionComments).toEqual(versionComments);
+    expect(publishInfo.publishDate).toEqual(createdOn);
+    expect(publishInfo.publisher).toEqual(publisher);
+    spy.mockRestore();
+  });
+
+  it('Empty Version Name & Comments', async () =>{
+    const ppa = new BaseProcessPublishAssortment(config, dc, mapFileUtil);
+    const history = [
+      {
+        id: 'sJbGx1Fpq1v2MmcI',
+        versionName: '',
+        versionComments: '',
+        createdOn
+      }
+    ];
+    const assortmentPublishChangeId = 'sJbGx1Fpq1v2MmcI';
+    const publisher = {
+      email: 'chris@vibeiq.com'
+    };
+    const assortmentName = 'VibeIQ Fall 2023';
+    const spy = jest.spyOn(ppa, 'getAssortment')
+      .mockImplementation(async (assortmentId) => {
+        return {id: assortmentId, name: assortmentName};
+      });
+    const publishInfo = await ppa.getPublishInfo(assortmentPublishChangeId, history, publisher);
+    expect(publishInfo.assortmentName).toEqual(assortmentName);
+    expect(publishInfo.versionName).toEqual('');
+    expect(publishInfo.versionComments).toEqual('');
+    expect(publishInfo.publishDate).toEqual(createdOn);
+    expect(publishInfo.publisher).toEqual(publisher);
+    spy.mockRestore();
+  });
+
+  it('Undefined Publisher', async () =>{
+    const ppa = new BaseProcessPublishAssortment(config, dc, mapFileUtil);
+
+    const assortmentPublishChangeId = 'sJbGx1Fpq1v2MmcI';
+    const publisher = undefined;
+    const assortmentName = 'VibeIQ Fall 2023';
+    const spy = jest.spyOn(ppa, 'getAssortment')
+      .mockImplementation(async (assortmentId) => {
+        return {id: assortmentId, name: assortmentName};
+      });
+    const publishInfo = await ppa.getPublishInfo(assortmentPublishChangeId, plan_history, publisher);
+    expect(publishInfo.assortmentName).toEqual(assortmentName);
+    expect(publishInfo.versionName).toEqual(versionName);
+    expect(publishInfo.versionComments).toEqual(versionComments);
+    expect(publishInfo.publishDate).toEqual(createdOn);
+    expect(publishInfo.publisher).toBeUndefined();
+    spy.mockRestore();
+  });
+
+  it('No APC', async () =>{
+    const ppa = new BaseProcessPublishAssortment(config, dc, mapFileUtil);
+
+    const assortmentPublishChangeId = 'bad-id';
+    const publisher = {
+      email: 'chris@vibeiq.com'
+    };
+    const assortmentName = 'VibeIQ Fall 2023';
+    const spy = jest.spyOn(ppa, 'getAssortment')
+      .mockImplementation(async (assortmentId) => {
+        return {id: assortmentId, name: assortmentName};
+      });
+    const publishInfo = await ppa.getPublishInfo(assortmentPublishChangeId, plan_history, publisher);
+    expect(publishInfo.assortmentName).toEqual(assortmentName);
+    expect(publishInfo.versionName).toBeUndefined();
+    expect(publishInfo.versionComments).toBeUndefined();
+    expect(publishInfo.publishDate).toBeUndefined();
+    expect(publishInfo.publisher).toEqual(publisher);
+    spy.mockRestore();
+  });
+
+  it('No APC history', async () =>{
+    const ppa = new BaseProcessPublishAssortment(config, dc, mapFileUtil);
+
+    const assortmentPublishChangeId = 'bad-id';
+    const publisher = {
+      email: 'chris@vibeiq.com'
+    };
+    const assortmentName = 'VibeIQ Fall 2023';
+    const spy = jest.spyOn(ppa, 'getAssortment')
+      .mockImplementation(async (assortmentId) => {
+        return {id: assortmentId, name: assortmentName};
+      });
+    const publishInfo = await ppa.getPublishInfo(assortmentPublishChangeId, undefined, publisher);
+    expect(publishInfo.assortmentName).toEqual(assortmentName);
+    expect(publishInfo.versionName).toBeUndefined();
+    expect(publishInfo.versionComments).toBeUndefined();
+    expect(publishInfo.publishDate).toBeUndefined();
+    expect(publishInfo.publisher).toEqual(publisher);
+    spy.mockRestore();
+  });
+
+});
 describe('getSeasonFederation', () => {
   const config = {
     identifierAtts: {

package/src/publish/base-process-publish-assortment.ts

@@ -25,6 +25,8 @@ export class BaseProcessPublishAssortment {
   private cache = {
     carriedFromSeason: {}
   };
+  private assortment: any;
+
   constructor(_config: FCConfig, _dc: DataConverter, _mapFileUtil: MapFileUtil) {
     this.config = _config;
     this.dc = _dc;
@@ -33,6 +35,10 @@ export class BaseProcessPublishAssortment {
   }
 
   public async process(event) {
+
+    const assortmentPublishChangeId = event.assortmentPublishChangeId;
+    let apcHistory;
+    let publisher;
     try {
       console.info('process-start!');
       const assortmentId = event.assortmentId;
@@ -49,12 +55,13 @@ export class BaseProcessPublishAssortment {
         return output;
       }
 
-      const assortmentPublishChangeId = event.assortmentPublishChangeId;
-      const apcHistory = await this.getApcHistory(assortmentId);
+      apcHistory = await this.getApcHistory(assortmentId);
+
       const sinceDate = await this.getSinceDate(assortmentId, assortmentPublishChangeId, apcHistory);
 
       //Get detail information
       const assortmentPublishChange = await this.downloadAssortmentPublishChange(assortmentId, assortmentPublishChangeId);
+      publisher = this.getPublisher(assortmentPublishChange);
 
       const changeDetail = await this.downloadHydratedChangeDetail(assortmentPublishChange);
 
@@ -65,33 +72,45 @@ export class BaseProcessPublishAssortment {
       const releasedForDevelopmentItemIds = this.getReleasedForDevelopmentItemAndFamilyIds(assortmentBaseline, deleteChanges);
       const itemToFederatedIdMapping = await this.getItemFederatedIds(/*allItemIds*/);
 
-      const publisher = this.getPublisher(assortmentPublishChange);
       const pcd = new PublishChangeData(assortmentId, seasonFed, assortmentPublishChangeId, sinceDate, publisher);
       pcd.itemToFederatedIdMapping = itemToFederatedIdMapping;
 
       pcd.releasedForDevelopmentItemIds = releasedForDevelopmentItemIds;
 
       const output = await this.processPublish(pcd, changeDetail, assortmentBaseline, deleteChanges);
+      output ['publishInfo'] = await this.getPublishInfo(assortmentPublishChangeId, apcHistory, publisher);
       console.info('process-end');
 
       return output;
     } catch (e) {
+      try {
+        const publishInfo = await this.getPublishInfo(assortmentPublishChangeId, apcHistory, publisher);
+        e.publishInfo = publishInfo;
+      }catch(e2){
+        console.log('catch e2: ' + e2.message);
+      }
       console.log('catch e: ' + e.message);
       throw e;
     }
   }
+  async getPublishInfo(assortmentPublishChangeId: any, apcHistory: any, publisher: any): Promise<any> {
+    const apc = apcHistory?.find(apc => apc?.id === assortmentPublishChangeId) || {};
+    const assortmentName = (await this.getAssortment(assortmentPublishChangeId))?.name;
+    const publishInfo = {
+      assortmentName,
+      versionName: apc?.versionName,
+      versionComments: apc?.versionComments,
+      publishDate: apc?.createdOn,
+      publisher
+    };
+
+    return publishInfo;
+  }
 
   async getSeasonFederation(assortmentId): Promise<SeasonFederation> {
-    let assortment;
-    try {
-      assortment = await new Entities().get({
-        entityName: 'assortment',
-        id: assortmentId
-      });
-      console.info('assortment-name: ' + assortment['name']);
-    } catch (e) {
-      console.warn(`No Assortment found for id: ${assortmentId}`);
-    }
+    const assortment = await this.getAssortment(assortmentId);
+    console.error('assortment-name: ' + assortment?.name);
+
     const publishToFlexPLM = assortment?.publishToFlexPLM;
     if (!publishToFlexPLM) {
       throw new Error(BaseProcessPublishAssortment.ASSORTMENT_NOT_PUBLISHABLE);
@@ -120,6 +139,18 @@ export class BaseProcessPublishAssortment {
     return seasonObj as SeasonFederation;
   }
 
+  async getAssortment(assortmentId: any) {
+    if(this.assortment != undefined){
+      return this.assortment;
+    }
+
+    this.assortment = await new Entities().get({
+      entityName: 'assortment',
+      id: assortmentId
+    });
+    return this.assortment;
+  }
+
   public async getSinceDate(assortmentId: any, assortmentPublishChangeId: any, apcHistory: object[]): Promise<Date> {
 
     let sinceDate = null;
@@ -265,7 +296,7 @@ export class BaseProcessPublishAssortment {
   }
 
   async downloadAssortmentPublishChange(assortmentId: string, assortmentPublishChangeId: string) {
-    const resourceString = '/assortments/' + assortmentId + '/history/' + assortmentPublishChangeId;
+    const resourceString = '/assortments/' + assortmentId + '/history/' + assortmentPublishChangeId + '?relations=createdBy';
     return await Request.request(
       resourceString,
       {

package/src/util/config-defaults.spec.ts

@@ -190,6 +190,37 @@ describe('all tests', () => {
       expect(itemPreDevelopmentLifecycleStages.includes(development));
     });
 
+    it('itemPreDevelopmentLifecycleStages as empty string', async () => {
+      console.log('itemPreDevelopmentLifecycleStages as empty string');
+      const concept = 'concept';
+      const startConfig = Object.assign({}, config);
+      startConfig['itemPreDevelopmentLifecycleStages'] = '';
+      console.log('startConfig: ' + JSON.stringify(startConfig));
+
+      const fcConfig: FCConfig = await ConfigDefaults.setConfigDefaults(startConfig);
+      console.log('fcConfig: ' + JSON.stringify(fcConfig));
+      const itemPreDevelopmentLifecycleStages = fcConfig['itemPreDevelopmentLifecycleStages'];
+      expect(itemPreDevelopmentLifecycleStages instanceof Array).toBeTruthy();
+      expect(itemPreDevelopmentLifecycleStages.length).toBe(1);
+      expect(itemPreDevelopmentLifecycleStages.includes(concept));
+
+    });
+
+    it('itemPreDevelopmentLifecycleStages as empty array', async () => {
+      console.log('itemPreDevelopmentLifecycleStages as empty string');
+      const concept = 'concept';
+      const startConfig = Object.assign({}, config);
+      startConfig['itemPreDevelopmentLifecycleStages'] = [];
+      console.log('startConfig: ' + JSON.stringify(startConfig));
+
+      const fcConfig: FCConfig = await ConfigDefaults.setConfigDefaults(startConfig);
+      console.log('fcConfig: ' + JSON.stringify(fcConfig));
+      const itemPreDevelopmentLifecycleStages = fcConfig['itemPreDevelopmentLifecycleStages'];
+      expect(itemPreDevelopmentLifecycleStages instanceof Array).toBeTruthy();
+      expect(itemPreDevelopmentLifecycleStages.length).toBe(1);
+      expect(itemPreDevelopmentLifecycleStages.includes(concept));
+
+    });
     it('identifierAtts-LCSProduct-get default', async () => {
       const startConfig = Object.assign({}, config);
       const objectClass = 'LCSProduct';

package/src/util/config-defaults.ts

@@ -13,6 +13,8 @@ export class ConfigDefaults {
     //List will be comma separated list in UI, so convert to array
     if(config?.itemPreDevelopmentLifecycleStages && !(config?.itemPreDevelopmentLifecycleStages instanceof Array)){
       config.itemPreDevelopmentLifecycleStages = config.itemPreDevelopmentLifecycleStages.split(',');
+    } else if(Object.keys(config).includes('itemPreDevelopmentLifecycleStages')){
+      delete config['itemPreDevelopmentLifecycleStages'];
     }
 
     const defaultConfig = {

package/src/util/thumbnail-util.ts

@@ -37,10 +37,6 @@ export class ThumbnailUtil {
   }
     /** Determines if a new image has been generated.  If any viewable is new, there might be a better
    * sized image.  So send the fileId as new.
-   *
-   * @param event
-   * @param customSizes
-   * @returns boolean
    */
     public isThumbnailNew(event, customSizes: any[]): boolean {
       const propertyDiffs = event?.propertyDiffs;