@contrail/flexplm 1.1.30 → 1.1.31

package/lib/publish/base-process-publish-assortment-callback.js

@@ -12,15 +12,17 @@ class BaseProcessPublishAssortmentCallback {
         console.log("ProcessPublishAssortmentCallback-config: " + JSON.stringify(this.config));
         const statusCounts = this.config["statusCounts"];
         console.log("statusCounts: " + JSON.stringify(statusCounts));
-        this.checkFailuresAndSendNotification(event);
+        const statMessage = (statusCounts)
+            ? await this.checkFailuresAndSendNotification(event)
+            : 'no statusCount';
         return {
-            message: "Done ProcessPublishAssortmentCallback-process()",
+            message: "Done ProcessPublishAssortmentCallback-process(): " + statMessage,
         };
     }
-    checkFailuresAndSendNotification(event) {
+    async checkFailuresAndSendNotification(event) {
         const statusCounts = JSON.parse(this.config["statusCounts"]);
         if (statusCounts["INVALID"] > 0 || statusCounts["FAILURE"] > 0) {
-            new sdk_1.Notification().Dispatch({
+            await new sdk_1.Notification().Dispatch({
                 message: `There were errors when publishing the season data. Please review the event and config information from context.`,
                 level: sdk_1.LogLevel.WARN,
                 context: {
@@ -28,7 +30,9 @@ class BaseProcessPublishAssortmentCallback {
                     config: this.config,
                 },
             });
+            return 'sent notification';
         }
+        return 'no notification needed';
     }
 }
 exports.BaseProcessPublishAssortmentCallback = BaseProcessPublishAssortmentCallback;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@contrail/flexplm",
-  "version": "1.1.30",
+  "version": "1.1.31",
   "description": "Library used for integration with flexplm.",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

package/src/publish/base-process-publish-assortment-callback.ts

@@ -21,18 +21,20 @@ export class BaseProcessPublishAssortmentCallback {
     const statusCounts = this.config["statusCounts"];
     console.log("statusCounts: " + JSON.stringify(statusCounts));
 
-    this.checkFailuresAndSendNotification(event);
+    const statMessage =(statusCounts)
+      ?await this.checkFailuresAndSendNotification(event)
+      :'no statusCount';
 
     return {
-      message: "Done ProcessPublishAssortmentCallback-process()",
+      message: "Done ProcessPublishAssortmentCallback-process(): " + statMessage,
     };
   }
 
-  private checkFailuresAndSendNotification(event) {
+  private async checkFailuresAndSendNotification(event): Promise<string> {
     const statusCounts = JSON.parse(this.config["statusCounts"]);
 
     if (statusCounts["INVALID"] > 0 || statusCounts["FAILURE"] > 0) {
-      new Notification().Dispatch({
+      await new Notification().Dispatch({
         message: `There were errors when publishing the season data. Please review the event and config information from context.`,
         level: LogLevel.WARN,
         context: {
@@ -40,6 +42,9 @@ export class BaseProcessPublishAssortmentCallback {
           config: this.config,
         },
       });
+      return 'sent notification';
     }
+
+    return 'no notification needed';
   }
 }

package/src/util/error-response-object.spec.ts

@@ -1,116 +1,116 @@
-import { AppActionCallbackStatus } from "@contrail/app-framework";
-import { ErrorResponseObject } from "./error-response-object";
-
-describe('getResponse() Tests', () =>{
-  it('no error provided', () => {
-    const e = undefined;
-
-    const response = ErrorResponseObject.getResponse(e);
-    expect(response.status).toMatch(AppActionCallbackStatus.FAILURE);
-    expect(response?.output?.message).toMatch('No error provided');
-  });
-  it('error with message', () => {
-    const e = {
-      message: 'Test'
-    };
-
-    const response = ErrorResponseObject.getResponse(e);
-    expect(response.status).toMatch(AppActionCallbackStatus.FAILURE);
-    expect(response?.output?.message).toMatch('Test');
-  });
-
-  it('error with details', () => {
-    const details = {
-      message: 'Detail Message',
-      itemType: [
-        {
-            message: "Type 'item:product:newBalance:apparel' cannot be assigned to a property with type 'item'."
-        }]
-    };
-    const e = {
-      message: 'Test',
-      details
-
-    };
-
-    const response = ErrorResponseObject.getResponse(e);
-    expect(response).toBeTruthy();
-    expect(response.status).toMatch(AppActionCallbackStatus.FAILURE);
-    expect(response.output.message).toMatch('Test');
-
-    const errorDetails = response.output.errorDetails;
-    expect(errorDetails).toBeTruthy();
-    expect(errorDetails.message).toMatch('Detail Message');
-    expect(errorDetails).toHaveProperty('itemType');
-  });
-
-  it('error with cause', () => {
-    const cause = {
-      code: 401,
-      message: 'cause message'
-    };
-    const e = {
-      message: 'Test',
-      cause
-    };
-
-    const response = ErrorResponseObject.getResponse(e);
-    expect(response.status).toMatch(AppActionCallbackStatus.FAILURE);
-    expect(response?.output?.message).toMatch('Test');
-    const resCause = response.output.cause;
-
-    expect(resCause).toBeTruthy();
-    expect(resCause.code).toBe(401);
-    expect(resCause.message).toMatch('cause message');
-
-  });
-
-  it('error with code', () => {
-    const e = {
-      message: 'Test',
-      code: 404
-    };
-
-    const response = ErrorResponseObject.getResponse(e);
-    expect(response.status).toMatch(AppActionCallbackStatus.FAILURE);
-    expect(response?.output?.message).toMatch('Test');
-    expect(response.output.code).toBe(404);
-  });
-
-  it('error with code', () => {
-    const e = {
-      message: 'Test',
-      name: 'Error'
-    };
-
-    const response = ErrorResponseObject.getResponse(e);
-    expect(response.status).toMatch(AppActionCallbackStatus.FAILURE);
-    expect(response?.output?.message).toMatch('Test');
-    expect(response.output.errorName).toMatch('Error');
-  });
-
-  it('error with errno', () => {
-    const e = {
-      message: 'Test',
-      errno: 500
-    };
-
-    const response = ErrorResponseObject.getResponse(e);
-    expect(response.status).toMatch(AppActionCallbackStatus.FAILURE);
-    expect(response?.output?.message).toMatch('Test');
-    expect(response.output.errno).toBe(500);
-  });
-
-  it('error with type', () => {
-    const e = {
-      message: 'Test',
-      type: 'system'
-    };
-
-    const response = ErrorResponseObject.getResponse(e);
-    expect(response.status).toMatch(AppActionCallbackStatus.FAILURE);
-    expect(response?.output?.message).toMatch('Test');
-    expect(response.output.type).toMatch('system');
-  });
-
+import { AppActionCallbackStatus } from "@contrail/app-framework";
+import { ErrorResponseObject } from "./error-response-object";
+
+describe('getResponse() Tests', () =>{
+  it('no error provided', () => {
+    const e = undefined;
+
+    const response = ErrorResponseObject.getResponse(e);
+    expect(response.status).toMatch(AppActionCallbackStatus.FAILURE);
+    expect(response?.output?.message).toMatch('No error provided');
+  });
+  it('error with message', () => {
+    const e = {
+      message: 'Test'
+    };
+
+    const response = ErrorResponseObject.getResponse(e);
+    expect(response.status).toMatch(AppActionCallbackStatus.FAILURE);
+    expect(response?.output?.message).toMatch('Test');
+  });
+
+  it('error with details', () => {
+    const details = {
+      message: 'Detail Message',
+      itemType: [
+        {
+            message: "Type 'item:product:newBalance:apparel' cannot be assigned to a property with type 'item'."
+        }]
+    };
+    const e = {
+      message: 'Test',
+      details
+
+    };
+
+    const response = ErrorResponseObject.getResponse(e);
+    expect(response).toBeTruthy();
+    expect(response.status).toMatch(AppActionCallbackStatus.FAILURE);
+    expect(response.output.message).toMatch('Test');
+
+    const errorDetails = response.output.errorDetails;
+    expect(errorDetails).toBeTruthy();
+    expect(errorDetails.message).toMatch('Detail Message');
+    expect(errorDetails).toHaveProperty('itemType');
+  });
+
+  it('error with cause', () => {
+    const cause = {
+      code: 401,
+      message: 'cause message'
+    };
+    const e = {
+      message: 'Test',
+      cause
+    };
+
+    const response = ErrorResponseObject.getResponse(e);
+    expect(response.status).toMatch(AppActionCallbackStatus.FAILURE);
+    expect(response?.output?.message).toMatch('Test');
+    const resCause = response.output.cause;
+
+    expect(resCause).toBeTruthy();
+    expect(resCause.code).toBe(401);
+    expect(resCause.message).toMatch('cause message');
+
+  });
+
+  it('error with code', () => {
+    const e = {
+      message: 'Test',
+      code: 404
+    };
+
+    const response = ErrorResponseObject.getResponse(e);
+    expect(response.status).toMatch(AppActionCallbackStatus.FAILURE);
+    expect(response?.output?.message).toMatch('Test');
+    expect(response.output.code).toBe(404);
+  });
+
+  it('error with code', () => {
+    const e = {
+      message: 'Test',
+      name: 'Error'
+    };
+
+    const response = ErrorResponseObject.getResponse(e);
+    expect(response.status).toMatch(AppActionCallbackStatus.FAILURE);
+    expect(response?.output?.message).toMatch('Test');
+    expect(response.output.errorName).toMatch('Error');
+  });
+
+  it('error with errno', () => {
+    const e = {
+      message: 'Test',
+      errno: 500
+    };
+
+    const response = ErrorResponseObject.getResponse(e);
+    expect(response.status).toMatch(AppActionCallbackStatus.FAILURE);
+    expect(response?.output?.message).toMatch('Test');
+    expect(response.output.errno).toBe(500);
+  });
+
+  it('error with type', () => {
+    const e = {
+      message: 'Test',
+      type: 'system'
+    };
+
+    const response = ErrorResponseObject.getResponse(e);
+    expect(response.status).toMatch(AppActionCallbackStatus.FAILURE);
+    expect(response?.output?.message).toMatch('Test');
+    expect(response.output.type).toMatch('system');
+  });
+
 });

package/src/util/error-response-object.ts

@@ -1,50 +1,50 @@
-import { AppActionCallBack, AppActionCallbackStatus } from "@contrail/app-framework";
-
-export class ErrorResponseObject {
-
-  /** Returns a response, checking for multiple possible error details
-   *
-   * @param e
-   * @returns
-   */
-  public static getResponse(e): AppActionCallBack {
-    if(!e){
-      const response: AppActionCallBack = {
-        status: AppActionCallbackStatus.FAILURE,
-        output: {
-          message: 'No error provided.'
-        }
-      };
-        return response;
-    }
-
-    const response: AppActionCallBack = {
-      status: AppActionCallbackStatus.FAILURE,
-      output: {
-        message: e.message
-      }
-    };
-    const output = response.output;
-
-    //Errors when persisting in VibeIQ
-    if(e.details) output.errorDetails = e.details;
-
-    if(e.code) output.code = e.code;
-    if(e.errno) output.errno = e.errno;
-    if(e.type) output.type = e.type;
-    if(e.name) output.errorName = e.name;
-
-    //Has original cause
-    if(e.cause){
-      output.cause = {};
-      const cause = output.cause;
-      if(e.cause.code) cause.code = e.cause.code;
-      if(e.cause.message) cause.message = e.cause.message;
-    }
-
-    if(e.stack){
-      console.log('ErrorResponseObject.getResponse stack: ' + e.stack);
-    }
-    return response;
-  }
+import { AppActionCallBack, AppActionCallbackStatus } from "@contrail/app-framework";
+
+export class ErrorResponseObject {
+
+  /** Returns a response, checking for multiple possible error details
+   *
+   * @param e
+   * @returns
+   */
+  public static getResponse(e): AppActionCallBack {
+    if(!e){
+      const response: AppActionCallBack = {
+        status: AppActionCallbackStatus.FAILURE,
+        output: {
+          message: 'No error provided.'
+        }
+      };
+        return response;
+    }
+
+    const response: AppActionCallBack = {
+      status: AppActionCallbackStatus.FAILURE,
+      output: {
+        message: e.message
+      }
+    };
+    const output = response.output;
+
+    //Errors when persisting in VibeIQ
+    if(e.details) output.errorDetails = e.details;
+
+    if(e.code) output.code = e.code;
+    if(e.errno) output.errno = e.errno;
+    if(e.type) output.type = e.type;
+    if(e.name) output.errorName = e.name;
+
+    //Has original cause
+    if(e.cause){
+      output.cause = {};
+      const cause = output.cause;
+      if(e.cause.code) cause.code = e.cause.code;
+      if(e.cause.message) cause.message = e.cause.message;
+    }
+
+    if(e.stack){
+      console.log('ErrorResponseObject.getResponse stack: ' + e.stack);
+    }
+    return response;
+  }
 }