@contrail/documents 1.18.0-alpha.b7a7dd2 → 1.18.0-alpha.c618827

package/CHANGELOG.md

@@ -9,8 +9,12 @@ Versioning follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ### Added
 
-- `DocumentChange.gestureId?: string` — optional marker a producer sets to correlate the
-  actions of one user gesture across a batch.
+- `ItemComponentService.isAnnotationRowEmpty(annotationElement, annotations)` — whether an item card's annotation row will render nothing, because the row is hidden or the item has no `category === 'property'` annotations. The single predicate behind the reservation, so the layout service and the canvas renderers cannot drift apart on the question. A missing row element is not treated as hidden: renderers supply a default row for item components that have none stored, so only the annotation data decides there.
+- `ItemComponentService.getAnnotationRowHeight(annotationElement, annotations, width)` — the row's reserved height, wrapping onto further rows when the badges do not fit `width`, and `0` when the row is empty. Every creation path must size the row through here so a card laid out by the Item Chooser and one laid out by board generation agree.
+
+### Fixed
+
+- `updateSizeAndPosition` no longer reserves space above the thumbnail for an annotation row that renders nothing. `calculateAnnotationHeight` returned a flat `fontSize + ANNOTATION_PADDING_Y` minimum even when the row was hidden or the item had no annotations, pushing the thumbnail down ~8px on every such card (DESIGN-150). It now returns `0` in those cases and the thumbnail sits at the card origin. Cards whose row does show a badge are unchanged.
 
 ## [1.17.0] - 2026-09-09
 

package/lib/components/item-component.service.d.ts

@@ -15,6 +15,8 @@ export interface ScaledItemCardResult {
 export declare class ItemComponentService {
     static isItemComponent(element: DocumentElement): boolean;
     static isThumbnailOnlyComponent(element: DocumentElement): boolean;
+    static isAnnotationRowEmpty(annotationElement: DocumentElement, annotations?: any[]): boolean;
+    static getAnnotationRowHeight(annotationElement: DocumentElement, annotations?: any[], width?: number): number;
     static updateSizeAndPosition(propertyElements: any[], componentElement: DocumentElement, annotatedElements?: any[]): any;
     private static getYMargin;
     private static calculateAnnotationHeight;

package/lib/components/item-component.service.js

@@ -17,6 +17,30 @@ class ItemComponentService {
         const imageElement = element.elements.find((e) => e.type == 'image');
         return (!annotationElement || annotationElement.isHidden) && imageElement && !imageElement.isHidden;
     }
+    static isAnnotationRowEmpty(annotationElement, annotations = []) {
+        if (annotationElement === null || annotationElement === void 0 ? void 0 : annotationElement.isHidden) {
+            return true;
+        }
+        return !(annotations === null || annotations === void 0 ? void 0 : annotations.some((annotation) => (annotation === null || annotation === void 0 ? void 0 : annotation.category) === 'property'));
+    }
+    static getAnnotationRowHeight(annotationElement, annotations = [], width = exports.DEFAULT_THUMBNAIL_WIDTH) {
+        var _a, _b;
+        if (this.isAnnotationRowEmpty(annotationElement, annotations)) {
+            return 0;
+        }
+        const annotationSize = ((_b = (_a = annotationElement === null || annotationElement === void 0 ? void 0 : annotationElement.style) === null || _a === void 0 ? void 0 : _a.font) === null || _b === void 0 ? void 0 : _b.size) || document_element_constants_1.ANNOTATION_IMG_SIZE;
+        const propertyAnnotations = annotations.filter((annotation) => (annotation === null || annotation === void 0 ? void 0 : annotation.category) === 'property');
+        let height = annotationSize + document_element_constants_1.ANNOTATION_PADDING_Y;
+        let count = 0;
+        propertyAnnotations.forEach(() => {
+            if ((count + 1) * annotationSize * 1.25 > width) {
+                count = 0;
+                height = height + annotationSize + document_element_constants_1.ANNOTATION_PADDING_Y;
+            }
+            count++;
+        });
+        return height;
+    }
     static updateSizeAndPosition(propertyElements, componentElement, annotatedElements = []) {
         var _a, _b, _c, _d;
         const newElements = [];
@@ -64,9 +88,11 @@ class ItemComponentService {
                     lastYPosition = element.position.y;
                 }
                 const annotationHeight = this.calculateAnnotationHeight(element, componentElement, width, annotatedElements);
-                lastYPosition = lastYPosition + annotationHeight;
                 if (annotationHeight === 0 && index === 0) {
-                    lastYPosition = lastYPosition + document_element_constants_1.ANNOTATION_IMG_SIZE;
+                    lastYPosition = 0;
+                }
+                else {
+                    lastYPosition = lastYPosition + annotationHeight;
                 }
             }
             element.size.width = width;
@@ -112,28 +138,8 @@ class ItemComponentService {
         return marginY;
     }
     static calculateAnnotationHeight(element, componentElement, width, annotatedElements = []) {
-        var _a, _b;
-        const annotationSize = ((_b = (_a = element.style) === null || _a === void 0 ? void 0 : _a.font) === null || _b === void 0 ? void 0 : _b.size) || document_element_constants_1.ANNOTATION_IMG_SIZE;
-        let height = annotationSize + document_element_constants_1.ANNOTATION_PADDING_Y;
-        let xPos = 0;
         const annotatedElement = annotatedElements.find((elem) => elem.id === componentElement.id);
-        if (!annotatedElement || element.isHidden) {
-            return height;
-        }
-        const annotations = annotatedElement.annotations.filter((annotation) => annotation.category === 'property');
-        if (annotations.length > 0) {
-            let count = 0;
-            annotations === null || annotations === void 0 ? void 0 : annotations.forEach((annotation) => {
-                if ((count + 1) * annotationSize * 1.25 > width) {
-                    count = 0;
-                    xPos = -width * 0.5;
-                    height = height + annotationSize + document_element_constants_1.ANNOTATION_PADDING_Y;
-                }
-                xPos = xPos + annotationSize * 1.25;
-                count++;
-            });
-        }
-        return height;
+        return this.getAnnotationRowHeight(element, annotatedElement === null || annotatedElement === void 0 ? void 0 : annotatedElement.annotations, width);
     }
     static getImageElement(element) {
         var _a;

package/lib/types/document-change.d.ts

@@ -18,5 +18,4 @@ export interface DocumentChange {
     backingAssortmentItemData?: any;
     targetSortIndex?: number;
     skipUndo?: boolean;
-    gestureId?: string;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@contrail/documents",
-  "version": "1.18.0-alpha.b7a7dd2",
+  "version": "1.18.0-alpha.c618827",
   "description": "Documents library for contrail platform",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",