@contrail/documents 1.14.1 → 1.15.0-alpha.4626e64

package/CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to `@contrail/documents` are documented here.
 Format follows [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 Versioning follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.15.0] - 2026-08-18
+
+### Added
+
+- `isValidSortIndex` — whether a value is a usable fractional-indexing key. `fractional-indexing` keeps its own `validateOrderKey` private, so callers that need to check a key before storing it had no way to do so beyond a non-empty-string test. A key that passes that test but breaks the grammar still sorts, so ordering looks fine; the failure surfaces later, when the next insert beside it calls `generateKeyBetween` and throws. One point is stricter than the library: every character must be in the base-62 digit set, since a key holding anything else can sort below the integer part it claims.
+
 ## [1.14.0] - 2026-07-29
 
 ### Added

package/lib/document-element-factory.js

@@ -38,7 +38,7 @@ class DocumentElementFactory {
         let element = this.initNewElement(type);
         element = Object.assign(element, options);
         if (((_a = element === null || element === void 0 ? void 0 : element.elements) === null || _a === void 0 ? void 0 : _a.length) > 0) {
-            element.elements = element.elements.map(e => {
+            element.elements = element.elements.map((e) => {
                 e.id = (0, nanoid_1.nanoid)(16);
                 return e;
             });
@@ -82,7 +82,7 @@ class DocumentElementFactory {
         element.elements = elements;
         element.modelBindings = modelBindings;
         if (((_a = element === null || element === void 0 ? void 0 : element.elements) === null || _a === void 0 ? void 0 : _a.length) > 0) {
-            element.elements = element.elements.map(e => {
+            element.elements = element.elements.map((e) => {
                 e.id = (0, nanoid_1.nanoid)(16);
                 return e;
             });
@@ -90,7 +90,7 @@ class DocumentElementFactory {
         return element;
     }
     static copyElements(elements, documentId, commonOptions = {}, positionOffset, lastFrameNumber) {
-        var _a, _b, _c;
+        var _a, _b;
         const oldIdToNewId = new Map();
         const newElements = [];
         const groupElements = [];
@@ -115,17 +115,18 @@ class DocumentElementFactory {
             }
             const newInnerElements = [];
             if (newElement.type === 'table') {
-                const oldChildElements = elements.filter(e => e.tableId === element.id && ['cell', 'column', 'row'].indexOf(e.type) !== -1);
+                const oldChildElements = elements.filter((e) => e.tableId === element.id && ['cell', 'column', 'row'].indexOf(e.type) !== -1);
                 let newTableElement, newChildElements = [];
                 try {
-                    [newTableElement, ...newChildElements] = document_table_1.TableCopyService.copy(element, oldChildElements);
+                    [newTableElement, ...newChildElements] = document_table_1.TableCopyService.copy(newElement, oldChildElements);
                 }
-                catch (e) {
-                    telemetry_1.logger.warn({ element, oldChildElements, newChildElements }, (_b = e === null || e === void 0 ? void 0 : e.message) !== null && _b !== void 0 ? _b : 'Invalid table element to copy');
+                catch (e) { }
+                if (oldChildElements.length > newChildElements.length || oldChildElements.length === 0) {
+                    telemetry_1.logger.warn({ newElement, oldChildElements, newChildElements }, 'Invalid table element to copy');
                     continue;
                 }
                 newElement = newTableElement;
-                newChildElements.forEach(newChildElement => {
+                newChildElements.forEach((newChildElement) => {
                     var _a;
                     let oldChildId;
                     if (newChildElement.type === 'row') {
@@ -137,7 +138,7 @@ class DocumentElementFactory {
                     else if (newChildElement.type === 'cell') {
                         const oldRowId = element.rowIds[newTableElement.rowIds.indexOf(newChildElement.rowId)];
                         const oldColumnId = element.columnIds[newTableElement.columnIds.indexOf(newChildElement.columnId)];
-                        oldChildId = (_a = elements.find(e => e.type === 'cell' && e.rowId === oldRowId && e.columnId === oldColumnId)) === null || _a === void 0 ? void 0 : _a.id;
+                        oldChildId = (_a = elements.find((e) => e.type === 'cell' && e.rowId === oldRowId && e.columnId === oldColumnId)) === null || _a === void 0 ? void 0 : _a.id;
                     }
                     newChildElement.documentId = documentId;
                     newChildElement.specifiedId = newChildElement.id;
@@ -158,7 +159,7 @@ class DocumentElementFactory {
                     newElement.position.x = newElement.position.x + positionOffset.x;
                     newElement.position.y = newElement.position.y + positionOffset.y;
                 }
-                if (['line', 'callout'].includes(newElement.type) && ((_c = newElement.points) === null || _c === void 0 ? void 0 : _c.length) > 0) {
+                if (['line', 'callout'].includes(newElement.type) && ((_b = newElement.points) === null || _b === void 0 ? void 0 : _b.length) > 0) {
                     newElement.points = newElement.points.map(([x, y]) => [x + positionOffset.x, y + positionOffset.y]);
                 }
             }
@@ -175,18 +176,18 @@ class DocumentElementFactory {
             if (DocumentElementFactory.isMask(newElement))
                 maskElements.push(newElement);
         }
-        groupElements.forEach(groupElement => {
+        groupElements.forEach((groupElement) => {
             groupElement.elementIds = groupElement.elementIds
-                .map(oldElementId => oldIdToNewId.get(oldElementId))
-                .filter(id => !!id);
+                .map((oldElementId) => oldIdToNewId.get(oldElementId))
+                .filter((id) => !!id);
         });
-        maskElements.forEach(maskElement => {
+        maskElements.forEach((maskElement) => {
             const newElementIds = maskElement.elementIds
-                .map(oldElementId => oldIdToNewId.get(oldElementId))
-                .filter(id => !!id);
+                .map((oldElementId) => oldIdToNewId.get(oldElementId))
+                .filter((id) => !!id);
             maskElement.elementIds = (newElementIds === null || newElementIds === void 0 ? void 0 : newElementIds.length) > 0 ? newElementIds : null;
         });
-        calloutElements.forEach(calloutElement => {
+        calloutElements.forEach((calloutElement) => {
             if (calloutElement.start.id) {
                 const startId = oldIdToNewId.get(calloutElement.start.id);
                 if (startId) {

package/lib/sort-index.d.ts

@@ -1,5 +1,6 @@
 import { DocumentElement } from './types';
 export declare function allElementsHaveSortIndex(elements: unknown[]): boolean;
+export declare function isValidSortIndex(sortIndex: unknown): sortIndex is string;
 export declare function buildKeyBetween(a: string | null, b: string | null): string;
 export declare function buildNKeysBetween(a: string | null, b: string | null, n: number): string[];
 export declare function compareSortIndex(a: DocumentElement, b: DocumentElement): number;

package/lib/sort-index.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.allElementsHaveSortIndex = allElementsHaveSortIndex;
+exports.isValidSortIndex = isValidSortIndex;
 exports.buildKeyBetween = buildKeyBetween;
 exports.buildNKeysBetween = buildNKeysBetween;
 exports.compareSortIndex = compareSortIndex;
@@ -9,6 +10,26 @@ function allElementsHaveSortIndex(elements) {
     return elements.every((element) => typeof element.sortIndex === 'string' &&
         element.sortIndex.length > 0);
 }
+const SMALLEST_INTEGER = 'A00000000000000000000000000';
+function getIntegerPartLength(head) {
+    if (head >= 'a' && head <= 'z')
+        return head.charCodeAt(0) - 'a'.charCodeAt(0) + 2;
+    if (head >= 'A' && head <= 'Z')
+        return 'Z'.charCodeAt(0) - head.charCodeAt(0) + 2;
+    return null;
+}
+function isValidSortIndex(sortIndex) {
+    if (typeof sortIndex !== 'string' || sortIndex.length === 0)
+        return false;
+    if (sortIndex === SMALLEST_INTEGER)
+        return false;
+    if (![...sortIndex].every((character) => fractional_indexing_1.BASE_62_DIGITS.includes(character)))
+        return false;
+    const integerPartLength = getIntegerPartLength(sortIndex[0]);
+    if (integerPartLength === null || integerPartLength > sortIndex.length)
+        return false;
+    return !sortIndex.slice(integerPartLength).endsWith('0');
+}
 function buildKeyBetween(a, b) {
     return (0, fractional_indexing_1.generateKeyBetween)(a, b);
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@contrail/documents",
-  "version": "1.14.1",
+  "version": "1.15.0-alpha.4626e64",
   "description": "Documents library for contrail platform",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -40,7 +40,7 @@
   },
   "dependencies": {
     "@contrail/actions": "^1.0.18",
-    "@contrail/document-table": "^1.2.3",
+    "@contrail/document-table": "^1.1.0",
     "@contrail/document-util": "^1.2.0",
     "@contrail/types": "^3.4.0",
     "fractional-indexing": "^2.1.0",