@contrail/cli 3.5.0-alpha.11f30e6 → 3.5.0-alpha.9d881a5

package/README.md

@@ -17,7 +17,7 @@ $ npm install -g @contrail/cli
 $ contrail COMMAND
 running command...
 $ contrail (--version)
-@contrail/cli/3.5.0-alpha.11f30e6 linux-x64 node-v24.14.1
+@contrail/cli/3.5.0-alpha.9d881a5 linux-x64 node-v24.14.1
 $ contrail --help [COMMAND]
 USAGE
   $ contrail COMMAND

package/dist/api/dash0/spans.d.ts

@@ -1,12 +1,7 @@
 import { Dash0Client } from './client';
 import { AttributeFilter, FlatSpan, OtlpAttribute, OtlpResourceSpans, OtlpSpan, TimeReferenceRange } from './types';
 export declare function paginateSpans(client: Dash0Client, filter: AttributeFilter[], timeRange: TimeReferenceRange, limit?: number): AsyncGenerator<OtlpResourceSpans, void, void>;
-export interface SampledTrace {
-    traceId: string;
-    anchorNs: bigint;
-}
-export declare function sampleTraceIdsForAction(client: Dash0Client, actionIdentifier: string, timeRange: TimeReferenceRange, maxTraces: number): Promise<SampledTrace[]>;
-export declare function bracketWindowAround(anchorNs: bigint, halfWindowMin?: number): TimeReferenceRange;
+export declare function sampleTraceIdsForAction(client: Dash0Client, actionIdentifier: string, timeRange: TimeReferenceRange, maxTraces: number): Promise<string[]>;
 export declare function fetchTraceSpans(client: Dash0Client, traceIdHex: string, timeRange: TimeReferenceRange): Promise<FlatSpan[]>;
 export declare function toFlat(sp: OtlpSpan, resourceAttrs: Record<string, string | number | boolean>): FlatSpan;
 export declare function flattenAttrs(attrs: OtlpAttribute[]): Record<string, string | number | boolean>;

package/dist/api/dash0/spans.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.b64ToHex = exports.flattenAttrs = exports.toFlat = exports.fetchTraceSpans = exports.bracketWindowAround = exports.sampleTraceIdsForAction = exports.paginateSpans = void 0;
+exports.b64ToHex = exports.flattenAttrs = exports.toFlat = exports.fetchTraceSpans = exports.sampleTraceIdsForAction = exports.paginateSpans = void 0;
 const PAGE_LIMIT = 50;
 const MAX_PAGES_PER_QUERY = 200;
 async function* paginateSpans(client, filter, timeRange, limit = PAGE_LIMIT) {
@@ -21,8 +21,8 @@ async function* paginateSpans(client, filter, timeRange, limit = PAGE_LIMIT) {
 }
 exports.paginateSpans = paginateSpans;
 async function sampleTraceIdsForAction(client, actionIdentifier, timeRange, maxTraces) {
-    const seen = new Map();
-    outer: for await (const rs of paginateSpans(client, [
+    const seen = new Set();
+    for await (const rs of paginateSpans(client, [
         {
             key: 'contrail.event_workflow.action.identifier',
             operator: 'is',
@@ -31,33 +31,15 @@ async function sampleTraceIdsForAction(client, actionIdentifier, timeRange, maxT
     ], timeRange)) {
         for (const ss of rs.scopeSpans ?? []) {
             for (const sp of ss.spans ?? []) {
-                const traceId = b64ToHex(sp.traceId);
-                const startNs = BigInt(sp.startTimeUnixNano);
-                const existing = seen.get(traceId);
-                if (existing === undefined || startNs < existing) {
-                    seen.set(traceId, startNs);
-                }
+                seen.add(b64ToHex(sp.traceId));
                 if (seen.size >= maxTraces)
-                    break outer;
+                    return [...seen];
             }
         }
     }
-    return [...seen.entries()].map(([traceId, anchorNs]) => ({ traceId, anchorNs }));
+    return [...seen];
 }
 exports.sampleTraceIdsForAction = sampleTraceIdsForAction;
-// Build a Dash0 absolute time range bracketing a trace anchor. ±halfWindowMin
-// around the anchor in ISO RFC3339; resilient to clock drift between sample
-// and fetch and wide enough to capture the full trace.
-function bracketWindowAround(anchorNs, halfWindowMin = 5) {
-    const halfMs = BigInt(halfWindowMin) * 60000n;
-    const fromMs = Number((anchorNs - halfMs * 1000000n) / 1000000n);
-    const toMs = Number((anchorNs + halfMs * 1000000n) / 1000000n);
-    return {
-        from: new Date(fromMs).toISOString(),
-        to: new Date(toMs).toISOString(),
-    };
-}
-exports.bracketWindowAround = bracketWindowAround;
 async function fetchTraceSpans(client, traceIdHex, timeRange) {
     const out = [];
     for await (const rs of paginateSpans(client, [{ key: 'otel.trace.id', operator: 'is', value: traceIdHex }], timeRange)) {

package/dist/commands/event-workflows/assess-impact.js

@@ -60,24 +60,20 @@ class AssessImpact extends basecommand_1.BaseCommand {
         this.log(`Samples:   target ${samples}`);
         this.log('');
         this.log('Sampling trace IDs...');
-        const sampled = await (0, spans_1.sampleTraceIdsForAction)(client, identifier, timeRange, samples);
-        if (sampled.length === 0) {
+        const traceIds = await (0, spans_1.sampleTraceIdsForAction)(client, identifier, timeRange, samples);
+        if (traceIds.length === 0) {
             this.warn(`No spans found for action.identifier="${identifier}" in the last ${lookback}. ` +
                 'Verify the identifier and dataset.');
             return;
         }
-        this.log(`Got ${sampled.length} trace(s). Fetching subtrees...`);
+        this.log(`Got ${traceIds.length} trace(s). Fetching subtrees...`);
         const perTraceDescendants = [];
         const actionDurationsNs = [];
         let dropped = 0;
         let totalOrphans = 0;
         let preciseRootCount = 0;
-        for (const { traceId, anchorNs } of sampled) {
-            // Bracket each trace fetch on the absolute timestamp captured at sample
-            // time. Avoids sliding-window edge effects where a trace at the boundary
-            // of the lookback window has its earliest spans excluded.
-            const traceWindow = (0, spans_1.bracketWindowAround)(anchorNs);
-            const spans = await (0, spans_1.fetchTraceSpans)(client, traceId, traceWindow);
+        for (const traceId of traceIds) {
+            const spans = await (0, spans_1.fetchTraceSpans)(client, traceId, timeRange);
             const result = (0, subtree_1.extractActionSubtree)(spans, identifier);
             if (!result) {
                 dropped++;

package/dist/helpers/event-workflow-impact/subtree.js

@@ -83,17 +83,10 @@ function extractActionSubtree(spans, identifier) {
             queue.push({ spanId: c.spanId, depth: depth + 1, serverAncestors: childServerCount });
         }
     }
-    // An orphan is a span whose parent was never observed AND whose time range
-    // falls inside the action span's time range. Orphans outside that range are
-    // unrelated trace spans (siblings of the action's lineage) and shouldn't
-    // taint the propagation-gap warning.
     let orphanCount = 0;
     for (const s of spans) {
-        if (!s.parentSpanId || byId.has(s.parentSpanId))
-            continue;
-        if (s.startNs < actionSpan.startNs || s.startNs > actionSpan.endNs)
-            continue;
-        orphanCount++;
+        if (s.parentSpanId && !byId.has(s.parentSpanId))
+            orphanCount++;
     }
     return { descendants, actionSpan, preciseRoot, orphanCount };
 }

package/dist/helpers/event-workflow-impact/subtree.spec.js

@@ -88,48 +88,16 @@ describe('extractActionSubtree', () => {
             expect(ids).toEqual(['http1', 'nestedDdb']);
         });
     });
-    describe('orphan counting', () => {
-        it('counts orphans inside the action span time range', () => {
-            const spans = [
-                s({
-                    spanId: 'consumer',
-                    parentSpanId: '',
-                    startNs: 1000n,
-                    endNs: 9000n,
-                    attrs: { 'contrail.event_workflow.action.identifier': IDENT },
-                }),
-                // Inside [1000, 9000] with missing parent → counts.
-                s({
-                    spanId: 'innerOrphan',
-                    parentSpanId: 'missing',
-                    startNs: 5000n,
-                    endNs: 6000n,
-                }),
-            ];
-            const result = (0, subtree_1.extractActionSubtree)(spans, IDENT);
-            expect(result.orphanCount).toBe(1);
-        });
-        it('ignores orphans whose time falls outside the action span', () => {
-            const spans = [
-                s({
-                    spanId: 'consumer',
-                    parentSpanId: '',
-                    startNs: 1000n,
-                    endNs: 9000n,
-                    attrs: { 'contrail.event_workflow.action.identifier': IDENT },
-                }),
-                // Sibling-of-action lineage span. Real parent is unobserved (window
-                // edge effect) but its time is outside the action's range — noise,
-                // not a real propagation gap.
-                s({
-                    spanId: 'unrelated',
-                    parentSpanId: 'missing',
-                    startNs: 50000n,
-                    endNs: 60000n,
-                }),
-            ];
-            const result = (0, subtree_1.extractActionSubtree)(spans, IDENT);
-            expect(result.orphanCount).toBe(0);
-        });
+    it('counts orphans (parent_id pointing outside the trace)', () => {
+        const spans = [
+            s({
+                spanId: 'consumer',
+                parentSpanId: '',
+                attrs: { 'contrail.event_workflow.action.identifier': IDENT },
+            }),
+            s({ spanId: 'unattached', parentSpanId: 'missing-parent' }),
+        ];
+        const result = (0, subtree_1.extractActionSubtree)(spans, IDENT);
+        expect(result.orphanCount).toBe(1);
     });
 });

package/oclif.manifest.json

@@ -1,5 +1,5 @@
 {
-  "version": "3.5.0-alpha.11f30e6",
+  "version": "3.5.0-alpha.9d881a5",
   "commands": {
     "app:create": {
       "id": "app:create",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@contrail/cli",
-  "version": "3.5.0-alpha.11f30e6",
+  "version": "3.5.0-alpha.9d881a5",
   "description": "VibeIQ's Contrail Platform CLI.",
   "bin": {
     "contrail-cli": "./bin/run",