@contextfort-ai/openclaw-secure 0.1.4 → 0.1.5

package/monitor/skills_guard/index.js

@@ -83,6 +83,7 @@ module.exports = function createSkillsGuard({ readFileSync, httpsRequest, baseDi
 
   function readSkillFiles(skillPath) {
     const files = [];
+    const binaryFiles = [];
     const MAX_FILE_SIZE = 1 * 1024 * 1024; // 1MB
     const MAX_TOTAL_SIZE = 5 * 1024 * 1024; // 5MB
     let totalSize = 0;
@@ -91,7 +92,7 @@ module.exports = function createSkillsGuard({ readFileSync, httpsRequest, baseDi
       let entries;
       try { entries = fs.readdirSync(dirPath, { withFileTypes: true }); } catch { return; }
       for (const e of entries) {
-        if (e.name.startsWith('.')) continue; // skip hidden
+        if (e.name.startsWith('.') || e.name === 'node_modules') continue; // skip hidden and node_modules
         const full = path.join(dirPath, e.name);
         if (e.isDirectory()) {
           walk(full, path.join(base, e.name));
@@ -100,11 +101,14 @@ module.exports = function createSkillsGuard({ readFileSync, httpsRequest, baseDi
             const stat = fs.statSync(full);
             if (stat.size > MAX_FILE_SIZE || stat.size === 0) continue;
             if (totalSize + stat.size > MAX_TOTAL_SIZE) continue;
-            // Skip binaries: read first 512 bytes and check for null bytes
+            // Check for binaries: read first 512 bytes and check for null bytes
             const buf = Buffer.alloc(Math.min(512, stat.size));
             const fd = fs.openSync(full, 'r');
             try { fs.readSync(fd, buf, 0, buf.length, 0); } finally { fs.closeSync(fd); }
-            if (buf.includes(0)) continue; // binary file
+            if (buf.includes(0)) {
+              binaryFiles.push(path.join(base, e.name));
+              continue;
+            }
 
             const content = readFileSync(full, 'utf8');
             totalSize += stat.size;
@@ -114,7 +118,7 @@ module.exports = function createSkillsGuard({ readFileSync, httpsRequest, baseDi
       }
     }
     walk(skillPath, '');
-    return files;
+    return { files, binaryFiles };
   }
 
   function hashSkillFiles(files) {
@@ -219,14 +223,26 @@ module.exports = function createSkillsGuard({ readFileSync, httpsRequest, baseDi
   }
 
   function scanSkillIfChanged(skillPath) {
-    const files = readSkillFiles(skillPath);
-    if (files.length === 0) {
+    const { files, binaryFiles } = readSkillFiles(skillPath);
+    if (files.length === 0 && binaryFiles.length === 0) {
       // Skill was deleted or is empty — remove from flagged
       flaggedSkills.delete(skillPath);
       skillContentHashes.delete(skillPath);
       saveScanCache();
       return;
     }
+
+    // Flag immediately if binary files found — legitimate skills should not contain binaries
+    if (binaryFiles.length > 0) {
+      flaggedSkills.set(skillPath, {
+        suspicious: true,
+        reason: `Skill contains binary files (${binaryFiles.join(', ')}). Legitimate skills should only contain text files. Please delete these binary files or remove this skill.`,
+      });
+      track('skill_binary_detected', { skill_name: path.basename(skillPath), binary_count: binaryFiles.length });
+      saveScanCache();
+      return;
+    }
+
     const hash = hashSkillFiles(files);
     if (skillContentHashes.get(skillPath) === hash) return; // unchanged
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@contextfort-ai/openclaw-secure",
-  "version": "0.1.4",
+  "version": "0.1.5",
   "description": "Runtime security guard for OpenClaw — blocks malicious commands before they execute",
   "bin": {
     "openclaw-secure": "./bin/openclaw-secure.js"