@contentgrowth/llm-service 0.6.2 → 0.6.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@contentgrowth/llm-service",
-  "version": "0.6.2",
+  "version": "0.6.4",
   "description": "Unified LLM Service for Content Growth",
   "main": "src/index.js",
   "type": "module",

package/src/llm/json-utils.js

@@ -12,6 +12,19 @@ export function extractJsonFromResponse(text) {
     return null;
   }
 
+  // Helper to sanitize JSON strings with unescaped control characters
+  function sanitizeJsonString(str) {
+    // Find all JSON strings: "..."
+    // Handle escaped quotes \" and backslashes \\
+    return str.replace(/"(?:[^"\\]|\\.)*"/g, (match) => {
+      // Replace unescaped control characters inside the string
+      return match
+        .replace(/\n/g, "\\n")
+        .replace(/\r/g, "\\r")
+        .replace(/\t/g, "\\t");
+    });
+  }
+
   // Helper function to attempt JSON parsing with escape sequence normalization
   function tryParseJson(jsonStr) {
     // First, try to parse as-is
@@ -36,10 +49,16 @@ export function extractJsonFromResponse(text) {
         } catch (e2) {
           // Log this failure too
           console.warn('Normalized JSON parse also failed:', e2.message);
-          throw e; // Throw original error
+          // Fall through to sanitization
         }
-      } else {
-        // No over-escaping pattern detected, throw original error
+      }
+
+      // Try sanitizing unescaped control characters (common LLM error)
+      try {
+        const sanitized = sanitizeJsonString(jsonStr);
+        return JSON.parse(sanitized);
+      } catch (e3) {
+        // If all attempts fail, throw the original error
         throw e;
       }
     }

package/src/llm/providers/gemini-provider.js

@@ -130,13 +130,30 @@ export class GeminiProvider extends BaseLLMProvider {
         const response = result.response;
         const toolCalls = response.functionCalls();
 
+        let textContent = '';
+        try {
+            textContent = response.text();
+        } catch (e) {
+            // response.text() throws if there is no text content (e.g. only tool calls)
+            // This is expected behavior for tool-only responses
+        }
+        // Validate that we have EITHER content OR tool calls
+        if (!textContent && (!toolCalls || toolCalls.length === 0)) {
+            console.error('[GeminiProvider] Model returned empty response (no text, no tool calls)');
+            console.error('[GeminiProvider] Last message:', JSON.stringify(lastMessage, null, 2));
+            throw new LLMServiceException(
+                'Model returned empty response. This usually means the prompt or schema is confusing the model.',
+                500
+            );
+        }
+
         // Return with parsed JSON if applicable
         return {
-            content: response.text(),
+            content: textContent,
             tool_calls: toolCalls ? toolCalls.map(fc => ({ type: 'function', function: fc })) : null,
             _responseFormat: options.responseFormat,
             ...(options.responseFormat && this._shouldAutoParse(options) ? {
-                parsedContent: this._safeJsonParse(response.text())
+                parsedContent: this._safeJsonParse(textContent)
             } : {})
         };
     }

package/src/llm/providers/openai-provider.js

@@ -1,6 +1,7 @@
 import OpenAI from 'openai';
 import { BaseLLMProvider } from './base-provider.js';
 import { extractJsonFromResponse } from '../json-utils.js';
+import { LLMServiceException } from '../../llm-service.js';
 
 export class OpenAIProvider extends BaseLLMProvider {
     constructor(config) {
@@ -58,6 +59,15 @@ export class OpenAIProvider extends BaseLLMProvider {
         const response = await this.client.chat.completions.create(requestPayload);
         const message = response.choices[0].message;
 
+        // Validate that we have EITHER content OR tool calls
+        if (!message.content && (!message.tool_calls || message.tool_calls.length === 0)) {
+            console.error('[OpenAIProvider] Model returned empty response (no text, no tool calls)');
+            throw new LLMServiceException(
+                'Model returned empty response. This usually means the prompt or schema is confusing the model.',
+                500
+            );
+        }
+
         // Return with parsed JSON if applicable
         return {
             content: message.content,