@contentful/field-editor-reference 4.3.7 → 4.3.8

package/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [4.3.8](https://github.com/contentful/field-editors/compare/@contentful/field-editor-reference@4.3.7...@contentful/field-editor-reference@4.3.8) (2022-06-15)
+
+### Bug Fixes
+
+- don't register onClick callbacks when isClickable is false ([#1163](https://github.com/contentful/field-editors/issues/1163)) ([fe6fc6b](https://github.com/contentful/field-editors/commit/fe6fc6b872acfde3b097c626d2eef81a7cc24193))
+
 ## [4.3.7](https://github.com/contentful/field-editors/compare/@contentful/field-editor-reference@4.3.6...@contentful/field-editor-reference@4.3.7) (2022-06-07)
 
 ### Bug Fixes

package/dist/field-editor-reference.cjs.development.js

@@ -2568,12 +2568,15 @@ function WrappedEntryCard(props) {
     }, "Move to bottom") : null].filter(function (item) {
       return item;
     }) : [],
-    onClick: function onClick(e) {
+    onClick: // Providing an onClick handler messes up with some rich text
+    // features e.g. pressing ENTER on a card to add a new paragraph
+    // underneath. It's crucial not to pass a custom handler when
+    // isClickable is disabled which in the case of RT it's.
+    props.isClickable ? function (e) {
       e.preventDefault();
-      if (!props.isClickable) return;
       if (props.onClick) return props.onClick(e);
       props.onEdit && props.onEdit();
-    }
+    } : undefined
   });
 }
 WrappedEntryCard.defaultProps = defaultProps;
@@ -3104,11 +3107,14 @@ var WrappedAssetCard = function WrappedAssetCard(props) {
       testId: "schedule-icon"
     })),
     src: entityFile && entityFile.url ? size === 'small' ? entityFile.url + "?w=150&h=150&fit=thumb" : entityFile.url + "?h=300" : '',
-    onClick: function onClick(e) {
+    onClick: // Providing an onClick handler messes up with some rich text
+    // features e.g. pressing ENTER on a card to add a new paragraph
+    // underneath. It's crucial not to pass a custom handler when
+    // isClickable is disabled which in the case of RT it's.
+    isClickable ? function (e) {
       e.preventDefault();
-      if (!isClickable) return;
       onEdit && onEdit();
-    },
+    } : undefined,
     dragHandleRender: props.renderDragHandle,
     withDragHandle: !!props.renderDragHandle,
     actions: [].concat(renderActions({