@contentful/field-editor-reference 4.3.7 → 4.3.10

package/CHANGELOG.md

@@ -3,6 +3,20 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [4.3.10](https://github.com/contentful/field-editors/compare/@contentful/field-editor-reference@4.3.9...@contentful/field-editor-reference@4.3.10) (2022-06-22)
+
+**Note:** Version bump only for package @contentful/field-editor-reference
+
+## [4.3.9](https://github.com/contentful/field-editors/compare/@contentful/field-editor-reference@4.3.8...@contentful/field-editor-reference@4.3.9) (2022-06-21)
+
+**Note:** Version bump only for package @contentful/field-editor-reference
+
+## [4.3.8](https://github.com/contentful/field-editors/compare/@contentful/field-editor-reference@4.3.7...@contentful/field-editor-reference@4.3.8) (2022-06-15)
+
+### Bug Fixes
+
+- don't register onClick callbacks when isClickable is false ([#1163](https://github.com/contentful/field-editors/issues/1163)) ([fe6fc6b](https://github.com/contentful/field-editors/commit/fe6fc6b872acfde3b097c626d2eef81a7cc24193))
+
 ## [4.3.7](https://github.com/contentful/field-editors/compare/@contentful/field-editor-reference@4.3.6...@contentful/field-editor-reference@4.3.7) (2022-06-07)
 
 ### Bug Fixes

package/dist/field-editor-reference.cjs.development.js

@@ -1548,7 +1548,8 @@ function useLinkActionsProps(props) {
       slide: slide,
       index: index
     });
-  }, [entityType, props.onCreate, props.onAction]);
+  }, // eslint-disable-next-line react-hooks/exhaustive-deps -- TODO: Evaluate the dependencies
+  [entityType, props.onCreate, props.onAction]);
   var onLinkedExisting = React.useCallback(function (entities, index) {
     if (index === void 0) {
       index = itemsLength;
@@ -1565,7 +1566,8 @@ function useLinkActionsProps(props) {
         index: index === undefined ? undefined : index + i
       });
     });
-  }, [entityType, props.onLink, props.onAction]);
+  }, // eslint-disable-next-line react-hooks/exhaustive-deps -- TODO: Evaluate the dependencies
+  [entityType, props.onLink, props.onAction]);
   var onCreate = React.useCallback( /*#__PURE__*/function () {
     var _ref = _asyncToGenerator( /*#__PURE__*/runtime_1.mark(function _callee(contentTypeId, index) {
       var _yield$createEntity, entity, slide;
@@ -1687,7 +1689,7 @@ function useLinkActionsProps(props) {
     return function onLinkSeveralExisting(_x4) {
       return _ref3.apply(this, arguments);
     };
-  }(); // FIXME: The memoization might rerun every time due to the always changing callback identities above 
+  }(); // FIXME: The memoization might rerun every time due to the always changing callback identities above
 
 
   return React.useMemo(function () {
@@ -1707,7 +1709,9 @@ function useLinkActionsProps(props) {
       onLinkedExisting: onLinkedExisting,
       itemsLength: itemsLength
     };
-  }, [entityType, canLinkMultiple, isDisabled, isEmpty, isFull, editorPermissions.canCreateEntity, editorPermissions.canLinkEntity, actionLabels, editorPermissions.creatableContentTypes.map(function (ct) {
+  }, // eslint-disable-next-line react-hooks/exhaustive-deps -- TODO: Evaluate the dependencies
+  [entityType, canLinkMultiple, isDisabled, isEmpty, isFull, editorPermissions.canCreateEntity, editorPermissions.canLinkEntity, actionLabels, // eslint-disable-next-line react-hooks/exhaustive-deps -- TODO: Evaluate the dependencies
+  editorPermissions.creatableContentTypes.map(function (ct) {
     return ct.sys.id;
   }).join(':'), onCreate, onLinkExisting, onLinkSeveralExisting, onCreated, onLinkedExisting, itemsLength]);
 }
@@ -1721,7 +1725,7 @@ function LinkEntityActions(_ref4) {
   return renderLinkActions(props);
 }
 
-// eslint-disable-next-line no-restricted-imports
+// eslint-disable-next-line -- TODO: describe this disable  no-restricted-imports
 /**
  * @param {Date|string} date A valid constructor argument for moment()
  * @param {boolean=} short Render only Today/Tomorrow/Yesterday if valid. Defaults to false
@@ -1801,7 +1805,7 @@ var ScheduledIconWithTooltip = function ScheduledIconWithTooltip(_ref) {
       });
     }); // This should only be ever called once. Following the eslint hint to add used
     // dependencies will cause page freeze (infinite loop)
-    // eslint-disable-next-line
+    // eslint-disable-next-line -- TODO: describe this disable
   }, []);
 
   if (status.type === 'loading' || status.type === 'error') {
@@ -1997,7 +2001,7 @@ function useEntitiesStore(props) {
           }
         });
       }
-    });
+    }); // eslint-disable-next-line react-hooks/exhaustive-deps -- TODO: Evaluate the dependencies
   }, [props.sdk, state.assets, state.entries]);
   return _extends({
     getOrLoadEntry: getOrLoadEntry,
@@ -2179,7 +2183,7 @@ function useContentTypePermissions(props) {
       return _checkContentTypeAccess.apply(this, arguments);
     }
 
-    void checkContentTypeAccess();
+    void checkContentTypeAccess(); // eslint-disable-next-line react-hooks/exhaustive-deps -- TODO: Evaluate the dependencies
   }, [availableContentTypes]);
   return {
     creatableContentTypes: creatableContentTypes,
@@ -2191,7 +2195,7 @@ function useContentTypePermissions(props) {
 function fromFieldValidations(field) {
   var _field$items$validati, _field$items, _linkContentTypeValid, _linkMimetypeGroupVal;
 
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  // eslint-disable-next-line -- TODO: describe this disable  @typescript-eslint/no-explicit-any
   var validations = [].concat(field.validations, (_field$items$validati = (_field$items = field.items) == null ? void 0 : _field$items.validations) != null ? _field$items$validati : []);
   var linkContentTypeValidations = validations.find(function (v) {
     return 'linkContentType' in v;
@@ -2319,7 +2323,7 @@ function useEditorPermissions(props) {
       return _checkCreateAccess.apply(this, arguments);
     }
 
-    void checkCreateAccess();
+    void checkCreateAccess(); // eslint-disable-next-line react-hooks/exhaustive-deps -- TODO: Evaluate the dependencies
   }, [entityType, parameters.instance, creatableContentTypes]);
   React.useEffect(function () {
     if (parameters.instance.showLinkEntityAction === false) {
@@ -2381,7 +2385,7 @@ function useEditorPermissions(props) {
       return _checkLinkAccess.apply(this, arguments);
     }
 
-    void checkLinkAccess();
+    void checkLinkAccess(); // eslint-disable-next-line react-hooks/exhaustive-deps -- TODO: Evaluate the dependencies
   }, [entityType, parameters.instance, readableContentTypes]);
   return {
     canCreateEntity: canCreateEntity,
@@ -2425,7 +2429,8 @@ function Editor(props) {
 
   var customCardRenderer = React.useCallback(function (cardProps, _, renderDefaultCard) {
     return props.renderCustomCard ? props.renderCustomCard(cardProps, linkActionsProps, renderDefaultCard) : false;
-  }, [linkActionsProps]);
+  }, // eslint-disable-next-line react-hooks/exhaustive-deps -- TODO: Evaluate the dependencies
+  [linkActionsProps]);
 
   if (!props.entityId) {
     return React.createElement(LinkEntityActions, Object.assign({
@@ -2568,12 +2573,15 @@ function WrappedEntryCard(props) {
     }, "Move to bottom") : null].filter(function (item) {
       return item;
     }) : [],
-    onClick: function onClick(e) {
+    onClick: // Providing an onClick handler messes up with some rich text
+    // features e.g. pressing ENTER on a card to add a new paragraph
+    // underneath. It's crucial not to pass a custom handler when
+    // isClickable is disabled which in the case of RT it's.
+    props.isClickable ? function (e) {
       e.preventDefault();
-      if (!props.isClickable) return;
       if (props.onClick) return props.onClick(e);
       props.onEdit && props.onEdit();
-    }
+    } : undefined
   });
 }
 WrappedEntryCard.defaultProps = defaultProps;
@@ -2641,7 +2649,7 @@ function FetchingWrappedEntryCard(props) {
       entries = _useEntities.entries;
 
   React.useEffect(function () {
-    getOrLoadEntry(props.entryId);
+    getOrLoadEntry(props.entryId); // eslint-disable-next-line react-hooks/exhaustive-deps -- TODO: Evaluate the dependencies
   }, [props.entryId]);
   var size = props.viewType === 'link' ? 'small' : 'default';
   var entry = entries[props.entryId];
@@ -2699,7 +2707,8 @@ function FetchingWrappedEntryCard(props) {
         type: 'rendered',
         entity: 'Entry'
       });
-    }
+    } // eslint-disable-next-line react-hooks/exhaustive-deps -- TODO: Evaluate the dependencies
+
   }, [entry]);
   return React.useMemo(function () {
     if (entry === 'failed') {
@@ -2773,7 +2782,7 @@ function FetchingWrappedEntryCard(props) {
       }
     }
 
-    return renderDefaultCard();
+    return renderDefaultCard(); // eslint-disable-next-line react-hooks/exhaustive-deps -- TODO: Evaluate the dependencies
   }, [props, entityKey]);
 }
 
@@ -2872,7 +2881,8 @@ function Editor$1(props) {
   }));
   var customCardRenderer = React.useCallback(function (cardProps, _, renderDefaultCard) {
     return props.renderCustomCard ? props.renderCustomCard(cardProps, linkActionsProps, renderDefaultCard) : false;
-  }, [linkActionsProps]);
+  }, // eslint-disable-next-line react-hooks/exhaustive-deps -- TODO: Evaluate the dependencies
+  [linkActionsProps]);
   return React.createElement(React.Fragment, null, props.children(_extends({}, props, {
     onSortStart: onSortStart,
     onSortEnd: onSortEnd,
@@ -3043,7 +3053,7 @@ var styles$3 = {
 };
 var defaultProps$1 = {
   isClickable: true
-}; // eslint-disable-next-line @typescript-eslint/no-explicit-any
+}; // eslint-disable-next-line -- TODO: describe this disable  @typescript-eslint/no-explicit-any
 
 function getFileType(file) {
   if (!file) {
@@ -3104,11 +3114,14 @@ var WrappedAssetCard = function WrappedAssetCard(props) {
       testId: "schedule-icon"
     })),
     src: entityFile && entityFile.url ? size === 'small' ? entityFile.url + "?w=150&h=150&fit=thumb" : entityFile.url + "?h=300" : '',
-    onClick: function onClick(e) {
+    onClick: // Providing an onClick handler messes up with some rich text
+    // features e.g. pressing ENTER on a card to add a new paragraph
+    // underneath. It's crucial not to pass a custom handler when
+    // isClickable is disabled which in the case of RT it's.
+    isClickable ? function (e) {
       e.preventDefault();
-      if (!isClickable) return;
       onEdit && onEdit();
-    },
+    } : undefined,
     dragHandleRender: props.renderDragHandle,
     withDragHandle: !!props.renderDragHandle,
     actions: [].concat(renderActions({
@@ -3201,7 +3214,7 @@ function FetchingWrappedAssetCard(props) {
       assets = _useEntities.assets;
 
   React.useEffect(function () {
-    getOrLoadAsset(props.assetId);
+    getOrLoadAsset(props.assetId); // eslint-disable-next-line react-hooks/exhaustive-deps -- TODO: Evaluate the dependencies
   }, [props.assetId]);
   var asset = assets[props.assetId];
   var entityKey = asset === 'failed' ? 'failed' : asset === undefined ? 'undefined' : ":" + asset.sys.id + ":" + asset.sys.version;
@@ -3211,7 +3224,8 @@ function FetchingWrappedAssetCard(props) {
         type: 'rendered',
         entity: 'Asset'
       });
-    }
+    } // eslint-disable-next-line react-hooks/exhaustive-deps -- TODO: Evaluate the dependencies
+
   }, [asset]);
 
   var onEdit = /*#__PURE__*/function () {
@@ -3343,7 +3357,7 @@ function FetchingWrappedAssetCard(props) {
       }
     }
 
-    return renderDefaultCard();
+    return renderDefaultCard(); // eslint-disable-next-line react-hooks/exhaustive-deps -- TODO: Evaluate the dependencies
   }, [props, entityKey]);
 }