@contentful/field-editor-reference 4.3.1 → 4.3.4

package/CHANGELOG.md

@@ -3,6 +3,25 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [4.3.4](https://github.com/contentful/field-editors/compare/@contentful/field-editor-reference@4.3.3...@contentful/field-editor-reference@4.3.4) (2022-05-06)
+
+### Bug Fixes
+
+- add a explanatory comment why we removed useCallback ([4359666](https://github.com/contentful/field-editors/commit/435966687e8e803f7e4fb20f2f7d89101d2fd20a))
+- do not use callback ([811bcfd](https://github.com/contentful/field-editors/commit/811bcfda4a0fadf0701b2d6e712d1871290ebdcb))
+
+## [4.3.3](https://github.com/contentful/field-editors/compare/@contentful/field-editor-reference@4.3.2...@contentful/field-editor-reference@4.3.3) (2022-05-03)
+
+### Bug Fixes
+
+- avoid disabling button if no creatable content type ([#1132](https://github.com/contentful/field-editors/issues/1132)) ([72c7b97](https://github.com/contentful/field-editors/commit/72c7b97019d4a1915fd295592f0724f7be08d424))
+
+## [4.3.2](https://github.com/contentful/field-editors/compare/@contentful/field-editor-reference@4.3.1...@contentful/field-editor-reference@4.3.2) (2022-04-29)
+
+### Bug Fixes
+
+- use creatableContentTypes for create access check ([#1131](https://github.com/contentful/field-editors/issues/1131)) ([5fcf527](https://github.com/contentful/field-editors/commit/5fcf527609605140564eb0ba172c8877b882ebdc))
+
 ## [4.3.1](https://github.com/contentful/field-editors/compare/@contentful/field-editor-reference@4.3.0...@contentful/field-editor-reference@4.3.1) (2022-04-28)
 
 ### Bug Fixes

package/dist/field-editor-reference.cjs.development.js

@@ -362,7 +362,7 @@ var CreateEntryLinkButton = function CreateEntryLinkButton(_ref) {
       endIcon: hasDropdown ? React__default.createElement(f36Icons.ChevronDownIcon, null) : undefined,
       variant: "secondary",
       className: styles.action,
-      isDisabled: disabled || isSelecting || contentTypes && contentTypes.length === 0,
+      isDisabled: disabled || isSelecting,
       startIcon: isSelecting ? undefined : plusIcon,
       size: "small",
       testId: "create-entry-link-button",
@@ -1607,8 +1607,9 @@ function useLinkActionsProps(props) {
     return function (_x, _x2) {
       return _ref.apply(this, arguments);
     };
-  }(), [sdk, entityType, onCreated]);
-  var onLinkExisting = React.useCallback( /*#__PURE__*/function () {
+  }(), [sdk, entityType, onCreated]); // Wrapping these two with useCallback caused a bug [ZEND-2154] where CTs were not propagated to the UI at all
+
+  var onLinkExisting = /*#__PURE__*/function () {
     var _ref2 = _asyncToGenerator( /*#__PURE__*/runtime_1.mark(function _callee2(index) {
       var entity;
       return runtime_1.wrap(function _callee2$(_context2) {
@@ -1643,11 +1644,12 @@ function useLinkActionsProps(props) {
       }, _callee2);
     }));
 
-    return function (_x3) {
+    return function onLinkExisting(_x3) {
       return _ref2.apply(this, arguments);
     };
-  }(), [sdk, entityType, onLinkedExisting]);
-  var onLinkSeveralExisting = React.useCallback( /*#__PURE__*/function () {
+  }();
+
+  var onLinkSeveralExisting = /*#__PURE__*/function () {
     var _ref3 = _asyncToGenerator( /*#__PURE__*/runtime_1.mark(function _callee3(index) {
       var entities;
       return runtime_1.wrap(function _callee3$(_context3) {
@@ -1682,10 +1684,12 @@ function useLinkActionsProps(props) {
       }, _callee3);
     }));
 
-    return function (_x4) {
+    return function onLinkSeveralExisting(_x4) {
       return _ref3.apply(this, arguments);
     };
-  }(), [sdk, entityType, onLinkedExisting]);
+  }(); // FIXME: The memoization might rerun every time due to the always changing callback identities above 
+
+
   return React.useMemo(function () {
     return {
       entityType: entityType,
@@ -2294,7 +2298,7 @@ function useEditorPermissions(props) {
                 if (entityType === 'Entry') {
                   // Hardcoded `true` value following https://contentful.atlassian.net/browse/DANTE-486
                   // TODO: refine permissions check in order to account for tags in rules
-                  _canCreate = readableContentTypes.length > 0 || true;
+                  _canCreate = creatableContentTypes.length > 0 || true;
                   setCanCreateEntity(_canCreate);
                 }