@contentful/experience-design-system-cli 2.11.4-dev-build-7abd382.0 → 2.11.4-dev-build-601ef74.0

package/dist/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@contentful/experience-design-system-cli",
-  "version": "2.11.4-dev-build-7abd382.0",
+  "version": "2.11.4-dev-build-601ef74.0",
   "description": "Contentful Experiences design system import CLI",
   "license": "MIT",
   "type": "module",

package/dist/src/analyze/command.js

@@ -196,6 +196,15 @@ export function registerAnalyzeCommand(program) {
         db.close();
         const allWarnings = [...extraction.warnings, ...filterWarnings];
         const { rows: componentRows, totalErrors } = buildAnalyzeViewRows(filteredComponents, validatedComponents, allWarnings);
+        // Split warnings: per-component (those whose prefix matches a surviving component name)
+        // are rendered under that component in the TUI; global ones (retry summaries,
+        // non-authorable skips, anything else) are rendered at the top of the warnings panel
+        // so they don't disappear into the count.
+        const componentNames = new Set(componentRows.map((r) => r.name));
+        const globalWarnings = allWarnings.filter((w) => {
+            const prefix = w.split(':', 1)[0]?.trim();
+            return !prefix || !componentNames.has(prefix);
+        });
         const analyzeResult = {
             sourceDirectory,
             sessionId,
@@ -203,6 +212,7 @@ export function registerAnalyzeCommand(program) {
             components: componentRows,
             totalWarnings: allWarnings.length,
             totalErrors,
+            globalWarnings,
         };
         if (process.stdout.isTTY) {
             const { waitUntilExit } = render(createElement(AnalyzeView, {

package/dist/src/analyze/extract/svelte.js

@@ -202,10 +202,11 @@ async function retryComponentWithProject(component, ctx, project, warnings) {
     }
     if (!members || members.length === 0)
         return false;
-    // If the only members are Snippet-typed (the partial-heritage signal that
-    // tripped the original warning), we haven't actually recovered useful props.
-    if (members.every((m) => m.isSnippet))
-        return false;
+    // If the resolver returned a complete member list — even when it's
+    // Snippet-only — that's a real answer, not a partial one. Apply it and
+    // drop `props-type-unresolved`. Whether the resulting component still
+    // needs review will be decided by the standard heuristics
+    // (no-props-or-slots, infra-fetch, etc.) downstream.
     const { props, snippetSlots } = extractFromTypeMembersOnly(members);
     // Merge any template <slot> entries that survived the original pass — we
     // can't easily re-derive those without re-parsing the fragment, but the
@@ -218,7 +219,9 @@ async function retryComponentWithProject(component, ctx, project, warnings) {
     const slotNames = new Set(finalSlots.map((s) => s.name));
     component.props = props.filter((p) => !slotNames.has(p.name));
     component.slots = finalSlots;
-    // Drop props-type-unresolved from reasons; recompute confidence.
+    // Drop `props-type-unresolved` from reasons: the type DID resolve. Other
+    // heuristics (no-props-or-slots, infra-fetch, etc.) decide whether the
+    // recovered component still needs review.
     const remainingReasons = (component.reviewReasons ?? []).filter((r) => r !== 'props-type-unresolved');
     const score = computeExtractionScore(component, {
         additionalIssueCount: remainingReasons.length,
@@ -227,8 +230,7 @@ async function retryComponentWithProject(component, ctx, project, warnings) {
     component.extractionConfidence = score.confidence;
     component.reviewReasons = score.reasons;
     component.needsReview = deriveNeedsReview(score.confidence);
-    // Remove the per-component unresolved-type warning so it doesn't muddy the
-    // summary line / TUI grouping after recovery.
+    // Remove the per-component unresolved-type warning — recovery is complete.
     const componentName = component.name;
     const idx = warnings.findIndex((w) => w.startsWith(`${componentName}: declared Props type `) && /resolved to /.test(w));
     if (idx >= 0)
@@ -461,22 +463,26 @@ function extractTypesFromExports(exportsField) {
  * When a large fraction of components emit the same `declared Props type ...
  * resolved to ... properties` warning (typical of headless libraries like
  * skeleton-svelte that extend types from external packages we can't reach),
- * collapse them into a single summary line at the top + the per-component
- * details below. Per-component reviewReasons and needsReview stay intact;
- * this only affects the warnings array's readability.
+ * replace ALL of them with a single summary line. Per-component
+ * reviewReasons + needsReview flags stay intact, so the user can still
+ * drill into any individual component to see the issue — we just don't
+ * flood the top-level warnings panel with N near-identical lines.
  *
  * Threshold: 3 or more identical-shape warnings. Below that, the literal
- * per-component lines are clearer than a summary.
+ * per-component lines are short enough to keep as-is.
  */
 function collapseUnresolvedTypeWarnings(warnings) {
     const isUnresolvedWarning = (w) => /declared Props type .* resolved to/.test(w);
-    const unresolved = warnings.filter(isUnresolvedWarning);
-    if (unresolved.length < 3)
+    const unresolvedCount = warnings.filter(isUnresolvedWarning).length;
+    if (unresolvedCount < 3)
         return warnings;
-    const summary = `Unresolved component types: ${unresolved.length} components have a declared Props type the parser couldn't fully resolve — ` +
+    const others = warnings.filter((w) => !isUnresolvedWarning(w));
+    const summary = `Unresolved component types: ${unresolvedCount} components have a declared Props type the parser couldn't fully resolve — ` +
         `most often a cross-package extends pattern (e.g. an interface that extends a type from a node_modules package). ` +
+        `Each affected component is flagged with reviewReasons: ['props-type-unresolved'] and needsReview = true; ` +
+        `select one in the TUI to drill in. ` +
         `See https://github.com/contentful/experience-design-system-sdk-public/pull/44 for context and partner workarounds.`;
-    return [summary, ...warnings];
+    return [summary, ...others];
 }
 async function extractFromSvelteFile(filePath, source) {
     const warnings = [];

package/dist/src/analyze/tui/AnalyzeView.d.ts

@@ -21,6 +21,15 @@ export type AnalyzeViewResult = {
     }>;
     totalWarnings: number;
     totalErrors: number;
+    /**
+     * Top-level warnings not associated with any surviving component:
+     *   - retry-pass summary lines
+     *   - "Skipped non-authorable component: …" — the component was filtered out and has no row to attach to
+     *   - any other extractor warning whose prefix doesn't match a component in `components`
+     * Always rendered at the top of the Warnings panel so they're visible in the TUI.
+     * Optional for backwards compatibility with older fixtures; treated as `[]` when absent.
+     */
+    globalWarnings?: string[];
 };
 type AnalyzeViewProps = {
     result: AnalyzeViewResult;

package/dist/src/analyze/tui/AnalyzeView.js

@@ -57,8 +57,8 @@ export function AnalyzeView({ result, onExit }) {
                     }), showScrollDown && _jsx(Text, { dimColor: true, children: " \u25BC scroll down" }), result.totalErrors > 0 && (_jsxs(_Fragment, { children: [_jsx(Text, { children: " " }), _jsx(Text, { dimColor: true, children: '─'.repeat(70) }), _jsx(Text, { bold: true, color: "red", children: 'Errors (' + result.totalErrors + ')' }), _jsx(Text, { dimColor: true, children: '─'.repeat(70) }), _jsx(Text, { children: " " }), result.components
                                 .filter((c) => c.errors.length > 0)
                                 .flatMap((c) => c.errors.map((e) => ({ component: c.name, error: e })))
-                                .map((e, i) => (_jsx(Text, { color: "red", children: '  ✗ ' + e.component + ': ' + e.error }, i)))] })), result.totalWarnings > 0 && (_jsxs(_Fragment, { children: [_jsx(Text, { children: " " }), _jsx(Text, { dimColor: true, children: '─'.repeat(70) }), _jsx(Text, { bold: true, color: "yellow", children: 'Warnings (' + result.totalWarnings + ')' }), _jsx(Text, { dimColor: true, children: '─'.repeat(70) }), _jsx(Text, { children: " " }), result.components
+                                .map((e, i) => (_jsx(Text, { color: "red", children: '  ✗ ' + e.component + ': ' + e.error }, i)))] })), result.totalWarnings > 0 && (_jsxs(_Fragment, { children: [_jsx(Text, { children: " " }), _jsx(Text, { dimColor: true, children: '─'.repeat(70) }), _jsx(Text, { bold: true, color: "yellow", children: 'Warnings (' + result.totalWarnings + ')' }), _jsx(Text, { dimColor: true, children: '─'.repeat(70) }), _jsx(Text, { children: " " }), (result.globalWarnings ?? []).map((w, i) => (_jsx(Text, { color: "yellow", children: '  ⚠ ' + w }, `g${i}`))), result.components
                                 .filter((c) => c.warnings.length > 0)
                                 .flatMap((c) => c.warnings.map((w) => ({ component: c.name, warning: w })))
-                                .map((w, i) => (_jsx(Text, { color: "yellow", children: '  ⚠ ' + w.component + ': ' + w.warning }, i)))] })), _jsx(Text, { children: " " }), _jsx(Text, { dimColor: true, children: 'Run: analyze select --session ' + result.sessionId }), _jsx(Text, { children: " " })] }), _jsx(Box, { borderStyle: "single", paddingX: 1, children: _jsx(Text, { dimColor: true, children: "Press Enter or q to exit" }) })] }));
+                                .map((w, i) => (_jsx(Text, { color: "yellow", children: '  ⚠ ' + (w.warning.startsWith(w.component + ': ') ? w.warning : w.component + ': ' + w.warning) }, `c${i}`)))] })), _jsx(Text, { children: " " }), _jsx(Text, { dimColor: true, children: 'Run: analyze select --session ' + result.sessionId }), _jsx(Text, { children: " " })] }), _jsx(Box, { borderStyle: "single", paddingX: 1, children: _jsx(Text, { dimColor: true, children: "Press Enter or q to exit" }) })] }));
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@contentful/experience-design-system-cli",
-  "version": "2.11.4-dev-build-7abd382.0",
+  "version": "2.11.4-dev-build-601ef74.0",
   "description": "Contentful Experiences design system import CLI",
   "license": "MIT",
   "type": "module",
@@ -37,7 +37,7 @@
     "svelte": "^5.56.4",
     "ts-morph": "^27.0.2",
     "typescript": "^5.9.3",
-    "@contentful/experience-design-system-types": "2.11.4-dev-build-7abd382.0"
+    "@contentful/experience-design-system-types": "2.11.4-dev-build-601ef74.0"
   },
   "devDependencies": {
     "@tsconfig/node24": "^24.0.3",