@contentful/experience-design-system-cli 2.11.4-dev-build-3c16094.0 → 2.11.4-dev-build-3e1df30.0

package/dist/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@contentful/experience-design-system-cli",
-  "version": "2.11.4-dev-build-3c16094.0",
+  "version": "2.11.4-dev-build-3e1df30.0",
   "description": "Contentful Experiences design system import CLI",
   "license": "MIT",
   "type": "module",

package/dist/src/analyze/extract/svelte.js

@@ -202,12 +202,11 @@ async function retryComponentWithProject(component, ctx, project, warnings) {
     }
     if (!members || members.length === 0)
         return false;
-    // Snippet-only resolution is still useful — it confirms the slot surface
-    // and lets us replace the original (which may have had fewer slot entries
-    // because the cold AST-only pass missed members declared in heritage).
-    // Apply the recovered slots, but DON'T drop `props-type-unresolved` from
-    // reasons (the prop side genuinely has no resolvable members).
-    const onlySnippets = members.every((m) => m.isSnippet);
+    // If the resolver returned a complete member list — even when it's
+    // Snippet-only — that's a real answer, not a partial one. Apply it and
+    // drop `props-type-unresolved`. Whether the resulting component still
+    // needs review will be decided by the standard heuristics
+    // (no-props-or-slots, infra-fetch, etc.) downstream.
     const { props, snippetSlots } = extractFromTypeMembersOnly(members);
     // Merge any template <slot> entries that survived the original pass — we
     // can't easily re-derive those without re-parsing the fragment, but the
@@ -220,23 +219,18 @@ async function retryComponentWithProject(component, ctx, project, warnings) {
     const slotNames = new Set(finalSlots.map((s) => s.name));
     component.props = props.filter((p) => !slotNames.has(p.name));
     component.slots = finalSlots;
-    // Recompute confidence. When only Snippets came back, keep the
-    // `props-type-unresolved` reason — slot surface is real but the prop side
-    // is still legitimately unresolved (the extends-from-node_modules failed).
-    // When real props came back, drop the reason: full recovery.
-    const remainingReasons = onlySnippets
-        ? (component.reviewReasons ?? [])
-        : (component.reviewReasons ?? []).filter((r) => r !== 'props-type-unresolved');
+    // Drop `props-type-unresolved` from reasons: the type DID resolve. Other
+    // heuristics (no-props-or-slots, infra-fetch, etc.) decide whether the
+    // recovered component still needs review.
+    const remainingReasons = (component.reviewReasons ?? []).filter((r) => r !== 'props-type-unresolved');
     const score = computeExtractionScore(component, {
         additionalIssueCount: remainingReasons.length,
         additionalReasons: remainingReasons,
     });
     component.extractionConfidence = score.confidence;
     component.reviewReasons = score.reasons;
-    component.needsReview = deriveNeedsReview(score.confidence) || remainingReasons.includes('props-type-unresolved');
-    // Remove the per-component unresolved-type warning. The `props-type-unresolved`
-    // reason on the component itself still carries the signal for TUI drill-down;
-    // the warnings array is replaced by the collapsed summary upstream.
+    component.needsReview = deriveNeedsReview(score.confidence);
+    // Remove the per-component unresolved-type warning — recovery is complete.
     const componentName = component.name;
     const idx = warnings.findIndex((w) => w.startsWith(`${componentName}: declared Props type `) && /resolved to /.test(w));
     if (idx >= 0)
@@ -1180,7 +1174,7 @@ function extractJsdocText(comments) {
 // ---------------------------------------------------------------------------
 // Extraction: ObjectPattern destructure + type-members
 // ---------------------------------------------------------------------------
-function extractFromDestructure(propsCall, ctx, typeMembers, warnings, additionalReasons) {
+function extractFromDestructure(propsCall, _ctx, typeMembers, warnings, additionalReasons) {
     const id = propsCall['id'];
     const properties = id['properties'] ?? [];
     const typeByName = new Map();
@@ -1236,9 +1230,14 @@ function extractFromDestructure(propsCall, ctx, typeMembers, warnings, additiona
     // are collected into the rest binding and are not individually addressable. Authoring
     // contract = the destructure list. (Type-members-only path runs separately for the
     // `const props: Props = $props()` no-destructure case.)
-    if (dropsRest) {
-        warnings.push(`${ctx.componentName}: rest element in $props() destructure dropped (${ctx.filePath}); cannot enumerate`);
-    }
+    // Note: a `...rest` element in the destructure is intentionally NOT warned on.
+    // Nearly every Svelte 5 component in real libraries uses rest-spread to pass
+    // arbitrary HTML attributes through to the underlying element, so this would
+    // fire on most components. The downstream pipeline already strips DOM/a11y
+    // pass-through attributes globally (see `project_dsi-dom-prop-exclusion-decision`),
+    // and the named props we DID extract from the destructure are the meaningful
+    // authoring API. Tracking the rest spread isn't useful signal.
+    void dropsRest;
     return {
         props: props.sort((a, b) => sortStable(a.name, b.name, propertyOrder(properties))),
         snippetNames,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@contentful/experience-design-system-cli",
-  "version": "2.11.4-dev-build-3c16094.0",
+  "version": "2.11.4-dev-build-3e1df30.0",
   "description": "Contentful Experiences design system import CLI",
   "license": "MIT",
   "type": "module",
@@ -37,7 +37,7 @@
     "svelte": "^5.56.4",
     "ts-morph": "^27.0.2",
     "typescript": "^5.9.3",
-    "@contentful/experience-design-system-types": "2.11.4-dev-build-3c16094.0"
+    "@contentful/experience-design-system-types": "2.11.4-dev-build-3e1df30.0"
   },
   "devDependencies": {
     "@tsconfig/node24": "^24.0.3",