@contentful/app-scripts 2.4.0-alpha.0 → 2.4.0

package/lib/generate-function/clone.d.ts

@@ -1,9 +1,9 @@
-import { GenerateFunctionSettings } from '../types';
-export declare function cloneFunction(localPath: string, settings: GenerateFunctionSettings): Promise<void>;
-export declare function getCloneURL(settings: GenerateFunctionSettings): string;
-export declare function touchupAppManifest(localPath: string, settings: GenerateFunctionSettings, renameFunctionFile: string): Promise<void>;
+import { GenerateFunctionSettingsInput } from '../types';
+export declare function cloneFunction(localPath: string, settings: GenerateFunctionSettingsInput): Promise<void>;
+export declare function getCloneURL(settings: GenerateFunctionSettingsInput): string;
+export declare function touchupAppManifest(localPath: string, settings: GenerateFunctionSettingsInput, renameFunctionFile: string): Promise<void>;
 export declare function moveFilesToFinalDirectory(localTmpPath: string, localFunctionsPath: string, localPath: string): void;
-export declare function renameClonedFiles(localTmpPath: string, settings: GenerateFunctionSettings): string;
+export declare function renameClonedFiles(localTmpPath: string, settings: GenerateFunctionSettingsInput): string;
 export declare function resolvePaths(localPath: string): {
     localTmpPath: string;
     localFunctionsPath: string;

package/lib/generate-function/clone.js

@@ -32,7 +32,7 @@ async function cloneFunction(localPath, settings) {
         const { localTmpPath, localFunctionsPath } = resolvePaths(localPath);
         const cloneURL = getCloneURL(settings);
         // Pass keepPackageJson if available in settings (from GenerateFunctionSettingsCLI)
-        const keepPackageJson = 'keepPackageJson' in settings ? settings.keepPackageJson : undefined;
+        const keepPackageJson = 'keepPackageJson' in settings && typeof settings.keepPackageJson === 'boolean' ? settings.keepPackageJson : false;
         await cloneAndResolveManifests(cloneURL, localTmpPath, localPath, localFunctionsPath, keepPackageJson);
         // now rename the function file. Find the file with a .ts or .js extension
         const renameFunctionFile = renameClonedFiles(localTmpPath, settings);
@@ -96,19 +96,18 @@ function resolvePaths(localPath) {
     const localFunctionsPath = (0, node_path_1.resolve)(localPath, 'functions');
     return { localTmpPath, localFunctionsPath };
 }
-async function cloneAndResolveManifests(cloneURL, localTmpPath, localPath, localFunctionsPath, keepPackageJson) {
+async function cloneAndResolveManifests(cloneURL, localTmpPath, localPath, localFunctionsPath, keepPackageJson = false) {
     const tigedInstance = await clone(cloneURL, localTmpPath);
     // merge the manifest from the template folder to the root folder
     await mergeAppManifest(localPath, localTmpPath);
-    // modify package.json build commands
+    // create a deep copy of the IGNORED_CLONED_FILES array
+    const ignoredFiles = Array.from(constants_1.IGNORED_CLONED_FILES);
     if (!keepPackageJson) {
+        // modify package.json build commands
         await updatePackageJsonWithBuild(localPath, localTmpPath);
-    }
-    // check if a tsconfig.json file exists already
-    const ignoredFiles = [...constants_1.IGNORED_CLONED_FILES];
-    if (!keepPackageJson) {
         ignoredFiles.push('package.json');
     }
+    // check if a tsconfig.json file exists already
     const tsconfigExists = await (0, file_1.exists)((0, node_path_1.resolve)(localFunctionsPath, 'tsconfig.json'));
     if (tsconfigExists) {
         ignoredFiles.push('tsconfig.json');

package/lib/types.d.ts

@@ -81,6 +81,7 @@ export interface GenerateFunctionSettings {
 export interface GenerateFunctionSettingsCLI extends GenerateFunctionSettings {
     keepPackageJson?: boolean;
 }
+export type GenerateFunctionSettingsInput = GenerateFunctionSettings | GenerateFunctionSettingsCLI;
 export interface AddLocationsOptions {
     organizationId?: string;
     definitionId?: string;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@contentful/app-scripts",
-  "version": "2.4.0-alpha.0",
+  "version": "2.4.0",
   "description": "A collection of scripts for building Contentful Apps",
   "author": "Contentful GmbH",
   "license": "MIT",
@@ -67,7 +67,7 @@
     "tiged": "^2.12.7",
     "zod": "^3.24.1"
   },
-  "gitHead": "1e2d5087dcc911e7590aab94e643eb1cea088cef",
+  "gitHead": "571371b92e6f7a3542d76192a15f002771708a86",
   "devDependencies": {
     "@types/adm-zip": "0.5.7",
     "@types/analytics-node": "3.1.14",