@contember/schema-migrations 2.0.0 → 2.1.0-alpha.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@contember/schema-migrations",
-  "version": "2.0.0",
+  "version": "2.1.0-alpha.1",
   "license": "Apache-2.0",
   "main": "./dist/production/index.js",
   "typings": "./dist/types/index.d.ts",
@@ -23,16 +23,16 @@
     }
   },
   "dependencies": {
-    "@contember/database": "2.0.0",
-    "@contember/database-migrations": "2.0.0",
-    "@contember/engine-common": "2.0.0",
-    "@contember/schema": "2.0.0",
-    "@contember/schema-utils": "2.0.0",
+    "@contember/database": "2.1.0-alpha.1",
+    "@contember/database-migrations": "2.1.0-alpha.1",
+    "@contember/engine-common": "2.1.0-alpha.1",
+    "@contember/schema": "2.1.0-alpha.1",
+    "@contember/schema-utils": "2.1.0-alpha.1",
     "fast-deep-equal": "^3.1.3",
     "rfc6902": "^5.1.1"
   },
   "devDependencies": {
-    "@contember/schema-definition": "2.0.0"
+    "@contember/schema-definition": "2.1.0-alpha.1"
   },
   "peerDependencies": {
     "pg": "^8.9.0"

package/src/modifications/columns/UpdateColumnDefinitionModification.ts

@@ -20,11 +20,14 @@ export class UpdateColumnDefinitionModificationHandler implements ModificationHa
 		const newColumn = this.data.definition
 
 		const hasNewSequence = !oldColumn.sequence && newColumn.sequence
-		const hasNewType = newColumn.columnType !== oldColumn.columnType
+		const oldColumnType = getColumnSqlType(oldColumn)
 		const columnType = getColumnSqlType(newColumn)
+		const hasNewType = columnType !== oldColumnType
 		const hasNullableChanged = oldColumn.nullable !== newColumn.nullable
 
-		const usingCast = `${wrapIdentifier(oldColumn.columnName)}::${columnType}`
+		const columnNameWrapped = wrapIdentifier(oldColumn.columnName)
+		const isChangedToArray = !oldColumn.list && newColumn.list
+		const usingCast = (isChangedToArray ? `ARRAY[${columnNameWrapped}]` : columnNameWrapped) + `::${columnType}`
 
 		const seedExpression = formatSeedExpression({
 			model: this.schema.model,

package/src/modifications/utils/columnUtils.ts

@@ -1,5 +1,8 @@
 import { Model } from '@contember/schema'
 
-export const getColumnSqlType = (column: Pick<Model.AnyColumn, 'type' | 'columnType'>) => column.type === Model.ColumnType.Enum
-	? `"${column.columnType}"`
-	: column.columnType
+export const getColumnSqlType = (column: Pick<Model.AnyColumn, 'type' | 'columnType' | 'list'>) =>
+	(column.type === Model.ColumnType.Enum
+		? `"${column.columnType}"`
+		: column.columnType
+	)
+	+ (column.list ? '[]' : '')

package/tests/cases/integration/createColumn.test.ts

@@ -172,3 +172,30 @@ ALTER "active" SET NOT NULL; ALTER TABLE "author" ADD "created_at" timestamptz;
 ALTER TABLE "author" ALTER "created_at" SET DATA TYPE timestamptz USING $pga$2024-01-01 10:00$pga$, ALTER "created_at" SET NOT NULL;
 `,
 }))
+
+describe('create list column', () => testMigrations({
+	original: createSchema({
+		Author: class Author {
+		},
+	}),
+	updated: createSchema({
+		Author: class Author {
+			emails = def.stringColumn().list()
+		},
+	}),
+	diff: [
+		{
+			modification: 'createColumn',
+			entityName: 'Author',
+			field: {
+				columnName: 'emails',
+				name: 'emails',
+				nullable: true,
+				type: Model.ColumnType.String,
+				columnType: 'text',
+				list: true,
+			},
+		},
+	],
+	sql: SQL`ALTER TABLE "author" ADD "emails" text[];`,
+}))

package/tests/cases/integration/updateColumnDefinition.test.ts

@@ -226,3 +226,30 @@ describe('set not null and fill with "using"', () => testMigrations({
 	],
 	sql: SQL` ALTER TABLE "author" ALTER "name" SET DATA TYPE text USING COALESCE("name"::text, $pga$unnamed$pga$), ALTER "name" SET NOT NULL;`,
 }))
+
+
+describe('change string to array string', () => testMigrations({
+	original: createSchema({
+		Author: class Author {
+			email = def.stringColumn()
+		},
+	}),
+	updated: createSchema({
+		Author: class Author {
+			email = def.stringColumn().list()
+		},
+	}),
+	diff: [
+		updateColumnDefinitionModification.createModification({
+			entityName: 'Author',
+			fieldName: 'email',
+			definition: {
+				type: Model.ColumnType.String,
+				columnType: 'text',
+				nullable: true,
+				list: true,
+			},
+		}),
+	],
+	sql: SQL`ALTER TABLE "author" ALTER "email" SET DATA TYPE text[] USING ARRAY["email"]::text[];`,
+}))