@contember/bindx-repeater 0.1.49 → 0.1.50

package/dist/hooks/useSortedItems.d.ts

@@ -1,6 +1,9 @@
-import type { EntityAccessor, HasManyAccessor, AnyBrand } from '@contember/bindx';
+import { type AnyBrand, type EntityAccessor, type HasManyAccessor } from '@contember/bindx';
 /**
- * Hook that returns sorted items from a has-many ref and repairs order field values.
+ * Hook that returns sorted items from a has-many ref.
+ *
+ * Rendering never writes: an item that joins the list gets its order value from the
+ * connect event instead, so sparse values on existing rows are left as they are.
  *
  * @param hasMany - The has-many ref
  * @param orderField - Optional field name for sorting

package/dist/hooks/useSortedItems.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"useSortedItems.d.ts","sourceRoot":"","sources":["../../src/hooks/useSortedItems.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,cAAc,EAAE,eAAe,EAAE,QAAQ,EAAE,MAAM,kBAAkB,CAAA;AAIjF;;;;;;GAMG;AACH,wBAAgB,cAAc,CAC7B,CAAC,SAAS,MAAM,EAChB,CAAC,GAAG,CAAC,EACL,MAAM,SAAS,QAAQ,GAAG,QAAQ,EAClC,WAAW,SAAS,MAAM,GAAG,MAAM,EACnC,OAAO,SAAS,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,GAAG,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,EAE/D,OAAO,EAAE,eAAe,CAAC,CAAC,EAAE,CAAC,EAAE,MAAM,EAAE,WAAW,EAAE,OAAO,CAAC,EAC5D,UAAU,EAAE,MAAM,GAAG,SAAS,GAC5B,cAAc,CAAC,CAAC,EAAE,CAAC,EAAE,MAAM,EAAE,WAAW,EAAE,OAAO,CAAC,EAAE,CAiBtD"}
+{"version":3,"file":"useSortedItems.d.ts","sourceRoot":"","sources":["../../src/hooks/useSortedItems.ts"],"names":[],"mappings":"AACA,OAAO,EAEN,KAAK,QAAQ,EACb,KAAK,cAAc,EACnB,KAAK,eAAe,EAEpB,MAAM,kBAAkB,CAAA;AAIzB;;;;;;;;;GASG;AACH,wBAAgB,cAAc,CAC7B,CAAC,SAAS,MAAM,EAChB,CAAC,GAAG,CAAC,EACL,MAAM,SAAS,QAAQ,GAAG,QAAQ,EAClC,WAAW,SAAS,MAAM,GAAG,MAAM,EACnC,OAAO,SAAS,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,GAAG,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,EAE/D,OAAO,EAAE,eAAe,CAAC,CAAC,EAAE,CAAC,EAAE,MAAM,EAAE,WAAW,EAAE,OAAO,CAAC,EAC5D,UAAU,EAAE,MAAM,GAAG,SAAS,GAC5B,cAAc,CAAC,CAAC,EAAE,CAAC,EAAE,MAAM,EAAE,WAAW,EAAE,OAAO,CAAC,EAAE,CA4CtD"}

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@contember/bindx-repeater",
-	"version": "0.1.49",
+	"version": "0.1.50",
 	"description": "Repeater components for has-many list management",
 	"type": "module",
 	"main": "./src/index.ts",
@@ -15,8 +15,8 @@
 		"react": ">=18.0.0"
 	},
 	"dependencies": {
-		"@contember/bindx": "0.1.49",
-		"@contember/bindx-react": "0.1.49"
+		"@contember/bindx": "0.1.50",
+		"@contember/bindx-react": "0.1.50"
 	},
 	"files": [
 		"dist",

package/src/hooks/useSortedItems.ts

@@ -1,10 +1,19 @@
-import { useEffect, useMemo } from 'react'
-import type { EntityAccessor, HasManyAccessor, AnyBrand } from '@contember/bindx'
+import { useCallback, useMemo } from 'react'
+import {
+	FIELD_REF_META,
+	type AnyBrand,
+	type EntityAccessor,
+	type HasManyAccessor,
+	type HasManyConnectedEvent,
+} from '@contember/bindx'
+import { useOnFieldEvent, useSnapshotStore } from '@contember/bindx-react'
 import { sortEntities } from '../utils/sortEntities.js'
-import { repairEntitiesOrder } from '../utils/repairEntitiesOrder.js'
 
 /**
- * Hook that returns sorted items from a has-many ref and repairs order field values.
+ * Hook that returns sorted items from a has-many ref.
+ *
+ * Rendering never writes: an item that joins the list gets its order value from the
+ * connect event instead, so sparse values on existing rows are left as they are.
  *
  * @param hasMany - The has-many ref
  * @param orderField - Optional field name for sorting
@@ -20,6 +29,7 @@ export function useSortedItems<
 	hasMany: HasManyAccessor<T, S, TBrand, TEntityName, TSchema>,
 	orderField: string | undefined,
 ): EntityAccessor<T, S, TBrand, TEntityName, TSchema>[] {
+	const store = useSnapshotStore()
 	const rawItems = hasMany?.items
 	const items = Array.isArray(rawItems) ? rawItems : []
 
@@ -28,12 +38,38 @@ export function useSortedItems<
 		[items, orderField],
 	)
 
-	useEffect(() => {
-		if (!orderField) {
-			return
+	const meta = hasMany?.[FIELD_REF_META]
+	const itemType = meta?.targetType
+
+	const assignOrderToNewItem = useCallback((event: HasManyConnectedEvent): void => {
+		if (orderField === undefined || itemType === undefined) return
+
+		const added = store.getEntitySnapshot<Record<string, unknown>>(itemType, event.itemId)
+		// An item already carrying an order keeps it — this only fills the gap.
+		if (added === undefined) return
+		const currentOrder = added.data[orderField]
+		if (currentOrder !== undefined && currentOrder !== null) return
+
+		// Read through the accessor so the live list is used, not the render snapshot:
+		// several items added in one tick must not all land on the same order.
+		let maxOrder = -1
+		for (const item of hasMany.items) {
+			const value = store.getEntitySnapshot<Record<string, unknown>>(itemType, item.id)?.data[orderField]
+			if (typeof value === 'number' && value > maxOrder) {
+				maxOrder = value
+			}
 		}
-		repairEntitiesOrder(sortedItems, orderField)
-	}, [orderField, sortedItems])
+
+		store.setFieldValue(itemType, event.itemId, [orderField], maxOrder + 1)
+	}, [store, hasMany, orderField, itemType])
+
+	useOnFieldEvent(
+		'hasMany:connected',
+		meta?.entityType ?? '',
+		meta?.entityId ?? '',
+		meta?.fieldName ?? '',
+		assignOrderToNewItem,
+	)
 
 	return sortedItems
 }