@constructor-io/constructorio-node 5.1.1 → 5.2.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@constructor-io/constructorio-node",
-  "version": "5.1.1",
+  "version": "5.2.0",
   "description": "Constructor.io Node.js client",
   "main": "src/constructorio.js",
   "types": "src/types/constructorio.d.ts",

package/src/modules/quizzes.js

@@ -108,7 +108,7 @@ class Quizzes {
    * @description Retrieve quiz question from Constructor.io API
    * @param {string} quizId - The identifier of the quiz
    * @param {string} parameters - Additional parameters to refine result set
-   * @param {array} parameters.answers - An array of answers in the format [[1,2],[1], ["true"], ["seen"], [""]]. Based on the question type, answers should either be an integer, "true", "false", "seen" or empty string ("") if skipped
+   * @param {array} parameters.answers - An array of answers in the format [[1,2],[1], ["true"], ["seen"], [""]]. Based on the question type, answers should either be an integer, "true", "false", "seen" or empty string ("") if the question is skippable: i.e., configured as `is_skippable:true`.
    * @param {string} [parameters.section] - Product catalog section
    * @param {string} [parameters.quizVersionId] - Version identifier for the quiz. Version ID will be returned with the first request and it should be passed with subsequent requests. More information can be found [here]{@link https://docs.constructor.com/reference/configuration-quizzes}
    * @param {string} [parameters.quizSessionId] - Session identifier for the quiz. Session ID will be returned with the first request and it should be passed with subsequent requests. More information can be found [here]{@link https://docs.constructor.com/reference/configuration-quizzes}
@@ -186,7 +186,7 @@ class Quizzes {
    * @description Retrieve quiz recommendation and filter expression from Constructor.io API
    * @param {string} quizId - The identifier of the quiz
    * @param {string} parameters - Additional parameters to refine result set
-   * @param {array} parameters.answers - An array of answers in the format [[1,2],[1], ["true"], ["seen"], [""]]. Based on the question type, answers should either be an integer, "true", "false", "seen" or empty string ("") if skipped
+   * @param {array} parameters.answers - An array of answers in the format [[1,2],[1], ["true"], ["seen"], [""]]. Based on the question type, answers should either be an integer, "true", "false", "seen" or empty string ("") if the question is skippable: i.e., configured as `is_skippable:true`.
    * @param {string} [parameters.section] - Product catalog section
    * @param {string} [parameters.quizVersionId] - Version identifier for the quiz. Version ID will be returned with the first request and it should be passed with subsequent requests. More information can be found [here]{@link https://docs.constructor.com/reference/configuration-quizzes}
    * @param {string} [parameters.quizSessionId] - Session identifier for the quiz. Session ID will be returned with the first request and it should be passed with subsequent requests. More information can be found [here]{@link https://docs.constructor.com/reference/configuration-quizzes}

package/src/modules/tracker.js

@@ -139,6 +139,7 @@ function send(url, userParameters, networkParameters, method = 'GET', body = {})
 
   if (request) {
     const instance = this;
+    const emitError = helpers.getEmitError(instance, { url, method });
 
     request.then((response) => {
       // Request was successful, and returned a 2XX status code
@@ -152,26 +153,25 @@ function send(url, userParameters, networkParameters, method = 'GET', body = {})
 
       // Request was successful, but returned a non-2XX status code
       else {
-        response.json().then((json) => {
-          instance.eventemitter.emit('error', {
-            url,
-            method,
-            message: json && json.message,
+        const contentType = response.headers.get('Content-Type') || '';
+
+        if (contentType.includes('application/json')) {
+          response.json().then((json) => {
+            emitError(json && json.message);
+          }).catch((error) => {
+            emitError(error.type);
           });
-        }).catch((error) => {
-          instance.eventemitter.emit('error', {
-            url,
-            method,
-            message: error.type,
+        } else {
+          // If not JSON, fallback to text
+          response.text().then((text) => {
+            emitError(text || 'Unknown error message');
+          }).catch((error) => {
+            emitError(`Error reading text: ${error.message}`);
           });
-        });
+        }
       }
     }).catch((error) => {
-      instance.eventemitter.emit('error', {
-        url,
-        method,
-        message: error.toString(),
-      });
+      emitError(error.toString());
     });
   }
 }

package/src/utils/helpers.js

@@ -134,6 +134,12 @@ const utils = {
 
     return url;
   },
+
+  getEmitError(instance, { url, method }) {
+    return function emitError(message) {
+      instance.eventemitter.emit('error', { url, method, message });
+    };
+  },
 };
 
 module.exports = utils;