@consiliency/agent-board-schema 1.57.0 → 1.58.0

package/tests/agent_board_federated_identity_injective_slug.test.sql

@@ -353,8 +353,11 @@ select is(
             where p.pronamespace = 'agent_board'::regnamespace
               and p.proname <> '_federated_identity_slug'
               and agent_board_test.stripped_body(p.oid, true) like '%\_federated\_identity\_slug(%') x),
-  '_enroll_federated_human_after_revocation_gate=1, _enroll_federated_identity_once=1, enroll_federated_human=1, enroll_federated_identity=2, onboard_federated_fleet_agent=1',
-  'CLS-3: exactly these five functions route through the helper, each with its own call count');
+  -- HOSTED (20261008000100) added two sites: exchange_delegate_credential and
+  -- tombstone_delegate_instance derive the hosted delegate's OWNER uid exactly as
+  -- enroll_federated_human derives the human's (IF-0-HOSTED-12's frozen owner identity).
+  '_enroll_federated_human_after_revocation_gate=1, _enroll_federated_identity_once=1, enroll_federated_human=1, enroll_federated_identity=2, exchange_delegate_credential=1, onboard_federated_fleet_agent=1, tombstone_delegate_instance=1',
+  'CLS-3: exactly these seven functions route through the helper, each with its own call count');
 
 -- CLS-4. The helper is not a public lever. It is pure and mints nothing, but it is the
 -- function that decides which account a pair maps to, and CREATE FUNCTION grants EXECUTE

package/tests/agent_board_fedsession_stored_identity_gate.test.sql

@@ -44,7 +44,10 @@ set search_path = extensions, public, agent_board;
 
 begin;
 
-select plan(29);
+-- 31 with HOSTED (20261008000100): two derivation sites, each exempt positively (13, 14).
+-- 33 with the HOSTED fix lane (PR #590): the exchange joins the class through its owner-liveness
+-- read and is exempted from the gate positively (assertions 2b, 2c).
+select plan(33);
 
 -- ---------------------------------------------------------------------------
 -- Section A -- the CLASS, derived from pg_proc, not from a list written here
@@ -84,15 +87,48 @@ select p.oid, p.proname, agent_board_test.stripped_body(p.oid, true) as body
          ~ agent_board_test.re(agent_board_test.qname_frag('agents', agent_board_test.bare_ok(p.oid)) || agent_board_test.same_stmt()
                                || agent_board_test.col_ref_frag('auth_user_id') || '\s*=');
 
+-- HOSTED fix lane (PR #590, finding N2): exchange_delegate_credential now reads the owner's
+-- human row on auth_user_id, to REFUSE an inactive owner (owner_inactive). It never hands that
+-- row back, so the stored-identity gate (which guards a RETURN of a row found by the derivation)
+-- has nothing to gate there. It is a class member exempted POSITIVELY, in two halves: the view
+-- below admits it only while its body holds exactly ONE agents-on-auth_user_id read (counted with
+-- the class query's own matcher, so a second read anywhere drops it back into the gated set and
+-- reds 3-7 by name), and 2c asserts, over that one body, that the read is the owner_inactive
+-- refusal. The exemption is keyed by name, a list of one; a new member is gated by default.
+create temp view _c246_refusal_only as
+select c.oid, c.proname
+  from _c246 c
+ where c.proname = 'exchange_delegate_credential'
+   and regexp_count(c.body, agent_board_test.re(agent_board_test.qname_frag('agents', agent_board_test.bare_ok(c.oid))
+                            || agent_board_test.same_stmt() || agent_board_test.col_ref_frag('auth_user_id') || '\s*=')) = 1;
+-- The members the gate applies to: the class, less the positively exempted refusal-only read.
+create temp view _c246g as
+select c.* from _c246 c where c.oid not in (select oid from _c246_refusal_only);
+
 -- 1 -- the class is NOT EMPTY. A class scan that finds nothing passes every
 -- "every member has X" assertion vacuously; this is the assertion that stops that.
-select is((select count(*)::int from _c246), 1,
-  'exactly one agent_board function both derives a fed-human owner uid and reads agents on auth_user_id');
+select is((select count(*)::int from _c246), 2,
+  'exactly two agent_board functions both derive a fed-human owner uid and read agents on auth_user_id');
 
--- 2 -- and it is the one we think it is, named POSITIVELY (not "no unexpected members").
+-- 2 -- and they are the ones we think they are, named POSITIVELY (not "no unexpected members").
 select is((select string_agg(proname, ',' order by proname) from _c246),
-  '_enroll_federated_human_after_revocation_gate',
-  'that function is _enroll_federated_human_after_revocation_gate');
+  '_enroll_federated_human_after_revocation_gate,exchange_delegate_credential',
+  'those functions are _enroll_federated_human_after_revocation_gate and exchange_delegate_credential');
+
+-- 2b (TAP ok 3; every later "-- N --" comment in this file is two BEHIND its TAP number) --
+-- the exempt and gated sets, by name.
+select is(
+  (select string_agg(proname, ',' order by proname) from _c246_refusal_only)
+  || ' | ' || (select string_agg(proname, ',' order by proname) from _c246g),
+  'exchange_delegate_credential | _enroll_federated_human_after_revocation_gate',
+  'EXEMPT: exchange_delegate_credential has exactly one agents-on-auth_user_id read; the gated set is the one function that returns a found row');
+-- 2c (TAP ok 4) -- and that one read is the owner_inactive refusal, over its one body.
+select ok(
+  (select agent_board_test.stripped_body(p.oid, true)
+     from pg_proc p join pg_namespace n on n.oid = p.pronamespace
+    where n.nspname = 'agent_board' and p.proname = 'exchange_delegate_credential')
+    ~ 'exists\s*\(\s*select\s+1\s+from\s+agent_board\.agents\s+a\s+where\s+a\.auth_user_id\s*=\s*v_owner\s+and\s+a\.status\s*<>\s*''active''\s*\)\s*then\s+raise\s+exception\s+''owner_inactive''',
+  'EXEMPT: exchange_delegate_credential''s agents-on-auth_user_id read only refuses: exists(... status <> active) then raise owner_inactive');
 
 -- BOTH return sites carry the gate -- asserted PER SITE, not as a count.
 --
@@ -120,14 +156,14 @@ select proname,
        (regexp_split_to_array(body, agent_board_test.re('\m' || agent_board_test.ci_re('exception when unique_violation') || '\M')))[1] as pre_handler,
        (regexp_split_to_array(body, agent_board_test.re('\m' || agent_board_test.ci_re('exception when unique_violation') || '\M')))[2] as in_handler,
        array_length(regexp_split_to_array(body, agent_board_test.re('\m' || agent_board_test.ci_re('exception when unique_violation') || '\M')), 1) as parts
-  from _c246;
+  from _c246g;
 
 -- 3 -- the split boundary is UNAMBIGUOUS for every member. With a second `exception
 -- when unique_violation` the two assertions below would be reading arbitrary halves,
 -- so this is asserted before anything is read from them.
 select is(
   (select string_agg(proname, ',' order by proname) from _c246parts where parts = 2),
-  (select string_agg(proname, ',' order by proname) from _c246),
+  (select string_agg(proname, ',' order by proname) from _c246g),
   'every class member has exactly one `exception when unique_violation`, so the per-site split is unambiguous');
 
 -- 4 -- SITE (7a): the idempotent branch, everything before the handler.
@@ -138,7 +174,7 @@ select is(
              || '\s+' || agent_board_test.ci_re('and') || '\s+'
              || agent_board_test.ident_re('v_existing') || '\s*\.\s*' || agent_board_test.ident_re('metadata') || '\s*#>>\s*''\{federation,subject\}''\s*=\s*' || agent_board_test.ident_re('p_subject')
              || '\s*,\s*' || agent_board_test.ci_re('false') || '\s*\)')),
-  (select string_agg(proname, ',' order by proname) from _c246),
+  (select string_agg(proname, ',' order by proname) from _c246g),
   'every class member carries the gate at return site (7a) -- the idempotent branch, BEFORE the unique_violation handler');
 
 -- 5 -- SITE (8a): the race handler, everything after. This is the site a single
@@ -151,7 +187,7 @@ select is(
              || '\s+' || agent_board_test.ci_re('and') || '\s+'
              || agent_board_test.ident_re('v_existing') || '\s*\.\s*' || agent_board_test.ident_re('metadata') || '\s*#>>\s*''\{federation,subject\}''\s*=\s*' || agent_board_test.ident_re('p_subject')
              || '\s*,\s*' || agent_board_test.ci_re('false') || '\s*\)')),
-  (select string_agg(proname, ',' order by proname) from _c246),
+  (select string_agg(proname, ',' order by proname) from _c246g),
   'every class member carries the gate at return site (8a) -- INSIDE the unique_violation race handler');
 
 -- 6 and 7 -- both sites raise the SAME refusal, so neither becomes a
@@ -168,14 +204,14 @@ select is(
 select is(
   (select string_agg(proname, ',' order by proname) from _c246parts
     where pre_handler ~ 'federated identity mismatch'),
-  (select string_agg(proname, ',' order by proname) from _c246),
+  (select string_agg(proname, ',' order by proname) from _c246g),
   'every class member raises the "federated identity mismatch" refusal at site (7a) -- the idempotent branch');
 
 -- 7
 select is(
   (select string_agg(proname, ',' order by proname) from _c246parts
     where in_handler ~ 'federated identity mismatch'),
-  (select string_agg(proname, ',' order by proname) from _c246),
+  (select string_agg(proname, ',' order by proname) from _c246g),
   'every class member raises the "federated identity mismatch" refusal at site (8a) -- INSIDE the race handler');
 
 -- ---------------------------------------------------------------------------
@@ -203,8 +239,29 @@ select is(
     where n.nspname = 'agent_board' and p.prokind in ('f', 'p')
       and p.proname <> '_federated_identity_slug'
       and agent_board_test.stripped_body(p.oid, true) like '%\_federated\_identity\_slug(%'),
-  '_enroll_federated_human_after_revocation_gate,_enroll_federated_identity_once,enroll_federated_human,enroll_federated_identity,onboard_federated_fleet_agent',
-  'the fed-human derivation set is exactly these five functions');
+  '_enroll_federated_human_after_revocation_gate,_enroll_federated_identity_once,enroll_federated_human,enroll_federated_identity,exchange_delegate_credential,onboard_federated_fleet_agent,tombstone_delegate_instance',
+  'the fed-human derivation set is exactly these seven functions (HOSTED added the exchange and the tombstone)');
+
+-- 13, 14 -- HOSTED (20261008000100): exchange_delegate_credential and
+-- tombstone_delegate_instance derive the OWNER's uid from the verified (issuer, subject),
+-- exactly as enroll_federated_human does (IF-0-HOSTED-12's frozen owner identity). They are
+-- exempt because neither returns an agent found by that uid: each uses it only as the
+-- instance's owner, inserted as delegate_instances.owner_user_id and compared with the stored
+-- one (owner_mismatch). The comparison is what is pinned, positively. The tombstone's absence
+-- of an agents read on auth_user_id is the class query's half (assertions 1-2); the exchange
+-- has one such read since the fix lane, the owner_inactive refusal, exempted by 2b and 2c.
+select ok(
+  (select agent_board_test.stripped_body(p.oid, true)
+     from pg_proc p join pg_namespace n on n.oid = p.pronamespace
+    where n.nspname = 'agent_board' and p.proname = 'exchange_delegate_credential')
+    ~ 'v_row\.owner_user_id\s+is\s+distinct\s+from\s+v_owner',
+  'EXEMPT: exchange_delegate_credential compares the stored instance owner with the derived uid (owner_mismatch)');
+select ok(
+  (select agent_board_test.stripped_body(p.oid, true)
+     from pg_proc p join pg_namespace n on n.oid = p.pronamespace
+    where n.nspname = 'agent_board' and p.proname = 'tombstone_delegate_instance')
+    ~ 'v_row\.owner_user_id\s+is\s+distinct\s+from\s+v_owner',
+  'EXEMPT: tombstone_delegate_instance compares the stored instance owner with the derived uid (owner_mismatch)');
 
 -- 9 -- enroll_federated_identity is exempt because it ALREADY compares the caller's
 -- pair against the creation-time stamp (#176/#244). Asserted on BOTH conjuncts: a

package/tests/agent_board_fk_lock_edges.test.sql

@@ -230,6 +230,9 @@ select is(
     '_redeem_unbounded_invite_for_agent: memberships(key share) then agents(key share) [unserialised]',
     '_upsert_board_membership_state: memberships(update) then agents(key share) [unserialised]',
     '_upsert_delivery_recipient: memberships(key share) then agents(key share) [unserialised]',
+    -- HOSTED (20261008000100). Advisory-serialised, as grant_board_role is: the fleet-ledger gate
+    -- row-locks the owner's agents row before the sink writes the delegate's membership.
+    'add_delegate_to_board: agents(share) then memberships(update) [advisory]',
     'create_tasking_delivery: agents(key share) then memberships(key share) [unserialised]',
     'enroll_federated_identity: agents(update) then memberships(key share) [unserialised]',
     'grant_board_role: agents(share) then memberships(update) [advisory]',
@@ -249,6 +252,12 @@ select is(
     'signed_send_direct_message: agents(key share) then memberships(key share) [unserialised]',
     'signed_send_multicast_message: agents(key share) then memberships(key share) [unserialised]',
     'subscribe_callback_endpoint: memberships(key share) then agents(key share) [unserialised]',
+    -- HOSTED (20261008000100). Unserialised, and deliberately NOT given the advisory lock:
+    -- add_delegate_to_board takes the instance row and THEN the advisory lock, so a tombstone
+    -- (instance row FOR UPDATE first) taking the advisory lock after it would be the ABBA this
+    -- file exists to catch. Every row it locks belongs to the tombstoned delegate -- its agents
+    -- row, its credentials, its memberships -- which onboarding never locks.
+    'tombstone_delegate_instance: agents(update) then memberships(update) [unserialised]',
     'update_board_membership: memberships(update) then agents(key share) [unserialised]'
   ]::text[],
   'FKL-9: the agents+board_memberships lock class, FK edges included (section 9''s text scan sees 3 of these)');