@consiliency/agent-board-schema 1.45.0 → 1.50.0

package/tests/agent_board_claimkey.test.sql

@@ -211,8 +211,14 @@ select set_eq(
   -- active machine claim(s) on the reclaimed fingerprint so the new owner can acquire. It routes the
   -- key through _canonical_claim_key (assertion 25 stays 0); its positive state claim (status set to
   -- 'released') is pinned in agent_board_fleet_machine_reclaim.test.sql.
-  array['acquire_claim', 'renew_claim', 'release_claim', 'reclaim_fleet_machine'],
-  'exactly acquire/renew/release/reclaim write agent_board.claims (catalog-enumerated writer class)');
+  -- set_board_claim_policy (#400) is a fifth writer: an advisory -> inherit revert re-applies the
+  -- ownerless TTL cap to that board's active ownerless claims. It is EXEMPT FROM ASSERTION 25 by a
+  -- DERIVED property and not by name -- its claims UPDATE sets only lease_expires_at/updated_at and
+  -- its body never mentions resource_key at all, so there is no key for the normalizer to canonicalize.
+  -- The exemption's positive claim (the reset moves lease timestamps and nothing else) is scored in
+  -- agent_board_board_claim_policy.test.sql BCP-11/13/14, which look the claims up BY resource_key.
+  array['acquire_claim', 'renew_claim', 'release_claim', 'reclaim_fleet_machine', 'set_board_claim_policy'],
+  'exactly acquire/renew/release/reclaim/set_board_claim_policy write agent_board.claims (catalog-enumerated writer class)');
 select is(
   (select count(*)::int
      from pg_proc p
@@ -220,6 +226,15 @@ select is(
     where n.nspname = 'agent_board'
       and p.prokind = 'f'
       and agent_board_test.stripped_body(p.oid) ~* '(insert\s+into|update)\s+(agent_board\.)?claims\M'
+      -- #400: SCOPED TO WRITERS THAT HAVE A KEY TO NORMALIZE. A claims writer whose body never
+      -- mentions resource_key cannot set one -- an UPDATE must name the column in its SET list and
+      -- an INSERT must name it in its column list (resource_key is NOT NULL) -- so requiring it to
+      -- call the normalizer would be dead code added to satisfy a check, which is the anti-pattern
+      -- rule 2 names. DERIVED, not a name exemption: a new writer that touches resource_key at all
+      -- is still in the population and still fails closed. STATED HOLE: `insert into claims select *
+      -- from ...` names no column and would slip past, which is the same shape assertion 24's regex
+      -- already cannot see.
+      and agent_board_test.stripped_body(p.oid) ~* '\mresource_key\M'
       -- message-board#196 Bucket B: read RAW, one comment naming _canonical_claim_key
       -- dropped a bypass writer out of this set and the count went to 0 green.
       -- anchored to the CALL shape: a bare-substring `!~` is satisfied by any