@consiliency/agent-board-schema 1.28.0 → 1.38.0

package/tests/agent_board_bundle_endpoint_compat.test.sql

@@ -1,5 +1,5 @@
 begin;
-select plan(12);
+select plan(21);
 
 -- objects exist
 select has_table('agent_board', 'bundle_installation', 'bundle_installation table exists');
@@ -25,27 +25,47 @@ select is((agent_board.get_bundle_compatibility() ->> 'ready'), 'false',
 select is((agent_board.get_bundle_compatibility() ->> 'schema_version'), '8',
   'compatibility reports schema version 8');
 
--- Post-MBSESSION the 8 core sends are re-granted to authenticated, so the LIVE
--- baseline posture is signed_write_enforced=false. Exercise BOTH branches in this
--- rolled-back txn. Enforced branch: revoke EXECUTE from authenticated on ALL
--- eight gated-write overloads (the probe checks by routine name, so any single
--- remaining overload grant keeps enforcement false) -> reports active=true.
-revoke execute on function agent_board.send_direct_message(uuid, uuid, uuid, text, text, text, text, text, jsonb) from authenticated;
-revoke execute on function agent_board.send_direct_message(uuid, uuid, jsonb, text, text, text, text, text, text, jsonb) from authenticated;
+-- #310: this block used to exercise the flag's two branches by revoking and re-granting the
+-- EIGHT send overloads, because the predicate asked whether `authenticated` could execute them.
+-- That predicate encoded the model 20260718000800 deliberately abandoned, and it reported
+-- `false` for a system that WAS enforcing. 20260918000100 re-points it at the signed gateway's
+-- grants, so the same two branches are now driven from a `signed_*` function instead.
+--
+-- Both branches still run inside this rolled-back txn, and driving BOTH is the point: an
+-- assertion that only ever sees `true` cannot tell "the flag is right" from "the flag is stuck".
+select is((agent_board.get_bundle_compatibility() ->> 'signed_write_enforced'), 'true',
+  'signed-write enforcement reports active on the shipped posture — the signed gateway exists and no signed_* is executable by authenticated or anon (#310)');
+
+-- Enforcement-off branch: EXECUTE on any ONE signed_* gateway reaching `authenticated` is
+-- enough. The probe iterates pg_proc rows, so this holds for every gateway and every overload,
+-- not just the one named here.
+grant execute on function agent_board.signed_post_board_message(jsonb, jsonb) to authenticated;
+select is((agent_board.get_bundle_compatibility() ->> 'signed_write_enforced'), 'false',
+  'enforcement flips to false when a single signed_* gateway becomes executable by authenticated');
+
+revoke execute on function agent_board.signed_post_board_message(jsonb, jsonb) from authenticated;
+
+-- `anon` is checked too, and separately: the retired predicate looked only at `authenticated`,
+-- so an anon grant on the signed path would have left it reporting enforced.
+grant execute on function agent_board.signed_send_direct_message(jsonb, jsonb) to anon;
+select is((agent_board.get_bundle_compatibility() ->> 'signed_write_enforced'), 'false',
+  'enforcement flips to false for an ANON grant as well — the retired predicate only looked at authenticated');
+
+revoke execute on function agent_board.signed_send_direct_message(jsonb, jsonb) from anon;
+select is((agent_board.get_bundle_compatibility() ->> 'signed_write_enforced'), 'true',
+  'and back to true once the grant is withdrawn — the flag tracks the grant rather than latching');
+
+-- The re-granted SEND path must NOT move the flag -- #310's defect stated as an assertion.
+-- This REVOKES and RE-GRANTS a send overload so it observes a genuine state change; the earlier
+-- draft asserted the same value twice with nothing happening in between, which documented the
+-- claim rather than probing it.
 revoke execute on function agent_board.send_multicast_message(uuid, uuid, uuid[], text, text, text, text, text, jsonb) from authenticated;
-revoke execute on function agent_board.send_multicast_message(uuid, uuid, jsonb, text, text, text, text, text, text, jsonb) from authenticated;
-revoke execute on function agent_board.post_board_message(uuid, uuid, uuid, text, text, text, text, text, jsonb) from authenticated;
-revoke execute on function agent_board.post_board_message(uuid, uuid, text, text, text, text, text, text, text, jsonb) from authenticated;
-revoke execute on function agent_board.create_tasking_delivery(uuid, uuid, text, text, uuid[], uuid, text, text, text, jsonb) from authenticated;
-revoke execute on function agent_board.create_tasking_delivery(uuid, uuid, text, text, jsonb, text, text, text, text, text, jsonb) from authenticated;
 select is((agent_board.get_bundle_compatibility() ->> 'signed_write_enforced'), 'true',
-  'signed-write enforcement reports active when all gated write RPCs are revoked from authenticated');
+  '#310: REVOKING a send RPC from authenticated does not move the flag — the retired predicate would have flipped to true here, which is precisely what it got wrong');
 
--- Re-grant branch: re-granting EXECUTE on any one gated write RPC (as MBSESSION
--- does at 20260718000800) flips enforcement back to false.
 grant execute on function agent_board.send_multicast_message(uuid, uuid, uuid[], text, text, text, text, text, jsonb) to authenticated;
-select is((agent_board.get_bundle_compatibility() ->> 'signed_write_enforced'), 'false',
-  'enforcement flips to false when any gated write RPC is re-granted to authenticated');
+select is((agent_board.get_bundle_compatibility() ->> 'signed_write_enforced'), 'true',
+  '#310: and RE-GRANTING it does not move the flag either — authenticated holding EXECUTE on the unsigned send path is the shipped model, not a lapse');
 
 -- after the materializer records an install: ready + bundle identity present,
 -- and no credential/row content leaks (only whitelisted keys)
@@ -57,5 +77,40 @@ select is(
   'true:1.1.0:deadbeef',
   'ready + bundle identity reported after install record');
 
+-- ===========================================================================
+-- SIGNEDWRITEMODEL (message-board#326)
+--
+-- `signed_write_enforced` has the right VALUE and the wrong NAME: it is called
+-- "signed write enforced" and it tests "the signed path is operator-only". The
+-- sibling below NAMES the proposition, so a reader decodes the boolean without
+-- consulting the 1.37.0 version boundary.
+-- ===========================================================================
+select is((agent_board.get_bundle_compatibility() ->> 'signed_write_model'),
+  'operator-only-gateway',
+  'MB326-1: the handshake NAMES the model its boolean is answering, so the flag decodes without a version boundary');
+
+-- The key is a CONSTANT about this bundle, not a derivation from the database.
+-- Driving the boolean to its other branch must not move it: a model that flipped
+-- with the state it describes would be a second boolean, not a label.
+grant execute on function agent_board.signed_post_board_message(jsonb, jsonb) to authenticated;
+select is(
+  (agent_board.get_bundle_compatibility() ->> 'signed_write_model') || ':' ||
+  (agent_board.get_bundle_compatibility() ->> 'signed_write_enforced'),
+  'operator-only-gateway:false',
+  'MB326-2: the model NAME is a constant about the bundle — it stays put while the boolean it labels flips to false');
+revoke execute on function agent_board.signed_post_board_message(jsonb, jsonb) from authenticated;
+
+-- ADDITIVE, which is the whole argument for adding rather than renaming.
+-- packages/agent-board-client/src/compatibility.ts recognises a health response
+-- with `"schema_version" in value && "signed_write_enforced" in value && "ready"
+-- in value`. Asserted as PRESENCE of each of the three, one at a time, because
+-- that is what the guard tests -- a combined check would pass on two of three.
+select ok(agent_board.get_bundle_compatibility() ? 'schema_version',
+  'MB326-3: the deployed client type guard''s first key is still PRESENT');
+select ok(agent_board.get_bundle_compatibility() ? 'signed_write_enforced',
+  'MB326-4: ...its second key, the one a rename or retirement would have removed, is still PRESENT');
+select ok(agent_board.get_bundle_compatibility() ? 'ready',
+  'MB326-5: ...and its third');
+
 select * from finish();
 rollback;