@consiliency/agent-board-schema 1.24.0 → 1.27.0

package/tests/agent_board_atomic_fleet_onboarding.test.sql

@@ -12,7 +12,7 @@
 -- runtime backstop at all.
 --
 -- WHAT THE FIX IS. Each positional assertion now locates its markers on
--- `pg_temp._stripped_body(<fn>)` -- prosrc with dollar-quoted blocks, single-quoted
+-- `agent_board_test.stripped_body(<fn>)` -- prosrc with dollar-quoted blocks, single-quoted
 -- literals, line comments and block comments removed in ONE alternation pass. The
 -- regex is copied BYTE-FOR-BYTE from agent_board_federated_lock_order_class.test.sql,
 -- where its three failure modes were found the hard way: a block comment whose body
@@ -123,24 +123,23 @@ create extension if not exists pgtap with schema extensions;
 set search_path = extensions, public, agent_board;
 
 begin;
-select plan(52);
+select plan(54);
 
 -- ---------------------------------------------------------------------------
--- The stripped-body reader every positional assertion below uses. A shared SQL
--- include is not workable in this harness -- the runner pipes
--- `begin; \i <file>; rollback;` into psql, so there is no reliable relative
--- include path -- so it is defined ONCE here instead of being copy-pasted into
--- nine call sites, which would guarantee drift. The regex is byte-identical to
--- agent_board_federated_lock_order_class.test.sql; see the header.
+-- The stripped-body reader every positional assertion below uses is
+-- agent_board_test.stripped_body(), defined ONCE for the whole suite in
+-- tests/fixtures/test-prereqs.sql (the runner applies that fixture before any
+-- test, so it needs no include path).
+--
+-- It used to be a local regex copied here and kept byte-identical to
+-- agent_board_federated_lock_order_class.test.sql so the two could not drift.
+-- They could not drift, and they were both WRONG: no regular expression can
+-- match a NESTED block comment, and `/* note /* x */ <code> */` therefore hid
+-- <code> from both files at once (message-board#199) -- 52/52 and 15/15 green
+-- with the boards lock genuinely relocated. The shared helper is a character
+-- scanner for that reason; see its header for the full enumeration of escape
+-- hatches and which ones a regex can and cannot close.
 -- ---------------------------------------------------------------------------
-create function pg_temp._stripped_body(p_fn regprocedure) returns text
-language sql stable as $strip$
-  select regexp_replace(p.prosrc,
-           $re$(\$[A-Za-z_0-9]*\$).*?\1|('([^']|'')*')|(--[^\n]*)|(/\*([^*]|\*+[^*/])*\*+/)$re$,
-           ' ', 'g')
-    from pg_proc p
-   where p.oid = p_fn;
-$strip$;
 
 select has_table('agent_board', 'fleet_onboarding_invite_bounds', 'immutable fleet invite bounds table exists');
 select has_pk('agent_board', 'fleet_onboarding_invite_bounds', 'fleet invite bounds are keyed by invite id');
@@ -248,38 +247,22 @@ select ok(
   'binding revocation is a permanent tombstone'
 );
 select ok(
-  strpos(
-    pg_temp._stripped_body('agent_board.revoke_fleet_machine_agent_binding(uuid,uuid,text,jsonb)'::regprocedure),
-    'from agent_board.fleet_machines m'
+  strpos(lower(agent_board_test.stripped_body('agent_board.revoke_fleet_machine_agent_binding(uuid,uuid,text,jsonb)'::regprocedure)), 'from agent_board.fleet_machines m'
   ) > 0
-  and strpos(
-    pg_temp._stripped_body('agent_board.revoke_fleet_machine_agent_binding(uuid,uuid,text,jsonb)'::regprocedure),
-    'from agent_board.fleet_machine_agents b where b.id = p_binding_id for update'
+  and strpos(lower(agent_board_test.stripped_body('agent_board.revoke_fleet_machine_agent_binding(uuid,uuid,text,jsonb)'::regprocedure)), 'from agent_board.fleet_machine_agents b where b.id = p_binding_id for update'
   ) > 0
-  and strpos(
-    pg_temp._stripped_body('agent_board.revoke_fleet_machine_agent_binding(uuid,uuid,text,jsonb)'::regprocedure),
-    'from agent_board.fleet_machines m'
-  ) < strpos(
-    pg_temp._stripped_body('agent_board.revoke_fleet_machine_agent_binding(uuid,uuid,text,jsonb)'::regprocedure),
-    'from agent_board.fleet_machine_agents b where b.id = p_binding_id for update'
+  and strpos(lower(agent_board_test.stripped_body('agent_board.revoke_fleet_machine_agent_binding(uuid,uuid,text,jsonb)'::regprocedure)), 'from agent_board.fleet_machines m'
+  ) < strpos(lower(agent_board_test.stripped_body('agent_board.revoke_fleet_machine_agent_binding(uuid,uuid,text,jsonb)'::regprocedure)), 'from agent_board.fleet_machine_agents b where b.id = p_binding_id for update'
   ),
   'exact binding revocation locks the machine before the binding [SOLE PIN: no isolation spec discriminates this ordering -- measured against all 20]'
 );
 select ok(
-  strpos(
-    pg_temp._stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure),
-    'where fm.id = p_machine_id for update'
+  strpos(lower(agent_board_test.stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure)), 'where fm.id = p_machine_id for update'
   ) > 0
-  and strpos(
-    pg_temp._stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure),
-    'from agent_board.agents a where a.id = v_enroll.agent_id for update'
+  and strpos(lower(agent_board_test.stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure)), 'from agent_board.agents a where a.id = v_enroll.agent_id for update'
   ) > 0
-  and strpos(
-    pg_temp._stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure),
-    'where fm.id = p_machine_id for update'
-  ) < strpos(
-    pg_temp._stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure),
-    'from agent_board.agents a where a.id = v_enroll.agent_id for update'
+  and strpos(lower(agent_board_test.stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure)), 'where fm.id = p_machine_id for update'
+  ) < strpos(lower(agent_board_test.stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure)), 'from agent_board.agents a where a.id = v_enroll.agent_id for update'
   ),
   'atomic onboarding locks the machine before its enrolled agent [CONFIRMATORY: atomic_fleet_binding_revoke.spec and atomic_fleet_lifecycle_races.spec both discriminate the inversion]'
 );
@@ -299,7 +282,7 @@ select ok(
 -- does not fail the claim.
 select ok(
   (with b as (
-     select pg_temp._stripped_body(
+     select agent_board_test.stripped_body(
        'agent_board.revoke_fleet_subject(text,uuid,uuid,text,jsonb)'::regprocedure) as t),
    p as (
      select t,
@@ -318,20 +301,12 @@ select ok(
   'agent fleet revocation takes its machine locks before the agent lock [SOLE PIN: no isolation spec discriminates this ordering -- measured against all 20]'
 );
 select ok(
-  strpos(
-    pg_temp._stripped_body('agent_board._revoke_agent_principal(uuid,uuid,text)'::regprocedure),
-    'from agent_board.agents a where a.id = p_agent_id for update'
+  strpos(lower(agent_board_test.stripped_body('agent_board._revoke_agent_principal(uuid,uuid,text)'::regprocedure)), 'from agent_board.agents a where a.id = p_agent_id for update'
   ) > 0
-  and strpos(
-    pg_temp._stripped_body('agent_board._revoke_agent_principal(uuid,uuid,text)'::regprocedure),
-    'from agent_board.agent_signing_keys'
+  and strpos(lower(agent_board_test.stripped_body('agent_board._revoke_agent_principal(uuid,uuid,text)'::regprocedure)), 'from agent_board.agent_signing_keys'
   ) > 0
-  and strpos(
-    pg_temp._stripped_body('agent_board._revoke_agent_principal(uuid,uuid,text)'::regprocedure),
-    'from agent_board.agents a where a.id = p_agent_id for update'
-  ) < strpos(
-    pg_temp._stripped_body('agent_board._revoke_agent_principal(uuid,uuid,text)'::regprocedure),
-    'from agent_board.agent_signing_keys'
+  and strpos(lower(agent_board_test.stripped_body('agent_board._revoke_agent_principal(uuid,uuid,text)'::regprocedure)), 'from agent_board.agents a where a.id = p_agent_id for update'
+  ) < strpos(lower(agent_board_test.stripped_body('agent_board._revoke_agent_principal(uuid,uuid,text)'::regprocedure)), 'from agent_board.agent_signing_keys'
   ),
   'subtree primitive locks the agent before signing keys [SOLE PIN: no isolation spec discriminates this ordering -- measured against all 20]'
 );
@@ -359,20 +334,12 @@ select ok(
 -- not-found case fail instead of pass; the other eight positional claims in this
 -- file already carried them.
 select ok(
-  strpos(
-    pg_temp._stripped_body('agent_board.revoke_agent(uuid,text)'::regprocedure),
-    'update agent_board.agents'
+  strpos(lower(agent_board_test.stripped_body('agent_board.revoke_agent(uuid,text)'::regprocedure)), 'update agent_board.agents'
   ) > 0
-  and strpos(
-    pg_temp._stripped_body('agent_board.revoke_agent(uuid,text)'::regprocedure),
-    'update agent_board.agent_credentials'
+  and strpos(lower(agent_board_test.stripped_body('agent_board.revoke_agent(uuid,text)'::regprocedure)), 'update agent_board.agent_credentials'
   ) > 0
-  and strpos(
-    pg_temp._stripped_body('agent_board.revoke_agent(uuid,text)'::regprocedure),
-    'update agent_board.agents'
-  ) < strpos(
-    pg_temp._stripped_body('agent_board.revoke_agent(uuid,text)'::regprocedure),
-    'update agent_board.agent_credentials'
+  and strpos(lower(agent_board_test.stripped_body('agent_board.revoke_agent(uuid,text)'::regprocedure)), 'update agent_board.agents'
+  ) < strpos(lower(agent_board_test.stripped_body('agent_board.revoke_agent(uuid,text)'::regprocedure)), 'update agent_board.agent_credentials'
   ),
   'legacy authenticated revoke_agent preserves agent-before-credential ordering [HISTORICAL: legacy platform-admin path, no live fleet counterparty and no isolation spec]'
 );
@@ -404,10 +371,18 @@ select ok(
     like '%from auth.users u where u.id = v_owner_user_id for update%fleet_human_revocations%r.issuer = p_issuer and r.subject = p_subject%',
   'identity enrollment locks the human owner and rejects durable total revocation'
 );
+-- LITERALS KEPT (the `true` second argument): every marker below is itself a
+-- string literal in the body -- `''federation''`, `''object''`, the
+-- `'{federation,replay,issuer}'` path, the raise message. Stripping literals here
+-- would delete the very text being located and make the `not like` vacuously true
+-- forever. Comments (all forms, INCLUDING NESTED) are still removed, so the
+-- message-board#196 comment masks are closed; a literal mask is inherent to a
+-- literal marker, which is why the isolation spec and not this line is the
+-- load-bearing guard.
 select ok(
-  pg_get_functiondef('agent_board.revoke_human_subtree(uuid,uuid,text)'::regprocedure)
+  agent_board_test.stripped_body('agent_board.revoke_human_subtree(uuid,uuid,text)'::regprocedure, true)
     like '%from auth.users u where u.id = p_owner_user_id for update%where a.owner_user_id = p_owner_user_id%jsonb_typeof(a.metadata -> ''federation'') = ''object''%not exists (%from agent_board.enrollment_federation_audit e%where e.agent_id = a.id%stable federation evidence not found for every linked agent%insert into agent_board.fleet_human_revocations%issuer, subject, owner_user_id%on conflict (issuer, subject) do nothing%where owner_user_id = p_owner_user_id%order by id%'
-    and pg_get_functiondef('agent_board.revoke_human_subtree(uuid,uuid,text)'::regprocedure)
+    and agent_board_test.stripped_body('agent_board.revoke_human_subtree(uuid,uuid,text)'::regprocedure, true)
       not like '%metadata #>> ''{federation,replay,issuer}''%',
   'total human revocation requires per-agent audit evidence before marking and enumeration'
 );
@@ -458,16 +433,10 @@ select ok(
 -- Ordering, not mere presence: the lock has to be held BEFORE the authorization
 -- decision reads the (possibly absent) ceiling, and BEFORE the writer upserts it.
 select ok(
-  strpos(
-    pg_temp._stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure),
-    'perform agent_board._lock_board_authority_ceiling(v_inv.board_id)'
+  strpos(lower(agent_board_test.stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure)), 'perform agent_board._lock_board_authority_ceiling(v_inv.board_id)'
   ) > 0
-  and strpos(
-    pg_temp._stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure),
-    'perform agent_board._lock_board_authority_ceiling(v_inv.board_id)'
-  ) < strpos(
-    pg_temp._stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure),
-    'agent_board._grant_within_ceiling('
+  and strpos(lower(agent_board_test.stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure)), 'perform agent_board._lock_board_authority_ceiling(v_inv.board_id)'
+  ) < strpos(lower(agent_board_test.stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure)), 'agent_board._grant_within_ceiling('
   ),
   'atomic onboarding holds the board ceiling lock before evaluating creator authority [REDUNDANT: implied by the advisory-before-boards and boards-before-ceiling-read claims below; an advisory moved between those two points violates the real ordering and still passes THIS one]'
 );
@@ -479,16 +448,10 @@ select ok(
 -- that catches the inversion; it is deliberately separate from the "before the
 -- ceiling read" assertion below, because that one passes in BOTH orders.
 select ok(
-  strpos(
-    pg_temp._stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure),
-    'perform agent_board._lock_board_authority_ceiling(v_inv.board_id)'
+  strpos(lower(agent_board_test.stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure)), 'perform agent_board._lock_board_authority_ceiling(v_inv.board_id)'
   ) > 0
-  and strpos(
-    pg_temp._stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure),
-    'perform agent_board._lock_board_authority_ceiling(v_inv.board_id)'
-  ) < strpos(
-    pg_temp._stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure),
-    'from agent_board.boards b
+  and strpos(lower(agent_board_test.stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure)), 'perform agent_board._lock_board_authority_ceiling(v_inv.board_id)'
+  ) < strpos(lower(agent_board_test.stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure)), 'from agent_board.boards b
    where b.id = v_inv.board_id
    for update'
   ),
@@ -508,34 +471,22 @@ select ok(
 -- ordering nothing else states, because the boards lock is taken for board liveness,
 -- not for the ceiling. Pin the ordering so a refactor that moves it is not silent.
 select ok(
-  strpos(
-    pg_temp._stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure),
-    'from agent_board.boards b
+  strpos(lower(agent_board_test.stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure)), 'from agent_board.boards b
    where b.id = v_inv.board_id
    for update'
   ) > 0
-  and strpos(
-    pg_temp._stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure),
-    'from agent_board.boards b
+  and strpos(lower(agent_board_test.stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure)), 'from agent_board.boards b
    where b.id = v_inv.board_id
    for update'
-  ) < strpos(
-    pg_temp._stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure),
-    'agent_board._grant_within_ceiling('
+  ) < strpos(lower(agent_board_test.stripped_body('agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text)'::regprocedure)), 'agent_board._grant_within_ceiling('
   ),
   'atomic onboarding holds the boards row FOR UPDATE before it reads the ceiling [CONFIRMATORY FOR FLAT MASKS ONLY: agent_board_federated_lock_order_class.test.sql EC-3 fails by name on the comment/literal mutants, but it carries the SAME strip, so a NESTED block comment takes this assertion and EC-3 green together -- see #199 in the header; atomic_fleet_authority_races.spec pins the OUTCOME only when this lock and the advisory are BOTH gone, and atomic_fleet_board_archive.spec BLOCKS rather than failing by name]'
 );
 select ok(
-  strpos(
-    pg_temp._stripped_body('agent_board.set_board_authority_ceiling(uuid,text)'::regprocedure),
-    'perform agent_board._lock_board_authority_ceiling(p_board_id)'
+  strpos(lower(agent_board_test.stripped_body('agent_board.set_board_authority_ceiling(uuid,text,uuid)'::regprocedure)), 'perform agent_board._lock_board_authority_ceiling(p_board_id)'
   ) > 0
-  and strpos(
-    pg_temp._stripped_body('agent_board.set_board_authority_ceiling(uuid,text)'::regprocedure),
-    'perform agent_board._lock_board_authority_ceiling(p_board_id)'
-  ) < strpos(
-    pg_temp._stripped_body('agent_board.set_board_authority_ceiling(uuid,text)'::regprocedure),
-    'insert into agent_board.board_authority_ceilings'
+  and strpos(lower(agent_board_test.stripped_body('agent_board.set_board_authority_ceiling(uuid,text,uuid)'::regprocedure)), 'perform agent_board._lock_board_authority_ceiling(p_board_id)'
+  ) < strpos(lower(agent_board_test.stripped_body('agent_board.set_board_authority_ceiling(uuid,text,uuid)'::regprocedure)), 'insert into agent_board.board_authority_ceilings'
   ),
   'the ceiling setter holds the same lock before its owner gate and upsert [BACKSTOP: tests/isolation/specs/ceiling_setter_lock_before_upsert.spec]'
 );
@@ -550,12 +501,22 @@ select ok(
 select is( -- pgtap-allow-raise-checked: catalog read only; the RPC names below are string literals in the expected array, never invoked
   (select array_agg(entry order by entry) from (
      select 'agent_board.' || regexp_replace(p.oid::regprocedure::text, '^([^(]*\.)?', '') || ' => ' ||
-            case when strpos(p.prosrc, '_lock_board_authority_ceiling') > 0
+            -- CALL SHAPE, not strpos on a bare name: this is the dangerous
+            -- direction -- a reader that DROPS the lock but keeps a variable named
+            -- after it would still print "serialized".
+      -- SCHEMA-QUALIFIED, because a bare-name anchor proves call SYNTAX, not callee
+      -- IDENTITY: `\m_lock_board_authority_ceiling\s*\(` also matches
+      -- `zz_other._lock_board_authority_ceiling(...)` (measured true). Every live call
+      -- site in agent_board is `agent_board.`-qualified, so requiring the
+      -- qualification costs nothing today and is fail-CLOSED if someone later writes
+      -- an unqualified call (it reads as NOT calling). Overload count is pinned
+      -- separately, so schema + name is the identity.
+            case when agent_board_test.stripped_body(p.oid) ~* '\magent_board\._lock_board_authority_ceiling\s*\('
                  then 'serialized' else 'UNSERIALIZED' end as entry
        from pg_proc p
        join pg_namespace n on n.oid = p.pronamespace
       where n.nspname = 'agent_board'
-        and strpos(p.prosrc, '_grant_within_ceiling') > 0
+        and strpos(lower(agent_board_test.stripped_body(p.oid)), '_grant_within_ceiling') > 0
    ) readers),
   array[
     'agent_board._redeem_unbounded_invite_for_agent(text,uuid) => UNSERIALIZED',
@@ -594,11 +555,18 @@ select is( -- pgtap-allow-raise-checked: catalog read only; the RPC names below
        from pg_proc p
        join pg_namespace n on n.oid = p.pronamespace
       where n.nspname = 'agent_board'
-        and (strpos(p.prosrc, 'fleet_onboarding_invite_bounds') > 0
-          or strpos(p.prosrc, 'fleet_human_revocations') > 0
-          or strpos(p.prosrc, 'fleet_revocation_events') > 0
-          or strpos(p.prosrc, '_lock_board_authority_ceiling') > 0
-          or strpos(p.prosrc, 'board_authority_ceilings:') > 0)
+        -- The first four markers are CODE (relation and function names), so the
+        -- body is read with literals stripped. The fifth is the advisory-lock key
+        -- prefix, which exists ONLY as a string literal
+        -- (`hashtextextended('agent_board.board_authority_ceilings:' || ...)`), so
+        -- that one predicate must KEEP literals or _lock_board_authority_ceiling --
+        -- the single function this migration creates -- silently leaves the class.
+        -- Comments are stripped in both modes.
+        and (strpos(lower(agent_board_test.stripped_body(p.oid)), 'fleet_onboarding_invite_bounds') > 0
+          or strpos(lower(agent_board_test.stripped_body(p.oid)), 'fleet_human_revocations') > 0
+          or strpos(lower(agent_board_test.stripped_body(p.oid)), 'fleet_revocation_events') > 0
+          or strpos(lower(agent_board_test.stripped_body(p.oid)), '_lock_board_authority_ceiling') > 0
+          or strpos(agent_board_test.stripped_body(p.oid, true), 'board_authority_ceilings:') > 0)
    ) definers),
   array[
     'agent_board._lock_board_authority_ceiling(uuid) [invoker] => service_role',
@@ -611,13 +579,62 @@ select is( -- pgtap-allow-raise-checked: catalog read only; the RPC names below
     'agent_board.evaluate_fleet_sender_policy(uuid,uuid,uuid,uuid,text,uuid,boolean) [definer] => authenticated,service_role',
     'agent_board.onboard_federated_fleet_agent(text,text,text,jsonb,text,text,text,text,boolean,text,text,text[],text[],text,uuid,uuid,text,text,text,text,text,text,text) [definer] => service_role',
     'agent_board.reactivate_fleet_machine(uuid,uuid,text) [definer] => service_role',
-    'agent_board.reclaim_fleet_machine(uuid,uuid,uuid,text,uuid) [definer] => service_role',
     'agent_board.revoke_fleet_subject(text,uuid,uuid,text,jsonb) [definer] => authenticated,service_role',
     'agent_board.revoke_human_subtree(uuid,uuid,text) [definer] => service_role',
-    'agent_board.set_board_authority_ceiling(uuid,text) [definer] => authenticated,service_role'
+    'agent_board.set_board_authority_ceiling(uuid,text,uuid) [definer] => authenticated,service_role',
+    -- Joined this class in #269 F4: the signed grant wrapper now takes the board advisory lock
+    -- FIRST, because its order was board_memberships(grantee) -> agents(signer) against
+    -- onboard_federated_fleet_agent's agents -> board_memberships -- a reproduced ABBA between
+    -- two honest callers. It is service_role-only like every other signed_* wrapper (#118).
+    'agent_board.signed_grant_board_role(jsonb,jsonb) [definer] => service_role'
   ]::text[],
   'every function on this migration set''s surface is declared with its definer flag and exact EXECUTE grantees'
 );
 
+-- WHAT THE message-board#196 CONVERSION REMOVED FROM THE CLASS ABOVE, and why
+-- it is restated here instead of being silently dropped.
+--
+-- reclaim_fleet_machine was a member of that class while the predicate read RAW
+-- prosrc -- and ONLY because a `--` comment in its body says "no
+-- fleet_revocation_events row is written per binding". It was in the surface
+-- class for SAYING IT IS NOT ON THE SURFACE. Reading the stripped body removes
+-- it, which is correct: it touches none of the five surfaces.
+--
+-- Its exact-grantee pin was real coverage, though, and an accidental member's
+-- coverage is still coverage. Per CLAUDE.md rule 1 an exemption is asserted
+-- POSITIVELY, never by absence of a match, so the claim it used to carry is
+-- restated as its own assertion.
+select is(
+  (select coalesce((
+     select string_agg(distinct coalesce(pg_get_userbyid(nullif(a.grantee, 0)), 'PUBLIC'), ','
+              order by coalesce(pg_get_userbyid(nullif(a.grantee, 0)), 'PUBLIC'))
+       from aclexplode(p.proacl) a
+      where a.privilege_type = 'EXECUTE'
+        and a.grantee <> p.proowner), '(none)')
+     || case when p.prosecdef then ' [definer]' else ' [invoker]' end
+     from pg_proc p
+     join pg_namespace n on n.oid = p.pronamespace
+    where n.nspname = 'agent_board'
+      -- identity by OID + identity-arguments, never by a rendered regprocedure:
+      -- this file puts agent_board on search_path, so `oid::regprocedure::text`
+      -- renders UNQUALIFIED and an 'agent_board.…' comparison silently matches
+      -- nothing (measured: this assertion read NULL until it was written this way).
+      and 'agent_board.' || regexp_replace(p.oid::regprocedure::text, '^([^(]*\.)?', '')
+          = 'agent_board.reclaim_fleet_machine(uuid,uuid,uuid,text,uuid)'),
+  'service_role [definer]',
+  'reclaim_fleet_machine -- off this surface once comments are stripped -- keeps its service_role-only definer grant'
+);
+
+
+-- The schema-qualified call anchor above treats `agent_board._lock_board_authority_ceiling` as an
+-- IDENTITY. That is only true while the name resolves to exactly one function:
+-- a second overload would be a different implementation the same anchor accepts.
+-- Catalog-derived, so a new overload fails here and the count names itself.
+select is(
+  (select count(*)::int from pg_proc p join pg_namespace n on n.oid = p.pronamespace
+    where n.nspname = 'agent_board' and p.proname = '_lock_board_authority_ceiling'),
+  1,
+  'agent_board._lock_board_authority_ceiling has exactly ONE overload, so the schema-qualified call anchor identifies it uniquely');
+
 select * from finish();
 rollback;

package/tests/agent_board_claimkey.test.sql

@@ -16,7 +16,7 @@ set search_path = extensions, public, agent_board;
 
 begin;
 
-select plan(25);
+select plan(26);
 
 select set_config('request.jwt.claim.role', 'service_role', true);
 select set_config('request.jwt.claim.sub', '', true);
@@ -219,11 +219,33 @@ select is(
      join pg_namespace n on n.oid = p.pronamespace
     where n.nspname = 'agent_board'
       and p.prokind = 'f'
-      and pg_get_functiondef(p.oid) ~* '(insert\s+into|update)\s+(agent_board\.)?claims\M'
-      and pg_get_functiondef(p.oid) !~ '_canonical_claim_key'),
+      and agent_board_test.stripped_body(p.oid) ~* '(insert\s+into|update)\s+(agent_board\.)?claims\M'
+      -- message-board#196 Bucket B: read RAW, one comment naming _canonical_claim_key
+      -- dropped a bypass writer out of this set and the count went to 0 green.
+      -- anchored to the CALL shape: a bare-substring `!~` is satisfied by any
+      -- identifier containing the name, e.g. an argument `p_canonical_claim_key`.
+      -- SCHEMA-QUALIFIED, because a bare-name anchor proves call SYNTAX, not callee
+      -- IDENTITY: `\m_canonical_claim_key\s*\(` also matches
+      -- `zz_other._canonical_claim_key(...)` (measured true). Every live call
+      -- site in agent_board is `agent_board.`-qualified, so requiring the
+      -- qualification costs nothing today and is fail-CLOSED if someone later writes
+      -- an unqualified call (it reads as NOT calling). Overload count is pinned
+      -- separately, so schema + name is the identity.
+      and agent_board_test.stripped_body(p.oid) !~* '\magent_board\._canonical_claim_key\s*\('),
   0,
   'every catalog-enumerated claims writer routes its resource_key through _canonical_claim_key');
 
+
+-- The schema-qualified call anchor above treats `agent_board._canonical_claim_key` as an
+-- IDENTITY. That is only true while the name resolves to exactly one function:
+-- a second overload would be a different implementation the same anchor accepts.
+-- Catalog-derived, so a new overload fails here and the count names itself.
+select is(
+  (select count(*)::int from pg_proc p join pg_namespace n on n.oid = p.pronamespace
+    where n.nspname = 'agent_board' and p.proname = '_canonical_claim_key'),
+  1,
+  'agent_board._canonical_claim_key has exactly ONE overload, so the schema-qualified call anchor identifies it uniquely');
+
 select * from finish();
 
 rollback;

package/tests/agent_board_consent_emission.test.sql

@@ -222,21 +222,18 @@ select is(
 -- anywhere in the body is fail-open twice over: the name in a comment or a dead branch would
 -- satisfy it, and calling the emitter TWICE would too -- while this suite claims exactly one
 -- event per transition.
--- Strips BOTH comment forms. The first version stripped only `--`, so a /* */ commented-out
--- call still satisfied the completeness assertion.
-create function pg_temp.code(p_oid oid) returns text language sql stable as $$
-  select regexp_replace(
-           regexp_replace(pg_get_functiondef(p_oid), '/\*.*?\*/', '', 'gs'),
-           '--[^\n]*', '', 'g');
-$$;
+-- The stripped reader is agent_board_test.stripped_body(), shared by the whole
+-- suite from tests/fixtures/test-prereqs.sql. The local version this replaces
+-- stripped both comment forms with a regex -- which still could not see a NESTED
+-- block comment (message-board#199) or a string literal.
 
 select is(
   (select coalesce(string_agg(p.proname, ', ' order by p.proname), '')
      from pg_proc p join pg_namespace n on n.oid = p.pronamespace
     where n.nspname = 'agent_board' and p.prokind = 'f'
       and p.prolang <> (select oid from pg_language where lanname = 'internal')
-      and pg_temp.code(p.oid) ~* '(insert into|update)[[:space:]]+agent_board\.board_memberships'
-      and pg_temp.code(p.oid) !~ 'perform agent_board\._emit_membership_event'
+      and agent_board_test.stripped_body(p.oid) ~* '(insert into|update)[[:space:]]+agent_board\.board_memberships'
+      and agent_board_test.stripped_body(p.oid) !~* 'perform agent_board\._emit_membership_event'
       and p.proname <> 'grant_board_role'),
   '',
   'COMPLETENESS: every function writing board_memberships emits, or is a stated exemption');
@@ -244,14 +241,21 @@ select is(
 -- ...and none of them emits MORE than once, which would break one-event-per-transition.
 select is(
   (select coalesce(string_agg(p.proname || '=' ||
-            (length(pg_temp.code(p.oid)) - length(replace(pg_temp.code(p.oid),
+            (length(agent_board_test.stripped_body(p.oid)) - length(replace(lower(agent_board_test.stripped_body(p.oid)),
               'perform agent_board._emit_membership_event', '')))
             / length('perform agent_board._emit_membership_event'), ', ' order by p.proname), '')
      from pg_proc p join pg_namespace n on n.oid = p.pronamespace
     where n.nspname = 'agent_board' and p.prokind = 'f'
       and p.prolang <> (select oid from pg_language where lanname = 'internal')
-      and pg_temp.code(p.oid) ~ 'perform agent_board\._emit_membership_event'
-      and (length(pg_temp.code(p.oid)) - length(replace(pg_temp.code(p.oid),
+      -- CASE-INSENSITIVE, and that is load-bearing rather than tidiness. SQL folds
+      -- unquoted identifiers, but `prosrc` is stored VERBATIM, so a writer spelling
+      -- the same call `AGENT_BOARD.…` or the same column `FINGERPRINT` is identical
+      -- to PostgreSQL and invisible to a case-sensitive scan. For a MEMBERSHIP
+      -- filter that is the fail-OPEN direction: the offender simply leaves the
+      -- class and the expected-empty assertion stays green. (Same mechanism
+      -- agent_board_wake_recovery.test.sql records for its own WR-7 filter.)
+      and agent_board_test.stripped_body(p.oid) ~* 'perform agent_board\._emit_membership_event'
+      and (length(agent_board_test.stripped_body(p.oid)) - length(replace(lower(agent_board_test.stripped_body(p.oid)),
             'perform agent_board._emit_membership_event', '')))
           / length('perform agent_board._emit_membership_event') <> 1),
   '',
@@ -259,7 +263,7 @@ select is(
 
 -- ...and the one exemption is genuinely state-blind: membership_state never appears in a SET.
 select ok(
-  (select pg_get_functiondef(p.oid) !~* 'set[^;]*membership_state[[:space:]]*='
+  (select agent_board_test.stripped_body(p.oid) !~* 'set[^;]*membership_state[[:space:]]*='
      from pg_proc p join pg_namespace n on n.oid = p.pronamespace
     where n.nspname = 'agent_board' and p.proname = 'grant_board_role'),
   'COMPLETENESS: the exemption holds -- grant_board_role never SETs membership_state');

package/tests/agent_board_consent_gating.test.sql

@@ -17,7 +17,7 @@ set search_path = extensions, public, agent_board;
 
 begin;
 
-select plan(53);
+select plan(54);
 
 create function pg_temp.claims(p_sub text) returns void language plpgsql as $$
 begin
@@ -298,14 +298,44 @@ select is(
       and p.prolang <> (select oid from pg_language where lanname = 'internal')
       and has_function_privilege('authenticated', p.oid, 'EXECUTE')
       -- reaches an active membership, directly or through the shared sink
-      and regexp_replace(pg_get_functiondef(p.oid), '--[^\n]*', '', 'g')
+      and agent_board_test.stripped_body(p.oid)
             -- Includes update_board_membership: a one-hop WRAPPER calling it with 'joined'
             -- reaches an active membership without ever naming the sink, and would otherwise
             -- evade this class assertion entirely.
-            ~ '(_upsert_board_membership_state|_redeem_invite_for_agent|update_board_membership|insert into agent_board\.board_memberships)'
-      -- gated: consults the predicate, or refuses a non-subject actor structurally
-      and regexp_replace(pg_get_functiondef(p.oid), '--[^\n]*', '', 'g')
-            !~ '(_membership_consent_present|actor mismatch|requires an act by that agent)'
+      -- CASE-INSENSITIVE, and that is load-bearing rather than tidiness. SQL folds
+      -- unquoted identifiers, but `prosrc` is stored VERBATIM, so a writer spelling
+      -- the same call `AGENT_BOARD.…` or the same column `FINGERPRINT` is identical
+      -- to PostgreSQL and invisible to a case-sensitive scan. For a MEMBERSHIP
+      -- filter that is the fail-OPEN direction: the offender simply leaves the
+      -- class and the expected-empty assertion stays green. (Same mechanism
+      -- agent_board_wake_recovery.test.sql records for its own WR-7 filter.)
+            ~* '(_upsert_board_membership_state|_redeem_invite_for_agent|update_board_membership|insert into agent_board\.board_memberships)'
+      -- gated: consults the predicate, or refuses a non-subject actor structurally.
+      --
+      -- SPLIT IN TWO, by what kind of thing each marker IS. The single `!~` over a
+      -- three-way alternation could not be read correctly in either mode: the
+      -- helper name is CODE and the other two are raise MESSAGES, so
+      -- literal-stripping deleted the messages (every route then looked ungated)
+      -- and literal-keeping left the messages maskable by any string.
+      --
+      -- The message half is therefore ANCHORED TO THE STATEMENT SHAPE
+      -- (message-board#196 remedy 2) rather than to the bare message: the text has
+      -- to follow a `raise exception` to count. Measured before the split: a
+      -- `raise debug 'gate: %', '_membership_consent_present';` planted in an
+      -- ungated update_board_membership took this class assertion GREEN with the
+      -- gate genuinely removed. It does not any more.
+      -- anchored to the CALL shape, for the same reason the message half below is
+      -- anchored to the raise shape: a bare substring is satisfied by a NAME.
+      -- SCHEMA-QUALIFIED, because a bare-name anchor proves call SYNTAX, not callee
+      -- IDENTITY: `\m_membership_consent_present\s*\(` also matches
+      -- `zz_other._membership_consent_present(...)` (measured true). Every live call
+      -- site in agent_board is `agent_board.`-qualified, so requiring the
+      -- qualification costs nothing today and is fail-CLOSED if someone later writes
+      -- an unqualified call (it reads as NOT calling). Overload count is pinned
+      -- separately, so schema + name is the identity.
+      and agent_board_test.stripped_body(p.oid) !~* '\magent_board\._membership_consent_present\s*\('
+      and agent_board_test.stripped_body(p.oid, true)
+            !~ 'raise[[:space:]]+exception[^;]{0,250}(actor mismatch|requires an act by that agent)'
       -- stated exemptions, each with a reason recorded in the migration header
       and p.proname not in (
         'create_board',        -- the actor IS the subject: it seeds the creator's own seat
@@ -329,7 +359,9 @@ select is(
      from pg_proc p
      join pg_namespace n on n.oid = p.pronamespace
      cross join lateral regexp_matches(
-       regexp_replace(pg_get_functiondef(p.oid), '--[^\n]*', '', 'g'),
+       -- LITERALS KEPT: the marker is the ARGUMENT ''joined''/''subscribed'' passed
+       -- to the sink -- a string literal in the code being matched.
+       agent_board_test.stripped_body(p.oid, true),
        '(?:_upsert_board_membership_state|update_board_membership)\s*\([^;]*?''(joined|subscribed)''',
        'g') m
     where n.nspname = 'agent_board'
@@ -343,7 +375,8 @@ select is(
      from pg_proc p
      join pg_namespace n on n.oid = p.pronamespace
      cross join lateral regexp_matches(
-       regexp_replace(pg_get_functiondef(p.oid), '--[^\n]*', '', 'g'),
+       -- LITERALS KEPT: same shape as above -- the state being written is a literal.
+       agent_board_test.stripped_body(p.oid, true),
        '(?:_upsert_board_membership_state|update_board_membership)\s*\([^;]*?''(invited|requested|left)''',
        'g') m
     where n.nspname = 'agent_board'
@@ -389,7 +422,7 @@ select is(
 -- silently reopening the race -- the classic wrong "fix" for lock-wait reports. `nowait`
 -- is excluded too (it at least fails loudly).
 select matches(
-  (select regexp_replace(regexp_replace(pg_get_functiondef(p.oid), '/\*.*?\*/', '', 'gs'), '--[^\n]*', '', 'g')
+  (select agent_board_test.stripped_body(p.oid)
      from pg_proc p join pg_namespace n on n.oid = p.pronamespace
     where n.nspname = 'agent_board' and p.proname = 'resolve_board_request'),
   'from agent_board\.board_memberships[[:space:]]+bm[[:space:]]+where bm\.board_id = p_board_id[[:space:]]+and bm\.agent_id = p_agent_id[[:space:]]+order by bm\.id[[:space:]]+for update;',
@@ -399,14 +432,14 @@ select matches(
 -- a lock taken after the check protects nothing.
 select ok(
   (select position('for update' in body) < position('_membership_consent_present' in body)
-     from (select regexp_replace(regexp_replace(pg_get_functiondef(p.oid), '/\*.*?\*/', '', 'gs'), '--[^\n]*', '', 'g') as body
+     from (select agent_board_test.stripped_body(p.oid) as body
              from pg_proc p join pg_namespace n on n.oid = p.pronamespace
             where n.nspname = 'agent_board' and p.proname = 'resolve_board_request') s),
   'LOCK: ...and reads consent AFTER taking it, not before');
 
 -- The sink acts on the row the CALLER named, rather than reselecting (#109).
 select matches(
-  (select regexp_replace(pg_get_functiondef(p.oid), '--[^\n]*', '', 'g')
+  (select agent_board_test.stripped_body(p.oid)
      from pg_proc p join pg_namespace n on n.oid = p.pronamespace
     where n.nspname = 'agent_board' and p.proname = '_upsert_board_membership_state'),
   'if p_membership_id is not null then',
@@ -485,5 +518,16 @@ select is(
 select is((select version from agent_board.schema_version), 8,
   'schema_version stays 8 -- additive');
 
+
+-- The schema-qualified call anchor above treats `agent_board._membership_consent_present` as an
+-- IDENTITY. That is only true while the name resolves to exactly one function:
+-- a second overload would be a different implementation the same anchor accepts.
+-- Catalog-derived, so a new overload fails here and the count names itself.
+select is(
+  (select count(*)::int from pg_proc p join pg_namespace n on n.oid = p.pronamespace
+    where n.nspname = 'agent_board' and p.proname = '_membership_consent_present'),
+  1,
+  'agent_board._membership_consent_present has exactly ONE overload, so the schema-qualified call anchor identifies it uniquely');
+
 select finish();
 rollback;

package/tests/agent_board_delegation_policies.test.sql

@@ -94,7 +94,9 @@ select is(
   false, 'over-ceiling grant is rejected (owner cannot grant admin when ceiling is member)');
 
 -- #13 owner-settable ceiling: set_board_authority_ceiling is owner-gated. ---------
-select has_function('agent_board', 'set_board_authority_ceiling', array['uuid','text'],
+-- #247 added the delegable p_actor_agent_id (null default => the pre-#247 path for every
+-- role), so the identity signature is (uuid, text, uuid).
+select has_function('agent_board', 'set_board_authority_ceiling', array['uuid','text','uuid'],
   'set_board_authority_ceiling exists');
 
 set local role authenticated;