@consiliency/agent-board-schema 1.24.0 → 1.25.0

package/tests/agent_board_outbox_wake_ordering.test.sql

@@ -93,8 +93,13 @@ select is(
     where n.nspname = 'agent_board'
       and p.prokind = 'f'
       and p.prolang <> (select oid from pg_language where lanname = 'internal')
-      and regexp_replace(pg_get_functiondef(p.oid), '--[^\n]*', '', 'g')
-            ~ 'insert into agent_board\.callback_outbox_events'),
+      -- CODE marker -> case-INSENSITIVE. PostgreSQL folds unquoted identifiers, so
+      -- `INSERT INTO AGENT_BOARD.CALLBACK_OUTBOX_EVENTS` is the same statement and a
+      -- case-sensitive scan drops that writer OUT of this exact set -- the fail-open
+      -- direction for a class filter. Missed by the round-3 sweep because that audit
+      -- was LINE-anchored and this predicate's operator sits on the next line.
+      and agent_board_test.stripped_body(p.oid)
+            ~* 'insert into agent_board\.callback_outbox_events'),
   '_queue_board_post_callbacks, _queue_inbox_callbacks',
   'WO-3 CLASS: the catalog names exactly the two known outbox writers -- a new writer fails here and NAMES ITSELF');
 
@@ -108,9 +113,9 @@ select is(
     where n.nspname = 'agent_board'
       and p.prokind = 'f'
       and p.prolang <> (select oid from pg_language where lanname = 'internal')
-      and regexp_replace(pg_get_functiondef(p.oid), '--[^\n]*', '', 'g')
+      and agent_board_test.stripped_body(p.oid)
             ~* 'insert into agent_board\.callback_outbox_events'
-      and regexp_replace(pg_get_functiondef(p.oid), '--[^\n]*', '', 'g')
+      and agent_board_test.stripped_body(p.oid)
             ~* 'overriding\s+(system|user)\s+value'),
   '',
   'WO-3 CLASS: no outbox writer uses OVERRIDING SYSTEM VALUE -- the identity bypass stays closed');
@@ -119,16 +124,16 @@ select is(
 -- WO-4 ORDERING
 -- ---------------------------------------------------------------------------
 select ok(
-  (select regexp_replace(pg_get_functiondef(p.oid), '--[^\n]*', '', 'g')
-            ~ 'order by coe\.available_at asc, coe\.seq asc'
+  (select agent_board_test.stripped_body(p.oid)
+            ~* 'order by coe\.available_at asc, coe\.seq asc'
      from pg_proc p
      join pg_namespace n on n.oid = p.pronamespace
     where n.nspname = 'agent_board' and p.proname = 'claim_callback_outbox_events'),
   'WO-4 claim_callback_outbox_events orders candidates by (available_at, seq)');
 
 select ok(
-  (select regexp_replace(pg_get_functiondef(p.oid), '--[^\n]*', '', 'g')
-            !~ 'coe\.id asc'
+  (select agent_board_test.stripped_body(p.oid)
+            !~* 'coe\.id asc'
      from pg_proc p
      join pg_namespace n on n.oid = p.pronamespace
     where n.nspname = 'agent_board' and p.proname = 'claim_callback_outbox_events'),
@@ -141,8 +146,8 @@ select ok(
 -- mutation produces NO failure. A property no mutation can break is not covered, so the
 -- pin has to be stated where the mutation actually lands.
 select ok(
-  (select regexp_replace(pg_get_functiondef(p.oid), '--[^\n]*', '', 'g')
-            ~ 'order by u\.seq asc'
+  (select agent_board_test.stripped_body(p.oid)
+            ~* 'order by u\.seq asc'
      from pg_proc p
      join pg_namespace n on n.oid = p.pronamespace
     where n.nspname = 'agent_board' and p.proname = 'claim_callback_outbox_events'),
@@ -201,7 +206,12 @@ select is(
      from pg_proc p
     where p.pronamespace = 'agent_board'::regnamespace
       and p.prosecdef
-      and pg_get_functiondef(p.oid) ~ 'callback_outbox_events'
+      -- CODE marker in a CLASS FILTER -> stripped + case-INSENSITIVE, matching WO-3
+      -- above. Raw text lets a comment pull a function IN (fail-closed, a false
+      -- alarm); case-sensitivity lets a function spelling the table
+      -- `AGENT_BOARD.CALLBACK_OUTBOX_EVENTS` drop OUT, so its executability is
+      -- never checked at all -- fail-OPEN, on a privilege gate.
+      and agent_board_test.stripped_body(p.oid) ~* 'callback_outbox_events'
       and (has_function_privilege('public', p.oid, 'EXECUTE')
         or has_function_privilege('anon', p.oid, 'EXECUTE')
         or has_function_privilege('authenticated', p.oid, 'EXECUTE'))),
@@ -213,7 +223,12 @@ select is(
      from pg_proc p
     where p.pronamespace = 'agent_board'::regnamespace
       and p.prosecdef
-      and pg_get_functiondef(p.oid) ~ 'callback_outbox_events'
+      -- CODE marker in a CLASS FILTER -> stripped + case-INSENSITIVE, matching WO-3
+      -- above. Raw text lets a comment pull a function IN (fail-closed, a false
+      -- alarm); case-sensitivity lets a function spelling the table
+      -- `AGENT_BOARD.CALLBACK_OUTBOX_EVENTS` drop OUT, so its executability is
+      -- never checked at all -- fail-OPEN, on a privilege gate.
+      and agent_board_test.stripped_body(p.oid) ~* 'callback_outbox_events'
       and not has_function_privilege('service_role', p.oid, 'EXECUTE')),
   '',
   'WO-5 CLASS: every SECURITY DEFINER function reaching callback_outbox_events is executable by service_role -- a dropped-and-recreated function that lost its grant names itself here');

package/tests/agent_board_rejectsem.test.sql

@@ -260,7 +260,7 @@ select is(pg_temp.state('b2000000-0000-4000-8000-000000000001','b1000000-0000-40
 select is(
   (select count(*)::int from pg_proc p join pg_namespace n on n.oid = p.pronamespace
     where n.nspname = 'agent_board' and p.proname = 'resolve_board_request'
-      and regexp_replace(pg_get_functiondef(p.oid), '--[^\n]*', '', 'g') ~ 'v_effective_state'),
+      and agent_board_test.stripped_body(p.oid) ~* 'v_effective_state'),
   1,
   'the rewrite happens in resolve_board_request, not in the shared sink');
 

package/tests/agent_board_rolereset.test.sql

@@ -28,7 +28,7 @@ set search_path = extensions, public, agent_board;
 
 begin;
 
-select plan(23);
+select plan(24);
 
 create temp table _rr_fixture (
   open_board uuid,
@@ -133,7 +133,17 @@ select is(
 
 -- 3. Redemption bypasses the mutator entirely, so the clamp cannot reach its preset. -
 select ok(
-  (select pg_get_functiondef(p.oid) not like '%_upsert_board_membership_state%'
+  -- anchored to the CALL shape rather than a bare `like '%…%'`: the claim is
+  -- that redemption never CALLS the mutator, and a variable or argument merely
+  -- named after it is not a call.
+      -- SCHEMA-QUALIFIED, because a bare-name anchor proves call SYNTAX, not callee
+      -- IDENTITY: `\m_upsert_board_membership_state\s*\(` also matches
+      -- `zz_other._upsert_board_membership_state(...)` (measured true). Every live call
+      -- site in agent_board is `agent_board.`-qualified, so requiring the
+      -- qualification costs nothing today and is fail-CLOSED if someone later writes
+      -- an unqualified call (it reads as NOT calling). Overload count is pinned
+      -- separately, so schema + name is the identity.
+  (select agent_board_test.stripped_body(p.oid) !~* '\magent_board\._upsert_board_membership_state\s*\('
      from pg_proc p join pg_namespace n on n.oid = p.pronamespace
     where n.nspname = 'agent_board' and p.proname = '_redeem_invite_for_agent'
     limit 1),
@@ -346,6 +356,17 @@ select is(
 select set_config('request.jwt.claim.role', '', true);
 select set_config('request.jwt.claim.sub', '', true);
 
+
+-- The schema-qualified call anchor above treats `agent_board._upsert_board_membership_state` as an
+-- IDENTITY. That is only true while the name resolves to exactly one function:
+-- a second overload would be a different implementation the same anchor accepts.
+-- Catalog-derived, so a new overload fails here and the count names itself.
+select is(
+  (select count(*)::int from pg_proc p join pg_namespace n on n.oid = p.pronamespace
+    where n.nspname = 'agent_board' and p.proname = '_upsert_board_membership_state'),
+  1,
+  'agent_board._upsert_board_membership_state has exactly ONE overload, so the schema-qualified call anchor identifies it uniquely');
+
 select finish();
 
 rollback;

package/tests/agent_board_rowid.test.sql

@@ -26,17 +26,18 @@ with defs as (
   select
     p.proname::text as proname,
     pg_get_function_identity_arguments(p.oid) as args,
-    regexp_replace(
-      regexp_replace(
-        pg_get_functiondef(p.oid),
-        E'--[^\\n]*(\\n|$)',
-        E'\\n',
-        'g'
-      ),
-      E'/\\*([^*]|\\*+[^*/])*\\*+/',
-      ' ',
-      'g'
-    ) as def
+    -- LITERALS STRIPPED, and re-derived rather than assumed. The first version of
+    -- this line kept literals "because some ORDER BY operands are literals"; that
+    -- was measured and is false for THIS view -- the derived checks over it match
+    -- `created_at desc` / `id desc`, which are code, and the whole file is 98/98
+    -- with literals stripped. Keeping them left a real, if narrow, hole: the site
+    -- set is built by splitting `def` on `;`, so a literal containing a semicolon
+    -- re-splits a statement and can drop it out of the set.
+    --
+    -- The two R-LINK-7 assertions below DO need literals (their patterns match the
+    -- operands `''removed''` / `''joined''`), and they read with `true`
+    -- individually. Verified by flipping them: they go red, assertions 12 and 13.
+    agent_board_test.stripped_body(p.oid) as def
   from pg_proc p
   join pg_namespace n on n.oid = p.pronamespace
   where n.nspname = 'agent_board'
@@ -582,7 +583,12 @@ select is(
 
 -- 12. EC-MBROWID-3 requires set-based removed standing, not one selected row.
 select ok(
-  (select regexp_replace(pg_get_functiondef(p.oid), '\s+', ' ', 'g') ~*
+  -- DATA literals in the marker (`''removed''`, `''joined''`, `''subscribed''` are
+  -- compared against column data, case-SENSITIVELY, at runtime), so this match is
+  -- case-sensitive too: `~*` cannot distinguish a live predicate from one rewritten
+  -- to `= ''REMOVED''`, which matches nothing. Same class as
+  -- agent_board_fleet_machine_reactivation.test.sql's `= ''machine''`.
+  (select regexp_replace(agent_board_test.stripped_body(p.oid, true), '\s+', ' ', 'g') ~
       'exists\s*\(\s*select\s+1\s+from\s+agent_board\.board_memberships.*membership_state\s*=\s*''removed''.*\)\s+and\s+not\s+exists\s*\(\s*select\s+1\s+from\s+agent_board\.board_memberships.*membership_state\s+in\s*\(\s*''joined''\s*,\s*''subscribed''\s*\)'
      from pg_proc p
      join pg_namespace n on n.oid = p.pronamespace
@@ -593,7 +599,12 @@ select ok(
 
 -- 13. Bootstrap must carry the same R-LINK-7 shape.
 select ok(
-  (select regexp_replace(pg_get_functiondef(p.oid), '\s+', ' ', 'g') ~*
+  -- DATA literals in the marker (`''removed''`, `''joined''`, `''subscribed''` are
+  -- compared against column data, case-SENSITIVELY, at runtime), so this match is
+  -- case-sensitive too: `~*` cannot distinguish a live predicate from one rewritten
+  -- to `= ''REMOVED''`, which matches nothing. Same class as
+  -- agent_board_fleet_machine_reactivation.test.sql's `= ''machine''`.
+  (select regexp_replace(agent_board_test.stripped_body(p.oid, true), '\s+', ' ', 'g') ~
       'not\s+exists\s*\(\s*select\s+1\s+from\s+agent_board\.board_memberships.*membership_state\s+in\s*\(\s*''joined''\s*,\s*''subscribed''\s*\).*\)\s+and\s+not\s+exists\s*\(\s*select\s+1\s+from\s+agent_board\.board_memberships.*membership_state\s*=\s*''removed'''
      from pg_proc p
      join pg_namespace n on n.oid = p.pronamespace

package/tests/agent_board_scoped_send_regrant.test.sql

@@ -128,13 +128,17 @@ select set_config('request.jwt.claim.role', '', true);
 select set_config('request.jwt.claim.sub', '', true);
 
 -- 6. Portal-offline static: no send RPC body references a Portal issuer / JWKS. -----
+-- LITERALS KEPT on both of these: a Portal issuer or JWKS URL would appear as a
+-- string LITERAL in the body, so the literal-stripping mode would delete exactly
+-- what the claim is looking for and both would pass forever. Comments are still
+-- stripped, so a `-- no portal here` note can no longer satisfy them.
 select ok(
-  position('portal' in lower(pg_get_functiondef(
-    'agent_board.post_board_message(uuid,uuid,uuid,text,text,text,text,text,jsonb)'::regprocedure))) = 0,
+  position('portal' in lower(agent_board_test.stripped_body(
+    'agent_board.post_board_message(uuid,uuid,uuid,text,text,text,text,text,jsonb)'::regprocedure, true))) = 0,
   'post_board_message references no Portal issuer/URL');
 select ok(
-  position('jwks' in lower(pg_get_functiondef(
-    'agent_board.post_board_message(uuid,uuid,uuid,text,text,text,text,text,jsonb)'::regprocedure))) = 0,
+  position('jwks' in lower(agent_board_test.stripped_body(
+    'agent_board.post_board_message(uuid,uuid,uuid,text,text,text,text,text,jsonb)'::regprocedure, true))) = 0,
   'post_board_message references no JWKS');
 
 select finish();