@consiliency/agent-board-schema 1.12.0 → 1.22.0

package/tests/agent_board_grants_hygiene.test.sql

@@ -0,0 +1,408 @@
+-- MBHYGIENE pgTAP: schema-version coverage and callback-policy liveness.
+--
+-- SECURITY DEFINER RPC controls are driven by JWT claims only. Direct-table RLS
+-- probes additionally SET LOCAL ROLE authenticated because PostgreSQL RLS binds
+-- to the database role, not to JWT claims.
+create extension if not exists pgtap with schema extensions;
+set search_path = extensions, public, agent_board;
+
+begin;
+
+select plan(20);
+
+create temp table _grants_hygiene_fixture (
+  owner_user uuid,
+  owner_agent uuid,
+  subscriber_user uuid,
+  subscriber_agent uuid,
+  unrelated_user uuid,
+  unrelated_agent uuid,
+  endpoint_id uuid,
+  subscription_id uuid,
+  outbox_id uuid,
+  attempt_id uuid
+) on commit drop;
+grant select on table _grants_hygiene_fixture to authenticated, service_role;
+
+do $$
+declare
+  v_suffix text := replace(substr(gen_random_uuid()::text, 1, 8), '-', '');
+  v_owner_user uuid;
+  v_owner_agent uuid := gen_random_uuid();
+  v_subscriber_user uuid;
+  v_subscriber_agent uuid := gen_random_uuid();
+  v_unrelated_user uuid;
+  v_unrelated_agent uuid := gen_random_uuid();
+  v_thread_id uuid := gen_random_uuid();
+  v_message_id uuid := gen_random_uuid();
+  v_endpoint_id uuid := gen_random_uuid();
+  v_subscription_id uuid := gen_random_uuid();
+  v_outbox_id uuid := gen_random_uuid();
+  v_attempt_id uuid := gen_random_uuid();
+begin
+  v_owner_user := public.ensure_github_user(
+    'hygiene-owner-' || v_suffix,
+    'hygiene-owner-' || v_suffix || '@example.test',
+    'hygiene-owner-' || v_suffix,
+    'HYGIENE Owner'
+  );
+  v_subscriber_user := public.ensure_github_user(
+    'hygiene-subscriber-' || v_suffix,
+    'hygiene-subscriber-' || v_suffix || '@example.test',
+    'hygiene-subscriber-' || v_suffix,
+    'HYGIENE Subscriber'
+  );
+  v_unrelated_user := public.ensure_github_user(
+    'hygiene-unrelated-' || v_suffix,
+    'hygiene-unrelated-' || v_suffix || '@example.test',
+    'hygiene-unrelated-' || v_suffix,
+    'HYGIENE Unrelated'
+  );
+
+  insert into agent_board.agents(
+    id, agent_type, kind, handle, display_name, status, auth_user_id, owner_user_id
+  )
+  values
+    (
+      v_owner_agent,
+      'agent',
+      'agent',
+      'hygiene-owner-' || v_suffix,
+      'HYGIENE Owner',
+      'active',
+      v_owner_user,
+      v_owner_user
+    ),
+    (
+      v_subscriber_agent,
+      'agent',
+      'agent',
+      'hygiene-subscriber-' || v_suffix,
+      'HYGIENE Subscriber',
+      'active',
+      v_subscriber_user,
+      v_subscriber_user
+    ),
+    (
+      v_unrelated_agent,
+      'agent',
+      'agent',
+      'hygiene-unrelated-' || v_suffix,
+      'HYGIENE Unrelated',
+      'active',
+      v_unrelated_user,
+      v_unrelated_user
+    );
+
+  insert into agent_board.threads(
+    id, thread_type, created_by_agent_id, subject
+  )
+  values (
+    v_thread_id, 'coordination', v_owner_agent, 'HYGIENE callback source'
+  );
+
+  insert into agent_board.messages(
+    id, thread_id, author_agent_id, message_sequence, message_type, body
+  )
+  values (
+    v_message_id, v_thread_id, v_owner_agent, 1, 'comment', 'HYGIENE callback source'
+  );
+
+  -- Load-bearing dead-arm arrangement: the subscriber is NOT the endpoint owner,
+  -- and the outbox recipient is also NOT the subscriber. The subscriber can reach
+  -- these rows only through callback_subscriptions.agent_id.
+  insert into agent_board.callback_endpoints(
+    id,
+    owner_agent_id,
+    endpoint_url,
+    endpoint_status,
+    verification_requested_at,
+    verified_at
+  )
+  values (
+    v_endpoint_id,
+    v_owner_agent,
+    'https://example.test/hygiene-' || v_suffix,
+    'verified',
+    timestamptz '2020-01-01',
+    timestamptz '2020-01-01'
+  );
+
+  insert into agent_board.callback_subscriptions(
+    id,
+    endpoint_id,
+    agent_id,
+    subscription_scope,
+    event_category,
+    subscription_status
+  )
+  values (
+    v_subscription_id,
+    v_endpoint_id,
+    v_subscriber_agent,
+    'own_inbox',
+    'inbox.item.delivered',
+    'active'
+  );
+
+  insert into agent_board.callback_outbox_events(
+    id,
+    endpoint_id,
+    subscription_id,
+    recipient_agent_id,
+    event_category,
+    delivery_mode,
+    source_kind,
+    source_message_id,
+    idempotency_key,
+    fetch_descriptor
+  )
+  values (
+    v_outbox_id,
+    v_endpoint_id,
+    v_subscription_id,
+    v_owner_agent,
+    'inbox.item.delivered',
+    'direct',
+    'message',
+    v_message_id,
+    'hygiene-outbox-' || v_suffix,
+    jsonb_build_object(
+      'surface', 'thread',
+      'targetId', v_thread_id::text,
+      'view', 'agent_board.v_thread_feed',
+      'filters', jsonb_build_object(),
+      'reason', 'MBHYGIENE callback policy liveness'
+    )
+  );
+
+  insert into agent_board.callback_delivery_attempts(
+    id,
+    outbox_event_id,
+    endpoint_id,
+    attempt_number,
+    attempt_outcome,
+    started_at,
+    finished_at
+  )
+  values (
+    v_attempt_id,
+    v_outbox_id,
+    v_endpoint_id,
+    1,
+    'delivered',
+    timestamptz '2020-01-01',
+    timestamptz '2020-01-01'
+  );
+
+  insert into _grants_hygiene_fixture(
+    owner_user,
+    owner_agent,
+    subscriber_user,
+    subscriber_agent,
+    unrelated_user,
+    unrelated_agent,
+    endpoint_id,
+    subscription_id,
+    outbox_id,
+    attempt_id
+  )
+  values (
+    v_owner_user,
+    v_owner_agent,
+    v_subscriber_user,
+    v_subscriber_agent,
+    v_unrelated_user,
+    v_unrelated_agent,
+    v_endpoint_id,
+    v_subscription_id,
+    v_outbox_id,
+    v_attempt_id
+  );
+end
+$$;
+
+-- 1. Initial service/operator control.
+select set_config('request.jwt.claim.role', '', true);
+select set_config('request.jwt.claim.sub', '', true);
+select is(
+  agent_board._is_service_role(),
+  true,
+  'control: grants-hygiene fixture block really runs as service_role');
+
+-- 2-7. schema_version is a service-role island with defense-in-depth RLS.
+select is(
+  (
+    select c.relrowsecurity
+    from pg_class c
+    join pg_namespace n on n.oid = c.relnamespace
+    where n.nspname = 'agent_board'
+      and c.relname = 'schema_version'
+      and c.relkind = 'r'
+  ),
+  true,
+  'schema_version has row level security enabled');
+
+select ok(
+  exists (
+    select 1
+    from pg_policy p
+    where p.polrelid = 'agent_board.schema_version'::regclass
+      and p.polpermissive
+      and p.polcmd = 'r'
+      and pg_get_expr(p.polqual, p.polrelid) = 'true'
+  ),
+  'schema_version has an explicit permissive read policy');
+
+select ok(
+  not has_table_privilege(
+    'authenticated',
+    'agent_board.schema_version',
+    'SELECT'
+  ),
+  'schema_version has no authenticated SELECT grant');
+
+select ok(
+  not has_table_privilege('anon', 'agent_board.schema_version', 'SELECT'),
+  'schema_version has no anon SELECT grant');
+
+select is(
+  (select version from agent_board.get_schema_version()),
+  8,
+  'service/operator get_schema_version RPC still returns version 8');
+
+set local role service_role;
+select is(
+  (select version from agent_board.schema_version),
+  8,
+  'service_role direct schema_version read remains allowed under RLS');
+reset role;
+
+-- Subscriber JWT controls run before SET LOCAL ROLE so the internal helpers remain
+-- callable. The following RPC probe intentionally stays JWT-only.
+select set_config('request.jwt.claim.role', 'authenticated', true);
+select set_config(
+  'request.jwt.claim.sub',
+  (select subscriber_user::text from _grants_hygiene_fixture),
+  true
+);
+
+-- 8-10. Required authenticated controls plus the RPC-only ALLOW contract.
+select is(
+  agent_board._is_service_role(),
+  false,
+  'control: subscriber callback block is not service_role');
+select is(
+  agent_board.current_agent_id(),
+  (select subscriber_agent from _grants_hygiene_fixture),
+  'control: subscriber callback block resolves the expected actor');
+select is(
+  (select version from agent_board.get_schema_version()),
+  8,
+  'authenticated get_schema_version RPC remains available without direct table access');
+
+-- Direct table and RLS probes require the database role switch.
+set local role authenticated;
+
+-- 11. Direct schema_version remains denied by the deployed RPC-only grant posture.
+select throws_ok(
+  $$select version from agent_board.schema_version$$,
+  '42501',
+  null,
+  'authenticated direct schema_version read remains denied');
+
+-- 12-13. Arrangement controls: subscriber is not endpoint owner, while the
+-- callback_subscriptions policy's separate EXISTS keeps its subscriber arm live.
+select is(
+  (
+    select count(*)::int
+    from agent_board.callback_endpoints ce
+    where ce.id = (select endpoint_id from _grants_hygiene_fixture)
+  ),
+  0,
+  'subscriber cannot read the foreign-owned callback endpoint');
+
+select is(
+  (
+    select count(*)::int
+    from agent_board.callback_subscriptions cs
+    where cs.id = (select subscription_id from _grants_hygiene_fixture)
+  ),
+  1,
+  'subscriber can read its callback subscription despite not owning the endpoint');
+
+-- 14-15. ALLOW: both formerly-dead subscriber arms must return their own rows.
+select is(
+  (
+    select count(*)::int
+    from agent_board.callback_outbox_events coe
+    where coe.id = (select outbox_id from _grants_hygiene_fixture)
+  ),
+  1,
+  'non-owner subscriber can read its callback outbox event');
+
+select is(
+  (
+    select count(*)::int
+    from agent_board.callback_delivery_attempts cda
+    where cda.id = (select attempt_id from _grants_hygiene_fixture)
+  ),
+  1,
+  'non-owner subscriber can read its callback delivery attempt');
+
+reset role;
+
+-- Unrelated-agent DENY twin, again with JWT controls before the DB role switch.
+select set_config(
+  'request.jwt.claim.sub',
+  (select unrelated_user::text from _grants_hygiene_fixture),
+  true
+);
+
+-- 16-17. Required non-vacuity controls.
+select is(
+  agent_board._is_service_role(),
+  false,
+  'control: unrelated callback block is not service_role');
+select is(
+  agent_board.current_agent_id(),
+  (select unrelated_agent from _grants_hygiene_fixture),
+  'control: unrelated callback block resolves the expected actor');
+
+set local role authenticated;
+
+-- 18-20. DENY: an unrelated agent sees none of the callback chain.
+select is(
+  (
+    select count(*)::int
+    from agent_board.callback_subscriptions cs
+    where cs.id = (select subscription_id from _grants_hygiene_fixture)
+  ),
+  0,
+  'unrelated agent cannot read the callback subscription');
+
+select is(
+  (
+    select count(*)::int
+    from agent_board.callback_outbox_events coe
+    where coe.id = (select outbox_id from _grants_hygiene_fixture)
+  ),
+  0,
+  'unrelated agent cannot read the callback outbox event');
+
+select is(
+  (
+    select count(*)::int
+    from agent_board.callback_delivery_attempts cda
+    where cda.id = (select attempt_id from _grants_hygiene_fixture)
+  ),
+  0,
+  'unrelated agent cannot read the callback delivery attempt');
+
+reset role;
+select set_config('request.jwt.claim.role', '', true);
+select set_config('request.jwt.claim.sub', '', true);
+
+select finish();
+
+rollback;

package/tests/agent_board_identity_providers.test.sql

@@ -77,6 +77,15 @@ select is(
     where issuer = 'https://portal.consiliency.io'),
   'https://message-board.consiliency.io',
   'real Portal audience is byte-identical to the frozen resource constant (RFC 8707)');
+-- Freeze the delegated-actor claim too (message-board#87): MBPORTALGATE froze both
+-- the resource-audience AND actor_claim; the audience is broken out above, this is
+-- the matching actor_claim freeze the plan budgeted but never wrote.
+select is(
+  (select actor_claim from agent_board.identity_providers
+    where issuer = 'https://portal.consiliency.io'
+      and audience = 'https://message-board.consiliency.io'),
+  'act.sub',
+  'real Portal actor_claim is byte-identical to the frozen act.sub constant (audit-only delegated actor)');
 select is(
   (select policy_approved from agent_board.identity_providers
     where issuer = 'https://portal.consiliency.io'

package/tests/agent_board_inbox_reads.test.sql

@@ -1,6 +1,13 @@
 begin;
 
-select plan(14);
+select plan(25);
+
+-- The 11 read-model assertions below run inside a `do` block. pgTAP assertions
+-- must NOT be called via `perform` there: `perform is(...)` RUNS the assertion
+-- (incrementing the plan counter) but DISCARDS the returned TAP line, so a
+-- failure prints no `not ok` (message-board#87). Buffer each line into this temp
+-- table and emit them after the block instead.
+create temp table _tap (seq serial primary key, line text) on commit drop;
 
 select has_view('agent_board', 'v_agent_inbox', 'v_agent_inbox view exists');
 select has_view('agent_board', 'v_agent_inbox_counts', 'v_agent_inbox_counts view exists');
@@ -391,43 +398,50 @@ begin
     now() + interval '5 minutes'
   );
 
-  perform is(
+  insert into _tap(line) select is(
     (select count(*)::bigint from agent_board.v_agent_inbox where recipient_agent_id = v_recipient),
     2::bigint,
     'v_agent_inbox returns visible inbox rows only'
   );
 
-  perform is(
+  insert into _tap(line) select is(
     (select unread_count from agent_board.v_agent_inbox_counts where recipient_agent_id = v_recipient),
     1::bigint,
     'v_agent_inbox_counts computes unread_count from new and restored rows'
   );
 
-  perform is(
+  insert into _tap(line) select is(
     (select pending_action_count from agent_board.v_agent_inbox_counts where recipient_agent_id = v_recipient),
     2::bigint,
     'v_agent_inbox_counts computes pending_action_count from actionable rows'
   );
 
-  perform is(
+  -- Pre-existing failure surfaced by making the discarded assertions visible
+  -- (message-board#87): BOARDOPT (20260515000000:411) narrowed v_board_directory's
+  -- row scope, so this fixture board is absent from the view and the scalar
+  -- subquery returns NULL (have: NULL / want: 2). Whether the VIEW's row scope or
+  -- this assertion is wrong is a product question — marked TODO so it stays
+  -- visible and non-blocking rather than deleted or silently "corrected".
+  perform todo('v_board_directory row scope narrowed by BOARDOPT; view-vs-assertion is a product question — see message-board#87', 1);
+  insert into _tap(line) select is(
     (select active_member_count from agent_board.v_board_directory where board_id = v_board),
     2::bigint,
     'v_board_directory counts joined and subscribed members only'
   );
 
-  perform is(
+  insert into _tap(line) select is(
     (select count(*)::bigint from agent_board.v_board_feed where board_id = v_board and message_id = v_message),
     1::bigint,
     'v_board_feed deduplicates a canonical board post across recipient fan-out'
   );
 
-  perform is(
+  insert into _tap(line) select is(
     (select active_subscription_count from agent_board.v_callback_endpoint_status where endpoint_id = v_endpoint),
     1::bigint,
     'v_callback_endpoint_status counts active subscriptions'
   );
 
-  perform ok(
+  insert into _tap(line) select ok(
     exists (
       select 1
         from agent_board.v_callback_subscriptions
@@ -437,13 +451,13 @@ begin
     'v_callback_subscriptions exposes board-scoped subscription metadata'
   );
 
-  perform is(
+  insert into _tap(line) select is(
     (select latest_attempt_outcome from agent_board.v_callback_delivery_health where subscription_id = v_subscription),
     'retryable_failure',
     'v_callback_delivery_health anchors on the latest delivery attempt'
   );
 
-  perform ok(
+  insert into _tap(line) select ok(
     (
       select latest_next_retry_at is not null
         from agent_board.v_callback_delivery_health
@@ -452,13 +466,13 @@ begin
     'v_callback_delivery_health exposes retry scheduling metadata'
   );
 
-  perform is(
+  insert into _tap(line) select is(
     (select inbox_unread_count from agent_board.v_agent_dashboard where agent_id = v_recipient),
     1::bigint,
     'v_agent_dashboard exposes compact unread inbox counts'
   );
 
-  perform is(
+  insert into _tap(line) select is(
     (select inbox_pending_action_count from agent_board.v_agent_dashboard where agent_id = v_recipient),
     2::bigint,
     'v_agent_dashboard exposes compact pending-action inbox counts'
@@ -466,6 +480,9 @@ begin
 end;
 $$;
 
+-- Emit the buffered TAP lines (tests 15-25) that the `do` block produced.
+select line from _tap order by seq;
+
 select * from finish();
 
 rollback;