@configura/web-api 2.4.1 → 2.4.2-alpha.0

package/dist/productConfiguration/CfgFeature.js

@@ -7,7 +7,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
         step((generator = generator.apply(thisArg, _arguments || [])).next());
     });
 };
-import { assertDefined, compareArrays, convertLength, count, Observable, someMatch, toLengthUnit, } from "@configura/web-utilities";
+import { Observable, assertDefined, compareArrays, convertLength, count, someMatch, toLengthUnit, } from "@configura/web-utilities";
 import { CfgProduct } from "../CfgProduct.js";
 import { CfgMtrlApplication } from "../material/CfgMtrlApplication.js";
 import { CfgMtrlApplicationSource } from "../material/CfgMtrlApplicationSource.js";
@@ -216,7 +216,7 @@ export class _CfgFeatureInternal {
             if (this.ancestorsSelected) {
                 const selectionCount = this._selectedOptions.length;
                 if (isSelectOne && selectionCount !== 1) {
-                    const wrongCountWarning = `A select-one Feature (i.e. neither optional nor multiple) should have exactly one Option selected. Feature key: "${this.key}". Actual: ${selectionCount}`;
+                    const wrongCountWarning = `A select-one Feature (i.e. neither optional nor multiple) should have exactly one Option selected. Feature code: "${this.code}". Actual: ${selectionCount}`;
                     if (this.rootProduct.settings.strictSelectOneSelectionCount) {
                         throw new Error(wrongCountWarning);
                     }

package/dist/productConfiguration/CfgOption.d.ts

@@ -91,6 +91,24 @@ export declare class _CfgOptionInternal {
     private _calculateUpcharge;
     get upcharge(): number;
     get priceChangeAtSelectChange(): number;
+    /**
+     * Get the child features that are contained within this option.
+     *
+     * Safe to call outside of the sync process, but may not contain any
+     * children until the sync process is complete.
+     */
+    getFeaturesOutsideSync(): CfgFeature[];
+    /**
+     * Get the child features that are contained within this option.
+     *
+     * ONLY ACCESS THIS PROPERTY UNDER THESE CONDITIONS:
+     * 1. The product is undergoing the sync group sync process.
+     * 2. AND you are operating on the new "target" product.
+     *
+     * Explanation: This method will generate all children if they have not been
+     * generated yet, which breaks sync group syncing, due to the presence of
+     * these children being used to determine if the sync should happen at all.
+     */
     get features(): CfgFeature[];
     /** Called by child to tell its parent that it has changed. */
     _childHasChanged: (freshRef: CfgFeature, bubbleMode: ProductConfigurationBubbleMode, committed: boolean) => Promise<void>;
@@ -154,6 +172,24 @@ export declare class CfgOption {
     get thumbnail(): string | undefined;
     get upcharge(): number;
     get priceChangeAtSelectChange(): number;
+    /**
+     * Get the child features that are contained within this option.
+     *
+     * Safe to call outside of the sync process, but may not contain any
+     * children until the sync process is complete.
+     */
+    getFeaturesOutsideSync(): CfgFeature[];
+    /**
+     * Get the child features that are contained within this option.
+     *
+     * ONLY ACCESS THIS PROPERTY UNDER THESE CONDITIONS:
+     * 1. The product is undergoing the sync group sync process.
+     * 2. AND you are operating on the new "target" product.
+     *
+     * Explanation: This method will generate all children if they have not been
+     * generated yet, which breaks sync group syncing, due to the presence of
+     * these children being used to determine if the sync should happen at all.
+     */
     get features(): CfgFeature[];
     listenForChange: (l: SingleArgCallback<OptionChangeNotification>) => void;
     stopListenForChange: (l: SingleArgCallback<OptionChangeNotification>) => void;

package/dist/productConfiguration/CfgOption.js

@@ -7,7 +7,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
         step((generator = generator.apply(thisArg, _arguments || [])).next());
     });
 };
-import { compareArrays, count, Observable, } from "@configura/web-utilities";
+import { Observable, compareArrays, count, } from "@configura/web-utilities";
 import { CfgProduct } from "../CfgProduct.js";
 import { CfgMtrlApplication } from "../material/CfgMtrlApplication.js";
 import { CfgMtrlApplicationSource } from "../material/CfgMtrlApplicationSource.js";
@@ -345,6 +345,27 @@ export class _CfgOptionInternal {
         }
         return 0;
     }
+    /**
+     * Get the child features that are contained within this option.
+     *
+     * Safe to call outside of the sync process, but may not contain any
+     * children until the sync process is complete.
+     */
+    getFeaturesOutsideSync() {
+        var _a;
+        return (_a = this._features) !== null && _a !== void 0 ? _a : [];
+    }
+    /**
+     * Get the child features that are contained within this option.
+     *
+     * ONLY ACCESS THIS PROPERTY UNDER THESE CONDITIONS:
+     * 1. The product is undergoing the sync group sync process.
+     * 2. AND you are operating on the new "target" product.
+     *
+     * Explanation: This method will generate all children if they have not been
+     * generated yet, which breaks sync group syncing, due to the presence of
+     * these children being used to determine if the sync should happen at all.
+     */
     get features() {
         if (this._features === undefined) {
             const allRefs = this.rawOption.featureRefs || [];
@@ -458,6 +479,26 @@ export class CfgOption {
     get priceChangeAtSelectChange() {
         return this._internal.priceChangeAtSelectChange;
     }
+    /**
+     * Get the child features that are contained within this option.
+     *
+     * Safe to call outside of the sync process, but may not contain any
+     * children until the sync process is complete.
+     */
+    getFeaturesOutsideSync() {
+        return this._internal.getFeaturesOutsideSync();
+    }
+    /**
+     * Get the child features that are contained within this option.
+     *
+     * ONLY ACCESS THIS PROPERTY UNDER THESE CONDITIONS:
+     * 1. The product is undergoing the sync group sync process.
+     * 2. AND you are operating on the new "target" product.
+     *
+     * Explanation: This method will generate all children if they have not been
+     * generated yet, which breaks sync group syncing, due to the presence of
+     * these children being used to determine if the sync should happen at all.
+     */
     get features() {
         return this._internal.features;
     }

package/dist/syncGroups/SyncGroupsTransaction.js

@@ -585,5 +585,5 @@ function getFeaturesFromProduct(product) {
 }
 function getFeaturesFromOption(option) {
     var _a;
-    return pairFeatures(option.target.features, (_a = option.initial) === null || _a === void 0 ? void 0 : _a.features);
+    return pairFeatures(option.target.features, (_a = option.initial) === null || _a === void 0 ? void 0 : _a.getFeaturesOutsideSync());
 }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@configura/web-api",
-	"version": "2.4.1",
+	"version": "2.4.2-alpha.0",
 	"license": "Apache-2.0",
 	"type": "module",
 	"main": "dist/index.js",
@@ -23,7 +23,7 @@
 		"access": "public"
 	},
 	"dependencies": {
-		"@configura/web-utilities": "2.4.1"
+		"@configura/web-utilities": "2.4.2-alpha.0"
 	},
-	"gitHead": "fdc897ffa3900daeee31eadbb1903e8ebf709666"
+	"gitHead": "1e32d06e8c30c72bcdd958c2f2b15456e5fed3d6"
 }