@configura/babylon-view 3.3.0 → 3.3.1-alpha.0

package/dist/geometry/stretch/CfgStretchData.d.ts

@@ -74,8 +74,11 @@ export declare class CfgStretchData {
      * actually use this for anything, but it can be handy for debug.
      * @param sp Start Point, the start anchor of the stretch line.
      * @param ep End Point, the end anchor of the stretch line.
-     * @param spToEpLength Distance from sp to ep.
-     * @param originalSpToEpLength spToEpLength before transforms.
+     * @param spToEpLength Distance from sp to ep in this instance's coordinate system. This changes
+     * when a scale is applied while descending through the model hierarchy.
+     * @param originalSpToEpLength Distance from sp to ep when the stretch was first created. This
+     * remains unchanged through all hierarchy transforms because morph influence is calculated
+     * against this original baseline.
      * @param normal The normal is from sp to ep and is the normal of every plane that divides this
      * stretch.
      * @param normalNormalized Normalized version of normal
@@ -89,8 +92,10 @@ export declare class CfgStretchData {
     /**
      * If the Matrix is identity the original CfgStretchData is returned.
      * If not a new CfgStretchData will be created.
-     * sp, ep, spToEpLength, normal, normalNormalized, scale will be cloned and transformed
-     * The rest will still reference the original objects
+     * sp, ep, spToEpLength, normal and normalNormalized are transformed into the destination
+     * coordinate system. originalSpToEpLength is intentionally preserved: it is a model-space
+     * baseline, not a measurement in the destination coordinate system.
+     * The rest will still reference the original objects.
      */
     applyMatrix(matrix: Matrix): CfgStretchData;
     /**

package/dist/geometry/stretch/CfgStretchData.js

@@ -85,8 +85,11 @@ export class CfgStretchData {
      * actually use this for anything, but it can be handy for debug.
      * @param sp Start Point, the start anchor of the stretch line.
      * @param ep End Point, the end anchor of the stretch line.
-     * @param spToEpLength Distance from sp to ep.
-     * @param originalSpToEpLength spToEpLength before transforms.
+     * @param spToEpLength Distance from sp to ep in this instance's coordinate system. This changes
+     * when a scale is applied while descending through the model hierarchy.
+     * @param originalSpToEpLength Distance from sp to ep when the stretch was first created. This
+     * remains unchanged through all hierarchy transforms because morph influence is calculated
+     * against this original baseline.
      * @param normal The normal is from sp to ep and is the normal of every plane that divides this
      * stretch.
      * @param normalNormalized Normalized version of normal
@@ -288,8 +291,10 @@ export class CfgStretchData {
     /**
      * If the Matrix is identity the original CfgStretchData is returned.
      * If not a new CfgStretchData will be created.
-     * sp, ep, spToEpLength, normal, normalNormalized, scale will be cloned and transformed
-     * The rest will still reference the original objects
+     * sp, ep, spToEpLength, normal and normalNormalized are transformed into the destination
+     * coordinate system. originalSpToEpLength is intentionally preserved: it is a model-space
+     * baseline, not a measurement in the destination coordinate system.
+     * The rest will still reference the original objects.
      */
     applyMatrix(matrix) {
         if (matrix.isIdentity()) {
@@ -298,7 +303,10 @@ export class CfgStretchData {
         const sp = Vector3.TransformCoordinates(this.sp, matrix);
         const ep = Vector3.TransformCoordinates(this.ep, matrix);
         const { spToEpLength, normal, normalizedNormal } = calculateNormals(sp, ep);
-        return new CfgStretchData(this.detailLevel, this.measureParam, this.stretchSymNodeId, this.originalReferenceLength, sp, ep, spToEpLength, this.spToEpLength, normal, normalizedNormal, this.sections);
+        return new CfgStretchData(this.detailLevel, this.measureParam, this.stretchSymNodeId, this.originalReferenceLength, sp, ep, spToEpLength, 
+        // A nested scale changes the local stretch geometry, but not the baseline used to
+        // calculate (requestedLength - originalLength) / originalLength.
+        this.originalSpToEpLength, normal, normalizedNormal, this.sections);
     }
     /**
      * Calculates the translation of a point which moves it from its original position to where it

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@configura/babylon-view",
-	"version": "3.3.0",
+	"version": "3.3.1-alpha.0",
 	"license": "Apache-2.0",
 	"type": "module",
 	"main": "dist/index.js",
@@ -22,13 +22,13 @@
 		"@babylonjs/loaders": "5.52.0",
 		"@babylonjs/materials": "5.52.0",
 		"@babylonjs/serializers": "5.52.0",
-		"@configura/web-core": "3.3.0",
-		"@configura/web-utilities": "3.3.0",
+		"@configura/web-core": "3.3.1-alpha.0",
+		"@configura/web-utilities": "3.3.1-alpha.0",
 		"babylonjs-gltf2interface": "5.22.0",
 		"exifr": "^7.1.3"
 	},
 	"devDependencies": {
-		"@configura/web-api": "3.3.0",
+		"@configura/web-api": "3.3.1-alpha.0",
 		"@types/react": "17.0.9",
 		"@types/react-dom": "17.0.6",
 		"del-cli": "^3.0.0",
@@ -37,5 +37,5 @@
 	"publishConfig": {
 		"access": "public"
 	},
-	"gitHead": "104ce32c903256c81b11337556386878fbd3980c"
+	"gitHead": "d93a2232ea58d2cc1ab2a7350b6f7320bfa71608"
 }