@conduction/nextcloud-vue 2.67.0 → 2.69.0

package/src/components/CnFormDialog/CnFormDialog.vue

@@ -462,6 +462,11 @@
 			:register="nestedCreate.register"
 			:item="null"
 			:initialData="nestedCreate.initialData"
+			:excludeFields="nestedCreate.form.excludeFields"
+			:includeFields="nestedCreate.form.includeFields"
+			:fieldOverrides="nestedCreate.form.fieldOverrides"
+			:size="nestedCreate.form.size"
+			:columns="nestedCreate.form.columns"
 			:recoverDraft="false"
 			data-testid="cn-form-dialog-nested-create"
 			@confirm="onNestedCreateConfirm"
@@ -2645,7 +2650,12 @@ export default {
 		 * the new object. When the referenced schema cannot be loaded, the
 		 * term alone is saved as before, so the field never dead-ends.
 		 *
+		 * The form is the one the schema's index page shows for its own Add
+		 * button: that page's `createOverride` saves it and its form settings
+		 * shape it, with the typed term in the name.
+		 *
 		 * @spec openspec/changes/form-pickers-from-schema/specs/schema-utilities/spec.md
+		 * @spec openspec/changes/nested-create-uses-page-config/specs/schema-utilities/spec.md
 		 * @param {object} field The reference field descriptor.
 		 * @param {string} term The typed search term.
 		 * @return {Promise<object|null>} The created object, or null.
@@ -2662,21 +2672,37 @@ export default {
 				store.registerObjectType(slug, schemaRef, register)
 			}
 			const labelField = this.referenceLabelField(field)
+			const loadSchema = async () => {
+				try {
+					return await store.fetchSchema(slug)
+				} catch {
+					return null
+				}
+			}
 			// The app may own how this schema is created (pipelinq's client and
 			// contact need a contact-first endpoint; a plain save 400s). A
 			// create override keeps this form and saves through the app's
 			// handler; a create modal (only when no override exists) opens the
 			// app's own dialog instead of the generic form.
-			const appCreate = this.appCreateFor(register, schemaRef)
+			//
+			// A stored schema usually names its reference by id (`$ref: 28`)
+			// while the manifest page names it by slug (`schema: 'client'`), so
+			// when the reference itself matches no page, the referenced schema
+			// is loaded and its slug, id and uuid are tried too.
+			let schema
+			let appCreate = this.appCreateFor(register, [schemaRef])
+			if (!appCreate.page) {
+				schema = await loadSchema()
+				if (schema) {
+					appCreate = this.appCreateFor(register, [schemaRef, schema.slug, schema.id, schema.uuid])
+				}
+			}
 			if (!appCreate.override && appCreate.modal) {
 				return this.openAppCreateModal(appCreate.modal, store, slug, labelField, term)
 			}
 			const override = appCreate.override
-			let schema = null
-			try {
-				schema = await store.fetchSchema(slug)
-			} catch {
-				schema = null
+			if (schema === undefined) {
+				schema = await loadSchema()
 			}
 			if (!schema || !schema.properties) {
 				const payload = { [labelField]: term }
@@ -2685,36 +2711,84 @@ export default {
 					: store.saveObject(slug, payload)
 			}
 			const initialData = {}
-			if (term && schema.properties[labelField]) {
-				initialData[labelField] = term
+			const prefillKey = this.nestedPrefillKey(schema, labelField)
+			if (term && prefillKey) {
+				initialData[prefillKey] = term
 			}
+			const form = appCreate.form || this.nestedFormConfig(null)
 			return new Promise((resolve) => {
-				this.nestedCreate = { field, schema, register, slug, schemaRef, initialData, override, resolve }
+				this.nestedCreate = { field, schema, register, slug, schemaRef, initialData, override, form, resolve }
 			})
 		},
 
+		/**
+		 * The property of the referenced schema the typed term belongs in: the
+		 * reference's label field when the schema has it, else its name, title
+		 * or label. Visibility is decided by the form (a page `fieldOverrides`
+		 * entry can make a read-only name editable), not here.
+		 *
+		 * @spec openspec/changes/nested-create-uses-page-config/specs/schema-utilities/spec.md
+		 * @param {object} schema The referenced schema.
+		 * @param {string} labelField The reference's label field.
+		 * @return {string|null} The property key, or null when none fits.
+		 */
+		nestedPrefillKey(schema, labelField) {
+			const properties = (schema && schema.properties) || {}
+			return [labelField, 'name', 'title', 'label'].find((key) => properties[key]) || null
+		},
+
+		/**
+		 * The create-form settings of the index page that lists a schema, in
+		 * the shape the nested CnFormDialog binds: the same `excludeFields`,
+		 * `includeFields`, `fieldOverrides`, `formSize` and `formColumns`
+		 * CnIndexPage hands its own Add form, so creating from a picker shows
+		 * the form the page shows. Without a page, the form's defaults.
+		 *
+		 * @spec openspec/changes/nested-create-uses-page-config/specs/schema-utilities/spec.md
+		 * @param {object|null} config The page's `config`, or null.
+		 * @return {{excludeFields: string[], includeFields: (string[]|null), fieldOverrides: object, size: string, columns: number}} The form settings.
+		 */
+		nestedFormConfig(config) {
+			const c = config || {}
+			const isMap = (v) => v !== null && typeof v === 'object' && !Array.isArray(v)
+			return {
+				excludeFields: Array.isArray(c.excludeFields) ? c.excludeFields : [],
+				includeFields: Array.isArray(c.includeFields) ? c.includeFields : null,
+				fieldOverrides: isMap(c.fieldOverrides) ? c.fieldOverrides : {},
+				size: typeof c.formSize === 'string' && c.formSize !== '' ? c.formSize : 'normal',
+				columns: c.formColumns === 2 ? 2 : 1,
+			}
+		},
+
 		/**
 		 * How the app creates objects of a schema, read off the manifest page
 		 * that lists them: the index page whose `config.schema` (and, when it
 		 * names one, `config.register`) matches. Its `config.createOverride` is
 		 * resolved to the registered handler; its `config.createModal` is the
-		 * registry key of a `kind: 'modal'` dialog.
+		 * registry key of a `kind: 'modal'` dialog; its form settings
+		 * (`fieldOverrides` and friends) shape the nested form.
 		 *
-		 * @spec openspec/changes/review-round-two/specs/schema-utilities/spec.md
+		 * The schema is matched on any of the given references, so a caller
+		 * holding the referenced schema can pass its slug, id and uuid: the
+		 * manifest names a schema by slug, a stored `$ref` often by id.
+		 *
+		 * @spec openspec/changes/nested-create-uses-page-config/specs/schema-utilities/spec.md
 		 * @param {string} register The reference's register.
-		 * @param {string} schemaRef The reference's schema slug or id.
-		 * @return {{override: (((formData: object, ctx: object) => Promise<object>)|null), modal: (string|null)}} What the app declared.
+		 * @param {string|Array<string|number>} schemaRefs The schema's slug, id or uuid, one or several.
+		 * @return {{page: (object|null), override: (((formData: object, ctx: object) => Promise<object>)|null), modal: (string|null), form: (object|null)}} What the app declared.
 		 */
-		appCreateFor(register, schemaRef) {
-			const none = { override: null, modal: null }
+		appCreateFor(register, schemaRefs) {
+			const none = { page: null, override: null, modal: null, form: null }
 			const pages = this.cnManifest && Array.isArray(this.cnManifest.pages) ? this.cnManifest.pages : []
-			const wanted = String(schemaRef).toLowerCase()
+			const wanted = (Array.isArray(schemaRefs) ? schemaRefs : [schemaRefs])
+				.filter((ref) => ref !== undefined && ref !== null && ref !== '')
+				.map((ref) => String(ref).toLowerCase())
 			const page = pages.find((p) => {
 				const config = p && p.config
 				if (!config || config.schema === undefined || config.schema === null) {
 					return false
 				}
-				if (String(config.schema).toLowerCase() !== wanted) {
+				if (!wanted.includes(String(config.schema).toLowerCase())) {
 					return false
 				}
 				return !config.register || String(config.register) === String(register)
@@ -2732,7 +2806,7 @@ export default {
 			const modal = modalEntry && modalEntry.kind === 'modal' && typeof this.cnOpenModal === 'function'
 				? config.createModal
 				: null
-			return { override: override || null, modal }
+			return { page, override: override || null, modal, form: this.nestedFormConfig(config) }
 		},
 
 		/**

package/src/components/CnIndexPage/CnIndexPage.md

@@ -866,6 +866,27 @@ actions, and the page's declaration stands as before. Wire the field on one
 list first, then check `rowActionsNotDeclared` to see what the server is
 offering that you have not declared yet.
 
+The built-in View, Edit, Copy and Delete carry the ids `view`, `edit`, `copy` and `delete`, and match this block by id only, never by their label.
+The right-click menu reads the same per-row list as the actions menu, so it drops the same refused actions.
+
+## Placing built-in row actions
+
+A `"builtin:view"`, `"builtin:edit"`, `"builtin:copy"` or `"builtin:delete"` string in `actions` puts that built-in at its position; enabled built-ins the array does not place are appended in the default order, and the `show*Action` toggles still decide whether each renders.
+
+```json
+"actionToggles": { "showViewAction": false },
+"actions": [
+  "builtin:edit",
+  "builtin:copy",
+  { "id": "file-list", "label": "File list", "handler": "openPublicationFiles" },
+  "builtin:delete"
+]
+```
+
+This renders Edit, Copy, File list, Delete, and makes Edit the keyboard primary action.
+The keyboard primary action is the first entry the menu shows and enables, so a hidden or disabled entry is skipped.
+See the CnIndexPage docs page for the full rules.
+
 ## State indicators on a row
 
 Declare `rowIndicators` and a row carries the flags a handler triages on. Each

package/src/components/CnIndexPage/CnIndexPage.vue

@@ -692,11 +692,11 @@
 					</template>
 				</CnCardGrid>
 
-				<!-- Right-click context menu (positioned at cursor via CSS) -->
+				<!-- Right-click context menu (positioned at cursor via CSS). Same per-row list as the row actions menu, so the two never drift. -->
 				<CnContextMenu
 					v-model:open="contextMenuOpen"
-					:actions="mergedActions"
-					:targetItem="contextMenuRow"
+					:actions="rowActionsFor(contextMenuShownRow)"
+					:targetItem="contextMenuShownRow"
 					@action="onRowAction"
 					@close="closeContextMenu" />
 
@@ -812,8 +812,10 @@ import { resolveClaimedTeams, resolveClaimTokens, splitViewsIntoTabs, viewAsTab,
 import { LIST_SHORTCUTS, listPaletteCommands, shortcutFor } from '../../utils/listShortcuts.js'
 import { multiKeySort } from '../../utils/multiKeySort.js'
 import { resolveDeepTokens, resolveFilterValue } from '../../utils/resolveFilterTokens.js'
+import { resolveRowActions } from '../../utils/resolveRowActions.js'
 import { resolveFilterMap } from '../../utils/routeFilters.js'
 import { availableRowActions, DEFAULT_ROW_ACTION_FIELD, refusalReasonFor, undeclaredRowActions } from '../../utils/rowActionAvailability.js'
+import { isRowActionVisible, rowActionPayload } from '../../utils/rowActionItem.js'
 import { isNewTabClick, isNewTabHandled, isRowMiddleClick, markNewTabHandled, preventMiddleClickAutoscroll } from '../../utils/rowAuxClick.js'
 import { DEFAULT_ROW_INDICATOR_CAP } from '../../utils/rowIndicators.js'
 import { buildRouteQueryFromViewState, buildViewCreatePayload, extractViewState, extractViewStateFromRouteQuery, savedViewScope, viewMatchesScope } from '../../utils/savedViewHelpers.js'
@@ -1687,7 +1689,11 @@ export default {
 			default: () => ({}),
 		},
 
-		/** Row action definitions (app-provided, merged with built-in actions) */
+		/**
+		 * Row action definitions, merged with the built-in View / Edit / Copy / Delete.
+		 * Objects are app actions.
+		 * A `"builtin:view"`, `"builtin:edit"`, `"builtin:copy"` or `"builtin:delete"` string places that built-in at its position when its `show*Action` toggle is on; enabled built-ins not placed are appended in that order.
+		 */
 		actions: {
 			type: Array,
 			default: () => [],
@@ -2761,6 +2767,8 @@ export default {
 			folderRowLayouts: {},
 			/** The row the keyboard is on, or -1. */
 			focusedRowIndex: -1,
+			// The row the context menu shows: set on open, never cleared on close, so a closing menu keeps its entries and a late close cannot null a reopened one.
+			contextMenuShownRow: null,
 			/** The row a quick edit is open on, or null. */
 			quickEditRow: null,
 			/** The row as the server holds it, after a stale save. */
@@ -3473,7 +3481,7 @@ export default {
 			if (this.quickEditFields.length > 0) {
 				handlers['row-quick-edit'] = () => this.focusedRow && this.openQuickEdit(this.focusedRow)
 			}
-			if (this.focusedRow && this.rowActionsFor(this.focusedRow).length > 0) {
+			if (this.focusedRow && this.primaryRowActionFor(this.focusedRow)) {
 				handlers['row-primary'] = () => this.runPrimaryRowAction()
 			}
 			return handlers
@@ -4154,7 +4162,8 @@ export default {
 		},
 
 		/**
-		 * Merged actions: app-provided first, then built-in defaults.
+		 * Merged actions: the declared entries in order, each `"builtin:<id>"` placeholder replaced by that built-in when its toggle is on, then the enabled built-ins not placed.
+		 * See `resolveRowActions`.
 		 *
 		 * REQ-MAD-3 / REQ-MAD-4 / REQ-MAD-5 / REQ-MAD-6 / REQ-MAD-7
 		 * (manifest-actions-dispatch) — for any action whose `handler`
@@ -4170,58 +4179,41 @@ export default {
 				registry: this.effectiveRegistry,
 				customComponents: this.effectiveCustomComponents,
 			}
-			// Drop anything that is not an action OBJECT. A bare string — the
-			// shorthand `"edit"` an author reasonably expects to mean "show the
-			// built-in Edit" — has no `label` and no `icon`, so it rendered as a
-			// full-height NcActionButton with nothing in it: an invisible,
-			// clickable, inert row in the overflow menu. Observed on dossiq,
-			// where `config.actions: ["create", "edit", "delete", {…}]` put three
-			// blank rows above the real ones on four different index pages.
-			//
-			// Named, not silently swallowed: a dropped action is a capability the
-			// author asked for and did not get, and the manifest schema now
-			// rejects the shape at authoring time (`config.actions` is governed by
-			// the same `action` definition as `pages[].actions`). Built-ins are
-			// turned on with the `show*Action` toggles, not by naming them here.
 			// A named source may supply its own row actions, on the same
 			// precedence as its columns: what the manifest declares wins, and the
-			// source is the DEFAULT for a page that declares none. Without this
-			// the source's `rowActions` were declared and never read — the third
-			// field of the same adapter to be wired late, after `columns` and
-			// `addLabel`.
-			//
-			// Note what this still cannot do: these are MERGED with the built-ins
-			// below, so a source can add an action but cannot say "these and no
-			// others". Suppressing a built-in is the `show*Action` toggles' job.
+			// source is the DEFAULT for a page that declares none.
+			// Either list may place built-ins with `"builtin:<id>"`; turning one on or off stays the `show*Action` toggles' job.
 			const manifestDeclared = this.actions && this.actions.length > 0
 			const declaredActions = manifestDeclared
 				? this.actions
 				: ((this.isNamedSource && this.namedSource && this.namedSource.rowActions) || [])
 
-			const declared = []
-			for (const a of declaredActions) {
-				if (a && typeof a === 'object' && !Array.isArray(a)) {
+			const { actions, warnings } = resolveRowActions(declaredActions, this.defaultActions, {
+				prepare: (a) => {
 					// A SOURCE action may say `action: 'open'`: open this row the
 					// way a row click does — the source's own navigation
 					// (`openRow`/`detailRoute`), with `edit-open` emitted so a
 					// host that configured a row target (`config.rowRoute`) wins.
-					// Resolved here because a source is a composable with no
-					// router; the flows source declared exactly this action and
-					// it rendered as a dead menu entry, because `action` was a
-					// key nothing read (dispatch reads `handler` and `type`).
-					// Source-declared actions only: the manifest grammar for
-					// navigation is `type`/`handler`, and stays so.
+					// Resolved here because a source is a composable with no router.
+					// Source-declared actions only: the manifest grammar for navigation is `type`/`handler`, and stays so.
 					if (!manifestDeclared && a.action === 'open' && typeof a.handler !== 'function') {
-						declared.push({ ...a, handler: (row) => this.openSourceRow(row) })
-						continue
+						return { ...a, handler: (row) => this.openSourceRow(row) }
 					}
-					declared.push(dispatchAction(a, ctx))
+					return dispatchAction(a, ctx)
+				},
+			})
+			for (const warning of warnings) {
+				// A toggle turned off at runtime (permissions, readOnly) legitimately silences a placeholder; the validator flags a statically-off one.
+				if (warning.code === 'disabled-placeholder') {
 					continue
 				}
-				// eslint-disable-next-line no-console
-				console.warn(`[CnIndexPage] Ignoring action ${JSON.stringify(a)}: actions must be objects with an id and a label. To show a built-in action use the showViewAction / showEditAction / showCopyAction / showDeleteAction props.`)
+				// A dropped entry is always named; the placement hints are dev-only.
+				if (warning.code === 'invalid-entry' || process.env.NODE_ENV !== 'production') {
+					// eslint-disable-next-line no-console
+					console.warn(`[CnIndexPage] "${this.title}": ${warning.message}`)
+				}
 			}
-			return [...declared, ...this.defaultActions]
+			return actions
 		},
 
 		hasRowActions() {
@@ -5467,9 +5459,20 @@ export default {
 		},
 
 		/**
-		 * Run the first action the focused row offers. "First" is the page's
-		 * order, narrowed by what the server allows on that record, so the
-		 * primary action is never one this caller may not run.
+		 * The first action a row's menu shows and enables: the page's order, narrowed by what the server allows, by `visible` / `visibleWhen`, and by `disabled`.
+		 * The keyboard therefore never runs what the menu hides or greys out.
+		 *
+		 * @param {object} row The row.
+		 * @return {(object|null)} The action, or null.
+		 * @spec openspec/changes/row-action-builtin-placement/specs/index-page/spec.md
+		 */
+		primaryRowActionFor(row) {
+			return this.rowActionsFor(row).find((action) => isRowActionVisible(action, row)
+				&& !(typeof action.disabled === 'function' ? action.disabled(row) : action.disabled)) || null
+		},
+
+		/**
+		 * Run the focused row's primary action (see `primaryRowActionFor`).
 		 *
 		 * @return {void}
 		 * @spec openspec/changes/working-list-row-actions/specs/index-page/spec.md
@@ -5479,14 +5482,14 @@ export default {
 			if (!row) {
 				return
 			}
-			const [first] = this.rowActionsFor(row)
+			const first = this.primaryRowActionFor(row)
 			if (!first) {
 				return
 			}
 			if (typeof first.handler === 'function') {
 				first.handler(row)
 			}
-			this.$emit('action', { action: first.label, row })
+			this.onRowAction(rowActionPayload(first, row))
 		},
 
 		/**
@@ -5803,16 +5806,22 @@ export default {
 		},
 
 		/**
-		 * Intercepts CnRowActions' bubbled `@action` so `handler: "none"`
-		 * actions are dropped before re-emit.
+		 * Intercepts CnRowActions' and CnContextMenu's bubbled `@action` so `handler: "none"` actions are dropped before re-emit.
+		 * A built-in is matched by its id, an app action by its label.
 		 *
-		 * @param {{action: string, row: object}} payload The bubbled action payload.
+		 * @param {{action: string, row: object, id?: string, builtin?: boolean}} payload The bubbled action payload.
 		 */
 		onRowAction(payload) {
-			const matched = this.mergedActions.find((a) => a.label === payload.action)
+			const matched = payload.builtin === true
+				? this.mergedActions.find((a) => a.builtin === true && a.id === payload.id)
+				: this.mergedActions.find((a) => a.builtin !== true && a.label === payload.action)
 			if (matched && matched._dispatchSuppress) {
 				return
 			}
+			/**
+			 * @event action A row action was chosen from a row's actions menu, its right-click menu or the keyboard primary action. Payload: `action` (the label), the row, the action's `id` when it has one, and `builtin: true` for a built-in View / Edit / Copy / Delete. Its handler has already run.
+			 * @type {{ action: string, row: object, id?: string, builtin?: boolean }}
+			 */
 			this.$emit('action', payload)
 		},
 
@@ -6758,6 +6767,7 @@ export default {
 		// --- Context menu handlers ---
 
 		onRowContextMenu({ row, event }) {
+			this.contextMenuShownRow = row
 			this.openContextMenu({ item: row, event })
 		},
 

package/src/components/CnIndexPage/defaultActions.js

@@ -14,9 +14,8 @@ import TrashCanOutline from 'vue-material-design-icons/TrashCanOutline.vue'
  *   without it, or when it returns null, View is a button.
  * @param {{ onView: (row: object) => void, onEdit: (row: object) => void, onCopy: (row: object) => void, onDelete: (row: object) => void }} opts.handlers
  *   Click handlers bound to each emitted action, in the same order as `flags`.
- * @return {Array<object>} The enabled actions in menu order (view, edit, copy,
- *   delete), each `{label, icon, handler}` — delete additionally `destructive`,
- *   view additionally `to` when `viewTo` is given.
+ * @return {Array<object>} The enabled actions in menu order (view, edit, copy, delete), each `{id, builtin: true, label, icon, handler}`.
+ *   The id is `view`, `edit`, `copy` or `delete`; delete additionally carries `destructive`, view additionally `to` when `viewTo` is given.
  */
 export function buildDefaultActions({ flags, viewIcon, viewTo = null, handlers }) {
 	// t() at BUILD-actions time, not module time: the labels were string
@@ -26,20 +25,20 @@ export function buildDefaultActions({ flags, viewIcon, viewTo = null, handlers }
 	// consuming app's language is already resolved.
 	const out = []
 	if (flags.view) {
-		const view = { label: t('nextcloud-vue', 'View'), icon: viewIcon, handler: handlers.onView }
+		const view = { id: 'view', builtin: true, label: t('nextcloud-vue', 'View'), icon: viewIcon, handler: handlers.onView }
 		if (typeof viewTo === 'function') {
 			view.to = viewTo
 		}
 		out.push(view)
 	}
 	if (flags.edit) {
-		out.push({ label: t('nextcloud-vue', 'Edit'), icon: Pencil, handler: handlers.onEdit })
+		out.push({ id: 'edit', builtin: true, label: t('nextcloud-vue', 'Edit'), icon: Pencil, handler: handlers.onEdit })
 	}
 	if (flags.copy) {
-		out.push({ label: t('nextcloud-vue', 'Copy'), icon: ContentCopy, handler: handlers.onCopy })
+		out.push({ id: 'copy', builtin: true, label: t('nextcloud-vue', 'Copy'), icon: ContentCopy, handler: handlers.onCopy })
 	}
 	if (flags.del) {
-		out.push({ label: t('nextcloud-vue', 'Delete'), icon: TrashCanOutline, destructive: true, handler: handlers.onDelete })
+		out.push({ id: 'delete', builtin: true, label: t('nextcloud-vue', 'Delete'), icon: TrashCanOutline, destructive: true, handler: handlers.onDelete })
 	}
 	return out
 }

package/src/components/CnRowActions/CnRowActions.vue

@@ -3,7 +3,7 @@
 		:primary="primary"
 		:menuName="menuName"
 		data-testid="cn-row-actions">
-		<template v-for="{ action, link } in renderedActions" :key="action.label">
+		<template v-for="{ action, link } in renderedActions" :key="actionKey(action)">
 			<!-- A navigate-only action is a real link, so it can be middle-clicked, opened in a new tab or copied. -->
 			<NcActionLink
 				v-if="link"
@@ -11,7 +11,7 @@
 				:target="link.target"
 				:title="getTitle(action)"
 				:class="{ 'cn-row-action--destructive': action.destructive }"
-				:data-testid="`cn-action-item-${slugifyLabel(action.label)}`"
+				:data-testid="actionTestId(action)"
 				closeAfterClick
 				@click="onLinkAction(action, link, $event)">
 				<template v-if="action.icon" #icon>
@@ -25,7 +25,7 @@
 				:title="getTitle(action)"
 				:disabled="isDisabled(action)"
 				:class="{ 'cn-row-action--destructive': action.destructive }"
-				:data-testid="`cn-action-item-${slugifyLabel(action.label)}`"
+				:data-testid="actionTestId(action)"
 				closeAfterClick
 				@click="onAction(action)">
 				<template v-if="action.icon" #icon>
@@ -42,7 +42,7 @@
 import { NcActionButton, NcActionLink, NcActions } from '@nextcloud/vue'
 import { followItemActionLink, resolveItemActionLink } from '../../utils/actionLink.js'
 import { isModifiedClick } from '../../utils/linkNavigation.js'
-import { evaluateVisibleWhenLocal, isLocallyDecidableVisibleWhen } from '../../utils/visibleWhen.js'
+import { isRowActionVisible, rowActionKey, rowActionPayload, rowActionTestId, slugifyActionLabel } from '../../utils/rowActionItem.js'
 import { CnIcon } from '../CnIcon/index.js'
 
 /**
@@ -103,11 +103,13 @@ export default {
 		 * - `to` (string | object | (row) => string | object) — render the entry as a link to this
 		 *   vue-router location; a plain click routes in place. Ignored when the router cannot resolve it.
 		 * - `linkTarget` (string) — the link's `target`, e.g. `_blank`
+		 * - `id` (string) — the action's id, passed in the `action` payload
+		 * - `builtin` (boolean) — set by CnIndexPage on its built-in View / Edit / Copy / Delete; a built-in's testid is `cn-action-item-<id>` in every locale and its key `builtin:<id>`
 		 *
 		 * A link entry still emits `action`, but its `handler` is not called: the link is the
 		 * navigation. A disabled entry, or a `to` without a resolvable route, stays a button.
 		 *
-		 * @type {Array<{label: string, icon: object | string, handler: (targetItem: object) => void, disabled: boolean | ((targetItem: object) => boolean), visible: boolean | ((targetItem: object) => boolean), title: string | ((targetItem: object) => string), destructive: boolean, href: string | ((targetItem: object) => string), to: string | object | ((targetItem: object) => string | object), linkTarget: string}>}
+		 * @type {Array<{label: string, id: string, builtin: boolean, icon: object | string, handler: (targetItem: object) => void, disabled: boolean | ((targetItem: object) => boolean), visible: boolean | ((targetItem: object) => boolean), title: string | ((targetItem: object) => string), destructive: boolean, href: string | ((targetItem: object) => string), to: string | object | ((targetItem: object) => string | object), linkTarget: string}>}
 		 */
 		actions: {
 			type: Array,
@@ -137,31 +139,13 @@ export default {
 
 	computed: {
 		/**
-		 * Filter actions by their `visible` predicate. An action without a
-		 * `visible` field is always shown (backwards compatible).
+		 * Filter actions by their `visibleWhen` and `visible` gates, with the same rule CnContextMenu uses.
+		 * An action without either always shows.
 		 *
 		 * @return {Array} Visible actions for the current row.
 		 */
 		visibleActions() {
-			return this.actions.filter((action) => {
-				// A manifest is JSON and cannot hold a function, so `visibleWhen` is
-				// the only per-row gate an app configured from one can express. Only
-				// a locally decidable condition is gated on: an endpoint/source one is
-				// not this evaluator's question, and nothing gated a row action at all
-				// before, so answering `false` to it would delete the entry outright.
-				if (action.visibleWhen
-					&& isLocallyDecidableVisibleWhen(action.visibleWhen)
-					&& evaluateVisibleWhenLocal(action.visibleWhen, this.row) === false) {
-					return false
-				}
-				if (action.visible === undefined) {
-					return true
-				}
-				if (typeof action.visible === 'function') {
-					return !!action.visible(this.row)
-				}
-				return !!action.visible
-			})
+			return this.actions.filter((action) => isRowActionVisible(action, this.row))
 		},
 
 		/**
@@ -210,7 +194,7 @@ export default {
 			if (action.handler && typeof action.handler === 'function') {
 				action.handler(this.row)
 			}
-			this.$emit('action', { action: action.label, row: this.row })
+			this.$emit('action', rowActionPayload(action, this.row))
 		},
 
 		/**
@@ -229,26 +213,41 @@ export default {
 			}
 			followItemActionLink(event, link, this.$router)
 			/**
-			 * @event action User picked an entry. Payload: the action's label and the row. A button entry has already run its `handler`; a link entry navigates instead, and a modified (new-tab) click on a link emits nothing.
-			 * @type {{ action: string, row: object|null }}
+			 * @event action User picked an entry. Payload: `action` (the label), the row, the action's `id` when it has one, and `builtin: true` for a CnIndexPage built-in. A button entry has already run its `handler`; a link entry navigates instead, and a modified (new-tab) click on a link emits nothing.
+			 * @type {{ action: string, row: object|null, id?: string, builtin?: boolean }}
 			 */
-			this.$emit('action', { action: action.label, row: this.row })
+			this.$emit('action', rowActionPayload(action, this.row))
 		},
 
 		/**
 		 * Slugify an action label for use in stable `data-testid` selectors.
-		 * Lowercase, kebab-case, strip non-alphanumeric. Used solely by the
-		 * `:data-testid` binding on NcActionButton — does not affect runtime
-		 * behaviour or rendered text.
+		 * Lowercase, kebab-case, strip non-alphanumeric.
 		 *
 		 * @param {string} label - The action's display label
 		 * @return {string} kebab-case slug suitable for a testid suffix.
 		 */
 		slugifyLabel(label) {
-			return String(label || '')
-				.toLowerCase()
-				.replace(/[^a-z0-9]+/g, '-')
-				.replace(/^-+|-+$/g, '')
+			return slugifyActionLabel(label)
+		},
+
+		/**
+		 * The entry's `data-testid`: `cn-action-item-<id>` for a built-in, the label slug otherwise.
+		 *
+		 * @param {object} action The action definition.
+		 * @return {string} The testid.
+		 */
+		actionTestId(action) {
+			return rowActionTestId(action)
+		},
+
+		/**
+		 * The entry's render key: `builtin:<id>` for a built-in, the label otherwise.
+		 *
+		 * @param {object} action The action definition.
+		 * @return {string} The key.
+		 */
+		actionKey(action) {
+			return rowActionKey(action)
 		},
 	},
 }

package/src/components/CnSetupWizard/CnSetupWizard.vue

@@ -641,9 +641,15 @@ export default {
 							value = this.choiceLabel(step, raw)
 						}
 					} else if (step.type === 'config-fields') {
+						// Only the fields the reader filled in: a row of empty
+						// "Name: , KvK: ," reads as broken, not as "not set".
 						value = this.fieldsFor(step)
-							.map((f) => `${f.label}: ${this.configModel[f.key] !== null && this.configModel[f.key] !== undefined ? this.configModel[f.key] : ''}`)
-							.join(', ')
+							.filter((f) => {
+								const v = this.configModel[f.key]
+								return v !== null && v !== undefined && String(v).trim() !== ''
+							})
+							.map((f) => `${f.label}: ${this.configModel[f.key]}`)
+							.join(', ') || t('nextcloud-vue', 'Not set')
 					}
 					if (this.isOnDemand(step)) {
 						const ran = this.ranThisSession(step.id)

package/src/components/CnStatWidget/CnStatWidget.vue

@@ -1312,7 +1312,7 @@ export default {
 		 * @return {string}
 		 */
 		formattedValue() {
-			return formatMetricValue(this.displayValue, this.content.format, this.configCtx)
+			return formatMetricValue(this.displayValue, this.content.format, this.configCtx, this.objectCtx?.object || null)
 		},
 
 		/**
@@ -1346,7 +1346,7 @@ export default {
 				return ''
 			}
 			const { prefix, suffix, ...rest } = (this.content.format || {})
-			return formatMetricValue(this.limitValue, rest, this.configCtx)
+			return formatMetricValue(this.limitValue, rest, this.configCtx, this.objectCtx?.object || null)
 		},
 
 		/**