@conduction/nextcloud-vue 2.66.0 → 2.68.0

package/src/utils/rowActionItem.js

@@ -0,0 +1,100 @@
+/**
+ * SPDX-FileCopyrightText: 2026 Conduction B.V. <info@conduction.nl>
+ * SPDX-License-Identifier: EUPL-1.2
+ *
+ * How a row action renders as a menu entry.
+ * CnRowActions and CnContextMenu both use these, so a row's actions menu and its right-click menu agree on which entries show and on each entry's key, testid and event payload.
+ */
+
+import { evaluateVisibleWhenLocal, isLocallyDecidableVisibleWhen } from './visibleWhen.js'
+
+/**
+ * Whether an action is a built-in row action (View, Edit, Copy, Delete).
+ *
+ * @param {object} action The action.
+ * @return {boolean} True for a built-in carrying an id.
+ */
+function isBuiltin(action) {
+	return !!action && action.builtin === true && typeof action.id === 'string' && action.id !== ''
+}
+
+/**
+ * Whether an action shows for an item.
+ * A locally decidable `visibleWhen` that is false hides it; an endpoint or source condition is not decided here.
+ * Then `visible` (a boolean or `(item) => boolean`) applies; without it the action shows.
+ *
+ * @param {object} action The action.
+ * @param {object|string|number|null} item The row or right-clicked item.
+ * @return {boolean} Whether the entry renders.
+ */
+export function isRowActionVisible(action, item) {
+	if (action.visibleWhen
+		&& isLocallyDecidableVisibleWhen(action.visibleWhen)
+		&& evaluateVisibleWhenLocal(action.visibleWhen, item) === false) {
+		return false
+	}
+	if (action.visible === undefined) {
+		return true
+	}
+	if (typeof action.visible === 'function') {
+		return !!action.visible(item)
+	}
+	return !!action.visible
+}
+
+/**
+ * Slugify a label for a `data-testid` suffix: lowercase, kebab-case, non-alphanumerics stripped.
+ *
+ * @param {string} label The label.
+ * @return {string} The slug.
+ */
+export function slugifyActionLabel(label) {
+	// One pass collapses every run of other characters to a single '-', so at
+	// most one '-' can sit at either end; trimming it by index keeps this
+	// linear. `/^-+|-+$/g` here was a ReDoS on long runs of '-' (CodeQL).
+	const slug = String(label || '')
+		.toLowerCase()
+		.replace(/[^a-z0-9]+/g, '-')
+	const start = slug.startsWith('-') ? 1 : 0
+	const end = slug.length > start && slug.endsWith('-') ? slug.length - 1 : slug.length
+	return slug.slice(start, end)
+}
+
+/**
+ * The render key of an entry: `builtin:<id>` for a built-in, the label for an app action.
+ * An app action with `id: "edit"` therefore never shares a key with the built-in Edit.
+ *
+ * @param {object} action The action.
+ * @return {string} The key.
+ */
+export function rowActionKey(action) {
+	return isBuiltin(action) ? `builtin:${action.id}` : action.label
+}
+
+/**
+ * The `data-testid` of an entry: `cn-action-item-<id>` for a built-in, in every locale, and the slug of the label for an app action.
+ *
+ * @param {object} action The action.
+ * @return {string} The testid.
+ */
+export function rowActionTestId(action) {
+	return `cn-action-item-${isBuiltin(action) ? action.id : slugifyActionLabel(action.label)}`
+}
+
+/**
+ * The `action` event payload for an entry: `action` is the label, `id` is the action's id when it has one, and `builtin: true` marks a built-in.
+ *
+ * @param {object} action The action.
+ * @param {object|string|number|null} row The row or right-clicked item.
+ * @return {{action: string, row: (object|string|number|null), id?: string, builtin?: true}} The payload.
+ */
+export function rowActionPayload(action, row) {
+	const payload = { action: action.label, row }
+	if (typeof action.id === 'string' && action.id !== '') {
+		payload.id = action.id
+	}
+	if (isBuiltin(action)) {
+		payload.builtin = true
+	}
+	return payload
+}

package/src/utils/timelineEvents.js

@@ -97,6 +97,49 @@ export function fieldEvents(object, fields, now = new Date()) {
  * @param {Date} [now] The reference moment.
  * @return {Array<object>} The events.
  */
+/**
+ * The text at a path of a list entry, or '' when the path is unset or empty.
+ *
+ * @param {object} row The list entry.
+ * @param {string|undefined} path The path to read.
+ * @return {string} The text.
+ */
+function textAt(row, path) {
+	if (!path) {
+		return ''
+	}
+	const value = readPath(row, path)
+	return value === null || value === undefined ? '' : String(value)
+}
+
+/**
+ * Events from a list held on the object itself, such as a status history:
+ * `[{ field, dateField, labelField?, label?, detailField? }]`. Each entry of the
+ * list at `field` becomes one event, dated by `dateField`, labelled by its
+ * `labelField` value (else `label`), with `detailField` as the line under it.
+ *
+ * @param {object} object The object.
+ * @param {Array<object>} lists The list configs.
+ * @param {Date} now The moment that separates past from upcoming.
+ * @return {Array<object>} The events.
+ * @spec openspec/changes/timeline-audit-trails-url/specs/timeline-widget/spec.md#requirement-a-list-on-the-object-becomes-dated-events
+ */
+export function listEvents(object, lists, now = new Date()) {
+	return (Array.isArray(lists) ? lists : [])
+		.filter((l) => l && typeof l.field === 'string' && typeof l.dateField === 'string')
+		.flatMap((l) => {
+			const rows = readPath(object, l.field)
+			return (Array.isArray(rows) ? rows : []).map((row, i) => makeEvent({
+				id: `list:${l.field}:${i}`,
+				raw: readPath(row, l.dateField),
+				label: textAt(row, l.labelField) || l.label || l.field,
+				detail: textAt(row, l.detailField),
+				source: 'list',
+			}, now))
+		})
+		.filter(Boolean)
+}
+
 export function relatedEvents(rows, config, now = new Date()) {
 	const cfg = config || {}
 	const dateField = cfg.dateField || '@self.created'

package/src/utils/validateManifest.js

@@ -6,6 +6,8 @@
 // names exist.
 import { BUILT_IN_FILE_COLUMNS } from '../components/CnFilesBrowser/filesBrowserColumns.js'
 import { LIBRARY_WIDGET_KEYS } from './libraryWidgetKeys.js'
+// The same resolver CnIndexPage orders row actions with, so the placement warnings measure the order that actually renders.
+import { resolveRowActions } from './resolveRowActions.js'
 // Shared slot→columns resolution so the validator's grid bound matches the
 // renderer (CnWidgetGrid) exactly. A mismatch would let a manifest pass
 // validation yet clip at render time.
@@ -120,9 +122,14 @@ const CHART_VALUE_AXIS_BASELINES = ['auto', 'zero', 'fit']
  *    page's own `config.columns` does not declare (the page declares which
  *    columns it has; a scope only chooses among them)
  *
+ * It also returns non-fatal `warnings`, which never affect `valid` (index pages with an `entitySource` are skipped):
+ *  - A `"builtin:<id>"` placeholder whose built-in the manifest's toggles turn off
+ *  - The built-in Delete enabled but not the last entry of the rendered row action order
+ *
  * @spec openspec/changes/manifest-v2-schema/specs/manifest-v2-schema/spec.md
+ * @spec openspec/changes/row-action-builtin-placement/specs/index-page/spec.md
  * @param {object} manifest The v2 manifest object to validate.
- * @return {{ valid: boolean, errors: string[] }}
+ * @return {{ valid: boolean, errors: string[], warnings: string[] }}
  */
 export function validateManifestV2(manifest) {
 	// Clone so Ajv useDefaults mutations don't affect the caller's copy.
@@ -789,7 +796,57 @@ export function validateManifestV2(manifest) {
 		})
 	}
 
-	return { valid: errors.length === 0, errors }
+	// --- Post-schema warnings (never affect `valid`) ---
+	const warnings = []
+
+	// W1. Row action placement on an index page: a placeholder whose built-in the manifest turns off, and the built-in Delete placed before other row actions.
+	//     An entitySource page is skipped: its built-in defaults depend on the source at runtime.
+	if (Array.isArray(clone.pages)) {
+		clone.pages.forEach((page, pIndex) => {
+			const config = page && page.type === 'index' && isPlainObject(page.config) ? page.config : null
+			if (!config || !Array.isArray(config.actions) || typeof config.entitySource === 'string') {
+				return
+			}
+			const resolved = resolveRowActions(config.actions, indexPageBuiltinStubs(config))
+			for (const warning of resolved.warnings) {
+				if (warning.code === 'disabled-placeholder') {
+					warnings.push(`pages[${pIndex}]/config/actions: ${warning.message}`)
+				}
+			}
+			if (resolved.deleteNotLast) {
+				warnings.push(`pages[${pIndex}]/config/actions: "builtin:delete" is not the last row action in the rendered order (enabled built-ins the array does not place are appended after it); Delete is normally last`)
+			}
+		})
+	}
+
+	return { valid: errors.length === 0, errors, warnings }
+}
+
+/**
+ * The built-in row actions an index page enables, as `{ id, builtin, label }` stubs in default order.
+ * They are read from its config the way CnPageRenderer derives the show*Action props: an explicit `config.show*Action` wins over `config.actionToggles`, and `config.readOnly: true` turns Edit, Copy and Delete off by default.
+ * A non-boolean value counts as the default.
+ *
+ * @param {object} config The page's config.
+ * @return {Array<{id: string, builtin: true, label: string}>} The enabled built-ins.
+ */
+function indexPageBuiltinStubs(config) {
+	const toggles = isPlainObject(config.actionToggles) ? config.actionToggles : {}
+	const flag = (key, readOnlyOff) => {
+		if (typeof config[key] === 'boolean') {
+			return config[key]
+		}
+		if (typeof toggles[key] === 'boolean') {
+			return toggles[key]
+		}
+		return !(readOnlyOff && config.readOnly === true)
+	}
+	return [
+		['view', flag('showViewAction', false)],
+		['edit', flag('showEditAction', true)],
+		['copy', flag('showCopyAction', true)],
+		['delete', flag('showDeleteAction', true)],
+	].filter(([, on]) => on).map(([id]) => ({ id, builtin: true, label: id }))
 }
 
 /**
@@ -853,7 +910,7 @@ function isSentinel(value) {
  *   `pageTypes` registry is known up-front. When omitted, any
  *   non-empty string is accepted; the runtime renderer logs a warning
  *   for unknown types.
- * @return {{ valid: boolean, errors: string[] }}
+ * @return {{ valid: boolean, errors: string[], warnings?: string[] }} A v2 manifest also gets `warnings`, which never affect `valid`.
  */
 export function validateManifest(manifest, options = {}) {
 	// Dispatch to v2 validator when the manifest declares a v2 $schema.