@conduction/nextcloud-vue 2.112.0 → 2.113.0

package/src/css/look-board.css

@@ -353,11 +353,8 @@
    end of a tab strip) is the board's neutral control: the main background, a
    grey border, the main text at 600 (DqZaak), not Nextcloud's primary tint.
    NcActions marks a secondary menu `action-item--secondary` on its root and
-   keeps a class given to it off, so the rule reads that marker. The label
-   hands its ink to --nldesign-color-on-surface for a theme that forces the
-   body ink onto every span (thematiq). */
+   keeps a class given to it off, so the rule reads that marker. */
 .cn-look-board .action-item.action-item--secondary .action-item__menutoggle.button-vue--secondary:not(.cn-look-nextcloud *) {
-	--nldesign-color-on-surface: var(--color-main-text);
 	border: 1px solid var(--cn-board-control-border);
 	border-radius: var(--cn-board-control-radius);
 	background: var(--color-main-background);
@@ -1164,14 +1161,6 @@
 	color: var(--cn-status-badge-ink);
 }
 
-/* A pill paints its own pairing of ink and fill. A theme that forces the body
-   ink onto every span (thematiq's text rule, `!important` at id level) reads
-   that ink from --nldesign-color-on-surface when the surface sets it, so the
-   pill hands it its own ink: "In behandeling" stays purple on purple. */
-.cn-look-board .cn-status-badge:not(.cn-look-nextcloud *) {
-	--nldesign-color-on-surface: var(--cn-status-badge-ink);
-}
-
 /* ---- Info notes (NcNoteCard type="info") -------------------------------- */
 /* The board's info note is a light-blue rounded box: no edge bar, 12px 14px
    of padding, radius 8, an 18px icon 10px before the text, 14px text in the
@@ -1223,9 +1212,7 @@
    hairline under each pair (DqZaak "Zaakgegevens"), the horizontal layout as
    two columns of 14px text, the label column as wide as its longest label
    (the side cards). Both at the board's line height, 1.2, not Nextcloud's 1.5:
-   a pair is 47px tall on the board. The muted label also hands its ink to
-   --nldesign-color-on-surface, which a theme that forces the body ink onto
-   every div (thematiq) reads. */
+   a pair is 47px tall on the board. */
 .cn-look-board .cn-detail-grid.cn-detail-grid--grid:not(.cn-look-nextcloud *) {
 	gap: 12px 24px;
 	font-size: 15px;
@@ -1256,7 +1243,6 @@
 }
 
 .cn-look-board .cn-detail-grid .cn-detail-grid__label:not(.cn-look-nextcloud *) {
-	--nldesign-color-on-surface: var(--color-text-maxcontrast);
 	min-width: 0;
 	color: var(--color-text-maxcontrast);
 	font-size: 13px;

package/src/schemas/app-manifest-v2.schema.json

@@ -3,7 +3,7 @@
 	"$id": "https://raw.githubusercontent.com/ConductionNL/nextcloud-vue/main/src/schemas/app-manifest-v2.schema.json",
 	"title": "Conduction App Manifest v2",
 	"description": "v2 schema for the JSON-driven page and navigation manifest consumed by @conduction/nextcloud-vue. Introduces a uniform widgets[] array on every page type with a per-slot grid coordinate system, a typed actions[] discriminator, and the required $schema field for version detection. v1 manifests continue to validate against app-manifest.schema.json (unchanged).",
-	"version": "2.134.0",
+	"version": "2.135.0",
 	"type": "object",
 	"required": ["$schema", "version"],
 	"allOf": [
@@ -3104,10 +3104,17 @@
 			}
 		},
 		"action": {
+			"description": "A page action: the fields of $defs/actionFields, nothing else, with children that are actions too. Row, bulk and navigation actions use it; header actions use $defs/headerAction.",
+			"$ref": "#/$defs/actionFields",
+			"properties": {
+				"children": { "items": { "$ref": "#/$defs/action" } }
+			},
+			"unevaluatedProperties": false
+		},
+		"actionFields": {
 			"type": "object",
 			"required": ["id", "label"],
-			"additionalProperties": false,
-			"description": "A typed page action with a discriminator field. The type field determines behaviour: handler (registry function), open-modal (modal by id), open-page (named route), navigate (URL), object-op (declarative OpenRegister mutation via useObjectStore), export (opens the shared CnMassExportDialog export launcher), open-form (schema-driven create dialog — CnActionButtons), refresh (bumps the cn:page:refresh signal), api-call (POST/PUT an app endpoint + toast + refresh — CnActionButtons/dispatchAction), agent (run a governed hermiq agent), run-node (invoke one OpenRegister flow node against the page object, config collected via a dialog sourced from the node's own declared form — CnActionButtons/dispatchAction, or-flow-run-node; distinct from the UNRELATED setup-wizard step type of a similar name, 'run-action'), toggle (two-way state button — CnActionButtons only, NOT dispatchable). When type is omitted, it defaults to 'handler' (back-compatibility with v1.3.0 action declarations). The Ajv instance is compiled with useDefaults: true so the default is applied during validation.",
+			"description": "The fields of an action, shared by $defs/action and the non-link $defs/headerAction, which close it and constrain `children`. A typed page action with a discriminator field. The type field determines behaviour: handler (registry function), open-modal (modal by id), open-page (named route), navigate (URL), object-op (declarative OpenRegister mutation via useObjectStore), export (opens the shared CnMassExportDialog export launcher), open-form (schema-driven create dialog — CnActionButtons), refresh (bumps the cn:page:refresh signal), api-call (POST/PUT an app endpoint + toast + refresh — CnActionButtons/dispatchAction), agent (run a governed hermiq agent), run-node (invoke one OpenRegister flow node against the page object, config collected via a dialog sourced from the node's own declared form — CnActionButtons/dispatchAction, or-flow-run-node; distinct from the UNRELATED setup-wizard step type of a similar name, 'run-action'), toggle (two-way state button — CnActionButtons only, NOT dispatchable). When type is omitted, it defaults to 'handler' (back-compatibility with v1.3.0 action declarations). The Ajv instance is compiled with useDefaults: true so the default is applied during validation.",
 			"properties": {
 				"id": {
 					"type": "string",
@@ -3365,8 +3372,7 @@
 				},
 				"children": {
 					"type": "array",
-					"description": "Sub-actions, rendered by CnActionButtons as this action's OWN chevron dropdown beside its button — deliberately not folded into the page's single overflow menu, because NcActions cannot nest and a list that grows per record (app versions, say) would swamp it. Children take the same shape as any action, `visibleWhen` included, and an action carrying them consumes none of the `inline` slots. The parent itself still renders its own button beside the chevron (`type` defaults to 'handler' when omitted), so a parent meant only to group its children needs a `handler` that does something meaningful — an untyped, handler-less parent renders a button that dispatches to nothing.",
-					"items": { "$ref": "#/$defs/action" }
+					"description": "Sub-actions, rendered by CnActionButtons as this action's OWN chevron dropdown beside its button — deliberately not folded into the page's single overflow menu, because NcActions cannot nest and a list that grows per record (app versions, say) would swamp it. Children take the same shape as any action, `visibleWhen` included, and an action carrying them consumes none of the `inline` slots. The parent itself still renders its own button beside the chevron (`type` defaults to 'handler' when omitted), so a parent meant only to group its children needs a `handler` that does something meaningful — an untyped, handler-less parent renders a button that dispatches to nothing. Each child is an action; a header action's child is a header action, so it may be a link with `href`."
 				},
 				"childrenLabel": {
 					"type": "string",
@@ -3438,6 +3444,42 @@
 				}
 			]
 		},
+		"headerAction": {
+			"description": "A page header action (`headerActions[]`, a detail page's `quickActions[]` / `primaryActionByStage` entry, and their `children[]`): an action ($ref action), or with `href` a link ($ref headerLinkAction). Only header actions take `href`; row, bulk and navigation actions do not (2.135.0).",
+			"if": { "type": "object", "required": ["href"] },
+			"then": { "$ref": "#/$defs/headerLinkAction" },
+			"else": {
+				"$ref": "#/$defs/actionFields",
+				"properties": {
+					"children": { "items": { "$ref": "#/$defs/headerAction" } }
+				},
+				"unevaluatedProperties": false
+			}
+		},
+		"headerLinkAction": {
+			"type": "object",
+			"required": ["id", "label", "href"],
+			"additionalProperties": false,
+			"description": "A header action that is a real link (`<a href>`), so it can be middle-clicked, opened in a new tab, copied and bookmarked. It only navigates: it runs no handler and emits no `header-action`, so it carries no `handler` and no other `type` (2.135.0).",
+			"properties": {
+				"id": { "type": "string", "description": "Unique action identifier within the page's actions array." },
+				"label": { "type": "string", "description": "i18n key resolved by the consuming app's t() function at render time." },
+				"href": {
+					"type": "string",
+					"pattern": "^(https?://|mailto:|tel:|/)",
+					"description": "The link. An absolute `http(s)`, `mailto:` or `tel:` URL and a protocol-relative `//host/...` URL are used as written. A path starting with a Nextcloud entry point (`/index.php/`, `/remote.php/`, `/public.php/`, `/ocs/`) is prefixed with the instance root unless it already starts with it; any other instance path (leading `/`, e.g. `/apps/integriq/connections`) goes through `generateUrl()`."
+				},
+				"target": { "type": "string", "enum": ["_blank", "_self"], "default": "_self", "description": "`_blank` opens the link in a new tab; `_self` opens it in place." },
+				"type": { "const": "handler", "description": "Only the default; a link has no other behaviour." },
+				"icon": { "type": "string", "description": "Optional icon: an MDI icon name or a CSS icon class, as on any action." },
+				"variant": { "type": "string", "description": "CnActionButtons button variant, as on any action." },
+				"group": { "type": "string", "minLength": 1, "description": "Detail page header actions only: the overflow menu group, as on any action." },
+				"adminOnly": { "type": "boolean", "default": false, "description": "Detail page header actions only: show the link to instance admins alone, as on any action." },
+				"visibleWhen": { "$ref": "#/$defs/visibleWhen", "description": "An optional predicate gating whether the link renders, as on any action." },
+				"children": { "type": "array", "description": "Sub-actions in the link's own chevron dropdown, as on any action.", "items": { "$ref": "#/$defs/headerAction" } },
+				"childrenLabel": { "type": "string", "description": "Name of the sub-action chevron, as on any action." }
+			}
+		},
 		"fieldValidation": {
 			"type": "object",
 			"additionalProperties": false,
@@ -4354,7 +4396,7 @@
 							"additionalProperties": {
 								"oneOf": [
 									{ "type": "string", "minLength": 1 },
-									{ "$ref": "#/$defs/action" }
+									{ "$ref": "#/$defs/headerAction" }
 								]
 							}
 						},
@@ -4365,7 +4407,7 @@
 							"items": {
 								"oneOf": [
 									{ "type": "string", "minLength": 1 },
-									{ "$ref": "#/$defs/action" }
+									{ "$ref": "#/$defs/headerAction" }
 								]
 							}
 						},
@@ -4489,8 +4531,8 @@
 						},
 						"headerActions": {
 							"type": "array",
-							"description": "Page-level header actions rendered inside CnActionsBar's overflow dropdown (between the built-in Refresh action and the `#action-items` slot). On a `type:'detail'` page the same entries render in the header's Actions menu, above the Request-a-feature / Report-a-bug / Documentation trio. Same shape as the row-level `actions[]` ($ref action), but handlers receive NO row context — they are page-level. Reserved ids (`refresh`, `import`, `export`, `copy`, `delete`) are dropped at render time to avoid shadowing built-ins. See manifest-icons-and-page-actions for the dispatch semantics.",
-							"items": { "$ref": "#/$defs/action" }
+							"description": "Page-level header actions rendered inside CnActionsBar's overflow dropdown (between the built-in Refresh action and the `#action-items` slot). On a `type:'detail'` page the same entries render in the header's Actions menu, above the Request-a-feature / Report-a-bug / Documentation trio. Same shape as the row-level `actions[]` ($ref action), but handlers receive NO row context — they are page-level. Reserved ids (`refresh`, `import`, `export`, `copy`, `delete`) are dropped at render time to avoid shadowing built-ins. An entry with `href` (instead of `handler`) renders as a real link to that URL and is never dispatched ($ref headerAction). See manifest-icons-and-page-actions for the dispatch semantics.",
+							"items": { "$ref": "#/$defs/headerAction" }
 						},
 						"bulkActions": {
 							"type": "array",

package/src/utils/actionLink.js

@@ -9,11 +9,114 @@
  * The rendering component turns it into an `<a href>`; a plain click on an
  * in-app `to` is routed through the router, anything else is the browser's.
  *
+ * A manifest `headerActions[]` entry may carry `href` too; the page turns it
+ * into the final URL with {@link headerActionAsLink} before it renders.
+ *
  * @module utils/actionLink
  */
 
+import { generateUrl, getRootUrl } from '@nextcloud/router'
 import { followLinkClick } from './linkNavigation.js'
 
+/** An absolute URL a manifest link may name, matching the schema's lowercase pattern. */
+const ABSOLUTE_HREF = /^(?:https?:\/\/|mailto:|tel:)/
+
+/** An instance path that already names a Nextcloud entry point, so generateUrl() must not add `/index.php`. */
+const ROUTED_PATH = /^\/(?:index\.php|remote\.php|public\.php|ocs)(?:[/?#]|$)/
+
+/** Bad hrefs already warned about, so a recomputing page warns once per value. */
+const warnedHrefs = new Set()
+
+/**
+ * Entries whose function handler was dropped for their href, warned about
+ * once. Keyed by `id`, else by the declared href and label (behind a NUL, so
+ * no real id collides), so entries without an id each get their own warning
+ * and a recomputing page does not repeat it.
+ */
+const warnedHandlers = new Set()
+
+/**
+ * The URL a manifest `href` points at: an absolute `http(s)`, `mailto:` or
+ * `tel:` URL as written, `//host/...` as written, an instance path that
+ * names an entry point (`/index.php/`, `/remote.php/`, `/public.php/`,
+ * `/ocs/`) under `getRootUrl()` (as written when it already starts with the
+ * root), any other instance path (leading `/`) through `generateUrl()`.
+ *
+ * @spec openspec/changes/header-action-href/specs/header-action-href/spec.md#requirement-a-header-action-href-resolves-to-a-url-on-this-instance-or-an-allowed-scheme
+ * @param {unknown} href The manifest `href`.
+ * @return {string} The URL, or '' for anything else (a relative path, another scheme).
+ */
+export function resolveManifestHref(href) {
+	if (typeof href !== 'string') {
+		return ''
+	}
+	const value = href.trim()
+	if (ABSOLUTE_HREF.test(value) || value.startsWith('//')) {
+		return value
+	}
+	const root = getRootUrl()
+	if (root && value.startsWith(root) && ROUTED_PATH.test(value.slice(root.length))) {
+		return value
+	}
+	if (ROUTED_PATH.test(value)) {
+		return root + value
+	}
+	if (value.startsWith('/')) {
+		return generateUrl(value)
+	}
+	return ''
+}
+
+/**
+ * A manifest header action in its link form. An entry with `href` gets the
+ * resolved URL and an anchor `target` (`_blank` when the manifest says so,
+ * else `_self`), and loses its `handler`: a link only navigates. Its
+ * `children` are resolved the same way. An `href` that resolves to nothing is
+ * dropped with a warning, along with a handler name, so the page renders its
+ * usual button for the entry (an index or reports page still emits
+ * `header-action` for it); a function `handler` (JS composition) is kept
+ * then and still runs. An entry with nothing to resolve, a function-valued
+ * `href` included, is returned as is. When the `href` does resolve, a
+ * function `handler` is dropped like any other, with a one-time warning.
+ *
+ * @spec openspec/changes/header-action-href/specs/header-action-href/spec.md#requirement-a-header-action-with-href-is-a-link-that-runs-and-emits-nothing
+ * @param {object} entry The manifest header action.
+ * @return {object} The entry, or a copy in link form.
+ */
+export function headerActionAsLink(entry) {
+	if (!entry || typeof entry !== 'object') {
+		return entry
+	}
+	let resolved = entry
+	if (Array.isArray(entry.children)) {
+		const children = entry.children.map(headerActionAsLink)
+		if (children.some((child, index) => child !== entry.children[index])) {
+			resolved = { ...entry, children }
+		}
+	}
+	if (typeof entry.href !== 'string' || entry.href === '') {
+		return resolved
+	}
+	const { href: declared, ...withoutHref } = resolved
+	const { handler: _handler, ...rest } = withoutHref
+	const href = resolveManifestHref(declared)
+	if (!href) {
+		if (!warnedHrefs.has(declared)) {
+			warnedHrefs.add(declared)
+			// eslint-disable-next-line no-console
+			console.warn(`headerActions[].id "${entry.id}": href "${declared}" is neither an http(s), mailto or tel URL nor an instance path starting with "/"; the entry renders without a link`)
+		}
+		return typeof entry.handler === 'function' ? withoutHref : rest
+	}
+	const handlerKey = entry.id ?? `\u0000${declared}|${entry.label ?? ''}`
+	if (typeof entry.handler === 'function' && !warnedHandlers.has(handlerKey)) {
+		warnedHandlers.add(handlerKey)
+		// eslint-disable-next-line no-console
+		console.warn(`headerActions[].id "${entry.id}": an entry with href never runs a handler, so its function handler is dropped`)
+	}
+	return { ...rest, href, target: entry.target === '_blank' ? '_blank' : '_self' }
+}
+
 /**
  * The href of an in-app router location. A string is a route PATH and goes
  * through the router as well, so a hash-history app gets its `#`.