@conduction/nextcloud-vue 0.1.0-beta.12 → 0.1.0-beta.14

package/src/components/CnSchemaFormDialog/CnSchemaConfigurationTab.vue

@@ -1,18 +1,18 @@
 <template>
 	<div class="cn-schema-form__form-editor">
 		<NcTextArea :disabled="loading"
-			label="Description"
+			:label="t('nextcloud-vue', 'Description')"
 			:value.sync="schema.description" />
 		<NcTextArea :disabled="loading"
-			label="Summary"
+			:label="t('nextcloud-vue', 'Summary')"
 			:value.sync="schema.summary" />
 		<NcTextField :disabled="loading"
-			label="Slug"
+			:label="t('nextcloud-vue', 'Slug')"
 			:value.sync="schema.slug" />
 
 		<!-- Schema Composition Section -->
 		<div>
-			<h3>Schema Composition (JSON Schema)</h3>
+			<h3>{{ t('nextcloud-vue', 'Schema composition (JSON Schema)') }}</h3>
 
 			<!-- allOf - Multiple Inheritance (Recommended) -->
 			<NcSelect
@@ -24,8 +24,8 @@
 				:close-on-select="false"
 				label="title"
 				track-by="id"
-				input-label="allOf - Inherits from ALL schemas (Recommended)"
-				placeholder="Select schemas to inherit from (supports multiple parents)">
+				:input-label="t('nextcloud-vue', 'allOf - Inherits from ALL schemas (Recommended)')"
+				:placeholder="t('nextcloud-vue', 'Select schemas to inherit from (supports multiple parents)')">
 				<template #option="{ title, description }">
 					<div class="cn-schema-form__schema-option">
 						<span class="cn-schema-form__option-title">{{ title }}</span>
@@ -34,11 +34,11 @@
 				</template>
 			</NcSelect>
 			<NcNoteCard v-if="schema.allOf && schema.allOf.length > 0" type="info">
-				<p><strong>allOf - Multiple Inheritance</strong></p>
-				<p>Instance must validate against ALL selected schemas. Properties from all parent schemas are merged. This is the recommended pattern for schema extension and multiple inheritance.</p>
-				<p><strong>Important:</strong> Child schemas can only ADD constraints, never relax them (Liskov Substitution Principle). Metadata (title, description, order) can be overridden.</p>
+				<p><strong>{{ t('nextcloud-vue', 'allOf - Multiple inheritance') }}</strong></p>
+				<p>{{ t('nextcloud-vue', 'Instance must validate against all selected schemas. Properties from all parent schemas are merged. This is the recommended pattern for schema extension and multiple inheritance.') }}</p>
+				<p><strong>{{ t('nextcloud-vue', 'Important:') }}</strong> {{ t('nextcloud-vue', 'Child schemas can only add constraints, never relax them (Liskov substitution principle). Metadata (title, description, order) can be overridden.') }}</p>
 				<div v-if="allOfSchemaNames.length > 0">
-					<strong>Parent Schemas:</strong>
+					<strong>{{ t('nextcloud-vue', 'Parent schemas:') }}</strong>
 					<ul>
 						<li v-for="name in allOfSchemaNames" :key="name">
 							{{ name }}
@@ -57,8 +57,8 @@
 				:close-on-select="false"
 				label="title"
 				track-by="id"
-				input-label="oneOf - Exactly ONE schema must match"
-				placeholder="Select schemas (instance must match exactly one)">
+				:input-label="t('nextcloud-vue', 'oneOf - Exactly one schema must match')"
+				:placeholder="t('nextcloud-vue', 'Select schemas (instance must match exactly one)')">
 				<template #option="{ title, description }">
 					<div class="cn-schema-form__schema-option">
 						<span class="cn-schema-form__option-title">{{ title }}</span>
@@ -67,8 +67,8 @@
 				</template>
 			</NcSelect>
 			<NcNoteCard v-if="schema.oneOf && schema.oneOf.length > 0" type="info">
-				<p><strong>oneOf - Mutually Exclusive</strong></p>
-				<p>Instance must validate against EXACTLY ONE of the selected schemas. Properties are NOT merged. Use for discriminated unions or type variants.</p>
+				<p><strong>{{ t('nextcloud-vue', 'oneOf - Mutually exclusive') }}</strong></p>
+				<p>{{ t('nextcloud-vue', 'Instance must validate against exactly one of the selected schemas. Properties are not merged. Use for discriminated unions or type variants.') }}</p>
 			</NcNoteCard>
 
 			<!-- anyOf - Flexible Composition -->
@@ -81,8 +81,8 @@
 				:close-on-select="false"
 				label="title"
 				track-by="id"
-				input-label="anyOf - At least ONE schema must match"
-				placeholder="Select schemas (instance must match at least one)">
+				:input-label="t('nextcloud-vue', 'anyOf - At least one schema must match')"
+				:placeholder="t('nextcloud-vue', 'Select schemas (instance must match at least one)')">
 				<template #option="{ title, description }">
 					<div class="cn-schema-form__schema-option">
 						<span class="cn-schema-form__option-title">{{ title }}</span>
@@ -91,73 +91,74 @@
 				</template>
 			</NcSelect>
 			<NcNoteCard v-if="schema.anyOf && schema.anyOf.length > 0" type="info">
-				<p><strong>anyOf - Flexible Composition</strong></p>
-				<p>Instance must validate against AT LEAST ONE of the selected schemas. Properties are NOT merged. More permissive than oneOf.</p>
+				<p><strong>{{ t('nextcloud-vue', 'anyOf - Flexible composition') }}</strong></p>
+				<p>{{ t('nextcloud-vue', 'Instance must validate against at least one of the selected schemas. Properties are not merged. More permissive than oneOf.') }}</p>
 			</NcNoteCard>
 		</div>
 		<NcSelect
 			v-model="schema.configuration.objectNameField"
 			:disabled="loading"
 			:options="propertyOptions"
-			input-label="Object Name Field"
-			placeholder="Select a property to use as object name" />
+			:input-label="t('nextcloud-vue', 'Object name field')"
+			:placeholder="t('nextcloud-vue', 'Select a property to use as object name')" />
 		<NcSelect
 			v-model="schema.configuration.objectDescriptionField"
 			:disabled="loading"
 			:options="propertyOptions"
-			input-label="Object Description Field"
-			placeholder="Select a property to use as object description" />
+			:input-label="t('nextcloud-vue', 'Object description field')"
+			:placeholder="t('nextcloud-vue', 'Select a property to use as object description')" />
 		<NcSelect
 			v-model="schema.configuration.objectImageField"
 			:disabled="loading"
 			:options="propertyOptions"
-			input-label="Object Image Field"
-			placeholder="Select a property to use as object image representing the object. e.g. logo (should contain base64 encoded image)" />
+			:input-label="t('nextcloud-vue', 'Object image field')"
+			:placeholder="t('nextcloud-vue', 'Select a property to use as object image representing the object. e.g. logo (should contain base64 encoded image)')" />
 		<NcSelect
 			v-model="schema.configuration.objectSummaryField"
 			:disabled="loading"
 			:options="propertyOptions"
-			input-label="Object Summary Field"
-			placeholder="Select a property to use as object summary. e.g. summary, abstract, or excerpt" />
+			:input-label="t('nextcloud-vue', 'Object summary field')"
+			:placeholder="t('nextcloud-vue', 'Select a property to use as object summary. e.g. summary, abstract, or excerpt')" />
 		<NcCheckboxRadioSwitch
 			:disabled="loading"
 			:checked.sync="schema.configuration.allowFiles">
-			Allow Files
+			{{ t('nextcloud-vue', 'Allow files') }}
 		</NcCheckboxRadioSwitch>
 		<NcCheckboxRadioSwitch
 			:disabled="loading"
 			:checked.sync="schema.configuration.autoPublish">
-			Auto-Publish Objects
+			{{ t('nextcloud-vue', 'Auto-publish objects') }}
 		</NcCheckboxRadioSwitch>
 		<NcTextField
 			v-model="allowedTagsInput"
 			:disabled="loading"
-			label="Allowed Tags (comma-separated)"
-			placeholder="image, document, audio, video"
+			:label="t('nextcloud-vue', 'Allowed tags (comma-separated)')"
+			:placeholder="t('nextcloud-vue', 'image, document, audio, video')"
 			@update:value="updateAllowedTags" />
 		<NcCheckboxRadioSwitch
 			:disabled="loading"
 			:checked.sync="schema.hardValidation">
-			Hard Validation
+			{{ t('nextcloud-vue', 'Hard validation') }}
 		</NcCheckboxRadioSwitch>
 		<NcTextField :disabled="loading"
-			label="Max Depth"
+			:label="t('nextcloud-vue', 'Max depth')"
 			type="number"
 			:value.sync="schema.maxDepth" />
 		<NcCheckboxRadioSwitch
 			:disabled="loading"
 			:checked.sync="schema.immutable">
-			Immutable
+			{{ t('nextcloud-vue', 'Immutable') }}
 		</NcCheckboxRadioSwitch>
 		<NcCheckboxRadioSwitch
 			:disabled="loading"
 			:checked.sync="schema.searchable">
-			Searchable in SOLR
+			{{ t('nextcloud-vue', 'Searchable in SOLR') }}
 		</NcCheckboxRadioSwitch>
 	</div>
 </template>
 
 <script>
+import { translate as t } from '@nextcloud/l10n'
 import {
 	NcTextField,
 	NcTextArea,
@@ -213,6 +214,7 @@ export default {
 		},
 	},
 	methods: {
+		t,
 		updateAllowedTags(value) {
 			if (!value || value.trim() === '') {
 				this.$set(this.schema.configuration, 'allowedTags', [])

package/src/components/CnSchemaFormDialog/CnSchemaFormDialog.vue

@@ -6,7 +6,8 @@
 		:dialog-title="dialogTitle"
 		entity-name="Schema"
 		:size="size"
-		:disable-save="!schemaItem.title"
+		:disable-save="!!saveDisabledReason"
+		:disable-save-tooltip="saveDisabledReason"
 		:success-text="resolvedSuccessText"
 		:cancel-label="cancelLabel"
 		:close-label="closeLabel"
@@ -19,14 +20,14 @@
 				<div v-if="schemaItem.id"
 					class="cn-schema-form__detail-item cn-schema-form__id-card">
 					<div class="cn-schema-form__id-card-header">
-						<span class="cn-schema-form__detail-label">ID / UUID:</span>
+						<span class="cn-schema-form__detail-label">{{ t('nextcloud-vue', 'ID / UUID:') }}</span>
 						<NcButton class="cn-schema-form__copy-button"
 							@click="copyToClipboard(schemaItem.uuid || schemaItem.id)">
 							<template #icon>
 								<Check v-if="isCopied" :size="20" />
 								<ContentCopy v-else :size="20" />
 							</template>
-							{{ isCopied ? 'Copied' : 'Copy' }}
+							{{ isCopied ? t('nextcloud-vue', 'Copied') : t('nextcloud-vue', 'Copy') }}
 						</NcButton>
 					</div>
 					<span class="cn-schema-form__detail-value">{{ schemaItem.id }}</span>
@@ -35,7 +36,7 @@
 				</div>
 				<div class="cn-schema-form__detail-item cn-schema-form__title-with-badge">
 					<NcTextField :disabled="dialogLoading"
-						label="Title *"
+						:label="t('nextcloud-vue', 'Title *')"
 						:value.sync="schemaItem.title" />
 					<span v-if="schemaItem.allOf && schemaItem.allOf.length > 0"
 						class="cn-schema-form__statusPill cn-schema-form__statusPill--success">
@@ -51,20 +52,20 @@
 					</span>
 				</div>
 				<div v-if="schemaItem.created" class="cn-schema-form__detail-item">
-					<span class="cn-schema-form__detail-label">Created:</span>
+					<span class="cn-schema-form__detail-label">{{ t('nextcloud-vue', 'Created:') }}</span>
 					<span class="cn-schema-form__detail-value">{{ new Date(schemaItem.created).toLocaleString() }}</span>
 				</div>
 				<div v-if="schemaItem.updated" class="cn-schema-form__detail-item">
-					<span class="cn-schema-form__detail-label">Updated:</span>
+					<span class="cn-schema-form__detail-label">{{ t('nextcloud-vue', 'Updated:') }}</span>
 					<span class="cn-schema-form__detail-value">{{ new Date(schemaItem.updated).toLocaleString() }}</span>
 				</div>
 				<div class="cn-schema-form__detail-item">
-					<span class="cn-schema-form__detail-label">Version:</span>
-					<span class="cn-schema-form__detail-value">{{ schemaItem.version || 'Not set' }}</span>
+					<span class="cn-schema-form__detail-label">{{ t('nextcloud-vue', 'Version:') }}</span>
+					<span class="cn-schema-form__detail-value">{{ schemaItem.version || t('nextcloud-vue', 'Not set') }}</span>
 				</div>
 				<div class="cn-schema-form__detail-item">
-					<span class="cn-schema-form__detail-label">Owner:</span>
-					<span class="cn-schema-form__detail-value">{{ schemaItem.owner || 'Not set' }}</span>
+					<span class="cn-schema-form__detail-label">{{ t('nextcloud-vue', 'Owner:') }}</span>
+					<span class="cn-schema-form__detail-value">{{ schemaItem.owner || t('nextcloud-vue', 'Not set') }}</span>
 				</div>
 			</div>
 		</template>
@@ -327,9 +328,9 @@ export default {
 		 */
 		dialogTabs() {
 			return [
-				{ id: 'properties', title: 'Properties' },
-				{ id: 'configuration', title: 'Configuration' },
-				{ id: 'security', title: 'Security' },
+				{ id: 'properties', title: t('nextcloud-vue', 'Properties') },
+				{ id: 'configuration', title: t('nextcloud-vue', 'Configuration') },
+				{ id: 'security', title: t('nextcloud-vue', 'Security') },
 			]
 		},
 		sortedUserGroups() {
@@ -357,15 +358,15 @@ export default {
 		},
 		typeOptionsForSelect() {
 			return [
-				{ id: 'string', label: 'String' },
-				{ id: 'number', label: 'Number' },
-				{ id: 'integer', label: 'Integer' },
-				{ id: 'boolean', label: 'Boolean' },
-				{ id: 'array', label: 'Array' },
-				{ id: 'object', label: 'Object' },
-				{ id: 'dictionary', label: 'Dictionary' },
-				{ id: 'file', label: 'File' },
-				{ id: 'oneOf', label: 'One Of' },
+				{ id: 'string', label: t('nextcloud-vue', 'String') },
+				{ id: 'number', label: t('nextcloud-vue', 'Number') },
+				{ id: 'integer', label: t('nextcloud-vue', 'Integer') },
+				{ id: 'boolean', label: t('nextcloud-vue', 'Boolean') },
+				{ id: 'array', label: t('nextcloud-vue', 'Array') },
+				{ id: 'object', label: t('nextcloud-vue', 'Object') },
+				{ id: 'dictionary', label: t('nextcloud-vue', 'Dictionary') },
+				{ id: 'file', label: t('nextcloud-vue', 'File') },
+				{ id: 'oneOf', label: t('nextcloud-vue', 'One of') },
 			]
 		},
 		propertyOptions() {
@@ -385,8 +386,25 @@ export default {
 		 */
 		resolvedSuccessText() {
 			if (this.successText) return this.successText
-			return 'Schema saved successfully.'
+			return t('nextcloud-vue', '{title} saved successfully.', { title: t('nextcloud-vue', 'Schema') })
 		},
+		/**
+		 * Returns a human-readable reason the save button is disabled, or '' when saving is allowed.
+		 * Used for both :disable-save and the WCAG tooltip/aria-label on the button.
+		 *
+		 * @return {string}
+		 */
+		saveDisabledReason() {
+			if (!this.schemaItem.title) {
+				return t('nextcloud-vue', 'A schema title is required before saving')
+			}
+			const hasUnnamedProperty = Object.keys(this.schemaItem.properties || {}).some(key => key === '')
+			if (hasUnnamedProperty) {
+				return t('nextcloud-vue', 'All properties must have a name before saving')
+			}
+			return ''
+		},
+
 		allOfSchemaNames() {
 			if (!this.schemaItem.allOf || !Array.isArray(this.schemaItem.allOf) || this.schemaItem.allOf.length === 0) {
 				return []
@@ -485,6 +503,7 @@ export default {
 		},
 	},
 	methods: {
+		t,
 		findSchemaBySlug(schemaSlug) {
 			if (!schemaSlug) return undefined
 			return this.availableSchemas.find(schema =>
@@ -623,29 +642,21 @@ export default {
 		},
 
 		addProperty() {
-			let newPropertyName = 'new'
-			let counter = 1
-
-			while (this.schemaItem.properties[newPropertyName]) {
-				counter++
-				newPropertyName = `new_${counter}`
-			}
-
-			this.$set(this.schemaItem.properties, newPropertyName, {
+			this.$set(this.schemaItem.properties, '', {
 				type: 'string',
 				format: '',
-				title: newPropertyName,
+				title: '',
 				description: '',
 				facetable: false,
 			})
 
 			this.checkPropertiesModified()
-			this.selectedProperty = newPropertyName
+			this.selectedProperty = ''
 		},
 
 		updatePropertyKey(oldKey, newKey) {
-			if (!newKey || newKey === oldKey) return
-			if (this.schemaItem.properties[newKey] && newKey !== oldKey) return
+			if (newKey === oldKey) return
+			if (this.schemaItem.properties[newKey] !== undefined && newKey !== oldKey) return
 
 			const propertyData = { ...this.schemaItem.properties[oldKey] }
 

package/src/components/CnSchemaFormDialog/CnSchemaPropertiesTab.vue

@@ -7,7 +7,8 @@
 				row-key="_id"
 				:selectable="false"
 				:row-class="getRowClass"
-				:empty-text="'No properties found. Click "Add property" to create one.'"
+				:cell-class="getCellClass"
+				:empty-text="t('nextcloud-vue', 'No properties found. Click "Add property" to create one.')"
 				@row-click="onRowClick">
 				<template #actions-header>
 					<NcButton
@@ -17,7 +18,7 @@
 						<template #icon>
 							<Plus :size="20" />
 						</template>
-						Add property
+						{{ t('nextcloud-vue', 'Add property') }}
 					</NcButton>
 				</template>
 
@@ -26,11 +27,11 @@
 						<AlertOutline v-if="isPropertyModified(row._key)"
 							:size="16"
 							class="cn-schema-form__warning-icon"
-							:title="'Property has been modified. Changes will only take effect after the schema is saved.'" />
+							:title="t('nextcloud-vue', 'Property has been modified. Changes will only take effect after the schema is saved.')" />
 						<NcTextField
 							ref="propertyNameInput"
 							:value="row._key"
-							label="(technical) Property Name"
+							:label="t('nextcloud-vue', '(technical) Property name')"
 							@update:value="onPropertyKeyUpdate(row._key, $event)"
 							@click.stop />
 					</div>
@@ -38,30 +39,30 @@
 						<AlertOutline v-if="isPropertyModified(row._key)"
 							:size="16"
 							class="cn-schema-form__warning-icon"
-							:title="'Property has been modified. Changes will only take effect after the schema is saved.'" />
+							:title="t('nextcloud-vue', 'Property has been modified. Changes will only take effect after the schema is saved.')" />
 						<div class="cn-schema-form__name-with-chips">
 							<span class="cn-schema-form__property-name">{{ row._key }}</span>
 							<div class="cn-schema-form__inline-chips">
 								<span v-if="isPropertyRequired(schema, row._key)"
-									class="cn-schema-form__property-chip cn-schema-form__chip-primary">Required</span>
+									class="cn-schema-form__property-chip cn-schema-form__chip-primary">{{ t('nextcloud-vue', 'Required') }}</span>
 								<span v-if="row.immutable"
-									class="cn-schema-form__property-chip cn-schema-form__chip-secondary">Immutable</span>
+									class="cn-schema-form__property-chip cn-schema-form__chip-secondary">{{ t('nextcloud-vue', 'Immutable') }}</span>
 								<span v-if="row.deprecated"
-									class="cn-schema-form__property-chip cn-schema-form__chip-warning">Deprecated</span>
+									class="cn-schema-form__property-chip cn-schema-form__chip-warning">{{ t('nextcloud-vue', 'Deprecated') }}</span>
 								<span v-if="row.visible === false"
-									class="cn-schema-form__property-chip cn-schema-form__chip-secondary">Hidden in view</span>
+									class="cn-schema-form__property-chip cn-schema-form__chip-secondary">{{ t('nextcloud-vue', 'Hidden in view') }}</span>
 								<span v-if="row.hideOnCollection"
-									class="cn-schema-form__property-chip cn-schema-form__chip-secondary">Hidden in Collection</span>
+									class="cn-schema-form__property-chip cn-schema-form__chip-secondary">{{ t('nextcloud-vue', 'Hidden in collection') }}</span>
 								<span v-if="row.hideOnForm"
-									class="cn-schema-form__property-chip cn-schema-form__chip-secondary">Hidden in Form</span>
+									class="cn-schema-form__property-chip cn-schema-form__chip-secondary">{{ t('nextcloud-vue', 'Hidden in form') }}</span>
 								<span v-if="row.const !== undefined"
-									class="cn-schema-form__property-chip cn-schema-form__chip-success">Constant</span>
+									class="cn-schema-form__property-chip cn-schema-form__chip-success">{{ t('nextcloud-vue', 'Constant') }}</span>
 								<span v-if="row.enum && row.enum.length > 0"
-									class="cn-schema-form__property-chip cn-schema-form__chip-success">Enumeration ({{ row.enum.length }})</span>
+									class="cn-schema-form__property-chip cn-schema-form__chip-success">{{ t('nextcloud-vue', 'Enumeration ({count})', { count: row.enum.length }) }}</span>
 								<span v-if="row.facetable === true || (typeof row.facetable === 'object' && row.facetable !== null)"
-									class="cn-schema-form__property-chip cn-schema-form__chip-info">Facetable</span>
+									class="cn-schema-form__property-chip cn-schema-form__chip-info">{{ t('nextcloud-vue', 'Facetable') }}</span>
 								<span v-if="hasCustomTableSettings(row._key)"
-									class="cn-schema-form__property-chip cn-schema-form__chip-table">Table</span>
+									class="cn-schema-form__property-chip cn-schema-form__chip-table">{{ t('nextcloud-vue', 'Table') }}</span>
 							</div>
 						</div>
 					</div>
@@ -72,7 +73,7 @@
 						v-if="selectedProperty === row._key"
 						v-model="schema.properties[row._key].type"
 						:options="typeOptionsForSelect"
-						input-label="Property Type"
+						:input-label="t('nextcloud-vue', 'Property type')"
 						@click.stop />
 					<span v-else>{{ row.type }}</span>
 				</template>
@@ -95,13 +96,14 @@
 			</CnDataTable>
 		</div>
 		<CnNoteCard v-if="propertiesModified && !loading" type="warning" class="cn-schema-form__properties-warning">
-			<p>Properties have been modified. Changes will only take effect after the schema is saved.</p>
+			<p>{{ t('nextcloud-vue', 'Properties have been modified. Changes will only take effect after the schema is saved.') }}</p>
 		</CnNoteCard>
 	</Fragment>
 </template>
 
 <!-- eslint-disable jsdoc/valid-types -->
 <script>
+import { translate as t } from '@nextcloud/l10n'
 import { NcButton, NcTextField, NcSelect } from '@nextcloud/vue'
 import { CnDataTable } from '../CnDataTable/index.js'
 import { CnNoteCard } from '../CnNoteCard/index.js'
@@ -166,8 +168,8 @@ export default {
 			nextPropertyId: 1,
 			isRenaming: false,
 			tableColumns: [
-				{ key: '_key', label: 'Name', sortable: false },
-				{ key: 'type', label: 'Type', sortable: false },
+				{ key: '_key', label: t('nextcloud-vue', 'Name'), sortable: false },
+				{ key: 'type', label: t('nextcloud-vue', 'Type'), sortable: false },
 			],
 		}
 	},
@@ -202,7 +204,7 @@ export default {
 	},
 	watch: {
 		selectedProperty(newKey) {
-			if (newKey) {
+			if (newKey !== null) {
 				// Skip focus+select when the change comes from a rename —
 				// onPropertyKeyUpdate handles its own cursor positioning.
 				if (this.isRenaming) {
@@ -227,6 +229,7 @@ export default {
 		},
 	},
 	methods: {
+		t,
 		getStablePropertyId(propertyName) {
 			if (!this.propertyStableIds[propertyName]) {
 				this.propertyStableIds[propertyName] = this.nextPropertyId++
@@ -265,14 +268,18 @@ export default {
 			return classes.join(' ')
 		},
 
+		getCellClass(row) {
+			return this.selectedProperty === row._key ? 'cn-schema-form__editing-cell' : ''
+		},
+
 		onRowClick(row) {
 			if (this.selectedProperty === row._key) return
 			this.$emit('update:selected-property', row._key)
 		},
 
 		onPropertyKeyUpdate(oldKey, newKey) {
-			if (!newKey || newKey === oldKey) return
-			if (this.schema.properties[newKey] && newKey !== oldKey) return
+			if (newKey === oldKey) return
+			if (this.schema.properties[newKey] !== undefined && newKey !== oldKey) return
 
 			this.isRenaming = true