@comput/pi-intercom 0.1.1 → 0.1.2

package/README.md

@@ -119,7 +119,7 @@ Tests use temporary directories, local test-only HTTP servers, and mocked Pi hos
 ### Not live-tested / remaining limitations
 
 - Actual Pi extension loading, idle/steering queue delivery, busy snapshots, session-name persistence, trust UI and session replacement/reload lifecycle with live Pi hosts.
-- Herdr tab creation, agent readiness, JSON response shapes, current-pane association and tab rename with live workers. Launcher CLI syntax was checked against installed help only. Herdr's temporary launcher alias is not Intercom/Pi identity and is not saved in config.
+- Complete Herdr create/register/configure/rename flow still needs end-to-end validation. The Windows launch path uses `herdr pane run` on the returned pane ID to invoke `pi.ps1` through explicitly encoded PowerShell, avoiding Herdr's failing `Start-Process pi` wrapper. Command submission is not agent readiness. This command path was live-tested in the previously failed tab: Pi started and registered successfully. No Herdr agent alias is needed.
 - Windows visible terminal/Pi process startup. Success only proves terminal creation, **not Pi readiness**; startup failures remain visible in that terminal. No live readiness handshake was added.
 - Actual persisted-session lookup and resumed worker startup; never-used session failure.
 - Cross-process/network-drive atomicity and Windows ACL/sharing failures (same-process temp-filesystem races are tested).

package/package.json

@@ -12,7 +12,7 @@
   "bugs": {
     "url": "https://github.com/mbundgaard/PiIntercom/issues"
   },
-  "version": "0.1.1",
+  "version": "0.1.2",
   "description": "Explicit local communication between Pi sessions; Pi orchestrates.",
   "type": "module",
   "keywords": [

package/src/launcher.ts

@@ -1,5 +1,4 @@
 import { execFile } from 'node:child_process';
-import { randomBytes } from 'node:crypto';
 import { promisify } from 'node:util';
 import { fail } from './config.js';
 import type { LaunchRequest } from './runtime.js';
@@ -31,12 +30,15 @@ export function launchers(options: LauncherOptions) {
       catch (e) { fail(`Herdr tab launch failed: ${String(e)}; no fallback or cleanup`); }
       const pane = created.result?.root_pane?.pane_id, tab = created.result?.tab?.tab_id;
       if (!pane || !tab) fail('Herdr creation response missing returned pane/tab IDs; no guessed targeting or cleanup');
-      // Herdr requires a unique lowercase launcher alias. This is not Pi identity,
-      // is never stored in Intercom config/wire, and assigns no responsibility.
-      const alias = `intercom-${randomBytes(6).toString('hex')}`;
-      try { await exec('herdr', ['agent', 'start', alias, '--kind', 'pi', '--pane', pane, '--timeout', '30000', '--', ...args]); }
-      catch (e) { fail(`Herdr agent launch failed in tab ${tab}, pane ${pane}: ${String(e)}. Tab/process may remain; no automatic cleanup/retry/replacement`); }
-      return { launched: true, tab, pane, registrationAwaited: false };
+      // Herdr's Windows agent-start wrapper uses Start-Process on `pi`, which
+      // can resolve to a PowerShell shim and fail with invalid Win32 application.
+      // Run an explicit PowerShell command in the returned shell pane instead.
+      // This acknowledges command submission only, not Pi readiness/registration.
+      const script = `$ErrorActionPreference='Stop'; Set-Location -LiteralPath ${psQuote(request.cwd)}; & (Get-Command pi.ps1 -ErrorAction Stop).Source ${args.map(psQuote).join(' ')}; if ($LASTEXITCODE -ne 0) { Write-Error ('Pi exited with code ' + $LASTEXITCODE) }`;
+      const command = `powershell.exe -NoProfile -ExecutionPolicy Bypass -EncodedCommand ${encoded(script)}`;
+      try { await exec('herdr', ['pane', 'run', pane, command]); }
+      catch (e) { fail(`Herdr Pi command submission failed in tab ${tab}, pane ${pane}: ${String(e)}. Tab/process may remain; no automatic cleanup/retry/replacement`); }
+      return { commandSubmitted: true, tab, pane, piReadiness: 'not observed; inspect pane for startup failures', registrationAwaited: false };
     }
     if (request.multiplexer !== 'none') fail('unsupported multiplexer');
     // Use encoded PowerShell rather than constructing cmd.exe command strings.