@comput/pi-intercom 0.1.0 → 0.1.2

package/README.md

@@ -96,7 +96,7 @@ Tool text output is bounded to 50 KiB/2000 lines. Full list data remains in the
 ## Development and validation
 
 ```sh
-npm install --ignore-scripts
+npm ci
 npm run typecheck
 npm test
 npm run check:package
@@ -104,14 +104,22 @@ npm run check:package
 PI_INTERCOM_PI_ROOT='C:/path/to/pi-coding-agent' npm run test:host
 ```
 
-Production source runs through Pi's TypeScript loader; `npm run build` generates `dist` for tests. Pi core/typebox are peer dependencies, not bundled. This implementation run installed only cached development dependencies offline with `--legacy-peer-deps`, then used local ignored junctions to installed Pi/typebox for validation. No installed dependency, global setting or unrelated project was changed.
+Production source runs through Pi's TypeScript loader; `npm run build` generates `dist` for tests. Pi core/typebox are peer dependencies, not bundled; pinned development copies are included in the lockfile for reproducible CI without local junctions.
+
+## Publishing
+
+`.github/workflows/publish.yml` publishes through npm Trusted Publishing (GitHub OIDC), without an npm token secret. Configure the npm trusted publisher as owner `mbundgaard`, repository `PiIntercom`, workflow `publish.yml`, with no environment.
+
+The workflow validates on Windows, then publishes with provenance from a GitHub-hosted Ubuntu runner. It runs when a GitHub release is published or when manually dispatched. Release tags must be `v<package.json version>`.
+
+Version `0.1.0` is already published and cannot be republished. For the next release, bump package and lockfile versions, commit/push, then publish a matching GitHub release. Do not dispatch publishing for an already published version. CI validates pushes and pull requests separately without publishing.
 
 Tests use temporary directories, local test-only HTTP servers, and mocked Pi hosts/launch executors. They never start agents, tabs, terminals, contact models, services or bridges, or access credentials.
 
 ### Not live-tested / remaining limitations
 
 - Actual Pi extension loading, idle/steering queue delivery, busy snapshots, session-name persistence, trust UI and session replacement/reload lifecycle with live Pi hosts.
-- Herdr tab creation, agent readiness, JSON response shapes, current-pane association and tab rename with live workers. Launcher CLI syntax was checked against installed help only. Herdr's temporary launcher alias is not Intercom/Pi identity and is not saved in config.
+- Complete Herdr create/register/configure/rename flow still needs end-to-end validation. The Windows launch path uses `herdr pane run` on the returned pane ID to invoke `pi.ps1` through explicitly encoded PowerShell, avoiding Herdr's failing `Start-Process pi` wrapper. Command submission is not agent readiness. This command path was live-tested in the previously failed tab: Pi started and registered successfully. No Herdr agent alias is needed.
 - Windows visible terminal/Pi process startup. Success only proves terminal creation, **not Pi readiness**; startup failures remain visible in that terminal. No live readiness handshake was added.
 - Actual persisted-session lookup and resumed worker startup; never-used session failure.
 - Cross-process/network-drive atomicity and Windows ACL/sharing failures (same-process temp-filesystem races are tested).

package/package.json

@@ -1,15 +1,47 @@
 {
   "name": "@comput/pi-intercom",
-  "publishConfig": { "access": "public", "registry": "https://registry.npmjs.org/" },
-  "version": "0.1.0",
+  "publishConfig": {
+    "access": "public",
+    "registry": "https://registry.npmjs.org/"
+  },
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/mbundgaard/PiIntercom.git"
+  },
+  "homepage": "https://github.com/mbundgaard/PiIntercom#readme",
+  "bugs": {
+    "url": "https://github.com/mbundgaard/PiIntercom/issues"
+  },
+  "version": "0.1.2",
   "description": "Explicit local communication between Pi sessions; Pi orchestrates.",
   "type": "module",
-  "keywords": ["pi-package"],
-  "pi": { "extensions": ["./src/index.ts"] },
-  "files": ["src", "README.md", "references/v1-specification.md", "references/implementation-blocker.md"],
-  "engines": { "node": ">=22" },
-  "peerDependencies": { "@earendil-works/pi-coding-agent": "*", "typebox": "*" },
-  "devDependencies": { "typescript": "^5.9.3", "@types/node": "^22.0.0" },
+  "keywords": [
+    "pi-package"
+  ],
+  "pi": {
+    "extensions": [
+      "./src/index.ts"
+    ]
+  },
+  "files": [
+    "src",
+    "README.md",
+    "references/v1-specification.md",
+    "references/implementation-blocker.md"
+  ],
+  "engines": {
+    "node": ">=22"
+  },
+  "peerDependencies": {
+    "@earendil-works/pi-coding-agent": "*",
+    "typebox": "*"
+  },
+  "devDependencies": {
+    "typescript": "^5.9.3",
+    "@types/node": "^22.0.0",
+    "@earendil-works/pi-coding-agent": "0.84.4",
+    "typebox": "1.3.7"
+  },
   "scripts": {
     "build": "tsc",
     "typecheck": "tsc --noEmit",

package/src/launcher.ts

@@ -1,5 +1,4 @@
 import { execFile } from 'node:child_process';
-import { randomBytes } from 'node:crypto';
 import { promisify } from 'node:util';
 import { fail } from './config.js';
 import type { LaunchRequest } from './runtime.js';
@@ -31,12 +30,15 @@ export function launchers(options: LauncherOptions) {
       catch (e) { fail(`Herdr tab launch failed: ${String(e)}; no fallback or cleanup`); }
       const pane = created.result?.root_pane?.pane_id, tab = created.result?.tab?.tab_id;
       if (!pane || !tab) fail('Herdr creation response missing returned pane/tab IDs; no guessed targeting or cleanup');
-      // Herdr requires a unique lowercase launcher alias. This is not Pi identity,
-      // is never stored in Intercom config/wire, and assigns no responsibility.
-      const alias = `intercom-${randomBytes(6).toString('hex')}`;
-      try { await exec('herdr', ['agent', 'start', alias, '--kind', 'pi', '--pane', pane, '--timeout', '30000', '--', ...args]); }
-      catch (e) { fail(`Herdr agent launch failed in tab ${tab}, pane ${pane}: ${String(e)}. Tab/process may remain; no automatic cleanup/retry/replacement`); }
-      return { launched: true, tab, pane, registrationAwaited: false };
+      // Herdr's Windows agent-start wrapper uses Start-Process on `pi`, which
+      // can resolve to a PowerShell shim and fail with invalid Win32 application.
+      // Run an explicit PowerShell command in the returned shell pane instead.
+      // This acknowledges command submission only, not Pi readiness/registration.
+      const script = `$ErrorActionPreference='Stop'; Set-Location -LiteralPath ${psQuote(request.cwd)}; & (Get-Command pi.ps1 -ErrorAction Stop).Source ${args.map(psQuote).join(' ')}; if ($LASTEXITCODE -ne 0) { Write-Error ('Pi exited with code ' + $LASTEXITCODE) }`;
+      const command = `powershell.exe -NoProfile -ExecutionPolicy Bypass -EncodedCommand ${encoded(script)}`;
+      try { await exec('herdr', ['pane', 'run', pane, command]); }
+      catch (e) { fail(`Herdr Pi command submission failed in tab ${tab}, pane ${pane}: ${String(e)}. Tab/process may remain; no automatic cleanup/retry/replacement`); }
+      return { commandSubmitted: true, tab, pane, piReadiness: 'not observed; inspect pane for startup failures', registrationAwaited: false };
     }
     if (request.multiplexer !== 'none') fail('unsupported multiplexer');
     // Use encoded PowerShell rather than constructing cmd.exe command strings.