@comprehend/telemetry-node 0.2.4 → 0.2.5

package/dist/ComprehendMetricsExporter.d.ts

@@ -12,7 +12,7 @@ export declare class ComprehendMetricsExporter implements PushMetricExporter {
     private sendTimeSeriesData;
     private sendCumulativeData;
     private getServiceSubject;
-    selectAggregationTemporality(instrumentType: InstrumentType): AggregationTemporality;
+    selectAggregationTemporality(_instrumentType: InstrumentType): AggregationTemporality;
     forceFlush(): Promise<void>;
     shutdown(): Promise<void>;
 }

package/dist/ComprehendMetricsExporter.js

@@ -141,14 +141,8 @@ class ComprehendMetricsExporter {
         const idString = `service:${name}:${namespace ?? ''}:${environment ?? ''}`;
         return hashIdString(idString);
     }
-    selectAggregationTemporality(instrumentType) {
-        switch (instrumentType) {
-            case sdk_metrics_1.InstrumentType.COUNTER:
-            case sdk_metrics_1.InstrumentType.HISTOGRAM:
-                return sdk_metrics_1.AggregationTemporality.DELTA;
-            default:
-                return sdk_metrics_1.AggregationTemporality.CUMULATIVE;
-        }
+    selectAggregationTemporality(_instrumentType) {
+        return sdk_metrics_1.AggregationTemporality.CUMULATIVE;
     }
     async forceFlush() {
     }

package/dist/ComprehendMetricsExporter.test.js

@@ -234,25 +234,17 @@ describe('ComprehendMetricsExporter', () => {
         });
     });
     describe('Aggregation Temporality', () => {
-        it('should return DELTA for COUNTER', () => {
-            expect(exporter.selectAggregationTemporality(sdk_metrics_1.InstrumentType.COUNTER))
-                .toBe(sdk_metrics_1.AggregationTemporality.DELTA);
-        });
-        it('should return DELTA for HISTOGRAM', () => {
-            expect(exporter.selectAggregationTemporality(sdk_metrics_1.InstrumentType.HISTOGRAM))
-                .toBe(sdk_metrics_1.AggregationTemporality.DELTA);
-        });
-        it('should return CUMULATIVE for OBSERVABLE_GAUGE', () => {
-            expect(exporter.selectAggregationTemporality(sdk_metrics_1.InstrumentType.OBSERVABLE_GAUGE))
-                .toBe(sdk_metrics_1.AggregationTemporality.CUMULATIVE);
-        });
-        it('should return CUMULATIVE for OBSERVABLE_COUNTER', () => {
-            expect(exporter.selectAggregationTemporality(sdk_metrics_1.InstrumentType.OBSERVABLE_COUNTER))
-                .toBe(sdk_metrics_1.AggregationTemporality.CUMULATIVE);
-        });
-        it('should return CUMULATIVE for GAUGE', () => {
-            expect(exporter.selectAggregationTemporality(sdk_metrics_1.InstrumentType.GAUGE))
-                .toBe(sdk_metrics_1.AggregationTemporality.CUMULATIVE);
+        it('should return CUMULATIVE for all instrument types', () => {
+            for (const instrumentType of [
+                sdk_metrics_1.InstrumentType.COUNTER,
+                sdk_metrics_1.InstrumentType.HISTOGRAM,
+                sdk_metrics_1.InstrumentType.OBSERVABLE_GAUGE,
+                sdk_metrics_1.InstrumentType.OBSERVABLE_COUNTER,
+                sdk_metrics_1.InstrumentType.GAUGE,
+            ]) {
+                expect(exporter.selectAggregationTemporality(instrumentType))
+                    .toBe(sdk_metrics_1.AggregationTemporality.CUMULATIVE);
+            }
         });
     });
     describe('Lifecycle', () => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@comprehend/telemetry-node",
-  "version": "0.2.4",
+  "version": "0.2.5",
   "description": "Integration of comprehend.dev with OpenTelemetry in Node.js and similar environemnts.",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

package/src/ComprehendMetricsExporter.test.ts

@@ -296,29 +296,17 @@ describe('ComprehendMetricsExporter', () => {
     });
 
     describe('Aggregation Temporality', () => {
-        it('should return DELTA for COUNTER', () => {
-            expect(exporter.selectAggregationTemporality(InstrumentType.COUNTER))
-                .toBe(AggregationTemporality.DELTA);
-        });
-
-        it('should return DELTA for HISTOGRAM', () => {
-            expect(exporter.selectAggregationTemporality(InstrumentType.HISTOGRAM))
-                .toBe(AggregationTemporality.DELTA);
-        });
-
-        it('should return CUMULATIVE for OBSERVABLE_GAUGE', () => {
-            expect(exporter.selectAggregationTemporality(InstrumentType.OBSERVABLE_GAUGE))
-                .toBe(AggregationTemporality.CUMULATIVE);
-        });
-
-        it('should return CUMULATIVE for OBSERVABLE_COUNTER', () => {
-            expect(exporter.selectAggregationTemporality(InstrumentType.OBSERVABLE_COUNTER))
-                .toBe(AggregationTemporality.CUMULATIVE);
-        });
-
-        it('should return CUMULATIVE for GAUGE', () => {
-            expect(exporter.selectAggregationTemporality(InstrumentType.GAUGE))
-                .toBe(AggregationTemporality.CUMULATIVE);
+        it('should return CUMULATIVE for all instrument types', () => {
+            for (const instrumentType of [
+                InstrumentType.COUNTER,
+                InstrumentType.HISTOGRAM,
+                InstrumentType.OBSERVABLE_GAUGE,
+                InstrumentType.OBSERVABLE_COUNTER,
+                InstrumentType.GAUGE,
+            ]) {
+                expect(exporter.selectAggregationTemporality(instrumentType))
+                    .toBe(AggregationTemporality.CUMULATIVE);
+            }
         });
     });
 

package/src/ComprehendMetricsExporter.ts

@@ -183,14 +183,8 @@ export class ComprehendMetricsExporter implements PushMetricExporter {
         return hashIdString(idString);
     }
 
-    selectAggregationTemporality(instrumentType: InstrumentType): AggregationTemporality {
-        switch (instrumentType) {
-            case InstrumentType.COUNTER:
-            case InstrumentType.HISTOGRAM:
-                return AggregationTemporality.DELTA;
-            default:
-                return AggregationTemporality.CUMULATIVE;
-        }
+    selectAggregationTemporality(_instrumentType: InstrumentType): AggregationTemporality {
+        return AggregationTemporality.CUMULATIVE;
     }
 
     async forceFlush(): Promise<void> {