@company-semantics/contracts 45.1.0 → 45.3.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@company-semantics/contracts",
-  "version": "45.1.0",
+  "version": "45.3.0",
   "private": false,
   "repository": {
     "type": "git",
@@ -48,6 +48,10 @@
       "types": "./src/chat/index.ts",
       "default": "./src/chat/index.ts"
     },
+    "./comments": {
+      "types": "./src/comments/index.ts",
+      "default": "./src/comments/index.ts"
+    },
     "./api": {
       "types": "./src/api/index.ts",
       "default": "./src/api/index.ts"
@@ -105,6 +109,8 @@
     "test": "NODE_OPTIONS='--max-old-space-size=4096' bash scripts/vitest-run.sh run",
     "test:run": "NODE_OPTIONS='--max-old-space-size=4096' bash scripts/vitest-run.sh run",
     "color": "tsx scripts/color.ts",
+    "anchor-corpus:check": "tsx scripts/anchor-corpus.ts",
+    "anchor-corpus:sync": "tsx scripts/anchor-corpus.ts --sync",
     "generate:spec-hash": "tsx scripts/generate-spec-hash.ts",
     "generate:spec-hash:check": "tsx scripts/generate-spec-hash.ts --check",
     "generate:api": "pnpm generate:api-types && pnpm generate:spec-hash && pnpm generate:openapi-routes",
@@ -149,7 +155,8 @@
     "overrides": {
       "brace-expansion@<5.0.9": ">=5.0.9",
       "minimatch@<10.2.3": ">=10.2.3",
-      "js-yaml@>=4.0.0 <4.3.0": ">=4.3.0 <5.0.0",
+      "nanoid@<3.3.17": ">=3.3.17",
+      "js-yaml@>=4.0.0 <4.3.1": ">=4.3.1 <5.0.0",
       "js-yaml@>=5.0.0 <5.2.2": ">=5.2.2 <6.0.0",
       "picomatch@<4.0.4": ">=4.0.4",
       "esbuild@<0.28.1": ">=0.28.1",
@@ -163,5 +170,5 @@
     "*.md": "markdownlint-cli2",
     "package.json": "node -e \"JSON.parse(require('fs').readFileSync('package.json'))\""
   },
-  "securityRequirementsVersion": "5227de9b2a68460019c85186c0318d77915e02df1eb8aa8d1516b001e84bc524"
+  "securityRequirementsVersion": "dfe68368cb5b7fdc67290fba5cd5a920c9a2ca9c20a9e297232a467b2022e5b5"
 }

package/src/__tests__/resource-keys.test.ts

@@ -2,6 +2,7 @@ import { describe, it, expect } from "vitest";
 import {
   toQueryKey,
   fromQueryKey,
+  isResourceKeyShape,
   matchesResourceKey,
   type ResourceKey,
 } from "../resource-keys.js";
@@ -172,3 +173,61 @@ describe("resource-keys: companyMdAccessRequests (per-doc identity)", () => {
     expect(matchesResourceKey(toQueryKey(key), docKey)).toBe(false);
   });
 });
+
+describe("resource-keys: commentThreads (composite subject identity)", () => {
+  // The FIRST member of the union whose identity needs two segments. Every
+  // other key is [type, scope] or [type, scope, oneId], and `fromQueryKey`'s
+  // single-field path hard-asserts exactly two trailing segments — so this key
+  // exercises machinery nothing else does. See ADR-CONTRACTS-116.
+  const SUBJECT_ID = "77777777-7777-4777-8777-777777777777";
+  const key: ResourceKey = {
+    type: "commentThreads",
+    orgId: ORG_ID,
+    subjectType: "company_md",
+    subjectId: SUBJECT_ID,
+  };
+
+  it("serialises to [type, orgId, subjectType, subjectId]", () => {
+    const qk = toQueryKey(key);
+    expect(qk).toEqual(["commentThreads", ORG_ID, "company_md", SUBJECT_ID]);
+    expect(qk).toHaveLength(4);
+  });
+
+  it("round-trips through fromQueryKey", () => {
+    expect(fromQueryKey(toQueryKey(key))).toEqual(key);
+  });
+
+  it("is recognised by isResourceKeyShape", () => {
+    // The wire-boundary predicate the user-event schema gates
+    // `resource.invalidated` payloads on. It counts scope discriminators, and a
+    // key with two identity segments must still present exactly ONE scope —
+    // otherwise the coalescer drops every comment invalidation frame.
+    expect(isResourceKeyShape(key)).toBe(true);
+  });
+
+  it("discriminates two subjects of the same CLASS", () => {
+    const other: ResourceKey = {
+      ...key,
+      subjectId: "88888888-8888-4888-8888-888888888888",
+    };
+    expect(matchesResourceKey(toQueryKey(key), key)).toBe(true);
+    expect(matchesResourceKey(toQueryKey(other), key)).toBe(false);
+  });
+
+  it("discriminates two subjects that share an ID across CLASSES", () => {
+    // The reason subjectType is in the key at all. Subject ids are per-class
+    // uuids; without the class segment, invalidating one class's thread list
+    // would flush another's for a colliding id.
+    const other: ResourceKey = { ...key, subjectType: "work_item" };
+    expect(matchesResourceKey(toQueryKey(other), key)).toBe(false);
+    expect(matchesResourceKey(toQueryKey(key), other)).toBe(false);
+  });
+
+  it("refuses a query key that is missing a segment", () => {
+    // A three-segment key would otherwise parse as some OTHER shape and hand
+    // the caller a ResourceKey with an undefined subjectId.
+    expect(() =>
+      fromQueryKey(["commentThreads", ORG_ID, "company_md"]),
+    ).toThrow(/commentThreads/);
+  });
+});

package/src/api/generated-spec-hash.ts

@@ -1,3 +1,3 @@
 // AUTO-GENERATED — do not edit. Run pnpm generate:spec-hash to regenerate.
-export const SPEC_HASH = 'b10dd357bc4f' as const;
-export const SPEC_HASH_FULL = 'b10dd357bc4fd990f9d6646954b3b1aa38f9dce4dd64ecfe8f5f83eb8f51a568' as const;
+export const SPEC_HASH = '6859374aa9bc' as const;
+export const SPEC_HASH_FULL = '6859374aa9bcdd861ecd151d6500ccc3a611774ffbce7830fcacbfd873393f95' as const;