@company-semantics/contracts 0.93.0 → 0.95.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@company-semantics/contracts",
-  "version": "0.93.0",
+  "version": "0.95.0",
   "private": false,
   "repository": {
     "type": "git",

package/src/chat/__tests__/runtime-profile.test.ts

@@ -0,0 +1,55 @@
+import { describe, it, expect } from 'vitest'
+import { CHAT_RUNTIME_PROFILES, DEFAULT_CHAT_RUNTIME_PROFILE } from '../runtime-profile.js'
+
+describe('CHAT_RUNTIME_PROFILES golden snapshot', () => {
+  it('exact values are frozen', () => {
+    expect(CHAT_RUNTIME_PROFILES).toStrictEqual([
+      { id: 'fast', label: 'Fast', description: 'Single-step, no tools', model: 'gpt-3.5-turbo' },
+      { id: 'balanced', label: 'Balanced', description: 'Multi-step with tools', model: 'gpt-4o' },
+      { id: 'agentic', label: 'Agentic', description: 'Agent loop, full reasoning', model: 'claude-sonnet-4-20250514' },
+    ])
+  })
+})
+
+describe('CHAT_RUNTIME_PROFILES invariants', () => {
+  it('covers all ChatRuntimeProfile values', () => {
+    const ids = CHAT_RUNTIME_PROFILES.map(p => p.id)
+    expect(ids).toContain('fast')
+    expect(ids).toContain('balanced')
+    expect(ids).toContain('agentic')
+  })
+
+  it('has no duplicate profile IDs', () => {
+    const ids = CHAT_RUNTIME_PROFILES.map(p => p.id)
+    expect(new Set(ids).size).toBe(ids.length)
+  })
+
+  it('all entries have non-empty label and description', () => {
+    for (const profile of CHAT_RUNTIME_PROFILES) {
+      expect(profile.label.length).toBeGreaterThan(0)
+      expect(profile.description.length).toBeGreaterThan(0)
+    }
+  })
+
+  it('all entries have non-empty model strings', () => {
+    for (const profile of CHAT_RUNTIME_PROFILES) {
+      expect(profile.model.length).toBeGreaterThan(0)
+    }
+  })
+})
+
+describe('DEFAULT_CHAT_RUNTIME_PROFILE', () => {
+  it('is agentic', () => {
+    expect(DEFAULT_CHAT_RUNTIME_PROFILE).toBe('agentic')
+  })
+
+  it('exists in CHAT_RUNTIME_PROFILES', () => {
+    const ids = CHAT_RUNTIME_PROFILES.map(p => p.id)
+    expect(ids).toContain(DEFAULT_CHAT_RUNTIME_PROFILE)
+  })
+
+  it('is a valid ChatRuntimeProfile value', () => {
+    const validIds = CHAT_RUNTIME_PROFILES.map(p => p.id) as readonly string[]
+    expect(validIds).toContain(DEFAULT_CHAT_RUNTIME_PROFILE)
+  })
+})

package/src/execution/__tests__/lifecycle.test.ts

@@ -172,7 +172,7 @@ describe('applyIntent', () => {
     expect(applyIntent('undone', 'confirm')).toBe('conflict')
   })
 
-  it('pending_confirmation + reject = approve', () => {
+  it('pending_confirmation + reject resolves as approve (rejection uses same cancel path)', () => {
     expect(applyIntent('pending_confirmation', 'reject')).toBe('approve')
   })
 

package/src/index.ts

@@ -243,13 +243,13 @@ export type {
   IdentityTrustLevel,
   TransferEligibilityResult,
   TransferMemberEligibility,
-  // Strategy domain types (PRD-00173)
-  StrategyVisibility,
-  StrategyDocLevel,
-  StrategySource,
-  StrategyDependency,
-  StrategyTreeNode,
-  StrategyDoc,
+  // Goals domain types (PRD-00173)
+  GoalVisibility,
+  GoalDocLevel,
+  GoalSource,
+  GoalDependency,
+  GoalTreeNode,
+  GoalDoc,
 } from './org/index'
 
 export { ROLE_DISPLAY_MAP, VIEW_SCOPE_MAP, getViewScope, TRANSFER_RESPONSIBILITIES, IDENTITY_TRUST_LEVEL_LABELS } from './org/index'

package/src/message-parts/__tests__/wire.test.ts

@@ -0,0 +1,127 @@
+import { describe, it, expect } from 'vitest'
+import { WireSurfaceBuilder } from '../wire.js'
+import type { ExecutionResultData } from '../execution.js'
+import type { UndoResultData } from '../execution.js'
+
+describe('WireSurfaceBuilder.toolList', () => {
+  it('returns data part with type data-tool-list', () => {
+    const tools = [{ name: 'search', description: 'Search tool', inputSchema: {} }] as any
+    const result = WireSurfaceBuilder.toolList(tools)
+    expect(result.type).toBe('data-tool-list')
+  })
+
+  it('data.tools matches input array exactly', () => {
+    const tools = [
+      { name: 'search', description: 'Search tool', inputSchema: {} },
+      { name: 'fetch', description: 'Fetch tool', inputSchema: { type: 'object' } },
+    ] as any
+    const result = WireSurfaceBuilder.toolList(tools)
+    expect(result.data.tools).toEqual(tools)
+  })
+
+  it('works with empty tools array', () => {
+    const result = WireSurfaceBuilder.toolList([])
+    expect(result.type).toBe('data-tool-list')
+    expect(result.data.tools).toEqual([])
+  })
+})
+
+describe('WireSurfaceBuilder.executionResult', () => {
+  const data: ExecutionResultData = {
+    actionId: 'act-1',
+    executionId: 'exec-001',
+    state: 'completed',
+    artifacts: [{ kind: 'profile_name', label: 'Name', status: 'success' }],
+    summary: { title: 'Profile Updated' },
+  }
+
+  it('returns data part with type data-execution-result', () => {
+    const result = WireSurfaceBuilder.executionResult(data)
+    expect(result.type).toBe('data-execution-result')
+  })
+
+  it('data matches input ExecutionResultData exactly', () => {
+    const result = WireSurfaceBuilder.executionResult(data)
+    expect(result.data).toEqual(data)
+  })
+
+  it('preserves actionId from input', () => {
+    const result = WireSurfaceBuilder.executionResult(data)
+    expect(result.data.actionId).toBe('act-1')
+  })
+})
+
+describe('WireSurfaceBuilder.undoResult', () => {
+  const data: UndoResultData = {
+    actionId: 'act-1',
+    executionId: 'exec-001',
+    undoExecutionId: 'undo-exec-002',
+    status: 'success',
+  }
+
+  it('returns data part with type data-undo-result', () => {
+    const result = WireSurfaceBuilder.undoResult(data)
+    expect(result.type).toBe('data-undo-result')
+  })
+
+  it('data matches input UndoResultData exactly', () => {
+    const result = WireSurfaceBuilder.undoResult(data)
+    expect(result.data).toEqual(data)
+  })
+
+  it('preserves undoExecutionId from input', () => {
+    const result = WireSurfaceBuilder.undoResult(data)
+    expect(result.data.undoExecutionId).toBe('undo-exec-002')
+  })
+})
+
+describe('WireSurfaceBuilder.messageStart', () => {
+  it('returns data part with type data-message-start', () => {
+    const result = WireSurfaceBuilder.messageStart('msg-123')
+    expect(result.type).toBe('data-message-start')
+  })
+
+  it('data.messageId matches input', () => {
+    const result = WireSurfaceBuilder.messageStart('msg-456')
+    expect(result.data.messageId).toBe('msg-456')
+  })
+
+  it('data.version is 1', () => {
+    const result = WireSurfaceBuilder.messageStart('msg-789')
+    expect(result.data.version).toBe(1)
+  })
+
+  it('data.timestamp is a valid ISO 8601 string', () => {
+    const result = WireSurfaceBuilder.messageStart('msg-ts')
+    const parsed = new Date(result.data.timestamp)
+    expect(parsed.toISOString()).toBe(result.data.timestamp)
+  })
+})
+
+describe('WireSurfaceBuilder.messageComplete', () => {
+  it('returns data part with type data-message-complete', () => {
+    const result = WireSurfaceBuilder.messageComplete('msg-123', 500)
+    expect(result.type).toBe('data-message-complete')
+  })
+
+  it('data.messageId matches input', () => {
+    const result = WireSurfaceBuilder.messageComplete('msg-456', 200)
+    expect(result.data.messageId).toBe('msg-456')
+  })
+
+  it('data.narrativeLength matches input', () => {
+    const result = WireSurfaceBuilder.messageComplete('msg-789', 1234)
+    expect(result.data.narrativeLength).toBe(1234)
+  })
+
+  it('data.version is 1', () => {
+    const result = WireSurfaceBuilder.messageComplete('msg-v', 100)
+    expect(result.data.version).toBe(1)
+  })
+
+  it('data.timestamp is a valid ISO 8601 string', () => {
+    const result = WireSurfaceBuilder.messageComplete('msg-ts', 300)
+    const parsed = new Date(result.data.timestamp)
+    expect(parsed.toISOString()).toBe(result.data.timestamp)
+  })
+})

package/src/org/__tests__/view-scopes.test.ts

@@ -0,0 +1,47 @@
+import { describe, it, expect } from 'vitest'
+import { VIEW_SCOPE_MAP, getViewScope } from '../view-scopes.js'
+
+describe('VIEW_SCOPE_MAP golden snapshot', () => {
+  it('exact values are frozen', () => {
+    expect(VIEW_SCOPE_MAP).toStrictEqual({
+      workspace: 'org.view_workspace',
+      timeline: 'org.view_timeline',
+      activity: 'org.view_activity',
+      goals: 'org.view_goals',
+      'internal-admin': 'internal.view_admin',
+      chat: null,
+      settings: null,
+      chats: null,
+      upgrade: null,
+    })
+  })
+})
+
+describe('getViewScope', () => {
+  it('returns the required scope for protected views', () => {
+    expect(getViewScope('workspace')).toBe('org.view_workspace')
+    expect(getViewScope('timeline')).toBe('org.view_timeline')
+    expect(getViewScope('activity')).toBe('org.view_activity')
+    expect(getViewScope('goals')).toBe('org.view_goals')
+    expect(getViewScope('internal-admin')).toBe('internal.view_admin')
+  })
+
+  it('returns null for public views', () => {
+    expect(getViewScope('chat')).toBeNull()
+    expect(getViewScope('settings')).toBeNull()
+    expect(getViewScope('chats')).toBeNull()
+    expect(getViewScope('upgrade')).toBeNull()
+  })
+
+  it('returns null for unknown view string', () => {
+    expect(getViewScope('nonexistent-view')).toBeNull()
+  })
+
+  it('returns null for empty string', () => {
+    expect(getViewScope('')).toBeNull()
+  })
+
+  it('returns null for view name that is a substring of a real view', () => {
+    expect(getViewScope('work')).toBeNull()
+  })
+})

package/src/org/{strategy.ts → goals.ts}

@@ -1,61 +1,61 @@
 /**
- * Strategy Domain Types
+ * Goals Domain Types
  *
- * Vocabulary types for the Company.md strategy feature.
+ * Vocabulary types for the Company.md goals feature.
  * Shared between backend (persistence/service) and app (UI rendering).
  * @see PRD-00173 for design rationale
  */
 
-export type StrategyVisibility = 'public' | 'private';
+export type GoalVisibility = 'public' | 'private';
 
-export type StrategyDocLevel = 'root' | 'department';
+export type GoalDocLevel = 'root' | 'department';
 
-export interface StrategySource {
+export interface GoalSource {
   readonly label: string;
   readonly sourceType: 'meeting' | 'document' | 'conversation' | 'manual';
   readonly referencedAt: string;
 }
 
-export interface StrategyDependency {
+export interface GoalDependency {
   readonly targetSlug: string;
   readonly description: string;
 }
 
-export interface StrategyTreeNode {
+export interface GoalTreeNode {
   readonly id: string;
   readonly slug: string;
   readonly title: string;
-  readonly level: StrategyDocLevel;
+  readonly level: GoalDocLevel;
   readonly department: string | null;
-  readonly visibility: StrategyVisibility;
+  readonly visibility: GoalVisibility;
   readonly canEdit: boolean;
   readonly memberCount: number;
 }
 
-export interface StrategyDocCore {
+export interface GoalDocCore {
   readonly id: string;
   readonly slug: string;
   readonly title: string;
-  readonly level: StrategyDocLevel;
+  readonly level: GoalDocLevel;
   readonly department: string | null;
   readonly content: string;
-  readonly visibility: StrategyVisibility;
+  readonly visibility: GoalVisibility;
   readonly parentId: string | null;
 }
 
-export interface StrategyDocCollaborators {
+export interface GoalDocCollaborators {
   readonly owner: { readonly id: string; readonly name: string } | null;
   readonly coOwners: ReadonlyArray<{ readonly id: string; readonly name: string }>;
   readonly canEdit: boolean;
   readonly members: ReadonlyArray<{ readonly id: string; readonly name: string }>;
 }
 
-export interface StrategyDocRelations {
+export interface GoalDocRelations {
   readonly inheritsFrom: string | null;
-  readonly sources: readonly StrategySource[];
-  readonly dependencies: readonly StrategyDependency[];
+  readonly sources: readonly GoalSource[];
+  readonly dependencies: readonly GoalDependency[];
   readonly createdAt: string;
   readonly updatedAt: string;
 }
 
-export type StrategyDoc = StrategyDocCore & StrategyDocCollaborators & StrategyDocRelations;
+export type GoalDoc = GoalDocCore & GoalDocCollaborators & GoalDocRelations;

package/src/org/index.ts

@@ -80,15 +80,15 @@ export type {
 export type { AuthorizableView } from './view-scopes';
 export { VIEW_SCOPE_MAP, getViewScope } from './view-scopes';
 
-// Strategy domain types (PRD-00173)
+// Goals domain types (PRD-00173)
 export type {
-  StrategyVisibility,
-  StrategyDocLevel,
-  StrategySource,
-  StrategyDependency,
-  StrategyTreeNode,
-  StrategyDocCore,
-  StrategyDocCollaborators,
-  StrategyDocRelations,
-  StrategyDoc,
-} from './strategy';
+  GoalVisibility,
+  GoalDocLevel,
+  GoalSource,
+  GoalDependency,
+  GoalTreeNode,
+  GoalDocCore,
+  GoalDocCollaborators,
+  GoalDocRelations,
+  GoalDoc,
+} from './goals';

package/src/org/view-scopes.ts

@@ -20,7 +20,7 @@ export const VIEW_SCOPE_MAP = {
   workspace: 'org.view_workspace',
   timeline: 'org.view_timeline',
   activity: 'org.view_activity',
-  strategy: 'org.view_strategy',
+  goals: 'org.view_goals',
   'internal-admin': 'internal.view_admin',
   // Public views (require only authentication)
   chat: null,

package/src/ralph/__tests__/prd.test.ts

@@ -0,0 +1,41 @@
+import { describe, it, expect } from 'vitest'
+import { REPO_PRECEDENCE } from '../prd.js'
+
+describe('REPO_PRECEDENCE', () => {
+  it('has contracts first (dependency source)', () => {
+    expect(REPO_PRECEDENCE[0]).toBe('company-semantics-contracts')
+  })
+
+  it('exact values and order are frozen (golden snapshot)', () => {
+    expect(REPO_PRECEDENCE).toStrictEqual([
+      'company-semantics-contracts',
+      'company-semantics-control',
+      'company-semantics-ci',
+      'company-semantics-backend',
+      'company-semantics-edge',
+      'company-semantics-app',
+      'company-semantics-site',
+    ])
+  })
+
+  it('has exactly 7 entries (all known repos)', () => {
+    expect(REPO_PRECEDENCE).toHaveLength(7)
+  })
+
+  it('has no duplicates', () => {
+    expect(new Set(REPO_PRECEDENCE).size).toBe(REPO_PRECEDENCE.length)
+  })
+
+  it('all entries start with company-semantics- prefix', () => {
+    for (const repo of REPO_PRECEDENCE) {
+      expect(repo).toMatch(/^company-semantics-/)
+    }
+  })
+
+  it('all entries are non-empty strings', () => {
+    for (const repo of REPO_PRECEDENCE) {
+      expect(typeof repo).toBe('string')
+      expect(repo.length).toBeGreaterThan(0)
+    }
+  })
+})

package/src/usage/types.ts

@@ -4,7 +4,7 @@
  * See PRD-00166 for design rationale and invariants.
  */
 
-export type AiFeature = 'chat' | 'chat_title' | 'ingest_summarize' | 'ingest_embedding' | 'strategy_extraction';
+export type AiFeature = 'chat' | 'chat_title' | 'ingest_summarize' | 'ingest_embedding' | 'goal_extraction';
 
 export interface UsageSummary {
   totalTokens: number;