@commonpub/layer 0.23.1 → 0.23.2

package/components/views/ArticleView.vue

@@ -419,13 +419,31 @@ useJsonLd({
   font-weight: 400;
 }
 
-/* ── AVATARS ── */
+/* ── AVATARS ──
+ * Two render modes share the .cpub-av class:
+ *   <img class="cpub-av cpub-av-lg" ...>     ← avatar photo
+ *   <div class="cpub-av cpub-av-lg">JD</div>  ← initials fallback when no avatar
+ *
+ * Sizing + border-radius is shared. But `display: flex` MUST NOT apply to
+ * the <img> — when a replaced element gets `display: flex` set, browsers
+ * (notably Chromium) treat the img content render-box inconsistently and
+ * the inline `object-fit: cover` is silently dropped, producing a squished
+ * (stretched-to-box) image instead of a center-cropped one. Visible on
+ * deveco.io blog pages where author avatars are vertical photos (e.g.
+ * 816×1456) rendered into a 44×44 square.
+ *
+ * Fix: scope display:flex centering to the div variant only.
+ */
 .cpub-av {
   width: 28px;
   height: 28px;
   border-radius: 50%;
   background: var(--surface3);
   border: var(--border-width-default) solid var(--border);
+  flex-shrink: 0;
+}
+
+div.cpub-av {
   display: flex;
   align-items: center;
   justify-content: center;
@@ -433,7 +451,12 @@ useJsonLd({
   font-weight: 600;
   color: var(--text-dim);
   font-family: var(--font-mono);
-  flex-shrink: 0;
+}
+
+/* Defensive: even when consumers forget the inline `object-fit:cover`,
+   img.cpub-av crops instead of stretching. */
+img.cpub-av {
+  object-fit: cover;
 }
 
 .cpub-av-lg { width: 44px; height: 44px; font-size: 14px; }

package/components/views/ProjectView.vue

@@ -763,12 +763,19 @@ async function handleBuild(): Promise<void> {
   flex-wrap: wrap;
 }
 
+/* See ArticleView.vue's .cpub-av comment for why display:flex is scoped
+ * to the div-variant only — stops img-variant from squishing portrait
+ * avatars (object-fit:cover gets dropped on flex-set replaced elements). */
 .cpub-av {
   width: 28px;
   height: 28px;
   border-radius: 50%;
   background: var(--surface3);
   border: var(--border-width-default) solid var(--border);
+  flex-shrink: 0;
+}
+
+div.cpub-av {
   display: flex;
   align-items: center;
   justify-content: center;
@@ -776,7 +783,10 @@ async function handleBuild(): Promise<void> {
   font-weight: 700;
   color: var(--text-dim);
   font-family: var(--font-mono);
-  flex-shrink: 0;
+}
+
+img.cpub-av {
+  object-fit: cover;
 }
 
 .cpub-av-lg { width: 36px; height: 36px; font-size: 12px; }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@commonpub/layer",
-  "version": "0.23.1",
+  "version": "0.23.2",
   "type": "module",
   "main": "./nuxt.config.ts",
   "files": [
@@ -55,12 +55,12 @@
     "@commonpub/config": "0.15.0",
     "@commonpub/editor": "0.7.11",
     "@commonpub/explainer": "0.7.15",
+    "@commonpub/docs": "0.6.3",
+    "@commonpub/learning": "0.5.2",
     "@commonpub/protocol": "0.12.0",
-    "@commonpub/server": "2.57.0",
     "@commonpub/schema": "0.17.0",
-    "@commonpub/learning": "0.5.2",
     "@commonpub/ui": "0.9.0",
-    "@commonpub/docs": "0.6.3"
+    "@commonpub/server": "2.57.0"
   },
   "devDependencies": {
     "@testing-library/jest-dom": "^6.9.1",

package/server/api/admin/features/index.put.ts

@@ -37,13 +37,15 @@ export default defineEventHandler(async (event) => {
 
   const merged = { ...existing, ...body.overrides };
 
-  // Remove overrides that match the base config default (no point overriding to same value)
-  const base = config.features as unknown as Record<string, boolean>;
-  for (const [key, value] of Object.entries(merged)) {
-    if (base[key] === value) {
-      delete (merged as Record<string, unknown>)[key];
-    }
-  }
+  // NOTE: previously this block tried to "remove overrides that match the
+  // base config" as a dedup, but `config.features` is the EFFECTIVE config
+  // (with overrides ALREADY applied) — so re-saving a previously-overridden
+  // flag would see `base[key] === value` (because the override was applied
+  // to base) and delete the override. The flag would then revert to the
+  // build-time default on next read. User-visible symptom: "I flipped X on
+  // in the UI but it kept reverting off." The dedup is dropped — the user's
+  // explicit override is persisted verbatim. Future "reset to default" can
+  // be a separate DELETE-overrides handler.
 
   await setInstanceSetting(db, 'features.overrides', merged, user.id, getRequestIP(event) ?? undefined);