@commonpub/layer 0.15.3 → 0.15.5

package/composables/useFeatures.ts

@@ -20,18 +20,35 @@ export interface FeatureFlags {
 
 let hydrated = false;
 
-const DEFAULT_FLAGS: FeatureFlags = {
+// Shared default shape. Exported so feature-gate middleware can use the same
+// initializer — if the middleware runs before useFeatures() and initializes
+// the 'feature-flags' state to a different value, useFeatures()'s own
+// initializer is skipped (Nuxt useState only inits once per key), and any
+// `flags.value.X` access would crash at runtime.
+export const DEFAULT_FLAGS: FeatureFlags = {
   content: true, social: true, hubs: true, docs: true, video: true,
   contests: false, events: false, learning: true, explainers: true,
   editorial: true, federation: false, admin: false, emailNotifications: false,
 };
 
-export function useFeatures() {
+/** Build the initial flags by merging the layer's runtime config over defaults. */
+export function getInitialFlags(): FeatureFlags {
   const config = useRuntimeConfig();
-  const buildFlags = (config.public.features as unknown as FeatureFlags) ?? DEFAULT_FLAGS;
+  const buildFlags = (config.public.features as unknown as Partial<FeatureFlags> | undefined) ?? {};
+  return { ...DEFAULT_FLAGS, ...buildFlags };
+}
 
-  // Shared reactive state — initialized from build-time config
-  const flags = useState<FeatureFlags>('feature-flags', () => ({ ...DEFAULT_FLAGS, ...buildFlags }));
+export function useFeatures() {
+  // Shared reactive state — initialized from build-time config.
+  // Uses the shared getInitialFlags() so middleware and composable agree on
+  // the default shape (see the DEFAULT_FLAGS export note above).
+  const flags = useState<FeatureFlags>('feature-flags', getInitialFlags);
+
+  // Defensive: if another consumer poisoned the state to null/undefined
+  // before we ran, repair it here so .value.X accesses don't crash.
+  if (flags.value == null) {
+    flags.value = getInitialFlags();
+  }
 
   // On client, fetch dynamic features once to pick up DB overrides
   if (import.meta.client && !hydrated) {

package/middleware/feature-gate.global.ts

@@ -2,7 +2,7 @@
 // Prevents client-side navigation to feature-gated pages when the flag is disabled.
 // Uses useState('feature-flags') which is hydrated by useFeatures() from /api/features.
 
-import type { FeatureFlags } from '../composables/useFeatures';
+import { getInitialFlags, type FeatureFlags } from '../composables/useFeatures';
 
 const ROUTE_FEATURE_MAP: Record<string, keyof FeatureFlags> = {
   '/learn': 'learning',
@@ -17,10 +17,16 @@ const ROUTE_FEATURE_MAP: Record<string, keyof FeatureFlags> = {
 export default defineNuxtRouteMiddleware((to) => {
   for (const [prefix, feature] of Object.entries(ROUTE_FEATURE_MAP)) {
     if (to.path === prefix || to.path.startsWith(prefix + '/')) {
-      // Prefer reactive state (hydrated from /api/features), fall back to build-time config
-      const featureState = useState<FeatureFlags | null>('feature-flags', () => null);
-      const flags = featureState.value ?? (useRuntimeConfig().public.features as Record<string, boolean>);
-      if (!(flags as Record<string, boolean>)[feature]) {
+      // IMPORTANT: use the same initializer as useFeatures(). Previously this
+      // initialized to `null`, which poisoned the shared state — Nuxt's
+      // useState only runs its initializer the first time a key is seen per
+      // request. When the layout later called useFeatures() with its own
+      // initializer, Nuxt returned the existing null state, and any
+      // flags.value.X access crashed with "Cannot read properties of null
+      // (reading '...')". That was the root cause of the commonpub.io
+      // /docs, /learn, /videos, /explainer SSR-500 bug (session 126).
+      const flags = useState<FeatureFlags>('feature-flags', getInitialFlags);
+      if (!flags.value[feature]) {
         throw createError({ statusCode: 404, statusMessage: 'Not Found' });
       }
       return;

package/nuxt.config.ts

@@ -95,12 +95,21 @@ export default defineNuxtConfig({
       instanceCookies: [] as Array<{ name: string; category: string; description: string; duration: string; provider?: string }>,
     },
   },
-  routeRules: {
-    ...(process.env.NUXT_PUBLIC_FEATURES_DOCS !== 'false' && {
-      '/docs/**': { prerender: true },
-    }),
-  },
+  // NOTE: /docs/** was previously set to `prerender: true` but this caused
+  // production 500s because the Docker build stage has no DB access. During
+  // prerender, the /api/docs fetch fails → the prerenderer saves the error
+  // HTML as /docs/index.html in .output/public, and crawlLinks propagated
+  // the failure to linked routes (/learn, /videos). Runtime SSR works fine
+  // because the app then has real DB access. If caching is later needed,
+  // use `swr: 60` (stale-while-revalidate at runtime), NOT `prerender: true`.
+  routeRules: {},
   nitro: {
     preset: 'node-server',
+    // Disable link-crawling during prerender so any future prerender rules
+    // can't accidentally cascade failures to other routes.
+    prerender: {
+      crawlLinks: false,
+      failOnError: false,
+    },
   },
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@commonpub/layer",
-  "version": "0.15.3",
+  "version": "0.15.5",
   "type": "module",
   "main": "./nuxt.config.ts",
   "files": [
@@ -55,11 +55,11 @@
     "zod": "^4.3.6",
     "@commonpub/docs": "0.6.2",
     "@commonpub/config": "0.10.0",
+    "@commonpub/auth": "0.5.1",
+    "@commonpub/editor": "0.7.9",
     "@commonpub/protocol": "0.9.9",
     "@commonpub/learning": "0.5.0",
-    "@commonpub/ui": "0.8.5",
-    "@commonpub/auth": "0.5.1",
-    "@commonpub/editor": "0.7.9"
+    "@commonpub/ui": "0.8.5"
   },
   "devDependencies": {
     "@testing-library/jest-dom": "^6.9.1",

package/pages/u/[username]/index.vue

@@ -74,6 +74,23 @@ const filteredContent = computed(() => {
 
 const p = computed(() => profile.value);
 
+// Activity heatmap data: count content items published per day (YYYY-MM-DD).
+// HeatmapGrid needs Record<string, number> keyed by ISO date; with no data
+// all cells render as level-0 (empty) which looks broken.
+const activityByDate = computed<Record<string, number>>(() => {
+  const items = content.value?.items;
+  if (!items?.length) return {};
+  const map: Record<string, number> = {};
+  for (const item of items) {
+    // Prefer publishedAt; fall back to createdAt. Items without either are skipped.
+    const ts = item.publishedAt ?? item.createdAt;
+    if (!ts) continue;
+    const date = String(ts).slice(0, 10);
+    map[date] = (map[date] ?? 0) + 1;
+  }
+  return map;
+});
+
 const { isAuthenticated, user } = useAuth();
 const toast = useToast();
 const isOwnProfile = computed(() => user.value?.username === username);
@@ -398,7 +415,7 @@ async function handleReport(): Promise<void> {
             <!-- Activity Heatmap -->
             <div class="cpub-sb-card">
               <div class="cpub-sb-title">Activity</div>
-              <HeatmapGrid :weeks="20" />
+              <HeatmapGrid :data="activityByDate" :weeks="20" />
             </div>
 
             <!-- Featured Projects -->

package/server/{routes/hubs/[slug].ts → middleware/hub-ap.ts}

@@ -1,9 +1,13 @@
 import { buildHubGroupActor } from '@commonpub/server';
 
 /**
- * Hub Group actor endpoint. Returns AP Group JSON-LD for federation.
- * Only responds to ActivityPub clients (Accept: application/activity+json).
- * Browser requests pass through to the Nuxt page handler.
+ * Middleware: serve ActivityPub Group actor JSON-LD for hub URIs.
+ *
+ * Matches /hubs/{slug} with AP Accept headers.
+ * Non-AP requests pass through to the Nuxt page renderer.
+ *
+ * This MUST be a middleware (not a server route) because a server route
+ * returning undefined sends HTTP 204, which prevents the Nuxt page from rendering.
  */
 export default defineEventHandler(async (event) => {
   const accept = getRequestHeader(event, 'accept') ?? '';
@@ -11,15 +15,16 @@ export default defineEventHandler(async (event) => {
     accept.includes('application/activity+json') ||
     accept.includes('application/ld+json');
 
-  // Only handle AP requests — let browser requests fall through to the page handler
   if (!isAPRequest) return;
 
+  const path = getRequestURL(event).pathname;
+  const match = path.match(/^\/hubs\/([a-z0-9][a-z0-9_-]*)$/);
+  if (!match) return;
+
   const config = useConfig();
   if (!config.features.federation || !config.features.federateHubs) return;
 
-  const slug = getRouterParam(event, 'slug');
-  if (!slug) return;
-
+  const slug = match[1]!;
   const db = useDB();
   const actor = await buildHubGroupActor(db, slug, config.instance.domain);
   if (!actor) return;

package/server/{routes/hubs/[slug]/posts/[postId].ts → middleware/hub-post-ap.ts}

@@ -4,9 +4,13 @@ import { hubPosts, users } from '@commonpub/schema';
 import { eq } from 'drizzle-orm';
 
 /**
- * Hub post AP Note endpoint.
- * Serves the Note JSON-LD when requested with AP Accept header.
- * Remote instances dereference this URI when processing Announce activities.
+ * Middleware: serve ActivityPub Note JSON-LD for hub post URIs.
+ *
+ * Matches /hubs/{slug}/posts/{postId} with AP Accept headers.
+ * Non-AP requests pass through to the Nuxt page renderer.
+ *
+ * This MUST be a middleware (not a server route) because a server route
+ * returning undefined sends HTTP 204, which prevents the Nuxt page from rendering.
  */
 export default defineEventHandler(async (event) => {
   const accept = getRequestHeader(event, 'accept') ?? '';
@@ -16,13 +20,15 @@ export default defineEventHandler(async (event) => {
 
   if (!isAPRequest) return;
 
+  const path = getRequestURL(event).pathname;
+  const match = path.match(/^\/hubs\/([a-z0-9][a-z0-9_-]*)\/posts\/([a-zA-Z0-9_-]+)$/);
+  if (!match) return;
+
   const config = useConfig();
   if (!config.features.federation || !config.features.federateHubs) return;
 
-  const slug = getRouterParam(event, 'slug');
-  const postId = getRouterParam(event, 'postId');
-  if (!slug || !postId) return;
-
+  const slug = match[1]!;
+  const postId = match[2]!;
   const db = useDB();
   const domain = config.instance.domain;
 
@@ -51,7 +57,6 @@ export default defineEventHandler(async (event) => {
 
   setResponseHeader(event, 'content-type', 'application/activity+json');
 
-  // Build Note content — share posts need special handling
   let noteContent = escapeHtmlForAP(post.content);
   const ext: Record<string, unknown> = {};